1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
|
From: sid <sidtosh4@gmail.com>
Date: Fri, 31 May 2024 20:35:07 +0100
Subject: Replace 'BaobabCellRendererProgress' with native
'GtkCellRendererProgress'
Baobab cell renderer is broken in brasero (displaying black bars). It
can be fixed, but the color idea is a bit confusing as it's not clear
what they mean. Theming is one other issue. So, we replace it with the
native 'GtkCellRendererProgress' from GTK3.
Baobab has made the same replacement during it's GTK4 port in 2021, so
it looks consistent with the rest of the ecosystem.
Forwarded: https://gitlab.gnome.org/GNOME/brasero/-/merge_requests/28
src/Makefile.am | 2 --
src/brasero-data-disc.c | 5 ++---
2 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/src/Makefile.am b/src/Makefile.am
index 55b933f..59fb13f 100644
@@ -91,8 +91,6 @@ brasero_SOURCES = \
brasero-file-filtered.c \
brasero-filter-option.h \
brasero-filter-option.c \
- baobab-cell-renderer-progress.c \
- baobab-cell-renderer-progress.h \
brasero-multi-song-props.h \
brasero-multi-song-props.c \
brasero-rename.h \
diff --git a/src/brasero-data-disc.c b/src/brasero-data-disc.c
index 458bb50..895f395 100644
@@ -36,7 +36,6 @@
#include "brasero-misc.h"
#include "eggtreemultidnd.h"
-#include "baobab-cell-renderer-progress.h"
#include "brasero-data-disc.h"
#include "brasero-file-filtered.h"
@@ -2369,14 +2368,14 @@ brasero_data_disc_init (BraseroDataDisc *object)
gtk_tree_view_column_set_sort_column_id (column, BRASERO_DATA_TREE_MODEL_MIME_DESC);
/* Space column */
- renderer = baobab_cell_renderer_progress_new ();
+ renderer = gtk_cell_renderer_progress_new ();
column = gtk_tree_view_column_new ();
gtk_tree_view_column_pack_start (column, renderer, FALSE);
gtk_tree_view_column_add_attribute (column, renderer,
"visible", BRASERO_DATA_TREE_MODEL_SHOW_PERCENT);
gtk_tree_view_column_add_attribute (column, renderer,
- "perc", BRASERO_DATA_TREE_MODEL_PERCENT);
+ "value", BRASERO_DATA_TREE_MODEL_PERCENT);
gtk_tree_view_column_set_title (column, _("Space"));
gtk_tree_view_append_column (GTK_TREE_VIEW (priv->tree), column);
|
