1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
|
From: sid <sidtosh4@gmail.com>
Date: Mon, 3 Jun 2024 18:51:08 +0100
Subject: Fix gcc 14.x build failure (due to -Wincompatible-pointer-types)
The changes for 'brasero-drive-properties.c' are kept inline with
'brasero-burn-options.c' (public API) for the sake of consistency.
Bug: https://gitlab.gnome.org/GNOME/brasero/-/issues/370
Bug-Debian: https://bugs.debian.org/1074854
Origin: https://gitlab.gnome.org/GNOME/brasero/-/merge_requests/30
Applied-upstream: 3.12.4, commit:5cdefa8c76ddb797bce8b67a3f5767678bd36a5a
---
libbrasero-burn/brasero-drive-properties.c | 10 +++-------
libbrasero-utils/brasero-metadata.c | 2 +-
libbrasero-utils/brasero-pk.c | 2 +-
3 files changed, 5 insertions(+), 9 deletions(-)
diff --git a/libbrasero-burn/brasero-drive-properties.c b/libbrasero-burn/brasero-drive-properties.c
index cfb2db1..22593cc 100644
--- a/libbrasero-burn/brasero-drive-properties.c
+++ b/libbrasero-burn/brasero-drive-properties.c
@@ -835,23 +835,19 @@ brasero_drive_properties_set_property (GObject *object,
GParamSpec *pspec)
{
BraseroDrivePropertiesPrivate *priv;
- BraseroBurnSession *session;
priv = BRASERO_DRIVE_PROPERTIES_PRIVATE (object);
switch (property_id) {
case PROP_SESSION: /* Readable and only writable at creation time */
- /* NOTE: no need to unref a potential previous session since
- * it's only set at construct time */
- session = g_value_get_object (value);
- priv->session = g_object_ref (session);
+ priv->session = g_object_ref (g_value_get_object (value));
brasero_drive_properties_update (BRASERO_DRIVE_PROPERTIES (object));
- priv->valid_sig = g_signal_connect (session,
+ priv->valid_sig = g_signal_connect (priv->session,
"is-valid",
G_CALLBACK (brasero_drive_properties_is_valid_cb),
object);
- priv->output_sig = g_signal_connect (session,
+ priv->output_sig = g_signal_connect (priv->session,
"output-changed",
G_CALLBACK (brasero_drive_properties_output_changed_cb),
object);
diff --git a/libbrasero-utils/brasero-metadata.c b/libbrasero-utils/brasero-metadata.c
index 1943368..ddfce8e 100644
--- a/libbrasero-utils/brasero-metadata.c
+++ b/libbrasero-utils/brasero-metadata.c
@@ -665,7 +665,7 @@ brasero_metadata_install_missing_plugins (BraseroMetadata *self)
context = gst_install_plugins_context_new ();
gst_install_plugins_context_set_xid (context, brasero_metadata_get_xid (self));
- status = gst_install_plugins_async ((gchar **) details->pdata,
+ status = gst_install_plugins_async ((const gchar* const*) details->pdata,
context,
brasero_metadata_install_plugins_result,
downloads);
diff --git a/libbrasero-utils/brasero-pk.c b/libbrasero-utils/brasero-pk.c
index aa71901..5f5ba21 100644
--- a/libbrasero-utils/brasero-pk.c
+++ b/libbrasero-utils/brasero-pk.c
@@ -230,7 +230,7 @@ brasero_pk_install_gstreamer_plugin (BraseroPK *package,
context = gst_install_plugins_context_new ();
gst_install_plugins_context_set_xid (context, xid);
- status = gst_install_plugins_async ((gchar **) gst_plugins->pdata,
+ status = gst_install_plugins_async ((const gchar* const*) gst_plugins->pdata,
context,
brasero_pk_install_gst_plugin_result,
package);
|
