1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
|
BRIDGE-MEMORY-LEAK-FOUND
----------------------------------------------------------------------------
From Michael Leodolter <Michael.Leodolter@lab1.psy.univie.ac.at>
Organization Brain Reserch Lab (BRL) Univ. Vienna
Date Thu, 05 Sep 1996 12:07:11 +0200
Newsgroups comp.os.linux.networking,comp.os.linux.development.system
Message-ID <322EA64F.4A03449@lab1.psy.univie.ac.at>
----------------------------------------------------------------------------
Hi,
I found the memory leak in the bridging code in br_forward().
br_forward should not lock.
It works for me as a 10/100-bridge on P133 with a ne2000-comp and a
SMC-9332.
-----------------------------------------------------------cut-here---
--- linux-2.0.16/net/bridge/br.c Fri Jul 19 07:24:05 1996
+++ linux/net/bridge/br.c Thu Sep 5 11:52:35 1996
@@ -1137,7 +1137,9 @@
/* happen in net_bh() in
dev.c) */
}
/* ok, forward this frame... */
+#if 0 /* ML */ /* is done in dev_queue_xmit */
skb_device_lock(skb);
+#endif
return(br_forward(skb, port));
default:
printk(KERN_DEBUG "br_receive_frame: port [%i]
unknown state [%i]\n",
------------------------------------------------------------cut-here---
I hope this was all, (too see it in the kernel),
thanks,
michael
--
--------------------------------------------------------
- Michael Leodolter Brain Research Lab (BRL) -
- Inst. of Psychology Univ. of Vienna -
- EMail: <Michael.Leodolter@univie.ac.at> -
- or <Michael.Leodolter@lab1.psy.univie.ac.at> -
- Tel: <+43-222-40103-2436> Fax: <+43-222-406 64 22> -
--------------------------------------------------------
|
