1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
|
#include "../test.h"
#include "../../src/asfd.h"
#include "../../src/conffile.h"
#include "../../src/fsops.h"
#include "../../src/iobuf.h"
#include "../../src/server/auth.h"
#include "../builders/build.h"
#include "../builders/build_asfd_mock.h"
#include "../builders/build_file.h"
#define BASE "utest_server_auth"
#define CONFFILE BASE "/burp.conf"
static int CNAME_LOWERCASE=0;
static int CNAME_FQDN=1;
static void clean(void)
{
fail_unless(!recursive_delete(BASE));
fail_unless(!recursive_delete(CLIENTCONFDIR));
}
struct pdata
{
int expected;
const char *passwd;
const char *plain_text;
};
static struct pdata p[] = {
// 1 is success, 0 is failure.
#ifdef HAVE_OPENBSD_OS // Feature not supported at all on openbsd.
{ -1, "hiH9IOyyrrl4k", "ifpqgio" },
#else
{ 1, "hiH9IOyyrrl4k", "ifpqgio" },
{ 0, "hiH9IOyyrrl4k", "ifpqgia" },
/* Salt format below is a GNU extension not present on other systems */
#if !defined(HAVE_NETBSD_OS) && !defined(HAVE_DARWIN_OS) && !defined(_AIX)
{ 1, "$6$dYCzeXf3$Vue9VQ49lBLtK7d273FxKYsWrF1WGwr3Th2GBCghj0WG61o/bXxEal/11pCdvWqN/Y1iSiOblqZhitBsqAOVe1", "testuser" },
{ 0, "x6$dYCzeXf3$Vue9VQ49lBLtK7d273FxKYsWrF1WGwr3Th2GBCghj0WG61o/bXxEal/11pCdvWqN/Y1iSiOblqZhitBsqAOVe1", "testuser" },
{ 0, "x6$dYCzeXf3$Vue9VQ49lBLtK7d273FxKYsWrF1WGwr3Th2GBCghj0WG61o/bXxEal/11pCdvWqN/Y1iSiOblqZhitBsqAOVe1", NULL },
#endif
{ 0, NULL, "testuser" },
{ 0, "123", "testuser" }
#endif
};
START_TEST(test_check_passwd)
{
FOREACH(p)
{
int result=check_passwd(p[i].passwd, p[i].plain_text);
fail_unless(result==p[i].expected);
}
}
END_TEST
static struct ioevent_list reads;
static struct ioevent_list writes;
static void do_test(
int expected_ret,
void setup_callback(struct asfd *asfd)
)
{
struct asfd *asfd;
struct conf **globalcs=NULL;
struct conf **cconfs=NULL;
clean();
fail_unless((globalcs=confs_alloc())!=NULL);
fail_unless((cconfs=confs_alloc())!=NULL);
confs_init(globalcs);
confs_init(cconfs);
build_file(CONFFILE, MIN_CLIENT_CONF);
fail_unless(!conf_load_global_only(CONFFILE, globalcs));
fail_unless(!set_string(globalcs[OPT_CLIENTCONFDIR], CLIENTCONFDIR));
fail_unless(!set_int(globalcs[OPT_CNAME_LOWERCASE], CNAME_LOWERCASE));
fail_unless(!set_int(globalcs[OPT_CNAME_FQDN], CNAME_FQDN));
asfd=asfd_mock_setup(&reads, &writes);
setup_callback(asfd);
fail_unless(authorise_server(
asfd,
globalcs,
cconfs
)==expected_ret);
asfd_free(&asfd);
asfd_mock_teardown(&reads, &writes);
confs_free(&globalcs);
confs_free(&cconfs);
alloc_check();
clean();
}
static void setup_initial_error(struct asfd *asfd)
{
int r=0;
asfd_mock_read(asfd, &r, -1, CMD_GEN, "adfdff");
}
static void setup_no_hello(struct asfd *asfd)
{
int r=0;
asfd_mock_read(asfd, &r, 0, CMD_GEN, "blarg");
}
static void setup_happy_path(struct asfd *asfd)
{
int r=0;
int w=0;
const char *cnames[] = {"testclient", NULL};
build_clientconfdir_files(cnames, "password=mypass\nkeep=4\n");
asfd_mock_read(asfd, &r, 0, CMD_GEN, "hello:" VERSION);
asfd_assert_write(asfd, &w, 0, CMD_GEN, "whoareyou:" VERSION);
asfd_mock_read(asfd, &r, 0, CMD_GEN, "testclient");
asfd_assert_write(asfd, &w, 0, CMD_GEN, "okpassword");
asfd_mock_read(asfd, &r, 0, CMD_GEN, "mypass");
asfd_assert_write(asfd, &w, 0, CMD_GEN, "ok");
}
static void setup_okpassword_error(struct asfd *asfd)
{
int r=0;
int w=0;
asfd_mock_read(asfd, &r, 0, CMD_GEN, "hello:" VERSION);
asfd_assert_write(asfd, &w, 0, CMD_GEN, "whoareyou:" VERSION);
asfd_mock_read(asfd, &r, 0, CMD_GEN, "testclient");
asfd_assert_write(asfd, &w, -1, CMD_GEN, "okpassword");
}
static void setup_whoareyou_error(struct asfd *asfd)
{
int r=0;
int w=0;
asfd_mock_read(asfd, &r, 0, CMD_GEN, "hello:" VERSION);
asfd_assert_write(asfd, &w, -1, CMD_GEN, "whoareyou:" VERSION);
}
static void setup_happy_path_version_unknown(struct asfd *asfd)
{
int r=0;
int w=0;
const char *cnames[] = {"testclient", NULL};
build_clientconfdir_files(cnames, "password=mypass\nkeep=4\n");
asfd_mock_read(asfd, &r, 0, CMD_GEN, "hello");
asfd_assert_write(asfd, &w, 0, CMD_GEN, "whoareyou");
asfd_mock_read(asfd, &r, 0, CMD_GEN, "testclient");
asfd_assert_write(asfd, &w, 0, CMD_GEN, "okpassword");
asfd_mock_read(asfd, &r, 0, CMD_GEN, "mypass");
asfd_assert_write(asfd, &w, 0, CMD_WARNING, "Client 'testclient' has an unknown version. Please upgrade.\n");
asfd_assert_write(asfd, &w, 0, CMD_GEN, "ok");
}
static void setup_happy_path_version_mismatch(struct asfd *asfd)
{
int r=0;
int w=0;
const char *cnames[] = {"testclient", NULL};
build_clientconfdir_files(cnames, "password=mypass\nkeep=4\n");
asfd_mock_read(asfd, &r, 0, CMD_GEN, "hello:2.0.0");
asfd_assert_write(asfd, &w, 0, CMD_GEN, "whoareyou:" VERSION);
asfd_mock_read(asfd, &r, 0, CMD_GEN, "testclient");
asfd_assert_write(asfd, &w, 0, CMD_GEN, "okpassword");
asfd_mock_read(asfd, &r, 0, CMD_GEN, "mypass");
asfd_assert_write(asfd, &w, 0, CMD_WARNING, "Client 'testclient' version '2.0.0' does not match server version '" VERSION "'. An upgrade is recommended.\n");
asfd_assert_write(asfd, &w, 0, CMD_GEN, "ok");
}
static void setup_wrong_password(struct asfd *asfd)
{
int r=0;
int w=0;
const char *cnames[] = {"testclient", NULL};
build_clientconfdir_files(cnames, "password=mypass\nkeep=4\n");
asfd_mock_read(asfd, &r, 0, CMD_GEN, "hello:" VERSION);
asfd_assert_write(asfd, &w, 0, CMD_GEN, "whoareyou:" VERSION);
asfd_mock_read(asfd, &r, 0, CMD_GEN, "testclient");
asfd_assert_write(asfd, &w, 0, CMD_GEN, "okpassword");
asfd_mock_read(asfd, &r, 0, CMD_GEN, "wrongpass");
}
static void setup_no_password_configured(struct asfd *asfd)
{
int r=0;
int w=0;
const char *cnames[] = {"testclient", NULL};
build_clientconfdir_files(cnames, NULL);
asfd_mock_read(asfd, &r, 0, CMD_GEN, "hello:" VERSION);
asfd_assert_write(asfd, &w, 0, CMD_GEN, "whoareyou:" VERSION);
asfd_mock_read(asfd, &r, 0, CMD_GEN, "testclient");
asfd_assert_write(asfd, &w, 0, CMD_GEN, "okpassword");
asfd_mock_read(asfd, &r, 0, CMD_GEN, "mypass");
}
#ifndef HAVE_OPENBSD_OS // Feature not supported on openbsd.
static void setup_passwd_failed(struct asfd *asfd)
{
int r=0;
int w=0;
const char *cnames[] = {"testclient", NULL};
build_clientconfdir_files(cnames, "passwd=hiH9IOyyrrl4k\nkeep=4\n");
asfd_mock_read(asfd, &r, 0, CMD_GEN, "hello:" VERSION);
asfd_assert_write(asfd, &w, 0, CMD_GEN, "whoareyou:" VERSION);
asfd_mock_read(asfd, &r, 0, CMD_GEN, "testclient");
asfd_assert_write(asfd, &w, 0, CMD_GEN, "okpassword");
asfd_mock_read(asfd, &r, 0, CMD_GEN, "dafklfd");
}
#endif
static void setup_no_keep_configured(struct asfd *asfd)
{
int r=0;
int w=0;
const char *cnames[] = {"testclient", NULL};
build_clientconfdir_files(cnames, "password=mypass");
asfd_mock_read(asfd, &r, 0, CMD_GEN, "hello:" VERSION);
asfd_assert_write(asfd, &w, 0, CMD_GEN, "whoareyou:" VERSION);
asfd_mock_read(asfd, &r, 0, CMD_GEN, "testclient");
asfd_assert_write(asfd, &w, 0, CMD_GEN, "okpassword");
asfd_mock_read(asfd, &r, 0, CMD_GEN, "mypass");
}
static void setup_lower_failed(struct asfd *asfd)
{
int r=0;
int w=0;
const char *cnames[] = {"testclient", NULL};
build_clientconfdir_files(cnames, "password=mypass\nkeep=4\n");
asfd_mock_read(asfd, &r, 0, CMD_GEN, "hello:" VERSION);
asfd_assert_write(asfd, &w, 0, CMD_GEN, "whoareyou:" VERSION);
asfd_mock_read(asfd, &r, 0, CMD_GEN, "TESTCLIENT");
asfd_assert_write(asfd, &w, 0, CMD_GEN, "okpassword");
asfd_mock_read(asfd, &r, 0, CMD_GEN, "mypass");
}
static void setup_lower_ok(struct asfd *asfd)
{
int r=0;
int w=0;
const char *cnames[] = {"testclient", NULL};
build_clientconfdir_files(cnames, "password=mypass\nkeep=4\n");
asfd_mock_read(asfd, &r, 0, CMD_GEN, "hello:" VERSION);
asfd_assert_write(asfd, &w, 0, CMD_GEN, "whoareyou:" VERSION);
asfd_mock_read(asfd, &r, 0, CMD_GEN, "TESTCLIENT");
asfd_assert_write(asfd, &w, 0, CMD_GEN, "okpassword");
asfd_mock_read(asfd, &r, 0, CMD_GEN, "mypass");
asfd_assert_write(asfd, &w, 0, CMD_GEN, "ok");
}
static void setup_fqdn_failed(struct asfd *asfd)
{
int r=0;
int w=0;
const char *cnames[] = {"testclient", NULL};
build_clientconfdir_files(cnames, "password=mypass\nkeep=4\n");
asfd_mock_read(asfd, &r, 0, CMD_GEN, "hello:" VERSION);
asfd_assert_write(asfd, &w, 0, CMD_GEN, "whoareyou:" VERSION);
asfd_mock_read(asfd, &r, 0, CMD_GEN, "testclient.f.q.d.n");
asfd_assert_write(asfd, &w, 0, CMD_GEN, "okpassword");
asfd_mock_read(asfd, &r, 0, CMD_GEN, "mypass");
}
static void setup_fqdn_ok(struct asfd *asfd)
{
int r=0;
int w=0;
const char *cnames[] = {"testclient", NULL};
build_clientconfdir_files(cnames, "password=mypass\nkeep=4\n");
asfd_mock_read(asfd, &r, 0, CMD_GEN, "hello:" VERSION);
asfd_assert_write(asfd, &w, 0, CMD_GEN, "whoareyou:" VERSION);
asfd_mock_read(asfd, &r, 0, CMD_GEN, "testclient.f.q.d.n");
asfd_assert_write(asfd, &w, 0, CMD_GEN, "okpassword");
asfd_mock_read(asfd, &r, 0, CMD_GEN, "mypass");
asfd_assert_write(asfd, &w, 0, CMD_GEN, "ok");
}
START_TEST(test_authorise_server)
{
do_test(-1, setup_initial_error);
do_test(-1, setup_no_hello);
do_test(0, setup_happy_path);
do_test(0, setup_happy_path_version_unknown);
do_test(0, setup_happy_path_version_mismatch);
do_test(-1, setup_whoareyou_error);
do_test(-1, setup_okpassword_error);
do_test(-1, setup_wrong_password);
do_test(-1, setup_no_password_configured);
#ifndef HAVE_OPENBSD_OS // Feature not supported on openbsd.
do_test(-1, setup_passwd_failed);
#endif
do_test(-1, setup_no_keep_configured);
#ifndef HAVE_DARWIN_OS
// MacOSX has case insensitive fs so this test fails in such case
do_test(-1, setup_lower_failed);
#endif
CNAME_LOWERCASE=1;
do_test(0, setup_lower_ok);
do_test(-1, setup_fqdn_failed);
CNAME_FQDN=0;
do_test(0, setup_fqdn_ok);
}
END_TEST
Suite *suite_server_auth(void)
{
Suite *s;
TCase *tc_core;
s=suite_create("server_auth");
tc_core=tcase_create("Core");
tcase_add_test(tc_core, test_check_passwd);
tcase_add_test(tc_core, test_authorise_server);
suite_add_tcase(s, tc_core);
return s;
}
|
