1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341
|
/***************************************************************************
* Copyright (C) 2013 by Pablo Daniel Pareja Obregon *
* *
* This is free software; you can redistribute it and/or modify *
* it under the terms of the GNU General Public License as published by *
* the Free Software Foundation; either version 2, or (at your option) *
* any later version. *
* *
* This software is distributed in the hope that it will be useful, *
* but WITHOUT ANY WARRANTY; without even the implied warranty of *
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the *
* GNU General Public License for more details. *
* *
* You should have received a copy of the GNU General Public License *
* along with this package; see the file COPYING. If not, write to *
* the Free Software Foundation, Inc., 51 Franklin Street - Fifth Floor, *
* Boston, MA 02110-1301, USA. *
***************************************************************************/
namespace Caneda
{
/*!
* \page CodingStylePage Caneda Coding Style
*
* \tableofcontents
*
* Extracted from Arora Coding Style. Feel free to edit to our needs.
*
* \section Introduction Introduction
*
* Caneda uses the same coding style as Qt. If you use the git_hooks there is
* a pre-commit_checkstyle that will warn you of style errors. Keeping the
* code consistant is important for readability both for fixing bugs and
* bringing in new developers. Base all dialogs on .ui files (ie create them
* using Qt Designer) so that layouts can be perfected effectively.
* SaveDocumentsDialog is an example for this.
*
* \subsection Indentation Indentation
* \li 4 spaces are used for indentation
* \li Spaces, not tabs!
*
* \subsection DeclaringVariables Declaring variables
* \li Declare each variable on a separate line
* \li Avoid short (e.g., a,rbarr,nughdeget) names whenever possible
* \li Single character variable names are only okay for counters and
* temporaries, where the purpose of the variable is obvious
* \li Wait with declaring a variable until it is needed
*
* \code{.cpp}
* // Wrong
* int a, b;
* char *c, *d;
* \endcode
*
* \code{.cpp}
* // Correct
* int height;
* int width;
* char *nameOfThis;
* char *nameOfThat;
* \endcode
*
* \li Variables and functions start with a small letter. Each consecutive word
* in a variable's name starts with a capital letter
* \li Avoid abbreviations
*
* \code{.cpp}
* // Wrong
* short Cntr;
* char ITEM_DELIM = '\t';
* \endcode
*
* \code{.cpp}
* // Correct
* short counter;
* char itemDelimiter = '\t';
* \endcode
*
* \li Classes always start with a big letter.
*
* \subsection Whitespace Whitespace
* \li Use blank lines to group statements together where suited
* \li Always use only one blank line
* \li Always use a single space after a keyword, and before a curly brace.
*
* \code{.cpp}
* // Wrong
* if(foo){
* }
* \endcode
*
* \code{.cpp}
* // Correct
* if (foo) {
* }
* \endcode
*
* \li For pointers or references, always use a single space before * or &,
* but never after. Exception: template parameters - use no space before and no
* space after * or &.
* \li No space after a cast.
* \li Avoid C-style casts when possible.
*
* \code{.cpp}
* // Wrong
* char* blockOfMemory = (char* ) malloc(data.size());
* \endcode
*
* \code{.cpp}
* // Correct
* char *blockOfMemory = (char *)malloc(data.size());
* char *blockOfMemory = reinterpret_cast<char*>(malloc(data.size()));
* \endcode
*
* \subsection Braces Braces
* \li As a base rule, the left curly brace goes on the same line as the start
* of the statement:
*
* \code{.cpp}
* // Wrong
* if (codec)
* {
* }
* \endcode
*
* \code{.cpp}
* // Correct
* if (codec) {
* }
* \endcode
*
* \li Exception: Function implementations and class declarations always have
* the left brace on the start of a line:
*
* \code{.cpp}
* static void foo(int g)
* {
* qDebug("foo: %i", g);
* }
* \endcode
*
* \code{.cpp}
* class Moo
* {
* };
* \endcode
*
* \li Use curly braces when the body of a conditional statement contains more
* than one line, and also if a single line statement is somewhat complex.
*
* \code{.cpp}
* // Wrong
* if (address.isEmpty()) {
* return false;
* }
*
* for (int i = 0; i < 10; ++i) {
* qDebug("%i", i);
* }
* \endcode
*
* \code{.cpp}
* // Correct
* if (address.isEmpty())
* return false;
*
* for (int i = 0; i < 10; ++i)
* qDebug("%i", i);
* \endcode
*
* \li Exception 1: Use braces also if the parent statement covers several
* lines / wraps
*
* \code{.cpp}
* // Correct
* if (address.isEmpty() || !isValid()
* || !codec) {
* return false;
* }
* \endcode
*
* \li Exception 2: Use braces also in if-then-else blocks where either the
* if-code or the else-code covers several lines
*
* \code{.cpp}
* // Wrong
* if (address.isEmpty())
* return false;
* else {
* qDebug("%s", qPrintable(address));
* ++it;
* }
* \endcode
*
* \code{.cpp}
* // Correct
* if (address.isEmpty()) {
* return false;
* } else {
* qDebug("%s", qPrintable(address));
* ++it;
* }
* \endcode
*
* \code{.cpp}
* // Wrong
* if (a)
* if (b)
* ...
* else
* ...
* \endcode
*
* \code{.cpp}
* // Correct
* if (a) {
* if (b)
* ...
* else
* ...
* }
* \endcode
*
* \li Use curly braces when the body of a conditional statement is empty
*
* \code{.cpp}
* // Wrong
* while (a);
* \endcode
*
* \code{.cpp}
* // Correct
* while (a) {}
* \endcode
*
* \subsection Parentheses Parentheses
* \li Use parentheses to group expressions:
*
* \code{.cpp}
* // Wrong
* if (a && b || c)
* \endcode
*
* \code{.cpp}
* // Correct
* if ((a && b) || c)
* \endcode
*
* \code{.cpp}
* // Wrong
* a + b & c
* \endcode
*
* \code{.cpp}
* // Correct
* (a + b) & c
* \endcode
*
* \subsection SwitchStatements Switch statements
* \li The case labels are on the same column as the switch
* \li Every case must have a break (or return) statement at the end or a
* comment to indicate that there's intentionally no break
*
* \code{.cpp}
* switch (myEnum) {
* case Value1:
* doSomething();
* break;
* case Value2:
* doSomethingElse();
* // fall through
* default:
* defaultHandling();
* break;
* }
* \endcode
*
* \subsection LineBreaks Line breaks
* \li Keep lines shorter than 100 characters; insert line breaks if necessary.
* \li Commas go at the end of a broken line; operators start at the beginning
* of the new line. The operator is at the end of the line to avoid having to
* scroll if your editor is too narrow.
*
* \code{.cpp}
* // Correct
* if (longExpression
* + otherLongExpression
* + otherOtherLongExpression) {
* }
* \endcode
*
* \code{.cpp}
* // Wrong
* if (longExpression +
* otherLongExpression +
* otherOtherLongExpression) {
* }
* \endcode
*
* \subsection ForwardDeclarations Forward declarations
* Use forward declaration when possible. Suppose you want to define a new
* class B that uses objects of class A. If B only uses references or pointers
* to A, use forward declarations (you don't need to include <A.h> in the
* header, but include it in the cpp). This will in turn speed a little bit the
* compilation.
*
* \code{.cpp}
* class A ;
*
* class B {
* private:
* A *fPtrA;
* public:
* void mymethod(const& A) const;
* };
* \endcode
*
* B derives from A or B explicitely (or implicitely) uses objects of class A.
* You then need to include <A.h>
*
* \code{.cpp}
* #include <A.h>
*
* class B : public A{
*
* };
*
* class C {
* private:
* A fA;
* public:
* void mymethod(A par);
* }
* \endcode
*
* \section GeneralException General exception
* Feel free to break a rule if it makes your code look bad.
*
*/
} // namespace Caneda
|