1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
|
// -*- compile-command: "./test_single_testcase.sh TTestSysUtils" -*-
{
Copyright 2015-2021 Michalis Kamburelis.
This file is part of "Castle Game Engine".
"Castle Game Engine" is free software; see the file COPYING.txt,
included in this distribution, for details about the copyright.
"Castle Game Engine" is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
----------------------------------------------------------------------------
}
unit TestSysUtils;
interface
uses
Classes, SysUtils, CastleTester;
type
TTestSysUtils = class(TCastleTestCase)
procedure TestDirectoryFileExists;
end;
implementation
uses CastleFilesUtils, CastleUriUtils;
procedure TTestSysUtils.TestDirectoryFileExists;
begin
{ Before FPC 3.2.0:
FPC FileExists on Unix answers true for both regular files and directories.
Unlike FPC FileExists on Windows, that answers true only for regular files.
See http://www.freepascal.org/docs-html/rtl/sysutils/fileexists.html
http://free-pascal-general.1045716.n5.nabble.com/FileExists-inconsistency-td2813433.html
IMHO that's quite bad.
- It's inconsistent across two platforms.
- And Unix behavior is unexpected.
FPC docs for FileExists say that this is deliberate on Unix,
because "on Unix files are directories".
But this seems like an after-thought explanation of a broken behavior
in FPC docs.
Indeed on Unix many things are "some kind of files"
(including directories, sockets, pipes) when looking at C API and kernel API,
but that's an internal detail for most people.
In normal conversations, in normal API descriptions,
when someone talks about "files", it's natural
(also to Unix users and developers) to understand
that you mean "regular files; not directories, network sockets, pipes...".
It was fixed in
https://github.com/graemeg/freepascal/commit/6fbfe3fc4c1dc23908b14a68fe54ae04d53ded73 ,
thankfully.
}
{$ifdef MSWINDOWS}
AssertFalse(FileExists(UriToFilenameSafe('castle-data:/')));
AssertFalse(FileExists(UriToFilenameSafe('castle-data:/images/')));
{$else}
{$if not defined(VER3_3)} // For FPC 3.3.1, the behavior depends on exact revision...
{$if defined(VER3_0) or defined(VER3_1)}
AssertTrue(FileExists(UriToFilenameSafe('castle-data:/')));
AssertTrue(FileExists(UriToFilenameSafe('castle-data:/images/')));
{$else}
AssertFalse(FileExists(UriToFilenameSafe('castle-data:/')));
AssertFalse(FileExists(UriToFilenameSafe('castle-data:/images/')));
{$endif}
{$endif}
{$endif}
AssertTrue(FileExists(UriToFilenameSafe('castle-data:/test.xml')));
AssertTrue(not FileExists(UriToFilenameSafe('castle-data:/test-not-existing.xml')));
{ Our RegularFileExists does not detect directory as "file". }
AssertFalse(RegularFileExists(UriToFilenameSafe('castle-data:/')));
AssertFalse(RegularFileExists(UriToFilenameSafe('castle-data:/images/')));
AssertTrue(RegularFileExists(UriToFilenameSafe('castle-data:/test.xml')));
AssertTrue(not RegularFileExists(UriToFilenameSafe('castle-data:/test-not-existing.xml')));
{ DirectoryExists detects directories, not regular files. }
AssertTrue(DirectoryExists(UriToFilenameSafe('castle-data:/')));
AssertTrue(DirectoryExists(UriToFilenameSafe('castle-data:/images/')));
AssertTrue(not DirectoryExists(UriToFilenameSafe('castle-data:/test.xml')));
AssertTrue(not DirectoryExists(UriToFilenameSafe('castle-data:/test-not-existing.xml')));
end;
initialization
RegisterTest(TTestSysUtils);
end.
|
