1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588
|
/*******************************************************************\
Module: Unit tests of the expression simplifier
Author: Michael Tautschnig
\*******************************************************************/
#include <util/arith_tools.h>
#include <util/bitvector_expr.h>
#include <util/byte_operators.h>
#include <util/c_types.h>
#include <util/cmdline.h>
#include <util/config.h>
#include <util/mathematical_expr.h>
#include <util/namespace.h>
#include <util/pointer_expr.h>
#include <util/pointer_predicates.h>
#include <util/simplify_expr.h>
#include <util/simplify_utils.h>
#include <util/std_expr.h>
#include <util/symbol_table.h>
#include <testing-utils/use_catch.h>
TEST_CASE("Simplify pointer_offset(address of array index)", "[core][util]")
{
config.set_arch("none");
symbol_tablet symbol_table;
namespacet ns(symbol_table);
array_typet array_type(char_type(), from_integer(2, size_type()));
symbol_exprt array("A", array_type);
index_exprt index(array, from_integer(1, c_index_type()));
address_of_exprt address_of(index);
exprt p_o=pointer_offset(address_of);
exprt simp=simplify_expr(p_o, ns);
REQUIRE(simp.is_constant());
const mp_integer offset_value =
numeric_cast_v<mp_integer>(to_constant_expr(simp));
REQUIRE(offset_value==1);
}
TEST_CASE("Simplify byte extract", "[core][util]")
{
// this test does require a proper architecture to be set so that byte extract
// uses adequate endianness
cmdlinet cmdline;
config.set(cmdline);
symbol_tablet symbol_table;
namespacet ns(symbol_table);
// byte-extracting type T at offset 0 from an object of type T yields the
// object
symbol_exprt s("foo", size_type());
byte_extract_exprt be =
make_byte_extract(s, from_integer(0, c_index_type()), size_type());
exprt simp = simplify_expr(be, ns);
REQUIRE(simp == s);
}
TEST_CASE("expr2bits and bits2expr respect bit order", "[core][util]")
{
symbol_tablet symbol_table;
namespacet ns(symbol_table);
exprt deadbeef = from_integer(0xdeadbeef, unsignedbv_typet(32));
const auto le = expr2bits(deadbeef, true, ns);
REQUIRE(le.has_value());
REQUIRE(le->size() == 32);
const auto should_be_deadbeef1 =
bits2expr(*le, unsignedbv_typet(32), true, ns);
REQUIRE(deadbeef == *should_be_deadbeef1);
const auto be = expr2bits(deadbeef, false, ns);
REQUIRE(be.has_value());
REQUIRE(be->size() == 32);
const auto should_be_deadbeef2 =
bits2expr(*be, unsignedbv_typet(32), false, ns);
REQUIRE(deadbeef == *should_be_deadbeef2);
c_bit_field_typet four_bits{unsignedbv_typet{8}, 4};
struct_typet st{{{"s", unsignedbv_typet{16}},
{"bf1", four_bits},
{"bf2", four_bits},
{"b", unsignedbv_typet{8}}}};
const auto fill_struct_le = bits2expr(*le, st, true, ns);
REQUIRE(fill_struct_le.has_value());
REQUIRE(
to_struct_expr(*fill_struct_le).operands()[1] ==
from_integer(0xd, four_bits));
REQUIRE(
to_struct_expr(*fill_struct_le).operands()[2] ==
from_integer(0xa, four_bits));
const auto fill_struct_be = bits2expr(*be, st, false, ns);
REQUIRE(fill_struct_be.has_value());
REQUIRE(
to_struct_expr(*fill_struct_be).operands()[1] ==
from_integer(0xb, four_bits));
REQUIRE(
to_struct_expr(*fill_struct_be).operands()[2] ==
from_integer(0xe, four_bits));
}
TEST_CASE("Simplify extractbit", "[core][util]")
{
// this test does require a proper architecture to be set so that byte extract
// uses adequate endianness
const cmdlinet cmdline;
config.set(cmdline);
const symbol_tablet symbol_table;
const namespacet ns(symbol_table);
// binary: 1101 1110 1010 1101 1011 1110 1110 1111
// ^MSB LSB^
// bit23^ bit4^
// extractbit and extractbits use offsets with respect to the
// least-significant bit, endianess does not impact them
const exprt deadbeef = from_integer(0xdeadbeef, unsignedbv_typet(32));
exprt eb1 = extractbit_exprt(deadbeef, 4);
bool unmodified = simplify(eb1, ns);
REQUIRE(!unmodified);
REQUIRE(eb1 == false_exprt());
exprt eb2 = extractbit_exprt(deadbeef, 23);
unmodified = simplify(eb2, ns);
REQUIRE(!unmodified);
REQUIRE(eb2 == true_exprt());
}
TEST_CASE("Simplify extractbits", "[core][util]")
{
// this test does require a proper architecture to be set so that byte extract
// uses adequate endianness
const cmdlinet cmdline;
config.set(cmdline);
const symbol_tablet symbol_table;
const namespacet ns(symbol_table);
const exprt deadbeef = from_integer(0xdeadbeef, unsignedbv_typet(32));
exprt eb = extractbits_exprt(deadbeef, 8, unsignedbv_typet(8));
bool unmodified = simplify(eb, ns);
REQUIRE(!unmodified);
REQUIRE(eb == from_integer(0xbe, unsignedbv_typet(8)));
}
TEST_CASE("Simplify shift", "[core][util]")
{
const symbol_tablet symbol_table;
const namespacet ns(symbol_table);
REQUIRE(
simplify_expr(shl_exprt(from_integer(5, signedbv_typet(8)), 1), ns) ==
from_integer(10, signedbv_typet(8)));
REQUIRE(
simplify_expr(ashr_exprt(from_integer(5, signedbv_typet(8)), 1), ns) ==
from_integer(2, signedbv_typet(8)));
REQUIRE(
simplify_expr(lshr_exprt(from_integer(5, unsignedbv_typet(8)), 1), ns) ==
from_integer(2, unsignedbv_typet(8)));
REQUIRE(
simplify_expr(ashr_exprt(from_integer(-4, signedbv_typet(8)), 1), ns) ==
from_integer(-2, signedbv_typet(8)));
REQUIRE(
simplify_expr(lshr_exprt(from_integer(-4, signedbv_typet(8)), 1), ns) ==
from_integer(126, signedbv_typet(8)));
}
TEST_CASE("Simplify dynamic object comparison", "[core][util]")
{
const symbol_tablet symbol_table;
const namespacet ns(symbol_table);
dynamic_object_exprt dynamic_object(signedbv_typet(8));
dynamic_object.set_instance(1);
address_of_exprt address_of_dynamic_object(dynamic_object);
equal_exprt compare_null(
address_of_dynamic_object,
null_pointer_exprt(to_pointer_type(address_of_dynamic_object.type())));
REQUIRE(simplify_expr(compare_null, ns) == false_exprt());
typecast_exprt cast_address(
address_of_dynamic_object, pointer_type(signedbv_typet(16)));
equal_exprt compare_null_through_cast(
cast_address, null_pointer_exprt(to_pointer_type(cast_address.type())));
REQUIRE(simplify_expr(compare_null_through_cast, ns) == false_exprt());
dynamic_object_exprt other_dynamic_object(signedbv_typet(8));
other_dynamic_object.set_instance(2);
address_of_exprt address_of_other_dynamic_object(other_dynamic_object);
equal_exprt compare_pointer_objects(
pointer_object(address_of_dynamic_object),
pointer_object(address_of_other_dynamic_object));
REQUIRE(simplify_expr(compare_pointer_objects, ns) == false_exprt());
symbol_exprt s{"foo", signedbv_typet{8}};
address_of_exprt address_of_symbol{s};
equal_exprt compare_symbol_dynamic{address_of_dynamic_object,
address_of_symbol};
REQUIRE(simplify_expr(compare_symbol_dynamic, ns) == false_exprt{});
}
TEST_CASE("Simplify pointer_object equality", "[core][util]")
{
// this test requires a proper architecture to be set up so that pointers have
// a width
const cmdlinet cmdline;
config.set(cmdline);
symbol_tablet symbol_table;
namespacet ns(symbol_table);
exprt p_o_void =
pointer_object(null_pointer_exprt{pointer_type(empty_typet{})});
exprt p_o_int =
pointer_object(null_pointer_exprt{pointer_type(signedbv_typet(32))});
exprt simp = simplify_expr(equal_exprt{p_o_void, p_o_int}, ns);
REQUIRE(simp.is_true());
}
TEST_CASE("Simplify cast from bool", "[core][util]")
{
symbol_tablet symbol_table;
namespacet ns(symbol_table);
{
// this checks that ((int)B)==1 turns into B
exprt B = symbol_exprt("B", bool_typet());
exprt comparison = equal_exprt(
typecast_exprt(B, signedbv_typet(32)),
from_integer(1, signedbv_typet(32)));
exprt simp = simplify_expr(comparison, ns);
REQUIRE(simp == B);
}
{
// this checks that ((int)B)==0 turns into !B
exprt B = symbol_exprt("B", bool_typet());
exprt comparison = equal_exprt(
typecast_exprt(B, signedbv_typet(32)),
from_integer(0, signedbv_typet(32)));
exprt simp = simplify_expr(comparison, ns);
REQUIRE(simp == not_exprt(B));
}
{
// this checks that ((int)B)!=1 turns into !B
exprt B = symbol_exprt("B", bool_typet());
exprt comparison = notequal_exprt(
typecast_exprt(B, signedbv_typet(32)),
from_integer(1, signedbv_typet(32)));
exprt simp = simplify_expr(comparison, ns);
REQUIRE(simp == not_exprt(B));
}
{
// this checks that ((int)B)!=0 turns into B
exprt B = symbol_exprt("B", bool_typet());
exprt comparison = notequal_exprt(
typecast_exprt(B, signedbv_typet(32)),
from_integer(0, signedbv_typet(32)));
exprt simp = simplify_expr(comparison, ns);
REQUIRE(simp == B);
}
}
TEST_CASE("simplify_expr boolean expressions", "[core][util]")
{
symbol_tablet symbol_table;
namespacet ns{symbol_table};
SECTION("Binary boolean operations")
{
struct test_entryt
{
exprt lhs;
exprt rhs;
exprt expected_value;
};
SECTION("AND")
{
std::vector<test_entryt> test_values = {
{true_exprt(), true_exprt(), true_exprt()},
{true_exprt(), false_exprt(), false_exprt()},
{false_exprt(), true_exprt(), false_exprt()},
{false_exprt(), false_exprt(), false_exprt()},
};
for(const auto &entry : test_values)
{
const exprt result = simplify_expr(and_exprt{entry.lhs, entry.rhs}, ns);
REQUIRE(result == entry.expected_value);
}
}
SECTION("OR")
{
std::vector<test_entryt> test_values = {
{true_exprt(), true_exprt(), true_exprt()},
{true_exprt(), false_exprt(), true_exprt()},
{false_exprt(), true_exprt(), true_exprt()},
{false_exprt(), false_exprt(), false_exprt()},
};
for(const auto &entry : test_values)
{
const exprt result = simplify_expr(or_exprt{entry.lhs, entry.rhs}, ns);
REQUIRE(result == entry.expected_value);
}
}
SECTION("Implies")
{
std::vector<test_entryt> test_values = {
{true_exprt(), true_exprt(), true_exprt()},
{true_exprt(), false_exprt(), false_exprt()},
{false_exprt(), true_exprt(), true_exprt()},
{false_exprt(), false_exprt(), true_exprt()},
};
for(const auto &entry : test_values)
{
const exprt result =
simplify_expr(implies_exprt{entry.lhs, entry.rhs}, ns);
REQUIRE(result == entry.expected_value);
}
}
}
SECTION("Not")
{
REQUIRE(simplify_expr(not_exprt{true_exprt()}, ns) == false_exprt());
REQUIRE(simplify_expr(not_exprt{false_exprt()}, ns) == true_exprt());
}
SECTION("Nested boolean expressions")
{
INFO("((!true) || (false => false)) && true)")
REQUIRE(
simplify_expr(
and_exprt{or_exprt{not_exprt{true_exprt{}},
implies_exprt{false_exprt{}, false_exprt{}}},
true_exprt{}},
ns) == true_exprt{});
}
SECTION("Numeric comparisons")
{
struct test_entryt
{
irep_idt comparison;
int lhs;
int rhs;
exprt expected;
};
std::vector<test_entryt> comparisons = {
{ID_lt, -1, 1, true_exprt()},
{ID_lt, 1, 1, false_exprt()},
{ID_lt, 1, -1, false_exprt()},
{ID_le, -1, 1, true_exprt()},
{ID_le, 1, 1, true_exprt()},
{ID_le, 1, -1, false_exprt()},
{ID_ge, -1, 1, false_exprt()},
{ID_ge, 1, 1, true_exprt()},
{ID_ge, 1, -1, true_exprt()},
{ID_gt, -1, 1, false_exprt()},
{ID_gt, 1, 1, false_exprt()},
{ID_gt, 1, -1, true_exprt()},
};
const auto binary_relation_from = [](const test_entryt &entry) {
const signedbv_typet int_type(32);
return binary_relation_exprt{from_integer(entry.lhs, int_type),
entry.comparison,
from_integer(entry.rhs, int_type)};
};
for(const test_entryt &test_entry : comparisons)
{
REQUIRE(
simplify_expr(binary_relation_from(test_entry), ns) ==
test_entry.expected);
}
}
}
TEST_CASE("Simplifying cast expressions", "[core][util]")
{
symbol_tablet symbol_table;
namespacet ns(symbol_table);
const auto short_type = signedbv_typet(16);
const auto int_type = signedbv_typet(32);
const auto long_type = signedbv_typet(64);
array_typet array_type(int_type, from_integer(5, int_type));
symbolt a_symbol{"a", array_type, irep_idt{}};
a_symbol.base_name = "a";
a_symbol.is_lvalue = true;
symbol_table.add(a_symbol);
symbolt i_symbol{"i", int_type, irep_idt{}};
i_symbol.base_name = "i";
i_symbol.is_lvalue = true;
symbol_table.add(i_symbol);
config.set_arch("none");
SECTION("Simplifying a[(signed long int)0]")
{
// a[(signed long int)0]
index_exprt expr{symbol_exprt{"a", array_type},
typecast_exprt{from_integer(0, int_type), long_type}};
// cast is applied on the constant
const auto simplified_expr = simplify_expr(expr, ns);
REQUIRE(
simplified_expr ==
index_exprt{symbol_exprt{"a", array_type}, from_integer(0, long_type)});
}
SECTION("Simplifying a[(signed long int)i]")
{
// a[(signed long int)0]
index_exprt expr{symbol_exprt{"a", array_type},
typecast_exprt{i_symbol.symbol_expr(), long_type}};
// Cast is not removed as up casting a symbol
const auto simplified_expr = simplify_expr(expr, ns);
REQUIRE(simplified_expr == expr);
}
SECTION("Simplifying a[(signed int)i]")
{
// a[(signed int)i]
index_exprt expr{symbol_exprt{"a", array_type},
typecast_exprt{i_symbol.symbol_expr(), int_type}};
const auto simplified_expr = simplify_expr(expr, ns);
REQUIRE(
simplified_expr ==
index_exprt{symbol_exprt{"a", array_type}, i_symbol.symbol_expr()});
}
SECTION("Simplifying a[(signed short)0]")
{
// a[(signed short)0]
index_exprt expr{symbol_exprt{"a", array_type},
typecast_exprt{from_integer(0, int_type), short_type}};
// Can be simplified as the number is a constant
const auto simplified_expr = simplify_expr(expr, ns);
REQUIRE(
simplified_expr ==
index_exprt{symbol_exprt{"a", array_type}, from_integer(0, short_type)});
}
SECTION("Simplifying a[(signed short)i]")
{
// a[(signed short)i]
index_exprt expr{symbol_exprt{"a", array_type},
typecast_exprt{i_symbol.symbol_expr(), short_type}};
// No simplification as the cast may have an effect
const auto simplified_expr = simplify_expr(expr, ns);
REQUIRE(simplified_expr == expr);
}
SECTION("Simplifying (unsigned)(B ? 4 : 5) > 3")
{
signedbv_typet sbv{4};
unsignedbv_typet ubv{4};
symbol_exprt b{"B", bool_typet{}};
if_exprt if_b{b, from_integer(4, sbv), from_integer(5, sbv)};
binary_relation_exprt comparison_gt{
typecast_exprt{if_b, ubv}, ID_gt, from_integer(3, ubv)};
exprt simp = simplify_expr(comparison_gt, ns);
REQUIRE(simp == true_exprt{});
}
}
TEST_CASE("Simplify bitor", "[core][util]")
{
const symbol_tablet symbol_table;
const namespacet ns(symbol_table);
SECTION("Simplification for raw bitvector")
{
bv_typet bv{4};
constant_exprt zero = from_integer(0, bv);
symbol_exprt b{"B", bv};
REQUIRE(simplify_expr(bitor_exprt{b, zero}, ns) == b);
}
}
TEST_CASE("Simplify inequality", "[core][util]")
{
symbol_tablet symbol_table;
namespacet ns(symbol_table);
{
// This checks that 3 < (B ? 4 : 5) simplifies to true, just like (B ? 4 :
// 5) > 3 simplifies to true.
signedbv_typet sbv{4};
symbol_exprt b{"B", bool_typet{}};
if_exprt if_b{b, from_integer(4, sbv), from_integer(5, sbv)};
binary_relation_exprt comparison_gt{if_b, ID_gt, from_integer(3, sbv)};
exprt simp = simplify_expr(comparison_gt, ns);
REQUIRE(simp == true_exprt{});
binary_relation_exprt comparison_lt{from_integer(3, sbv), ID_lt, if_b};
simp = simplify_expr(comparison_lt, ns);
REQUIRE(simp == true_exprt{});
}
}
TEST_CASE("Simplify bitxor", "[core][util]")
{
config.set_arch("none");
const symbol_tablet symbol_table;
const namespacet ns(symbol_table);
SECTION("Simplification for c_bool")
{
constant_exprt false_c_bool = from_integer(0, c_bool_type());
REQUIRE(
simplify_expr(bitxor_exprt{false_c_bool, false_c_bool}, ns) ==
false_c_bool);
}
}
TEST_CASE("Simplify power", "[core][util]")
{
const symbol_tablet symbol_table;
const namespacet ns{symbol_table};
SECTION("Simplification for power")
{
symbol_exprt a{"a", integer_typet{}};
REQUIRE(
simplify_expr(power_exprt{a, from_integer(1, integer_typet{})}, ns) == a);
}
}
|