1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
|
/*
Copyright 2024 Northern.tech AS
This file is part of CFEngine 3 - written and maintained by Northern.tech AS.
This program is free software; you can redistribute it and/or modify it
under the terms of the GNU General Public License as published by the
Free Software Foundation; version 3.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program; if not, write to the Free Software
Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA
To the extent this program is licensed as part of the Enterprise
versions of CFEngine, the applicable Commercial Open Source License
(COSL) may apply to this file if you as a licensee so wish it. See
included file COSL.txt.
*/
#include <files_properties.h>
#include <files_names.h>
#include <files_interfaces.h>
#include <item_lib.h>
static Item *SUSPICIOUSLIST = NULL; /* GLOBAL_P */
void AddFilenameToListOfSuspicious(const char *pattern)
{
PrependItem(&SUSPICIOUSLIST, pattern, NULL);
}
static const char *const SKIPFILES[] =
{
".",
"..",
"lost+found",
".cfengine.rm",
NULL
};
/* TODO rework to accept only one param: path+nodename */
static bool ConsiderFile(const char *nodename, const char *path, struct stat *stat)
{
int i;
if (nodename[0] == '\0')
{
Log(LOG_LEVEL_ERR, "Empty (null) filename detected in '%s', skipping", path);
return false;
}
if (stat != NULL && (S_ISREG(stat->st_mode) || S_ISLNK(stat->st_mode)) &&
IsItemIn(SUSPICIOUSLIST, nodename))
{
Log(LOG_LEVEL_WARNING, "Filename '%s/%s' is classified as suspiscious, skipping", path, nodename);
return false;
}
/* A file named '...' is likely to be a path traversal attempt, see http://cwe.mitre.org/data/definitions/32.html */
if (strcmp(nodename, "...") == 0)
{
Log(LOG_LEVEL_WARNING, "Possible path traversal attempt detected in '%s/%s', skipping", path, nodename);
return false;
}
for (i = 0; SKIPFILES[i] != NULL; i++)
{
if (strcmp(nodename, SKIPFILES[i]) == 0)
{
Log(LOG_LEVEL_VERBOSE, "Filename '%s/%s' is classified as ignorable, skipping", path, nodename);
return false;
}
}
return true;
}
bool ConsiderLocalFile(const char *filename, const char *directory)
{
struct stat stat;
if (lstat(filename, &stat) == -1)
{
return ConsiderFile(filename, directory, NULL);
}
else
{
return ConsiderFile(filename, directory, &stat);
}
}
bool ConsiderAbstractFile(const char *filename, const char *directory, const FileCopy *fc, AgentConnection *conn)
{
/* First check if the file should be avoided, e.g. ".." - before sending
* anything over the network*/
if (!ConsiderFile(filename, directory, NULL))
{
return false;
}
/* TODO this function should accept the joined path in the first place
* since it's joined elsewhere as well, if split needed do it here. */
char buf[CF_BUFSIZE];
int ret = snprintf(buf, sizeof(buf), "%s/%s", directory, filename);
if (ret < 0)
{
Log(LOG_LEVEL_ERR,
"Unexpected failure from snprintf (%d - %s) on '%s' "
"(ConsiderAbstractFile)", errno, GetErrorStr(), buf);
return false;
}
else if ((size_t) ret >= sizeof(buf))
{
Log(LOG_LEVEL_ERR,
"Filename too long! Directory '%s' filename '%s'",
directory, filename);
return false;
}
/* Second, send the STAT command. */
struct stat stat;
if (cf_lstat(buf, &stat, fc, conn) == -1)
{
return false; /* stat() failed */
}
else
{
/* Reconsider, but using stat info this time. */
return ConsiderFile(filename, directory, &stat);
}
}
|
