1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
|
#include <test.h>
#include <iteration.c>
static void test_FindDollarParen(void)
{
/* not found */
assert_int_equal(FindDollarParen("", 1), 0);
assert_int_equal(FindDollarParen(" ", 2), 1);
assert_int_equal(FindDollarParen("$", 2), 1);
assert_int_equal(FindDollarParen("(", 2), 1);
assert_int_equal(FindDollarParen("{", 2), 1);
assert_int_equal(FindDollarParen("$ ", 3), 2);
assert_int_equal(FindDollarParen("$$", 3), 2);
assert_int_equal(FindDollarParen("$[", 3), 2);
assert_int_equal(FindDollarParen("($", 3), 2);
assert_int_equal(FindDollarParen(" $", 3), 2);
assert_int_equal(FindDollarParen(" $[", 4), 3);
assert_int_equal(FindDollarParen("$ (", 4), 3);
assert_int_equal(FindDollarParen("$ {", 4), 3);
/* found */
assert_int_equal(FindDollarParen("${", 3), 0);
assert_int_equal(FindDollarParen("$(", 3), 0);
assert_int_equal(FindDollarParen(" $(", 4), 1);
assert_int_equal(FindDollarParen(" ${", 4), 1);
assert_int_equal(FindDollarParen("$$(", 4), 1);
assert_int_equal(FindDollarParen("$${", 4), 1);
// Detect out of bounds read:
// If max is 0, it shouldn't try to deref these invalid pointers:
char a = 'a';
assert_int_equal(FindDollarParen((char *)0x1, 0), 0);
assert_int_equal(FindDollarParen((&a) + 1, 0), 0);
// Should not read past max bytes:
char b[1] = {'b'};
assert_int_equal(FindDollarParen(b, 1), 1);
char c[8] = {'c', 'c', 'c', 'c', 'c', 'c', 'c', 'c'};
assert_int_equal(FindDollarParen(c, 8), 8);
// We had some problems with FindDollarParen reading outside a buffer
// so I added these cryptic but useful tests. Some of them will only
// fail if you run tests with ASAN, valgrind or similar.
}
static void test_IsMangled(void)
{
/* Simply true. */
assert_false(IsMangled(""));
assert_false(IsMangled("blah"));
assert_false(IsMangled("namespace:blah"));
assert_false(IsMangled("scope.blah"));
assert_false(IsMangled("namespace:scope.blah"));
/* Simply false. */
assert_true(IsMangled("scope#blah"));
assert_true(IsMangled("namespace*blah"));
assert_true(IsMangled("namespace*scope.blah"));
assert_true(IsMangled("namespace:scope#blah"));
/* Complicated: nested expansions shouldn't affect result */
assert_false(IsMangled("$("));
assert_false(IsMangled("${"));
assert_false(IsMangled("blah$(blue)"));
assert_false(IsMangled("blah$(scope.blue)"));
assert_false(IsMangled("blah$(scope#blue)"));
assert_false(IsMangled("blah$(namespace:blue)"));
assert_false(IsMangled("blah$(namespace*blue)"));
assert_false(IsMangled("blah$(namespace:scope.blue)"));
assert_false(IsMangled("blah$(namespace:scope#blue)"));
assert_false(IsMangled("blah$(namespace*scope.blue)"));
assert_false(IsMangled("blah$(namespace*scope#blue)"));
assert_false(IsMangled("scope.blah$(blue)"));
assert_false(IsMangled("scope.blah$(scope.blue)"));
assert_false(IsMangled("scope.blah$(scope#blue)"));
assert_false(IsMangled("scope.blah$(namespace:blue)"));
assert_false(IsMangled("scope.blah$(namespace*blue)"));
assert_false(IsMangled("scope.blah$(namespace:scope.blue)"));
assert_false(IsMangled("scope.blah$(namespace:scope#blue)"));
assert_false(IsMangled("scope.blah$(namespace*scope.blue)"));
assert_false(IsMangled("scope.blah$(namespace*scope#blue)"));
assert_true(IsMangled("scope#blah$(blue)"));
assert_true(IsMangled("scope#blah$(scope.blue)"));
assert_true(IsMangled("scope#blah$(scope#blue)"));
assert_true(IsMangled("scope#blah$(namespace:blue)"));
assert_true(IsMangled("scope#blah$(namespace*blue)"));
assert_true(IsMangled("scope#blah$(namespace:scope.blue)"));
assert_true(IsMangled("scope#blah$(namespace:scope#blue)"));
assert_true(IsMangled("scope#blah$(namespace*scope.blue)"));
assert_true(IsMangled("scope#blah$(namespace*scope#blue)"));
assert_true(IsMangled("namespace*blah$(blue)"));
assert_true(IsMangled("namespace*blah$(scope.blue)"));
assert_true(IsMangled("namespace*blah$(scope#blue)"));
assert_true(IsMangled("namespace*blah$(namespace:blue)"));
assert_true(IsMangled("namespace*blah$(namespace*blue)"));
assert_true(IsMangled("namespace*blah$(namespace:scope.blue)"));
assert_true(IsMangled("namespace*blah$(namespace:scope#blue)"));
assert_true(IsMangled("namespace*blah$(namespace*scope.blue)"));
assert_true(IsMangled("namespace*blah$(namespace*scope#blue)"));
assert_false(IsMangled("$(scope#blah)"));
assert_false(IsMangled("$(namespace*blah)"));
assert_false(IsMangled("$(namespace*scope#blah)"));
/* Multiple nested expansions, again, none should matter. */
assert_false(IsMangled("blah$(blue$(bleh))"));
assert_false(IsMangled("blah$(scope.blue$(scope#bleh))"));
/* Array indexes shouldn't affect the result either. */
assert_false(IsMangled("["));
assert_false(IsMangled("blah[$(blue)]"));
assert_false(IsMangled("blah$(blue[bleh])"));
assert_false(IsMangled("blah[S#i]"));
assert_false(IsMangled("blah[S#i][N*i]"));
assert_false(IsMangled("blah[S#i][N*i]"));
assert_true(IsMangled("S#blah[S.blue]"));
assert_true(IsMangled("S#blah[N:blue]"));
assert_true(IsMangled("S#blah[S#blue]"));
assert_true(IsMangled("N*blah[S.blue]"));
assert_true(IsMangled("N*blah[N:blue]"));
assert_true(IsMangled("N*S.blah[N:blue]"));
assert_true(IsMangled("N*S.blah[S.blue]"));
assert_false(IsMangled("S.blah[S#i][N*i]"));
assert_true (IsMangled("S#blah[S#i][N*i]"));
assert_false(IsMangled("[scope#blah]"));
assert_false(IsMangled("[namespace*blah]"));
assert_false(IsMangled("[namespace*scope#blah]"));
/* Complicated: combine nested variables with array expansions. */
assert_false(IsMangled("[$("));
assert_false(IsMangled("S.blah[$("));
assert_false(IsMangled("S.blah[i]$(blah)"));
assert_false(IsMangled("S.blah[$(i)]"));
assert_false(IsMangled("S.v[$(i)]"));
assert_true (IsMangled("S#v[$(i)]"));
assert_true (IsMangled("N*v[$(i)]"));
assert_false(IsMangled("N:v[$(i)]"));
assert_false(IsMangled("N:v[$(N*i)]"));
assert_false(IsMangled("N:v[$(S#i)]"));
assert_true (IsMangled("N*v[$(S#i)]"));
assert_true (IsMangled("S#v[$(S#i)]"));
assert_false(IsMangled("v[$(N*S#i)]"));
assert_false(IsMangled("v[$(N:S#i)]"));
assert_false(IsMangled("v[$(N*S.i)]"));
assert_false(IsMangled("S.v[$(N*S#i)]"));
assert_true (IsMangled("S#v[$(N*S#i)]"));
assert_false(IsMangled("N:v[$(N*S#i)]"));
assert_true (IsMangled("N*v[$(N*S#i)]"));
}
static void Mangle_TestHelper(const char *orig, const char *expected)
{
printf("Testing MangleVarRefString: %s\n", orig);
char *s = xstrdup(orig);
MangleVarRefString(s, strlen(s));
assert_string_equal(s, expected);
free(s);
}
static void Mangle_TestHelperWithLength1(const char *orig, size_t orig_len,
const char *expected)
{
printf("Testing MangleVarRefString: %.*s\n", (int) orig_len, orig);
char *s = xstrdup(orig);
MangleVarRefString(s, orig_len);
assert_string_equal(s, expected);
free(s);
}
/* NOTE: this one changes "orig" in-place. */
static void Mangle_TestHelperWithLength2(char *orig, size_t orig_len,
const char *expected, size_t expected_len)
{
printf("Testing MangleVarRefString: %.*s\n", (int) orig_len, orig);
MangleVarRefString(orig, orig_len);
assert_memory_equal(orig, expected, expected_len);
}
static void test_MangleVarRefString(void)
{
Mangle_TestHelper ("", "");
Mangle_TestHelperWithLength1 ("a", 0, "a");
Mangle_TestHelper ("a.b", "a#b");
/* Force length to 1, no change should occur. */
Mangle_TestHelperWithLength1 ("a.b", 1, "a.b");
Mangle_TestHelper ("a:b", "a*b");
/* Force length to 1, no change should occur. */
Mangle_TestHelperWithLength1 ("a:b", 1, "a:b");
Mangle_TestHelper ("a:b.c", "a*b#c");
/* Force length to 1, no change should occur. */
Mangle_TestHelperWithLength1 ("a:b.c", 1, "a:b.c");
/* Never mangle after array indexing */
Mangle_TestHelper ("a[b.c]", "a[b.c]");
/* "this" scope never gets mangled. */
Mangle_TestHelper ("this.a", "this.a");
/* Inner expansions never get mangled. */
Mangle_TestHelper ("a_$(s.i)", "a_$(s.i)");
Mangle_TestHelper ("a_$(n:i)", "a_$(n:i)");
/* Only before the inner expansion it gets mangled. */
Mangle_TestHelper ("s.a_$(s.i)", "s#a_$(s.i)");
Mangle_TestHelper ("n:a_$(n:i)", "n*a_$(n:i)");
/* Testing non '\0'-terminated char arrays. */
char A[4] = {'a','b','.','c'};
Mangle_TestHelperWithLength2(A, 0, "ab.c", 4);
Mangle_TestHelperWithLength2(A, 4, "ab#c", 4);
char B[3] = {'a',':','b'};
Mangle_TestHelperWithLength2(B, 0, "a:b", 3);
Mangle_TestHelperWithLength2(B, 3, "a*b", 3);
char C[1] = {'a'};
Mangle_TestHelperWithLength2(C, 0, "a", 1);
Mangle_TestHelperWithLength2(C, 1, "a", 1);
}
/* NOTE: the two variables "i" and "j" are defined as empty slists in the
* EvalContext. */
static void IteratorPrepare_TestHelper(
const char *promiser,
size_t expected_wheels_num,
const char **expected_wheels)
{
/* INIT EvalContext and Promise. */
EvalContext *evalctx = EvalContextNew();
Policy *policy = PolicyNew();
Bundle *bundle = PolicyAppendBundle(policy, "ns1", "bundle1", "agent",
NULL, NULL);
BundleSection *section = BundleAppendSection(bundle, "dummy");
Promise *promise = BundleSectionAppendPromise(section, promiser,
(Rval) { NULL, RVAL_TYPE_NOPROMISEE },
"any", NULL);
EvalContextStackPushBundleFrame(evalctx, bundle, NULL, false);
EvalContextStackPushBundleSectionFrame(evalctx, section);
PromiseIterator *iterctx = PromiseIteratorNew(promise);
char *promiser_copy = xstrdup(promiser);
/* Insert the variables "i" and "j" as empty Rlists in the EvalContext, so
* that the iteration engine creates wheels for them. */
{
VarRef *ref_i = VarRefParseFromBundle("i", bundle);
EvalContextVariablePut(evalctx, ref_i,
(Rlist *) NULL, CF_DATA_TYPE_STRING_LIST,
NULL);
VarRefDestroy(ref_i);
VarRef *ref_j = VarRefParseFromBundle("j", bundle);
EvalContextVariablePut(evalctx, ref_j,
(Rlist *) NULL, CF_DATA_TYPE_STRING_LIST,
NULL);
VarRefDestroy(ref_j);
}
/* TEST */
printf("Testing PromiseIteratorPrepare: %s\n", promiser);
PromiseIteratorPrepare(iterctx, evalctx, promiser_copy);
/* CHECK */
assert_true(iterctx->wheels != NULL);
size_t wheels_num = SeqLength(iterctx->wheels);
assert_int_equal(wheels_num, expected_wheels_num);
for (size_t i = 0; i < expected_wheels_num; i++)
{
const Wheel *wheel = SeqAt(iterctx->wheels, i);
assert_string_equal(wheel->varname_unexp, expected_wheels[i]);
}
/* CLEANUP */
free(promiser_copy);
PromiseIteratorDestroy(iterctx);
EvalContextStackPopFrame(evalctx);
EvalContextStackPopFrame(evalctx);
PolicyDestroy(policy);
EvalContextDestroy(evalctx);
}
static void test_PromiseIteratorPrepare(void)
{
IteratorPrepare_TestHelper("", 0, NULL);
/* No wheel added for "blah" because this variable does not resolve. */
IteratorPrepare_TestHelper("$(blah)", 0, NULL);
/* "$(i)" is a valid list, but these syntaxes are not correct. */
IteratorPrepare_TestHelper("i", 0, NULL);
IteratorPrepare_TestHelper("$i", 0, NULL);
IteratorPrepare_TestHelper("$(i", 0, NULL);
/* The following however is correct and should add one wheel */
IteratorPrepare_TestHelper("$(i)", 1,
(const char *[]) {"i"});
IteratorPrepare_TestHelper("$(i))", 1,
(const char *[]) {"i"});
IteratorPrepare_TestHelper("$(i)(", 1,
(const char *[]) {"i"});
IteratorPrepare_TestHelper("$(i)$(", 1,
(const char *[]) {"i"});
/* The same variable twice should just add one wheel. */
IteratorPrepare_TestHelper("$(i)$(i)", 1,
(const char *[]) {"i"});
/* "$(ij)" does not resolve. */
IteratorPrepare_TestHelper("$(i)$(ij)", 1,
(const char *[]) {"i"});
/* Both "$(i)" and "$(j)" resolve. */
IteratorPrepare_TestHelper("$(i)$(j)", 2,
(const char *[]) {"i","j"});
IteratorPrepare_TestHelper("$(i))$(j)", 2,
(const char *[]) {"i","j"});
IteratorPrepare_TestHelper("0$(i)$(j)", 2,
(const char *[]) {"i","j"});
IteratorPrepare_TestHelper("$(i)1$(j)", 2,
(const char *[]) {"i","j"});
IteratorPrepare_TestHelper("$(i)$(j)2", 2,
(const char *[]) {"i","j"});
IteratorPrepare_TestHelper("0$(i)1$(j)", 2,
(const char *[]) {"i","j"});
IteratorPrepare_TestHelper("0$(i)1$(j)2", 2,
(const char *[]) {"i","j"});
/* Any variable dependent on other variables should be added as a wheel. */
IteratorPrepare_TestHelper("$(A[$(i)][$(j)])", 3,
(const char *[]) {"i","j", "A[$(i)][$(j)]"});
/* Even if the inner variables don't resolve. */
IteratorPrepare_TestHelper("$(A[$(blah)][$(blue)])", 1,
(const char *[]) {"A[$(blah)][$(blue)]"});
IteratorPrepare_TestHelper("$(A[1][2]) $(A[$(i)][$(j)])", 3,
(const char *[]) {"i","j", "A[$(i)][$(j)]"});
IteratorPrepare_TestHelper("$(A[$(B[$(i)])][$(j)])", 4,
(const char *[]) {"i", "B[$(i)]", "j", "A[$(B[$(i)])][$(j)]"});
IteratorPrepare_TestHelper("$(A[$(B[$(i)][$(j)])])", 4,
(const char *[]) {"i","j", "B[$(i)][$(j)]", "A[$(B[$(i)][$(j)])]"});
}
int main()
{
PRINT_TEST_BANNER();
const UnitTest tests[] =
{
unit_test(test_FindDollarParen),
unit_test(test_IsMangled),
unit_test(test_MangleVarRefString),
unit_test(test_PromiseIteratorPrepare),
};
int ret = run_tests(tests);
return ret;
}
|
