1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
|
// Copyright (c) 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/bookmarks/bookmark_html_writer.h"
#include "base/files/scoped_temp_dir.h"
#include "base/i18n/time_formatting.h"
#include "base/run_loop.h"
#include "base/strings/string16.h"
#include "base/strings/string_util.h"
#include "base/strings/utf_string_conversions.h"
#include "base/time/time.h"
#include "chrome/browser/bookmarks/bookmark_model_factory.h"
#include "chrome/browser/favicon/favicon_service.h"
#include "chrome/browser/favicon/favicon_service_factory.h"
#include "chrome/browser/history/history_service.h"
#include "chrome/browser/history/history_service_factory.h"
#include "chrome/common/importer/imported_bookmark_entry.h"
#include "chrome/common/importer/imported_favicon_usage.h"
#include "chrome/test/base/testing_profile.h"
#include "chrome/utility/importer/bookmark_html_reader.h"
#include "components/bookmarks/browser/bookmark_model.h"
#include "components/bookmarks/test/bookmark_test_helpers.h"
#include "content/public/test/test_browser_thread_bundle.h"
#include "grit/components_strings.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "third_party/skia/include/core/SkBitmap.h"
#include "ui/base/l10n/l10n_util.h"
#include "ui/gfx/codec/png_codec.h"
namespace {
const int kIconWidth = 16;
const int kIconHeight = 16;
void MakeTestSkBitmap(int w, int h, SkBitmap* bmp) {
bmp->allocN32Pixels(w, h);
uint32_t* src_data = bmp->getAddr32(0, 0);
for (int i = 0; i < w * h; i++) {
src_data[i] = SkPreMultiplyARGB(i % 255, i % 250, i % 245, i % 240);
}
}
} // namespace
class BookmarkHTMLWriterTest : public testing::Test {
protected:
void SetUp() override {
testing::Test::SetUp();
ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());
path_ = temp_dir_.path().AppendASCII("bookmarks.html");
}
// Converts an ImportedBookmarkEntry to a string suitable for assertion
// testing.
base::string16 BookmarkEntryToString(const ImportedBookmarkEntry& entry) {
base::string16 result;
result.append(base::ASCIIToUTF16("on_toolbar="));
if (entry.in_toolbar)
result.append(base::ASCIIToUTF16("true"));
else
result.append(base::ASCIIToUTF16("false"));
result.append(base::ASCIIToUTF16(" url=") +
base::UTF8ToUTF16(entry.url.spec()));
result.append(base::ASCIIToUTF16(" path="));
for (size_t i = 0; i < entry.path.size(); ++i) {
if (i != 0)
result.append(base::ASCIIToUTF16("/"));
result.append(entry.path[i]);
}
result.append(base::ASCIIToUTF16(" title="));
result.append(entry.title);
result.append(base::ASCIIToUTF16(" time="));
result.append(base::TimeFormatFriendlyDateAndTime(entry.creation_time));
return result;
}
// Creates a set of bookmark values to a string for assertion testing.
base::string16 BookmarkValuesToString(bool on_toolbar,
const GURL& url,
const base::string16& title,
base::Time creation_time,
const base::string16& f1,
const base::string16& f2,
const base::string16& f3) {
ImportedBookmarkEntry entry;
entry.in_toolbar = on_toolbar;
entry.url = url;
if (!f1.empty()) {
entry.path.push_back(f1);
if (!f2.empty()) {
entry.path.push_back(f2);
if (!f3.empty())
entry.path.push_back(f3);
}
}
entry.title = title;
entry.creation_time = creation_time;
return BookmarkEntryToString(entry);
}
void AssertBookmarkEntryEquals(const ImportedBookmarkEntry& entry,
bool on_toolbar,
const GURL& url,
const base::string16& title,
base::Time creation_time,
const base::string16& f1,
const base::string16& f2,
const base::string16& f3) {
EXPECT_EQ(BookmarkValuesToString(on_toolbar, url, title, creation_time,
f1, f2, f3),
BookmarkEntryToString(entry));
}
base::ScopedTempDir temp_dir_;
base::FilePath path_;
};
// Class that will notify message loop when file is written.
class BookmarksObserver : public BookmarksExportObserver {
public:
explicit BookmarksObserver(base::RunLoop* loop) : loop_(loop) {
DCHECK(loop);
}
void OnExportFinished() override { loop_->Quit(); }
private:
base::RunLoop* loop_;
DISALLOW_COPY_AND_ASSIGN(BookmarksObserver);
};
// Tests bookmark_html_writer by populating a BookmarkModel, writing it out by
// way of bookmark_html_writer, then using the importer to read it back in.
TEST_F(BookmarkHTMLWriterTest, Test) {
content::TestBrowserThreadBundle thread_bundle;
TestingProfile profile;
ASSERT_TRUE(profile.CreateHistoryService(true, false));
profile.BlockUntilHistoryProcessesPendingRequests();
profile.CreateFaviconService();
profile.CreateBookmarkModel(true);
BookmarkModel* model = BookmarkModelFactory::GetForProfile(&profile);
bookmarks::test::WaitForBookmarkModelToLoad(model);
// Create test PNG representing favicon for url1.
SkBitmap bitmap;
MakeTestSkBitmap(kIconWidth, kIconHeight, &bitmap);
std::vector<unsigned char> icon_data;
gfx::PNGCodec::EncodeBGRASkBitmap(bitmap, false, &icon_data);
// Populate the BookmarkModel. This creates the following bookmark structure:
// Bookmarks bar
// F1
// url1
// F2
// url2
// url3
// url4
// Other
// url1
// url2
// F3
// F4
// url1
// Mobile
// url1
// <bookmark without a title.>
base::string16 f1_title = base::ASCIIToUTF16("F\"&;<1\"");
base::string16 f2_title = base::ASCIIToUTF16("F2");
base::string16 f3_title = base::ASCIIToUTF16("F 3");
base::string16 f4_title = base::ASCIIToUTF16("F4");
base::string16 url1_title = base::ASCIIToUTF16("url 1");
base::string16 url2_title = base::ASCIIToUTF16("url&2");
base::string16 url3_title = base::ASCIIToUTF16("url\"3");
base::string16 url4_title = base::ASCIIToUTF16("url\"&;");
base::string16 unnamed_bookmark_title = base::ASCIIToUTF16("");
GURL url1("http://url1");
GURL url1_favicon("http://url1/icon.ico");
GURL url2("http://url2");
GURL url3("http://url3");
GURL url4("javascript:alert(\"Hello!\");");
GURL unnamed_bookmark_url("about:blank");
base::Time t1(base::Time::Now());
base::Time t2(t1 + base::TimeDelta::FromHours(1));
base::Time t3(t1 + base::TimeDelta::FromHours(1));
base::Time t4(t1 + base::TimeDelta::FromHours(1));
const BookmarkNode* f1 = model->AddFolder(
model->bookmark_bar_node(), 0, f1_title);
model->AddURLWithCreationTimeAndMetaInfo(f1, 0, url1_title, url1, t1, NULL);
HistoryServiceFactory::GetForProfile(&profile, Profile::EXPLICIT_ACCESS)->
AddPage(url1, base::Time::Now(), history::SOURCE_BROWSED);
FaviconServiceFactory::GetForProfile(&profile, Profile::EXPLICIT_ACCESS)
->SetFavicons(url1,
url1_favicon,
favicon_base::FAVICON,
gfx::Image::CreateFrom1xBitmap(bitmap));
const BookmarkNode* f2 = model->AddFolder(f1, 1, f2_title);
model->AddURLWithCreationTimeAndMetaInfo(f2, 0, url2_title, url2, t2, NULL);
model->AddURLWithCreationTimeAndMetaInfo(
model->bookmark_bar_node(), 1, url3_title, url3, t3, NULL);
model->AddURLWithCreationTimeAndMetaInfo(
model->other_node(), 0, url1_title, url1, t1, NULL);
model->AddURLWithCreationTimeAndMetaInfo(
model->other_node(), 1, url2_title, url2, t2, NULL);
const BookmarkNode* f3 = model->AddFolder(model->other_node(), 2, f3_title);
const BookmarkNode* f4 = model->AddFolder(f3, 0, f4_title);
model->AddURLWithCreationTimeAndMetaInfo(f4, 0, url1_title, url1, t1, NULL);
model->AddURLWithCreationTimeAndMetaInfo(
model->bookmark_bar_node(), 2, url4_title, url4, t4, NULL);
model->AddURLWithCreationTimeAndMetaInfo(
model->mobile_node(), 0, url1_title, url1, t1, NULL);
model->AddURLWithCreationTimeAndMetaInfo(model->mobile_node(),
1,
unnamed_bookmark_title,
unnamed_bookmark_url,
t2,
NULL);
base::RunLoop run_loop;
// Write to a temp file.
BookmarksObserver observer(&run_loop);
bookmark_html_writer::WriteBookmarks(&profile, path_, &observer);
run_loop.Run();
// Clear favicon so that it would be read from file.
FaviconServiceFactory::GetForProfile(&profile, Profile::EXPLICIT_ACCESS)
->SetFavicons(url1, url1_favicon, favicon_base::FAVICON, gfx::Image());
// Read the bookmarks back in.
std::vector<ImportedBookmarkEntry> parsed_bookmarks;
std::vector<ImportedFaviconUsage> favicons;
bookmark_html_reader::ImportBookmarksFile(base::Callback<bool(void)>(),
base::Callback<bool(const GURL&)>(),
path_,
&parsed_bookmarks,
&favicons);
// Check loaded favicon (url1 is represented by 4 separate bookmarks).
EXPECT_EQ(4U, favicons.size());
for (size_t i = 0; i < favicons.size(); i++) {
if (url1_favicon == favicons[i].favicon_url) {
EXPECT_EQ(1U, favicons[i].urls.size());
std::set<GURL>::const_iterator iter = favicons[i].urls.find(url1);
ASSERT_TRUE(iter != favicons[i].urls.end());
ASSERT_TRUE(*iter == url1);
ASSERT_TRUE(favicons[i].png_data == icon_data);
}
}
// Verify we got back what we wrote.
ASSERT_EQ(9U, parsed_bookmarks.size());
// Windows and ChromeOS builds use Sentence case.
base::string16 bookmark_folder_name =
l10n_util::GetStringUTF16(IDS_BOOKMARK_BAR_FOLDER_NAME);
AssertBookmarkEntryEquals(parsed_bookmarks[0], true, url1, url1_title, t1,
bookmark_folder_name, f1_title, base::string16());
AssertBookmarkEntryEquals(parsed_bookmarks[1], true, url2, url2_title, t2,
bookmark_folder_name, f1_title, f2_title);
AssertBookmarkEntryEquals(parsed_bookmarks[2], true, url3, url3_title, t3,
bookmark_folder_name, base::string16(),
base::string16());
AssertBookmarkEntryEquals(parsed_bookmarks[3], true, url4, url4_title, t4,
bookmark_folder_name, base::string16(),
base::string16());
AssertBookmarkEntryEquals(parsed_bookmarks[4], false, url1, url1_title, t1,
base::string16(), base::string16(),
base::string16());
AssertBookmarkEntryEquals(parsed_bookmarks[5], false, url2, url2_title, t2,
base::string16(), base::string16(),
base::string16());
AssertBookmarkEntryEquals(parsed_bookmarks[6], false, url1, url1_title, t1,
f3_title, f4_title, base::string16());
AssertBookmarkEntryEquals(parsed_bookmarks[7], false, url1, url1_title, t1,
base::string16(), base::string16(),
base::string16());
AssertBookmarkEntryEquals(parsed_bookmarks[8], false, unnamed_bookmark_url,
unnamed_bookmark_title, t2,
base::string16(), base::string16(),
base::string16());
}
|
