1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
|
// Copyright (c) 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/app/chrome_command_ids.h"
#include "chrome/browser/bookmarks/bookmark_model_factory.h"
#include "chrome/browser/chrome_page_zoom.h"
#include "chrome/browser/ui/browser_command_controller.h"
#include "chrome/browser/ui/browser_commands.h"
#include "chrome/browser/ui/browser_finder.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
#include "chrome/common/url_constants.h"
#include "chrome/test/base/browser_with_test_window_test.h"
#include "chrome/test/base/testing_profile.h"
#include "components/bookmarks/browser/bookmark_model.h"
#include "components/bookmarks/test/bookmark_test_helpers.h"
#include "components/ui/zoom/zoom_controller.h"
#include "content/public/browser/navigation_controller.h"
#include "content/public/browser/navigation_entry.h"
#include "content/public/browser/web_contents.h"
typedef BrowserWithTestWindowTest BrowserCommandsTest;
using content::OpenURLParams;
using content::Referrer;
using content::WebContents;
using ui_zoom::ZoomController;
// Tests IDC_SELECT_TAB_0, IDC_SELECT_NEXT_TAB, IDC_SELECT_PREVIOUS_TAB and
// IDC_SELECT_LAST_TAB.
TEST_F(BrowserCommandsTest, TabNavigationAccelerators) {
GURL about_blank(url::kAboutBlankURL);
// Create three tabs.
AddTab(browser(), about_blank);
AddTab(browser(), about_blank);
AddTab(browser(), about_blank);
// Select the second tab.
browser()->tab_strip_model()->ActivateTabAt(1, false);
CommandUpdater* updater = browser()->command_controller()->command_updater();
// Navigate to the first tab using an accelerator.
updater->ExecuteCommand(IDC_SELECT_TAB_0);
ASSERT_EQ(0, browser()->tab_strip_model()->active_index());
// Navigate to the second tab using the next accelerators.
updater->ExecuteCommand(IDC_SELECT_NEXT_TAB);
ASSERT_EQ(1, browser()->tab_strip_model()->active_index());
// Navigate back to the first tab using the previous accelerators.
updater->ExecuteCommand(IDC_SELECT_PREVIOUS_TAB);
ASSERT_EQ(0, browser()->tab_strip_model()->active_index());
// Navigate to the last tab using the select last accelerator.
updater->ExecuteCommand(IDC_SELECT_LAST_TAB);
ASSERT_EQ(2, browser()->tab_strip_model()->active_index());
}
// Tests IDC_DUPLICATE_TAB.
TEST_F(BrowserCommandsTest, DuplicateTab) {
GURL url1("http://foo/1");
GURL url2("http://foo/2");
GURL url3("http://foo/3");
GURL url4("http://foo/4");
// Navigate to three urls, plus a pending URL that hasn't committed.
AddTab(browser(), url1);
NavigateAndCommitActiveTab(url2);
NavigateAndCommitActiveTab(url3);
content::NavigationController& orig_controller =
browser()->tab_strip_model()->GetWebContentsAt(0)->GetController();
orig_controller.LoadURL(
url4, content::Referrer(), ui::PAGE_TRANSITION_LINK, std::string());
EXPECT_EQ(3, orig_controller.GetEntryCount());
EXPECT_TRUE(orig_controller.GetPendingEntry());
size_t initial_window_count = chrome::GetTotalBrowserCount();
// Duplicate the tab.
chrome::ExecuteCommand(browser(), IDC_DUPLICATE_TAB);
// The duplicated tab should not end up in a new window.
size_t window_count = chrome::GetTotalBrowserCount();
ASSERT_EQ(initial_window_count, window_count);
// And we should have a newly duplicated tab.
ASSERT_EQ(2, browser()->tab_strip_model()->count());
// Verify the stack of urls.
content::NavigationController& controller =
browser()->tab_strip_model()->GetWebContentsAt(1)->GetController();
EXPECT_EQ(3, controller.GetEntryCount());
EXPECT_EQ(2, controller.GetCurrentEntryIndex());
EXPECT_EQ(url1, controller.GetEntryAtIndex(0)->GetURL());
EXPECT_EQ(url2, controller.GetEntryAtIndex(1)->GetURL());
EXPECT_EQ(url3, controller.GetEntryAtIndex(2)->GetURL());
EXPECT_FALSE(controller.GetPendingEntry());
}
// Tests IDC_VIEW_SOURCE (See http://crbug.com/138140).
TEST_F(BrowserCommandsTest, ViewSource) {
GURL url1("http://foo/1");
GURL url2("http://foo/2");
// Navigate to a URL, plus a pending URL that hasn't committed.
AddTab(browser(), url1);
content::NavigationController& orig_controller =
browser()->tab_strip_model()->GetWebContentsAt(0)->GetController();
orig_controller.LoadURL(
url2, content::Referrer(), ui::PAGE_TRANSITION_LINK, std::string());
EXPECT_EQ(1, orig_controller.GetEntryCount());
EXPECT_TRUE(orig_controller.GetPendingEntry());
size_t initial_window_count = chrome::GetTotalBrowserCount();
// View Source.
chrome::ExecuteCommand(browser(), IDC_VIEW_SOURCE);
// The view source tab should not end up in a new window.
size_t window_count = chrome::GetTotalBrowserCount();
ASSERT_EQ(initial_window_count, window_count);
// And we should have a newly duplicated tab.
ASSERT_EQ(2, browser()->tab_strip_model()->count());
// Verify we are viewing the source of the last committed entry.
GURL view_source_url("view-source:http://foo/1");
content::NavigationController& controller =
browser()->tab_strip_model()->GetWebContentsAt(1)->GetController();
EXPECT_EQ(1, controller.GetEntryCount());
EXPECT_EQ(0, controller.GetCurrentEntryIndex());
EXPECT_EQ(url1, controller.GetEntryAtIndex(0)->GetURL());
EXPECT_EQ(view_source_url, controller.GetEntryAtIndex(0)->GetVirtualURL());
EXPECT_FALSE(controller.GetPendingEntry());
}
TEST_F(BrowserCommandsTest, BookmarkCurrentPage) {
// We use profile() here, since it's a TestingProfile.
profile()->CreateBookmarkModel(true);
BookmarkModel* model = BookmarkModelFactory::GetForProfile(profile());
bookmarks::test::WaitForBookmarkModelToLoad(model);
// Navigate to a url.
GURL url1("http://foo/1");
AddTab(browser(), url1);
browser()->OpenURL(OpenURLParams(
url1, Referrer(), CURRENT_TAB, ui::PAGE_TRANSITION_TYPED, false));
chrome::BookmarkCurrentPageAllowingExtensionOverrides(browser());
// It should now be bookmarked in the bookmark model.
EXPECT_EQ(profile(), browser()->profile());
EXPECT_TRUE(model->IsBookmarked(url1));
}
// Tests back/forward in new tab (Control + Back/Forward button in the UI).
TEST_F(BrowserCommandsTest, BackForwardInNewTab) {
GURL url1("http://foo/1");
GURL url2("http://foo/2");
// Make a tab with the two pages navigated in it.
AddTab(browser(), url1);
NavigateAndCommitActiveTab(url2);
// Go back in a new background tab.
chrome::GoBack(browser(), NEW_BACKGROUND_TAB);
EXPECT_EQ(0, browser()->tab_strip_model()->active_index());
ASSERT_EQ(2, browser()->tab_strip_model()->count());
WebContents* zeroth = browser()->tab_strip_model()->GetWebContentsAt(0);
WebContents* first = browser()->tab_strip_model()->GetWebContentsAt(1);
// The original tab should be unchanged.
EXPECT_EQ(url2, zeroth->GetLastCommittedURL());
EXPECT_TRUE(zeroth->GetController().CanGoBack());
EXPECT_FALSE(zeroth->GetController().CanGoForward());
// The new tab should be like the first one but navigated back. Since we
// didn't wait for the load to complete, we can't use GetLastCommittedURL.
EXPECT_EQ(url1, first->GetVisibleURL());
EXPECT_FALSE(first->GetController().CanGoBack());
EXPECT_TRUE(first->GetController().CanGoForward());
// Select the second tab and make it go forward in a new background tab.
browser()->tab_strip_model()->ActivateTabAt(1, true);
// TODO(brettw) bug 11055: It should not be necessary to commit the load here,
// but because of this bug, it will assert later if we don't. When the bug is
// fixed, one of the three commits here related to this bug should be removed
// (to test both codepaths).
CommitPendingLoad(&first->GetController());
EXPECT_EQ(1, browser()->tab_strip_model()->active_index());
chrome::GoForward(browser(), NEW_BACKGROUND_TAB);
// The previous tab should be unchanged and still in the foreground.
EXPECT_EQ(url1, first->GetLastCommittedURL());
EXPECT_FALSE(first->GetController().CanGoBack());
EXPECT_TRUE(first->GetController().CanGoForward());
EXPECT_EQ(1, browser()->tab_strip_model()->active_index());
// There should be a new tab navigated forward.
ASSERT_EQ(3, browser()->tab_strip_model()->count());
WebContents* second = browser()->tab_strip_model()->GetWebContentsAt(2);
// Since we didn't wait for load to complete, we can't use
// GetLastCommittedURL.
EXPECT_EQ(url2, second->GetVisibleURL());
EXPECT_TRUE(second->GetController().CanGoBack());
EXPECT_FALSE(second->GetController().CanGoForward());
// Now do back in a new foreground tab. Don't bother re-checking every sngle
// thing above, just validate that it's opening properly.
browser()->tab_strip_model()->ActivateTabAt(2, true);
// TODO(brettw) bug 11055: see the comment above about why we need this.
CommitPendingLoad(&second->GetController());
chrome::GoBack(browser(), NEW_FOREGROUND_TAB);
ASSERT_EQ(3, browser()->tab_strip_model()->active_index());
ASSERT_EQ(url1,
browser()->tab_strip_model()->GetActiveWebContents()->
GetVisibleURL());
// Same thing again for forward.
// TODO(brettw) bug 11055: see the comment above about why we need this.
CommitPendingLoad(&
browser()->tab_strip_model()->GetActiveWebContents()->GetController());
chrome::GoForward(browser(), NEW_FOREGROUND_TAB);
ASSERT_EQ(4, browser()->tab_strip_model()->active_index());
ASSERT_EQ(url2,
browser()->tab_strip_model()->GetActiveWebContents()->
GetVisibleURL());
}
TEST_F(BrowserCommandsTest, OnMaxZoomIn) {
TabStripModel* tab_strip_model = browser()->tab_strip_model();
GURL url("http://www.google.com");
AddTab(browser(), url);
content::WebContents* contents1 = tab_strip_model->GetWebContentsAt(0);
// Continue to zoom in until zoom percent reaches 500.
for (int i = 0; i < 9; ++i) {
chrome_page_zoom::Zoom(contents1, content::PAGE_ZOOM_IN);
}
// TODO(a.sarkar.arun@gmail.com): Figure out why Zoom-In menu item is not
// disabled after Max-zoom is reached. Force disable Zoom-In menu item
// from the context menu since it breaks try jobs on bots.
if (chrome::IsCommandEnabled(browser(), IDC_ZOOM_PLUS))
chrome::UpdateCommandEnabled(browser(), IDC_ZOOM_PLUS, false);
ZoomController* zoom_controller = ZoomController::FromWebContents(contents1);
EXPECT_EQ(zoom_controller->GetZoomPercent(), 500.0f);
EXPECT_FALSE(chrome::IsCommandEnabled(browser(), IDC_ZOOM_PLUS));
EXPECT_TRUE(chrome::IsCommandEnabled(browser(), IDC_ZOOM_NORMAL));
EXPECT_TRUE(chrome::IsCommandEnabled(browser(), IDC_ZOOM_MINUS));
}
TEST_F(BrowserCommandsTest, OnMaxZoomOut) {
TabStripModel* tab_strip_model = browser()->tab_strip_model();
GURL url("http://www.google.com");
AddTab(browser(), url);
content::WebContents* contents1 = tab_strip_model->GetWebContentsAt(0);
// Continue to zoom out until zoom percent reaches 25.
for (int i = 0; i < 7; ++i) {
chrome_page_zoom::Zoom(contents1, content::PAGE_ZOOM_OUT);
}
ZoomController* zoom_controller = ZoomController::FromWebContents(contents1);
EXPECT_EQ(zoom_controller->GetZoomPercent(), 25.0f);
EXPECT_TRUE(chrome::IsCommandEnabled(browser(), IDC_ZOOM_PLUS));
EXPECT_TRUE(chrome::IsCommandEnabled(browser(), IDC_ZOOM_NORMAL));
EXPECT_FALSE(chrome::IsCommandEnabled(browser(), IDC_ZOOM_MINUS));
}
TEST_F(BrowserCommandsTest, OnZoomReset) {
TabStripModel* tab_strip_model = browser()->tab_strip_model();
GURL url("http://www.google.com");
AddTab(browser(), url);
content::WebContents* contents1 = tab_strip_model->GetWebContentsAt(0);
// Change the zoom percentage to 100.
chrome_page_zoom::Zoom(contents1, content::PAGE_ZOOM_RESET);
ZoomController* zoom_controller = ZoomController::FromWebContents(contents1);
EXPECT_EQ(zoom_controller->GetZoomPercent(), 100.0f);
EXPECT_TRUE(chrome::IsCommandEnabled(browser(), IDC_ZOOM_PLUS));
EXPECT_FALSE(chrome::IsCommandEnabled(browser(), IDC_ZOOM_NORMAL));
EXPECT_TRUE(chrome::IsCommandEnabled(browser(), IDC_ZOOM_MINUS));
}
TEST_F(BrowserCommandsTest, OnZoomLevelChanged) {
TabStripModel* tab_strip_model = browser()->tab_strip_model();
GURL url("http://www.google.com");
AddTab(browser(), url);
content::WebContents* contents1 = tab_strip_model->GetWebContentsAt(0);
// Changing zoom percentage from default should enable all the zoom
// NSMenuItems.
chrome_page_zoom::Zoom(contents1, content::PAGE_ZOOM_IN);
ZoomController* zoom_controller = ZoomController::FromWebContents(contents1);
EXPECT_EQ(zoom_controller->GetZoomPercent(), 110.0f);
EXPECT_TRUE(chrome::IsCommandEnabled(browser(), IDC_ZOOM_PLUS));
EXPECT_TRUE(chrome::IsCommandEnabled(browser(), IDC_ZOOM_NORMAL));
EXPECT_TRUE(chrome::IsCommandEnabled(browser(), IDC_ZOOM_MINUS));
}
TEST_F(BrowserCommandsTest, OnZoomChangedForActiveTab) {
TabStripModel* tab_strip_model = browser()->tab_strip_model();
GURL url("http://www.google.com");
GURL url1("http://code.google.com");
// Add First tab.
AddTab(browser(), url);
AddTab(browser(), url1);
content::WebContents* contents1 = tab_strip_model->GetWebContentsAt(0);
ZoomController* zoom_controller = ZoomController::FromWebContents(contents1);
EXPECT_EQ(zoom_controller->GetZoomPercent(), 100.0f);
EXPECT_TRUE(chrome::IsCommandEnabled(browser(), IDC_ZOOM_PLUS));
EXPECT_FALSE(chrome::IsCommandEnabled(browser(), IDC_ZOOM_NORMAL));
EXPECT_TRUE(chrome::IsCommandEnabled(browser(), IDC_ZOOM_MINUS));
// Add Second tab.
content::WebContents* contents2 = tab_strip_model->GetWebContentsAt(1);
tab_strip_model->ActivateTabAt(1, true);
EXPECT_TRUE(tab_strip_model->IsTabSelected(1));
chrome_page_zoom::Zoom(contents2, content::PAGE_ZOOM_OUT);
zoom_controller = ZoomController::FromWebContents(contents2);
EXPECT_EQ(zoom_controller->GetZoomPercent(), 90.0f);
EXPECT_TRUE(chrome::IsCommandEnabled(browser(), IDC_ZOOM_PLUS));
EXPECT_TRUE(chrome::IsCommandEnabled(browser(), IDC_ZOOM_NORMAL));
EXPECT_TRUE(chrome::IsCommandEnabled(browser(), IDC_ZOOM_MINUS));
}
|
