1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382
|
// Copyright 2014 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/chromeos/net/cert_verify_proc_chromeos.h"
#include "crypto/nss_util_internal.h"
#include "crypto/scoped_test_nss_chromeos_user.h"
#include "net/base/net_errors.h"
#include "net/base/test_data_directory.h"
#include "net/cert/cert_verify_proc.h"
#include "net/cert/cert_verify_result.h"
#include "net/cert/nss_cert_database_chromeos.h"
#include "net/test/cert_test_util.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace chromeos {
class CertVerifyProcChromeOSTest : public testing::Test {
public:
CertVerifyProcChromeOSTest() : user_1_("user1"), user_2_("user2") {}
virtual void SetUp() override {
// Initialize nss_util slots.
ASSERT_TRUE(user_1_.constructed_successfully());
ASSERT_TRUE(user_2_.constructed_successfully());
user_1_.FinishInit();
user_2_.FinishInit();
// Create NSSCertDatabaseChromeOS for each user.
db_1_.reset(new net::NSSCertDatabaseChromeOS(
crypto::GetPublicSlotForChromeOSUser(user_1_.username_hash()),
crypto::GetPrivateSlotForChromeOSUser(
user_1_.username_hash(),
base::Callback<void(crypto::ScopedPK11Slot)>())));
db_2_.reset(new net::NSSCertDatabaseChromeOS(
crypto::GetPublicSlotForChromeOSUser(user_2_.username_hash()),
crypto::GetPrivateSlotForChromeOSUser(
user_2_.username_hash(),
base::Callback<void(crypto::ScopedPK11Slot)>())));
// Create default verifier and for each user.
verify_proc_default_ = new CertVerifyProcChromeOS();
verify_proc_1_ = new CertVerifyProcChromeOS(db_1_->GetPublicSlot());
verify_proc_2_ = new CertVerifyProcChromeOS(db_2_->GetPublicSlot());
// Load test cert chains from disk.
certs_1_ =
net::CreateCertificateListFromFile(net::GetTestCertsDirectory(),
"multi-root-chain1.pem",
net::X509Certificate::FORMAT_AUTO);
ASSERT_EQ(4U, certs_1_.size());
certs_2_ =
net::CreateCertificateListFromFile(net::GetTestCertsDirectory(),
"multi-root-chain2.pem",
net::X509Certificate::FORMAT_AUTO);
ASSERT_EQ(4U, certs_2_.size());
// The chains:
// 1. A (end-entity) -> B -> C -> D (self-signed root)
// 2. A (end-entity) -> B -> C2 -> E (self-signed root)
ASSERT_TRUE(certs_1_[0]->Equals(certs_2_[0].get()));
ASSERT_TRUE(certs_1_[1]->Equals(certs_2_[1].get()));
ASSERT_FALSE(certs_1_[2]->Equals(certs_2_[2].get()));
ASSERT_EQ("C CA", certs_1_[2]->subject().common_name);
ASSERT_EQ("C CA", certs_2_[2]->subject().common_name);
root_1_.push_back(certs_1_.back());
root_2_.push_back(certs_2_.back());
ASSERT_EQ("D Root CA", root_1_[0]->subject().common_name);
ASSERT_EQ("E Root CA", root_2_[0]->subject().common_name);
}
int VerifyWithAdditionalTrustAnchors(
net::CertVerifyProc* verify_proc,
const net::CertificateList& additional_trust_anchors,
net::X509Certificate* cert,
std::string* root_subject_name) {
int flags = 0;
net::CertVerifyResult verify_result;
int error = verify_proc->Verify(cert,
"127.0.0.1",
flags,
NULL,
additional_trust_anchors,
&verify_result);
if (verify_result.verified_cert.get() &&
!verify_result.verified_cert->GetIntermediateCertificates().empty()) {
net::X509Certificate::OSCertHandle root =
verify_result.verified_cert->GetIntermediateCertificates().back();
root_subject_name->assign(root->subjectName);
} else {
root_subject_name->clear();
}
return error;
}
int Verify(net::CertVerifyProc* verify_proc,
net::X509Certificate* cert,
std::string* root_subject_name) {
net::CertificateList additional_trust_anchors;
return VerifyWithAdditionalTrustAnchors(
verify_proc, additional_trust_anchors, cert, root_subject_name);
}
protected:
crypto::ScopedTestNSSChromeOSUser user_1_;
crypto::ScopedTestNSSChromeOSUser user_2_;
scoped_ptr<net::NSSCertDatabaseChromeOS> db_1_;
scoped_ptr<net::NSSCertDatabaseChromeOS> db_2_;
scoped_refptr<net::CertVerifyProc> verify_proc_default_;
scoped_refptr<net::CertVerifyProc> verify_proc_1_;
scoped_refptr<net::CertVerifyProc> verify_proc_2_;
net::CertificateList certs_1_;
net::CertificateList certs_2_;
net::CertificateList root_1_;
net::CertificateList root_2_;
};
// Test that the CertVerifyProcChromeOS doesn't trusts roots that are in other
// user's slots or that have been deleted, and that verifying done by one user
// doesn't affect verifications done by others.
TEST_F(CertVerifyProcChromeOSTest, TestChainVerify) {
scoped_refptr<net::X509Certificate> server = certs_1_[0];
std::string verify_root;
// Before either of the root certs have been trusted, all verifications should
// fail with CERT_AUTHORITY_INVALID.
EXPECT_EQ(net::ERR_CERT_AUTHORITY_INVALID,
Verify(verify_proc_default_.get(), server.get(), &verify_root));
EXPECT_EQ(net::ERR_CERT_AUTHORITY_INVALID,
Verify(verify_proc_1_.get(), server.get(), &verify_root));
EXPECT_EQ(net::ERR_CERT_AUTHORITY_INVALID,
Verify(verify_proc_2_.get(), server.get(), &verify_root));
// Import and trust the D root for user 1.
net::NSSCertDatabase::ImportCertFailureList failed;
EXPECT_TRUE(db_1_->ImportCACerts(
root_1_, net::NSSCertDatabase::TRUSTED_SSL, &failed));
EXPECT_EQ(0U, failed.size());
// Imported CA certs are not trusted by default verifier.
EXPECT_EQ(net::ERR_CERT_AUTHORITY_INVALID,
Verify(verify_proc_default_.get(), server.get(), &verify_root));
// User 1 should now verify successfully through the D root.
EXPECT_EQ(net::OK, Verify(verify_proc_1_.get(), server.get(), &verify_root));
EXPECT_EQ("CN=D Root CA", verify_root);
// User 2 should still fail.
EXPECT_EQ(net::ERR_CERT_AUTHORITY_INVALID,
Verify(verify_proc_2_.get(), server.get(), &verify_root));
// Import and trust the E root for user 2.
failed.clear();
EXPECT_TRUE(db_2_->ImportCACerts(
root_2_, net::NSSCertDatabase::TRUSTED_SSL, &failed));
EXPECT_EQ(0U, failed.size());
// Imported CA certs are not trusted by default verifier.
EXPECT_EQ(net::ERR_CERT_AUTHORITY_INVALID,
Verify(verify_proc_default_.get(), server.get(), &verify_root));
// User 1 should still verify successfully through the D root.
EXPECT_EQ(net::OK, Verify(verify_proc_1_.get(), server.get(), &verify_root));
EXPECT_EQ("CN=D Root CA", verify_root);
// User 2 should now verify successfully through the E root.
EXPECT_EQ(net::OK, Verify(verify_proc_2_.get(), server.get(), &verify_root));
EXPECT_EQ("CN=E Root CA", verify_root);
// Delete D root.
EXPECT_TRUE(db_1_->DeleteCertAndKey(root_1_[0].get()));
EXPECT_EQ(net::ERR_CERT_AUTHORITY_INVALID,
Verify(verify_proc_default_.get(), server.get(), &verify_root));
// User 1 should now fail to verify.
EXPECT_EQ(net::ERR_CERT_AUTHORITY_INVALID,
Verify(verify_proc_1_.get(), server.get(), &verify_root));
// User 2 should still verify successfully through the E root.
EXPECT_EQ(net::OK, Verify(verify_proc_2_.get(), server.get(), &verify_root));
EXPECT_EQ("CN=E Root CA", verify_root);
// Delete E root.
EXPECT_TRUE(db_2_->DeleteCertAndKey(root_2_[0].get()));
EXPECT_EQ(net::ERR_CERT_AUTHORITY_INVALID,
Verify(verify_proc_default_.get(), server.get(), &verify_root));
// User 1 should still fail to verify.
EXPECT_EQ(net::ERR_CERT_AUTHORITY_INVALID,
Verify(verify_proc_1_.get(), server.get(), &verify_root));
// User 2 should now fail to verify.
EXPECT_EQ(net::ERR_CERT_AUTHORITY_INVALID,
Verify(verify_proc_2_.get(), server.get(), &verify_root));
}
// Test that roots specified through additional_trust_anchors are trusted for
// that verification, and that there is not any caching that affects later
// verifications.
TEST_F(CertVerifyProcChromeOSTest, TestAdditionalTrustAnchors) {
EXPECT_TRUE(verify_proc_default_->SupportsAdditionalTrustAnchors());
EXPECT_TRUE(verify_proc_1_->SupportsAdditionalTrustAnchors());
scoped_refptr<net::X509Certificate> server = certs_1_[0];
std::string verify_root;
net::CertificateList additional_trust_anchors;
// Before either of the root certs have been trusted, all verifications should
// fail with CERT_AUTHORITY_INVALID.
EXPECT_EQ(net::ERR_CERT_AUTHORITY_INVALID,
VerifyWithAdditionalTrustAnchors(verify_proc_default_.get(),
additional_trust_anchors,
server.get(),
&verify_root));
EXPECT_EQ(net::ERR_CERT_AUTHORITY_INVALID,
VerifyWithAdditionalTrustAnchors(verify_proc_1_.get(),
additional_trust_anchors,
server.get(),
&verify_root));
// Use D Root CA as additional trust anchor. Verifications should succeed now.
additional_trust_anchors.push_back(root_1_[0]);
EXPECT_EQ(net::OK,
VerifyWithAdditionalTrustAnchors(verify_proc_default_.get(),
additional_trust_anchors,
server.get(),
&verify_root));
EXPECT_EQ("CN=D Root CA", verify_root);
EXPECT_EQ(net::OK,
VerifyWithAdditionalTrustAnchors(verify_proc_1_.get(),
additional_trust_anchors,
server.get(),
&verify_root));
EXPECT_EQ("CN=D Root CA", verify_root);
// User 2 should still fail.
EXPECT_EQ(net::ERR_CERT_AUTHORITY_INVALID,
VerifyWithAdditionalTrustAnchors(verify_proc_2_.get(),
net::CertificateList(),
server.get(),
&verify_root));
// Without additional trust anchors, verification should fail again.
additional_trust_anchors.clear();
EXPECT_EQ(net::ERR_CERT_AUTHORITY_INVALID,
VerifyWithAdditionalTrustAnchors(verify_proc_default_.get(),
additional_trust_anchors,
server.get(),
&verify_root));
EXPECT_EQ(net::ERR_CERT_AUTHORITY_INVALID,
VerifyWithAdditionalTrustAnchors(verify_proc_1_.get(),
additional_trust_anchors,
server.get(),
&verify_root));
// Import and trust the D Root CA for user 2.
net::CertificateList roots;
roots.push_back(root_1_[0]);
net::NSSCertDatabase::ImportCertFailureList failed;
EXPECT_TRUE(
db_2_->ImportCACerts(roots, net::NSSCertDatabase::TRUSTED_SSL, &failed));
EXPECT_EQ(0U, failed.size());
// Use D Root CA as additional trust anchor. Verifications should still
// succeed even if the cert is trusted by a different profile.
additional_trust_anchors.push_back(root_1_[0]);
EXPECT_EQ(net::OK,
VerifyWithAdditionalTrustAnchors(verify_proc_default_.get(),
additional_trust_anchors,
server.get(),
&verify_root));
EXPECT_EQ("CN=D Root CA", verify_root);
EXPECT_EQ(net::OK,
VerifyWithAdditionalTrustAnchors(verify_proc_1_.get(),
additional_trust_anchors,
server.get(),
&verify_root));
EXPECT_EQ("CN=D Root CA", verify_root);
EXPECT_EQ(net::OK,
VerifyWithAdditionalTrustAnchors(verify_proc_2_.get(),
additional_trust_anchors,
server.get(),
&verify_root));
EXPECT_EQ("CN=D Root CA", verify_root);
}
class CertVerifyProcChromeOSOrderingTest
: public CertVerifyProcChromeOSTest,
public ::testing::WithParamInterface<
std::tr1::tuple<bool, int, std::string> > {};
// Test a variety of different combinations of (maybe) verifying / (maybe)
// importing / verifying again, to try to find any cases where caching might
// affect the results.
// http://crbug.com/396501
TEST_P(CertVerifyProcChromeOSOrderingTest, DISABLED_TrustThenVerify) {
const ParamType& param = GetParam();
const bool verify_first = std::tr1::get<0>(param);
const int trust_bitmask = std::tr1::get<1>(param);
const std::string test_order = std::tr1::get<2>(param);
DVLOG(1) << "verify_first: " << verify_first
<< " trust_bitmask: " << trust_bitmask
<< " test_order: " << test_order;
scoped_refptr<net::X509Certificate> server = certs_1_[0];
std::string verify_root;
if (verify_first) {
// Before either of the root certs have been trusted, all verifications
// should fail with CERT_AUTHORITY_INVALID.
EXPECT_EQ(net::ERR_CERT_AUTHORITY_INVALID,
Verify(verify_proc_default_.get(), server.get(), &verify_root));
EXPECT_EQ(net::ERR_CERT_AUTHORITY_INVALID,
Verify(verify_proc_1_.get(), server.get(), &verify_root));
EXPECT_EQ(net::ERR_CERT_AUTHORITY_INVALID,
Verify(verify_proc_2_.get(), server.get(), &verify_root));
}
int expected_user1_result = net::ERR_CERT_AUTHORITY_INVALID;
int expected_user2_result = net::ERR_CERT_AUTHORITY_INVALID;
if (trust_bitmask & 1) {
expected_user1_result = net::OK;
// Import and trust the D root for user 1.
net::NSSCertDatabase::ImportCertFailureList failed;
EXPECT_TRUE(db_1_->ImportCACerts(
root_1_, net::NSSCertDatabase::TRUSTED_SSL, &failed));
EXPECT_EQ(0U, failed.size());
for (size_t i = 0; i < failed.size(); ++i) {
LOG(ERROR) << "import fail " << failed[i].net_error << " for "
<< failed[i].certificate->subject().GetDisplayName();
}
}
if (trust_bitmask & 2) {
expected_user2_result = net::OK;
// Import and trust the E root for user 2.
net::NSSCertDatabase::ImportCertFailureList failed;
EXPECT_TRUE(db_2_->ImportCACerts(
root_2_, net::NSSCertDatabase::TRUSTED_SSL, &failed));
EXPECT_EQ(0U, failed.size());
for (size_t i = 0; i < failed.size(); ++i) {
LOG(ERROR) << "import fail " << failed[i].net_error << " for "
<< failed[i].certificate->subject().GetDisplayName();
}
}
// Repeat the tests twice, they should return the same each time.
for (int i = 0; i < 2; ++i) {
SCOPED_TRACE(i);
for (std::string::const_iterator j = test_order.begin();
j != test_order.end();
++j) {
switch (*j) {
case 'd':
// Default verifier should always fail.
EXPECT_EQ(
net::ERR_CERT_AUTHORITY_INVALID,
Verify(verify_proc_default_.get(), server.get(), &verify_root));
break;
case '1':
EXPECT_EQ(expected_user1_result,
Verify(verify_proc_1_.get(), server.get(), &verify_root));
if (expected_user1_result == net::OK)
EXPECT_EQ("CN=D Root CA", verify_root);
break;
case '2':
EXPECT_EQ(expected_user2_result,
Verify(verify_proc_2_.get(), server.get(), &verify_root));
if (expected_user2_result == net::OK)
EXPECT_EQ("CN=E Root CA", verify_root);
break;
default:
FAIL();
}
}
}
}
INSTANTIATE_TEST_CASE_P(
Variations,
CertVerifyProcChromeOSOrderingTest,
::testing::Combine(
::testing::Bool(),
::testing::Range(0, 1 << 2),
::testing::Values("d12", "d21", "1d2", "12d", "2d1", "21d")));
} // namespace chromeos
|