1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441
|
// Copyright 2014 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "base/files/file_path.h"
#include "base/scoped_observer.h"
#include "base/strings/string_number_conversions.h"
#include "base/strings/string_util.h"
#include "base/strings/stringprintf.h"
#include "chrome/browser/extensions/activity_log/activity_actions.h"
#include "chrome/browser/extensions/activity_log/activity_log.h"
#include "chrome/browser/extensions/activity_log/ad_network_database.h"
#include "chrome/browser/extensions/extension_browsertest.h"
#include "chrome/test/base/ui_test_utils.h"
#include "extensions/common/extension.h"
#include "extensions/test/extension_test_message_listener.h"
#include "net/test/embedded_test_server/embedded_test_server.h"
#include "net/test/embedded_test_server/http_response.h"
#include "url/gurl.h"
namespace net {
namespace test_server {
struct HttpRequest;
}
}
namespace extensions {
namespace {
// The "ad network" that we are using. Any src or href equal to this should be
// considered an ad network.
const char kAdNetwork1[] = "http://www.known-ads.adnetwork";
const char kAdNetwork2[] = "http://www.also-known-ads.adnetwork";
// The current stage of the test.
enum Stage {
BEFORE_RESET, // We are about to reset the page.
RESETTING, // We are resetting the page.
TESTING // The reset is complete, and we are testing.
};
// The string sent by the test to indicate that the page reset will begin.
const char kResetBeginString[] = "Page Reset Begin";
// The string sent by the test to indicate that page reset is complete.
const char kResetEndString[] = "Page Reset End";
// The string sent by the test to indicate a JS error was caught in the test.
const char kJavascriptErrorString[] = "Testing Error";
// The string sent by the test to indicate that we have concluded the full test.
const char kTestCompleteString[] = "Test Complete";
std::string InjectionTypeToString(Action::InjectionType type) {
switch (type) {
case Action::NO_AD_INJECTION:
return "No Ad Injection";
case Action::INJECTION_NEW_AD:
return "Injection New Ad";
case Action::INJECTION_REMOVED_AD:
return "Injection Removed Ad";
case Action::INJECTION_REPLACED_AD:
return "Injection Replaced Ad";
case Action::INJECTION_LIKELY_NEW_AD:
return "Injection Likely New Ad";
case Action::INJECTION_LIKELY_REPLACED_AD:
return "Injection Likely Replaced Ad";
case Action::NUM_INJECTION_TYPES:
return "Num Injection Types";
}
return std::string();
}
// An implementation of ActivityLog::Observer that, for every action, sends it
// through Action::DidInjectAd(). This will keep track of the observed
// injections, and can be enabled or disabled as needed (for instance, this
// should be disabled while we are resetting the page).
class ActivityLogObserver : public ActivityLog::Observer {
public:
explicit ActivityLogObserver(content::BrowserContext* context);
virtual ~ActivityLogObserver();
// Disable the observer (e.g., to reset the page).
void disable() { enabled_ = false; }
// Enable the observer, resetting the state.
void enable() {
injection_type_ = Action::NO_AD_INJECTION;
found_multiple_injections_ = false;
enabled_ = true;
}
Action::InjectionType injection_type() const { return injection_type_; }
bool found_multiple_injections() const { return found_multiple_injections_; }
private:
void OnExtensionActivity(scoped_refptr<Action> action) override;
ScopedObserver<ActivityLog, ActivityLog::Observer> scoped_observer_;
// The associated BrowserContext.
content::BrowserContext* context_;
// The type of the last injection.
Action::InjectionType injection_type_;
// Whether or not we found multiple injection types (which shouldn't happen).
bool found_multiple_injections_;
// Whether or not the observer is enabled.
bool enabled_;
};
ActivityLogObserver::ActivityLogObserver(content::BrowserContext* context)
: scoped_observer_(this),
context_(context),
injection_type_(Action::NO_AD_INJECTION),
found_multiple_injections_(false),
enabled_(false) {
ActivityLog::GetInstance(context_)->AddObserver(this);
}
ActivityLogObserver::~ActivityLogObserver() {}
void ActivityLogObserver::OnExtensionActivity(scoped_refptr<Action> action) {
if (!enabled_)
return;
Action::InjectionType type =
action->DidInjectAd(NULL /* no rappor service */);
if (type != Action::NO_AD_INJECTION) {
if (injection_type_ != Action::NO_AD_INJECTION)
found_multiple_injections_ = true;
injection_type_ = type;
}
}
// A mock for the AdNetworkDatabase. This simply says that the URL
// http://www.known-ads.adnetwork is an ad network, and nothing else is.
class TestAdNetworkDatabase : public AdNetworkDatabase {
public:
TestAdNetworkDatabase();
~TestAdNetworkDatabase() override;
private:
bool IsAdNetwork(const GURL& url) const override;
GURL ad_network_url1_;
GURL ad_network_url2_;
};
TestAdNetworkDatabase::TestAdNetworkDatabase() : ad_network_url1_(kAdNetwork1),
ad_network_url2_(kAdNetwork2) {
}
TestAdNetworkDatabase::~TestAdNetworkDatabase() {}
bool TestAdNetworkDatabase::IsAdNetwork(const GURL& url) const {
return url == ad_network_url1_ || url == ad_network_url2_;
}
scoped_ptr<net::test_server::HttpResponse> HandleRequest(
const net::test_server::HttpRequest& request) {
scoped_ptr<net::test_server::BasicHttpResponse> response(
new net::test_server::BasicHttpResponse());
response->set_code(net::HTTP_OK);
return response.Pass();
}
} // namespace
class AdInjectionBrowserTest : public ExtensionBrowserTest {
protected:
AdInjectionBrowserTest();
~AdInjectionBrowserTest() override;
void SetUpOnMainThread() override;
void TearDownOnMainThread() override;
// Handle the "Reset Begin" stage of the test.
testing::AssertionResult HandleResetBeginStage();
// Handle the "Reset End" stage of the test.
testing::AssertionResult HandleResetEndStage();
// Handle the "Testing" stage of the test.
testing::AssertionResult HandleTestingStage(const std::string& message);
// Handle a JS error encountered in a test.
testing::AssertionResult HandleJSError(const std::string& message);
const base::FilePath& test_data_dir() { return test_data_dir_; }
ExtensionTestMessageListener* listener() { return listener_.get(); }
ActivityLogObserver* observer() { return observer_.get(); }
private:
// The name of the last completed test; used in case of unexpected failure for
// debugging.
std::string last_test_;
// A listener for any messages from our ad-injecting extension.
scoped_ptr<ExtensionTestMessageListener> listener_;
// An observer to be alerted when we detect ad injection.
scoped_ptr<ActivityLogObserver> observer_;
// The current stage of the test.
Stage stage_;
};
AdInjectionBrowserTest::AdInjectionBrowserTest() : stage_(BEFORE_RESET) {
}
AdInjectionBrowserTest::~AdInjectionBrowserTest() {
}
void AdInjectionBrowserTest::SetUpOnMainThread() {
ExtensionBrowserTest::SetUpOnMainThread();
ASSERT_TRUE(embedded_test_server()->InitializeAndWaitUntilReady());
embedded_test_server()->RegisterRequestHandler(base::Bind(&HandleRequest));
test_data_dir_ =
test_data_dir_.AppendASCII("activity_log").AppendASCII("ad_injection");
observer_.reset(new ActivityLogObserver(profile()));
// We use a listener in order to keep the actions in the Javascript test
// synchronous. At the end of each stage, the test will send us a message
// with the stage and status, and will not advance until we reply with
// a message.
listener_.reset(new ExtensionTestMessageListener(true /* will reply */));
// Enable the activity log for this test.
ActivityLog::GetInstance(profile())->SetWatchdogAppActiveForTesting(true);
// Set the ad network database.
AdNetworkDatabase::SetForTesting(
scoped_ptr<AdNetworkDatabase>(new TestAdNetworkDatabase));
}
void AdInjectionBrowserTest::TearDownOnMainThread() {
observer_.reset(NULL);
listener_.reset(NULL);
ActivityLog::GetInstance(profile())->SetWatchdogAppActiveForTesting(false);
ExtensionBrowserTest::TearDownOnMainThread();
}
testing::AssertionResult AdInjectionBrowserTest::HandleResetBeginStage() {
if (stage_ != BEFORE_RESET) {
return testing::AssertionFailure()
<< "In incorrect stage. Last Test: " << last_test_;
}
// Stop looking for ad injection, since some of the reset could be considered
// ad injection.
observer()->disable();
stage_ = RESETTING;
return testing::AssertionSuccess();
}
testing::AssertionResult AdInjectionBrowserTest::HandleResetEndStage() {
if (stage_ != RESETTING) {
return testing::AssertionFailure()
<< "In incorrect stage. Last test: " << last_test_;
}
// Look for ad injection again, now that the reset is over.
observer()->enable();
stage_ = TESTING;
return testing::AssertionSuccess();
}
testing::AssertionResult AdInjectionBrowserTest::HandleTestingStage(
const std::string& message) {
if (stage_ != TESTING) {
return testing::AssertionFailure()
<< "In incorrect stage. Last test: " << last_test_;
}
// The format for a testing message is:
// "<test_name>:<expected_change>"
// where <test_name> is the name of the test and <expected_change> is
// either -1 for no ad injection (to test against false positives) or the
// number corresponding to ad_detection::InjectionType.
size_t sep = message.find(':');
int expected_change = -1;
if (sep == std::string::npos ||
!base::StringToInt(message.substr(sep + 1), &expected_change) ||
(expected_change < Action::NO_AD_INJECTION ||
expected_change >= Action::NUM_INJECTION_TYPES)) {
return testing::AssertionFailure()
<< "Invalid message received for testing stage: " << message;
}
last_test_ = message.substr(0, sep);
Action::InjectionType expected_injection =
static_cast<Action::InjectionType>(expected_change);
std::string error;
if (observer()->found_multiple_injections()) {
error = "Found multiple injection types. "
"Only one injection is expected per test.";
} else if (expected_injection != observer()->injection_type()) {
// We need these static casts, because size_t is different on different
// architectures, and printf becomes unhappy.
error = base::StringPrintf(
"Incorrect Injection Found: Expected: %s, Actual: %s",
InjectionTypeToString(expected_injection).c_str(),
InjectionTypeToString(observer()->injection_type()).c_str());
}
stage_ = BEFORE_RESET;
if (!error.empty()) {
return testing::AssertionFailure()
<< "Error in Test '" << last_test_ << "': " << error;
}
return testing::AssertionSuccess();
}
testing::AssertionResult AdInjectionBrowserTest::HandleJSError(
const std::string& message) {
// The format for a testing message is:
// "Testing Error:<test_name>:<error>"
// where <test_name> is the name of the test and <error> is the error which
// was encountered.
size_t first_sep = message.find(':');
size_t second_sep = message.find(':', first_sep + 1);
if (first_sep == std::string::npos || second_sep == std::string::npos) {
return testing::AssertionFailure()
<< "Invalid message received: " << message;
}
std::string test_name =
message.substr(first_sep + 1, second_sep - first_sep - 1);
std::string test_err = message.substr(second_sep + 1);
// We set the stage here, so that subsequent tests don't fail.
stage_ = BEFORE_RESET;
return testing::AssertionFailure() << "Javascript Error in test '"
<< test_name << "': " << test_err;
}
// This is the primary Ad-Injection browser test. It loads an extension that
// has a content script that, in turn, injects ads left, right, and center.
// The content script waits after each injection for a response from this
// browsertest, in order to ensure synchronicity. After each injection, the
// content script cleans up after itself. For significantly more detailed
// comments, see
// chrome/test/data/extensions/activity_log/ad_injection/content_script.js.
IN_PROC_BROWSER_TEST_F(AdInjectionBrowserTest, DetectAdInjections) {
const Extension* extension = LoadExtension(test_data_dir_);
ASSERT_TRUE(extension);
ui_test_utils::NavigateToURL(browser(), embedded_test_server()->GetURL("/"));
std::string message;
while (message != "TestComplete") {
listener()->WaitUntilSatisfied();
message = listener()->message();
if (message == kResetBeginString) {
ASSERT_TRUE(HandleResetBeginStage());
} else if (message == kResetEndString) {
ASSERT_TRUE(HandleResetEndStage());
} else if (!message.compare(
0, strlen(kJavascriptErrorString), kJavascriptErrorString)) {
EXPECT_TRUE(HandleJSError(message));
} else if (message == kTestCompleteString) {
break; // We're done!
} else { // We're in some kind of test.
EXPECT_TRUE(HandleTestingStage(message));
}
// In all cases (except for "Test Complete", in which case we already
// break'ed), we reply with a continue message.
listener()->Reply("Continue");
listener()->Reset();
}
}
// If this test grows, we should consolidate it and AdInjectionBrowserTest.
class ExecuteScriptAdInjectionBrowserTest : public ExtensionBrowserTest {
protected:
void SetUpOnMainThread() override;
void TearDownOnMainThread() override;
};
void ExecuteScriptAdInjectionBrowserTest::SetUpOnMainThread() {
ExtensionBrowserTest::SetUpOnMainThread();
ASSERT_TRUE(embedded_test_server()->InitializeAndWaitUntilReady());
embedded_test_server()->RegisterRequestHandler(base::Bind(&HandleRequest));
// Enable the activity log for this test.
ActivityLog::GetInstance(profile())->SetWatchdogAppActiveForTesting(true);
// Set the ad network database.
AdNetworkDatabase::SetForTesting(
scoped_ptr<AdNetworkDatabase>(new TestAdNetworkDatabase));
}
void ExecuteScriptAdInjectionBrowserTest::TearDownOnMainThread() {
ActivityLog::GetInstance(profile())->SetWatchdogAppActiveForTesting(false);
ExtensionBrowserTest::TearDownOnMainThread();
}
// Test that using chrome.tabs.executeScript doesn't circumvent our detection.
// Since each type of injection is tested more thoroughly in the test above,
// this test just needs to make sure that we detect anything from executeScript.
IN_PROC_BROWSER_TEST_F(ExecuteScriptAdInjectionBrowserTest,
ExecuteScriptAdInjection) {
const Extension* extension =
LoadExtension(test_data_dir_.AppendASCII("activity_log")
.AppendASCII("execute_script_ad_injection"));
ASSERT_TRUE(extension);
ExtensionTestMessageListener listener(false); // Won't reply.
listener.set_extension_id(extension->id());
ActivityLogObserver observer(profile());
observer.enable();
ui_test_utils::NavigateToURL(browser(), embedded_test_server()->GetURL("/"));
// The extension sends a "Done" message when the script has executed.
listener.WaitUntilSatisfied();
EXPECT_EQ("Done", listener.message());
// We should have injected an ad.
EXPECT_EQ(Action::INJECTION_NEW_AD, observer.injection_type());
EXPECT_FALSE(observer.found_multiple_injections());
}
// TODO(rdevlin.cronin): We test a good amount of ways of injecting ads with
// the above test, but more is better in testing.
// See crbug.com/357204.
} // namespace extensions
|