1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276
|
// Copyright 2014 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "base/run_loop.h"
#include "chrome/browser/extensions/extension_install_prompt.h"
#include "chrome/browser/extensions/extension_reenabler.h"
#include "chrome/browser/extensions/extension_service.h"
#include "chrome/browser/extensions/extension_service_test_base.h"
#include "chrome/browser/extensions/extension_system_factory.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/test/base/testing_profile.h"
#include "components/crx_file/id_util.h"
#include "extensions/browser/extension_registry.h"
#include "extensions/browser/management_policy.h"
#include "extensions/browser/test_extensions_browser_client.h"
#include "extensions/common/extension.h"
#include "extensions/common/extension_builder.h"
#include "extensions/common/value_builder.h"
namespace extensions {
namespace {
// A simple provider that says all extensions must remain disabled.
class TestManagementProvider : public ManagementPolicy::Provider {
public:
TestManagementProvider() {}
~TestManagementProvider() override {}
private:
// MananagementPolicy::Provider:
std::string GetDebugPolicyProviderName() const override { return "test"; }
bool MustRemainDisabled(const Extension* extension,
Extension::DisableReason* reason,
base::string16* error) const override {
return true;
}
DISALLOW_COPY_AND_ASSIGN(TestManagementProvider);
};
// A helper class for all the various callbacks associated with reenabling an
// extension. This class also helps store the results of the run.
class CallbackHelper {
public:
CallbackHelper() {}
~CallbackHelper() {}
// Get a callback to run on the completion of the reenable process and reset
// |result_|.
ExtensionReenabler::Callback GetCallback() {
result_.reset();
return base::Bind(&CallbackHelper::OnComplete,
base::Unretained(this));
}
// Check if we have receved any result, and if it matches the expected one.
bool has_result() const { return result_.get() != nullptr; }
bool result_matches(ExtensionReenabler::ReenableResult expected) const {
return result_.get() && *result_ == expected;
}
// Create a test ExtensionInstallPrompt that will not display any UI (which
// causes unit tests to crash), but rather runs the given |quit_closure| (with
// the prompt still active|.
scoped_ptr<ExtensionInstallPrompt> CreateTestPrompt(
content::WebContents* web_contents,
const base::Closure& quit_closure) {
quit_closure_ = quit_closure;
scoped_ptr<ExtensionInstallPrompt> prompt(
new ExtensionInstallPrompt(web_contents));
prompt->set_callback_for_test(base::Bind(&CallbackHelper::OnShow,
base::Unretained(this)));
return prompt.Pass();
}
private:
// The callback to run once the reenable process finishes.
void OnComplete(ExtensionReenabler::ReenableResult result) {
result_.reset(new ExtensionReenabler::ReenableResult(result));
}
// The callback to run when a test ExtensionInstallPrompt is ready to show.
void OnShow(ExtensionInstallPromptShowParams* show_params,
ExtensionInstallPrompt::Delegate* delegate,
scoped_refptr<ExtensionInstallPrompt::Prompt> prompt) {
DCHECK(!quit_closure_.is_null());
quit_closure_.Run();
quit_closure_ = base::Closure();
}
// The closure to quit the currently-running loop; used with test
// ExtensionInstallPrompts.
base::Closure quit_closure_;
// The result of the reenable process, or null if the process hasn't finished.
scoped_ptr<ExtensionReenabler::ReenableResult> result_;
DISALLOW_COPY_AND_ASSIGN(CallbackHelper);
};
} // namespace
class ExtensionReenablerUnitTest : public ExtensionServiceTestBase {
public:
ExtensionReenablerUnitTest() {}
~ExtensionReenablerUnitTest() override {}
private:
void SetUp() override;
void TearDown() override;
scoped_ptr<TestExtensionsBrowserClient> test_browser_client_;
DISALLOW_COPY_AND_ASSIGN(ExtensionReenablerUnitTest);
};
void ExtensionReenablerUnitTest::SetUp() {
ExtensionServiceTestBase::SetUp();
InitializeEmptyExtensionService();
// We need a TestExtensionsBrowserClient because the real one tries to
// implicitly convert any browser context to a (non-Testing)Profile.
test_browser_client_.reset(new TestExtensionsBrowserClient(profile()));
test_browser_client_->set_extension_system_factory(
ExtensionSystemFactory::GetInstance());
ExtensionsBrowserClient::Set(test_browser_client_.get());
}
void ExtensionReenablerUnitTest::TearDown() {
profile_.reset();
ExtensionsBrowserClient::Set(nullptr);
test_browser_client_.reset();
ExtensionServiceTestBase::TearDown();
}
// Test that the ExtensionReenabler reenables disabled extensions.
TEST_F(ExtensionReenablerUnitTest, TestReenablingDisabledExtension) {
// Create a simple extension and add it to the service.
scoped_refptr<const Extension> extension =
ExtensionBuilder().
SetManifest(DictionaryBuilder().Set("name", "test ext").
Set("version", "1.0").
Set("manifest_version", 2).
Set("description", "a test ext")).
SetID(crx_file::id_util::GenerateId("test ext")).
Build();
service()->AddExtension(extension.get());
EXPECT_TRUE(registry()->enabled_extensions().Contains(extension->id()));
CallbackHelper callback_helper;
// Check that the ExtensionReenabler can re-enable disabled extensions.
{
// Disable the extension due to a permissions increase (the only type of
// disablement we handle with the ExtensionReenabler so far).
service()->DisableExtension(extension->id(),
Extension::DISABLE_PERMISSIONS_INCREASE);
// Sanity check that it's disabled.
EXPECT_TRUE(registry()->disabled_extensions().Contains(extension->id()));
// Automatically confirm install prompts.
ExtensionInstallPrompt::g_auto_confirm_for_tests =
ExtensionInstallPrompt::ACCEPT;
// Run the ExtensionReenabler.
scoped_ptr<ExtensionReenabler> extension_reenabler =
ExtensionReenabler::PromptForReenable(extension,
profile(),
nullptr, // No web contents.
GURL(), // No referrer.
callback_helper.GetCallback());
base::RunLoop().RunUntilIdle();
// The extension should be enabled.
EXPECT_TRUE(registry()->enabled_extensions().Contains(extension->id()));
EXPECT_TRUE(
callback_helper.result_matches(ExtensionReenabler::REENABLE_SUCCESS));
}
// Check that we don't re-enable extensions that must remain disabled, and
// that the re-enabler reports failure correctly.
{
ManagementPolicy* management_policy =
ExtensionSystem::Get(browser_context())->management_policy();
ASSERT_TRUE(management_policy);
TestManagementProvider test_provider;
management_policy->RegisterProvider(&test_provider);
service()->DisableExtension(extension->id(),
Extension::DISABLE_PERMISSIONS_INCREASE);
scoped_ptr<ExtensionReenabler> extension_reenabler =
ExtensionReenabler::PromptForReenable(extension,
profile(),
nullptr, // No web contents.
GURL(), // No referrer.
callback_helper.GetCallback());
base::RunLoop().RunUntilIdle();
// The extension should be enabled.
EXPECT_TRUE(registry()->disabled_extensions().Contains(extension->id()));
EXPECT_TRUE(
callback_helper.result_matches(ExtensionReenabler::NOT_ALLOWED));
management_policy->UnregisterProvider(&test_provider);
}
// Check that canceling the re-enable prompt doesn't re-enable the extension.
{
// Disable it again, and try canceling the prompt.
service()->DisableExtension(extension->id(),
Extension::DISABLE_PERMISSIONS_INCREASE);
ExtensionInstallPrompt::g_auto_confirm_for_tests =
ExtensionInstallPrompt::CANCEL;
scoped_ptr<ExtensionReenabler> extension_reenabler =
ExtensionReenabler::PromptForReenable(extension,
profile(),
nullptr, // No web contents.
GURL(), // No referrer.
callback_helper.GetCallback());
base::RunLoop().RunUntilIdle();
// The extension should remain disabled.
EXPECT_TRUE(registry()->disabled_extensions().Contains(extension->id()));
EXPECT_TRUE(
callback_helper.result_matches(ExtensionReenabler::USER_CANCELED));
}
// Test that if the extension is re-enabled while the prompt is active, the
// prompt exits and reports success.
{
// Don't auto-confirm, so that the prompt "stays around".
ExtensionInstallPrompt::g_auto_confirm_for_tests =
ExtensionInstallPrompt::NONE;
base::RunLoop run_loop;
scoped_ptr<ExtensionReenabler> extension_reenabler =
ExtensionReenabler::PromptForReenableWithPromptForTest(
extension,
profile(),
callback_helper.GetCallback(),
callback_helper.CreateTestPrompt(nullptr, run_loop.QuitClosure()));
run_loop.Run();
// We shouldn't have any result yet (the user hasn't confirmed or canceled).
EXPECT_FALSE(callback_helper.has_result());
// Reenable the extension. This should count as a success for reenabling.
service()->GrantPermissionsAndEnableExtension(extension.get());
EXPECT_TRUE(
callback_helper.result_matches(ExtensionReenabler::REENABLE_SUCCESS));
}
// Test that prematurely destroying the re-enable prompt doesn't crash and
// reports an "aborted" result.
{
// Disable again, and create another prompt.
service()->DisableExtension(extension->id(),
Extension::DISABLE_PERMISSIONS_INCREASE);
base::RunLoop run_loop;
scoped_ptr<ExtensionReenabler> extension_reenabler =
ExtensionReenabler::PromptForReenableWithPromptForTest(
extension,
profile(),
callback_helper.GetCallback(),
callback_helper.CreateTestPrompt(nullptr, run_loop.QuitClosure()));
run_loop.Run();
EXPECT_FALSE(callback_helper.has_result());
// Destroy the reenabler to simulate the owning context being shut down
// (e.g., the tab closing).
extension_reenabler.reset();
EXPECT_TRUE(
callback_helper.result_matches(ExtensionReenabler::ABORTED));
}
}
} // namespace extensions
|