1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
|
// Copyright (c) 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include <vector>
#include "chrome/browser/extensions/webstore_inline_installer.h"
#include "chrome/common/extensions/webstore_install_result.h"
#include "chrome/test/base/chrome_render_view_host_test_harness.h"
#include "content/public/browser/web_contents.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "url/gurl.h"
namespace extensions {
namespace {
// Wraps WebstoreInlineInstaller to provide access to domain verification
// methods for testing.
class TestWebstoreInlineInstaller : public WebstoreInlineInstaller {
public:
explicit TestWebstoreInlineInstaller(content::WebContents* contents,
const std::string& requestor_url);
bool TestCheckRequestorPermitted(const base::DictionaryValue& webstore_data) {
std::string error;
return CheckRequestorPermitted(webstore_data, &error);
}
protected:
~TestWebstoreInlineInstaller() override;
};
void TestInstallerCallback(bool success,
const std::string& error,
webstore_install::Result result) {}
TestWebstoreInlineInstaller::TestWebstoreInlineInstaller(
content::WebContents* contents,
const std::string& requestor_url)
: WebstoreInlineInstaller(contents,
"",
GURL(requestor_url),
base::Bind(&TestInstallerCallback)) {
}
TestWebstoreInlineInstaller::~TestWebstoreInlineInstaller() {}
// We inherit from ChromeRenderViewHostTestHarness only for
// CreateTestWebContents, because we need a mock WebContents to support the
// underlying WebstoreInlineInstaller in each test case.
class WebstoreInlineInstallerTest : public ChromeRenderViewHostTestHarness {
public:
// testing::Test
void SetUp() override;
void TearDown() override;
bool TestSingleVerifiedSite(const std::string& requestor_url,
const std::string& verified_site);
bool TestMultipleVerifiedSites(
const std::string& requestor_url,
const std::vector<std::string>& verified_sites);
protected:
scoped_ptr<content::WebContents> web_contents_;
};
void WebstoreInlineInstallerTest::SetUp() {
ChromeRenderViewHostTestHarness::SetUp();
web_contents_.reset(CreateTestWebContents());
}
void WebstoreInlineInstallerTest::TearDown() {
web_contents_.reset(NULL);
ChromeRenderViewHostTestHarness::TearDown();
}
// Simulates a test against the verified site string from a Webstore item's
// "verified_site" manifest entry.
bool WebstoreInlineInstallerTest::TestSingleVerifiedSite(
const std::string& requestor_url,
const std::string& verified_site) {
base::DictionaryValue webstore_data;
webstore_data.SetString("verified_site", verified_site);
scoped_refptr<TestWebstoreInlineInstaller> installer =
new TestWebstoreInlineInstaller(web_contents_.get(), requestor_url);
return installer->TestCheckRequestorPermitted(webstore_data);
}
// Simulates a test against a list of verified site strings from a Webstore
// item's "verified_sites" manifest entry.
bool WebstoreInlineInstallerTest::TestMultipleVerifiedSites(
const std::string& requestor_url,
const std::vector<std::string>& verified_sites) {
base::ListValue* sites = new base::ListValue();
for (std::vector<std::string>::const_iterator it = verified_sites.begin();
it != verified_sites.end(); ++it) {
sites->Append(new base::StringValue(*it));
}
base::DictionaryValue webstore_data;
webstore_data.Set("verified_sites", sites);
scoped_refptr<TestWebstoreInlineInstaller> installer =
new TestWebstoreInlineInstaller(web_contents_.get(), requestor_url);
return installer->TestCheckRequestorPermitted(webstore_data);
}
} // namespace
TEST_F(WebstoreInlineInstallerTest, DomainVerification) {
// Exact domain match.
EXPECT_TRUE(TestSingleVerifiedSite("http://example.com", "example.com"));
// The HTTPS scheme is allowed.
EXPECT_TRUE(TestSingleVerifiedSite("https://example.com", "example.com"));
// The file: scheme is not allowed.
EXPECT_FALSE(TestSingleVerifiedSite("file:///example.com", "example.com"));
// Trailing slash in URL.
EXPECT_TRUE(TestSingleVerifiedSite("http://example.com/", "example.com"));
// Page on the domain.
EXPECT_TRUE(TestSingleVerifiedSite("http://example.com/page.html",
"example.com"));
// Page on a subdomain.
EXPECT_TRUE(TestSingleVerifiedSite("http://sub.example.com/page.html",
"example.com"));
// Root domain when only a subdomain is verified.
EXPECT_FALSE(TestSingleVerifiedSite("http://example.com/",
"sub.example.com"));
// Different subdomain when only a subdomain is verified.
EXPECT_FALSE(TestSingleVerifiedSite("http://www.example.com/",
"sub.example.com"));
// Port matches.
EXPECT_TRUE(TestSingleVerifiedSite("http://example.com:123/",
"example.com:123"));
// Port doesn't match.
EXPECT_FALSE(TestSingleVerifiedSite("http://example.com:456/",
"example.com:123"));
// Port is missing in the requestor URL.
EXPECT_FALSE(TestSingleVerifiedSite("http://example.com/",
"example.com:123"));
// Port is missing in the verified site (any port matches).
EXPECT_TRUE(TestSingleVerifiedSite("http://example.com:123/", "example.com"));
// Path matches.
EXPECT_TRUE(TestSingleVerifiedSite("http://example.com/path",
"example.com/path"));
// Path doesn't match.
EXPECT_FALSE(TestSingleVerifiedSite("http://example.com/foo",
"example.com/path"));
// Path is missing.
EXPECT_FALSE(TestSingleVerifiedSite("http://example.com",
"example.com/path"));
// Path matches (with trailing slash).
EXPECT_TRUE(TestSingleVerifiedSite("http://example.com/path/",
"example.com/path"));
// Path matches (is a file under the path).
EXPECT_TRUE(TestSingleVerifiedSite("http://example.com/path/page.html",
"example.com/path"));
// Path and port match.
EXPECT_TRUE(TestSingleVerifiedSite(
"http://example.com:123/path/page.html", "example.com:123/path"));
// Match specific valid schemes
EXPECT_TRUE(TestSingleVerifiedSite("http://example.com",
"http://example.com"));
EXPECT_TRUE(TestSingleVerifiedSite("https://example.com",
"https://example.com"));
// Mismatch specific vaild schemes
EXPECT_FALSE(TestSingleVerifiedSite("https://example.com",
"http://example.com"));
EXPECT_FALSE(TestSingleVerifiedSite("http://example.com",
"https://example.com"));
// Invalid scheme spec
EXPECT_FALSE(TestSingleVerifiedSite("file://example.com",
"file://example.com"));
std::vector<std::string> verified_sites;
verified_sites.push_back("foo.example.com");
verified_sites.push_back("bar.example.com:123");
verified_sites.push_back("example.com/unicorns");
// Test valid examples against the site list.
EXPECT_TRUE(TestMultipleVerifiedSites("http://foo.example.com",
verified_sites));
EXPECT_TRUE(TestMultipleVerifiedSites("http://bar.example.com:123",
verified_sites));
EXPECT_TRUE(TestMultipleVerifiedSites(
"http://cooking.example.com/unicorns/bacon.html", verified_sites));
// Test invalid examples against the site list.
EXPECT_FALSE(TestMultipleVerifiedSites("http://example.com",
verified_sites));
EXPECT_FALSE(TestMultipleVerifiedSites("file://foo.example.com",
verified_sites));
EXPECT_FALSE(TestMultipleVerifiedSites("http://baz.example.com",
verified_sites));
EXPECT_FALSE(TestMultipleVerifiedSites("http://bar.example.com:456",
verified_sites));
}
} // namespace extensions
|
