1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515
|
// Copyright (c) 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "base/command_line.h"
#include "base/memory/scoped_vector.h"
#include "base/path_service.h"
#include "base/strings/stringprintf.h"
#include "chrome/browser/extensions/extension_apitest.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_finder.h"
#include "chrome/browser/ui/browser_iterator.h"
#include "chrome/browser/ui/panels/panel_manager.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
#include "chrome/common/chrome_paths.h"
#include "chrome/common/chrome_switches.h"
#include "chrome/test/base/test_switches.h"
#include "chrome/test/base/ui_test_utils.h"
#include "content/public/browser/render_process_host.h"
#include "content/public/browser/web_contents.h"
#include "content/public/common/result_codes.h"
#include "content/public/common/url_constants.h"
#include "content/public/test/browser_test_utils.h"
#include "extensions/browser/extension_host.h"
#include "extensions/browser/process_manager.h"
#include "extensions/common/constants.h"
#include "extensions/common/extension.h"
#include "extensions/common/switches.h"
#include "extensions/test/extension_test_message_listener.h"
#include "extensions/test/result_catcher.h"
#include "net/dns/mock_host_resolver.h"
#include "net/test/embedded_test_server/embedded_test_server.h"
#include "testing/gtest/include/gtest/gtest.h"
#if defined(USE_ASH)
#include "extensions/browser/app_window/app_window_registry.h"
#endif
#if defined(USE_ASH) && defined(OS_CHROMEOS)
// TODO(stevenjb): Figure out the correct behavior for Ash + Win
#define USE_ASH_PANELS
#endif
using content::OpenURLParams;
using content::Referrer;
using content::WebContents;
// Disabled, http://crbug.com/64899.
IN_PROC_BROWSER_TEST_F(ExtensionApiTest, DISABLED_WindowOpen) {
base::CommandLine::ForCurrentProcess()->AppendSwitch(
extensions::switches::kEnableExperimentalExtensionApis);
extensions::ResultCatcher catcher;
ASSERT_TRUE(LoadExtensionIncognito(test_data_dir_
.AppendASCII("window_open").AppendASCII("spanning")));
EXPECT_TRUE(catcher.GetNextResult()) << catcher.message();
}
int GetPanelCount(Browser* browser) {
#if defined(USE_ASH_PANELS)
return static_cast<int>(extensions::AppWindowRegistry::Get(
browser->profile())->app_windows().size());
#else
return PanelManager::GetInstance()->num_panels();
#endif
}
bool WaitForTabsAndPopups(Browser* browser,
int num_tabs,
int num_popups,
int num_panels) {
SCOPED_TRACE(
base::StringPrintf("WaitForTabsAndPopups tabs:%d, popups:%d, panels:%d",
num_tabs, num_popups, num_panels));
// We start with one tab and one browser already open.
++num_tabs;
size_t num_browsers = static_cast<size_t>(num_popups) + 1;
const base::TimeDelta kWaitTime = base::TimeDelta::FromSeconds(10);
base::TimeTicks end_time = base::TimeTicks::Now() + kWaitTime;
while (base::TimeTicks::Now() < end_time) {
if (chrome::GetBrowserCount(browser->profile(),
browser->host_desktop_type()) == num_browsers &&
browser->tab_strip_model()->count() == num_tabs &&
GetPanelCount(browser) == num_panels)
break;
content::RunAllPendingInMessageLoop();
}
EXPECT_EQ(num_browsers,
chrome::GetBrowserCount(browser->profile(),
browser->host_desktop_type()));
EXPECT_EQ(num_tabs, browser->tab_strip_model()->count());
EXPECT_EQ(num_panels, GetPanelCount(browser));
int num_popups_seen = 0;
for (chrome::BrowserIterator iter; !iter.done(); iter.Next()) {
if (*iter == browser)
continue;
EXPECT_TRUE((*iter)->is_type_popup());
++num_popups_seen;
}
EXPECT_EQ(num_popups, num_popups_seen);
return ((num_browsers ==
chrome::GetBrowserCount(browser->profile(),
browser->host_desktop_type())) &&
(num_tabs == browser->tab_strip_model()->count()) &&
(num_panels == GetPanelCount(browser)) &&
(num_popups == num_popups_seen));
}
IN_PROC_BROWSER_TEST_F(ExtensionApiTest, BrowserIsApp) {
host_resolver()->AddRule("a.com", "127.0.0.1");
ASSERT_TRUE(StartEmbeddedTestServer());
ASSERT_TRUE(LoadExtension(
test_data_dir_.AppendASCII("window_open").AppendASCII("browser_is_app")));
EXPECT_TRUE(WaitForTabsAndPopups(browser(), 0, 2, 0));
for (chrome::BrowserIterator iter; !iter.done(); iter.Next()) {
if (*iter == browser())
ASSERT_FALSE(iter->is_app());
else
ASSERT_TRUE(iter->is_app());
}
}
IN_PROC_BROWSER_TEST_F(ExtensionApiTest, WindowOpenPopupDefault) {
ASSERT_TRUE(StartEmbeddedTestServer());
ASSERT_TRUE(LoadExtension(
test_data_dir_.AppendASCII("window_open").AppendASCII("popup")));
const int num_tabs = 1;
const int num_popups = 0;
EXPECT_TRUE(WaitForTabsAndPopups(browser(), num_tabs, num_popups, 0));
}
IN_PROC_BROWSER_TEST_F(ExtensionApiTest, WindowOpenPopupIframe) {
ASSERT_TRUE(StartEmbeddedTestServer());
base::FilePath test_data_dir;
PathService::Get(chrome::DIR_TEST_DATA, &test_data_dir);
embedded_test_server()->ServeFilesFromDirectory(test_data_dir);
ASSERT_TRUE(LoadExtension(
test_data_dir_.AppendASCII("window_open").AppendASCII("popup_iframe")));
const int num_tabs = 1;
const int num_popups = 0;
EXPECT_TRUE(WaitForTabsAndPopups(browser(), num_tabs, num_popups, 0));
}
IN_PROC_BROWSER_TEST_F(ExtensionApiTest, WindowOpenPopupLarge) {
ASSERT_TRUE(StartEmbeddedTestServer());
ASSERT_TRUE(LoadExtension(
test_data_dir_.AppendASCII("window_open").AppendASCII("popup_large")));
// On other systems this should open a new popup window.
const int num_tabs = 0;
const int num_popups = 1;
EXPECT_TRUE(WaitForTabsAndPopups(browser(), num_tabs, num_popups, 0));
}
IN_PROC_BROWSER_TEST_F(ExtensionApiTest, WindowOpenPopupSmall) {
ASSERT_TRUE(StartEmbeddedTestServer());
ASSERT_TRUE(LoadExtension(
test_data_dir_.AppendASCII("window_open").AppendASCII("popup_small")));
// On ChromeOS this should open a new panel (acts like a new popup window).
// On other systems this should open a new popup window.
const int num_tabs = 0;
const int num_popups = 1;
EXPECT_TRUE(WaitForTabsAndPopups(browser(), num_tabs, num_popups, 0));
}
// Disabled on Windows. Often times out or fails: crbug.com/177530
#if defined(OS_WIN)
#define MAYBE_PopupBlockingExtension DISABLED_PopupBlockingExtension
#else
#define MAYBE_PopupBlockingExtension PopupBlockingExtension
#endif
IN_PROC_BROWSER_TEST_F(ExtensionApiTest, MAYBE_PopupBlockingExtension) {
host_resolver()->AddRule("*", "127.0.0.1");
ASSERT_TRUE(StartEmbeddedTestServer());
ASSERT_TRUE(LoadExtension(
test_data_dir_.AppendASCII("window_open").AppendASCII("popup_blocking")
.AppendASCII("extension")));
EXPECT_TRUE(WaitForTabsAndPopups(browser(), 5, 3, 0));
}
IN_PROC_BROWSER_TEST_F(ExtensionApiTest, PopupBlockingHostedApp) {
host_resolver()->AddRule("*", "127.0.0.1");
ASSERT_TRUE(test_server()->Start());
ASSERT_TRUE(LoadExtension(
test_data_dir_.AppendASCII("window_open").AppendASCII("popup_blocking")
.AppendASCII("hosted_app")));
// The app being tested owns the domain a.com . The test URLs we navigate
// to below must be within that domain, so that they fall within the app's
// web extent.
GURL::Replacements replace_host;
std::string a_dot_com = "a.com";
replace_host.SetHostStr(a_dot_com);
const std::string popup_app_contents_path(
"files/extensions/api_test/window_open/popup_blocking/hosted_app/");
GURL open_tab =
test_server()->GetURL(popup_app_contents_path + "open_tab.html")
.ReplaceComponents(replace_host);
GURL open_popup =
test_server()->GetURL(popup_app_contents_path + "open_popup.html")
.ReplaceComponents(replace_host);
browser()->OpenURL(OpenURLParams(
open_tab, Referrer(), NEW_FOREGROUND_TAB, ui::PAGE_TRANSITION_TYPED,
false));
browser()->OpenURL(OpenURLParams(
open_popup, Referrer(), NEW_FOREGROUND_TAB,
ui::PAGE_TRANSITION_TYPED, false));
EXPECT_TRUE(WaitForTabsAndPopups(browser(), 3, 1, 0));
}
IN_PROC_BROWSER_TEST_F(ExtensionApiTest, WindowArgumentsOverflow) {
ASSERT_TRUE(RunExtensionTest("window_open/argument_overflow")) << message_;
}
class WindowOpenPanelDisabledTest : public ExtensionApiTest {
void SetUpCommandLine(base::CommandLine* command_line) override {
ExtensionApiTest::SetUpCommandLine(command_line);
// TODO(jennb): Re-enable when panels are enabled by default.
// command_line->AppendSwitch(switches::kDisablePanels);
}
};
IN_PROC_BROWSER_TEST_F(WindowOpenPanelDisabledTest,
DISABLED_WindowOpenPanelNotEnabled) {
ASSERT_TRUE(RunExtensionTest("window_open/panel_not_enabled")) << message_;
}
class WindowOpenPanelTest : public ExtensionApiTest {
void SetUpCommandLine(base::CommandLine* command_line) override {
ExtensionApiTest::SetUpCommandLine(command_line);
command_line->AppendSwitch(switches::kEnablePanels);
}
};
#if defined(USE_ASH_PANELS)
// On Ash, this currently fails because we're currently opening new panel
// windows as popup windows instead.
#define MAYBE_WindowOpenPanel DISABLED_WindowOpenPanel
#else
#define MAYBE_WindowOpenPanel WindowOpenPanel
#endif
IN_PROC_BROWSER_TEST_F(WindowOpenPanelTest, MAYBE_WindowOpenPanel) {
ASSERT_TRUE(RunExtensionTest("window_open/panel")) << message_;
}
#if defined(USE_ASH_PANELS) || defined(OS_LINUX)
// On Ash, this currently fails because we're currently opening new panel
// windows as popup windows instead.
// We're also failing on Linux-aura due to the panel is not opened in the
// right origin.
#define MAYBE_WindowOpenPanelDetached DISABLED_WindowOpenPanelDetached
#else
#define MAYBE_WindowOpenPanelDetached WindowOpenPanelDetached
#endif
IN_PROC_BROWSER_TEST_F(WindowOpenPanelTest, MAYBE_WindowOpenPanelDetached) {
ASSERT_TRUE(RunExtensionTest("window_open/panel_detached")) << message_;
}
#if defined(OS_LINUX) && !defined(OS_CHROMEOS)
// TODO(erg): Bring up ash http://crbug.com/300084
#define MAYBE_CloseNonExtensionPanelsOnUninstall \
DISABLED_CloseNonExtensionPanelsOnUninstall
#else
#define MAYBE_CloseNonExtensionPanelsOnUninstall \
CloseNonExtensionPanelsOnUninstall
#endif
IN_PROC_BROWSER_TEST_F(WindowOpenPanelTest,
MAYBE_CloseNonExtensionPanelsOnUninstall) {
#if defined(OS_WIN) && defined(USE_ASH)
// Disable this test in Metro+Ash for now (http://crbug.com/262796).
if (base::CommandLine::ForCurrentProcess()->HasSwitch(
switches::kAshBrowserTests))
return;
#endif
#if defined(USE_ASH_PANELS)
// On Ash, new panel windows open as popup windows instead.
int num_popups, num_panels;
if (base::CommandLine::ForCurrentProcess()->HasSwitch(
switches::kEnablePanels)) {
num_popups = 2;
num_panels = 2;
} else {
num_popups = 4;
num_panels = 0;
}
#else
int num_popups = 2;
int num_panels = 2;
#endif
ASSERT_TRUE(StartEmbeddedTestServer());
// Setup listeners to wait on strings we expect the extension pages to send.
std::vector<std::string> test_strings;
test_strings.push_back("content_tab");
if (num_panels)
test_strings.push_back("content_panel");
test_strings.push_back("content_popup");
ScopedVector<ExtensionTestMessageListener> listeners;
for (size_t i = 0; i < test_strings.size(); ++i) {
listeners.push_back(
new ExtensionTestMessageListener(test_strings[i], false));
}
const extensions::Extension* extension = LoadExtension(
test_data_dir_.AppendASCII("window_open").AppendASCII(
"close_panels_on_uninstall"));
ASSERT_TRUE(extension);
// Two tabs. One in extension domain and one in non-extension domain.
// Two popups - one in extension domain and one in non-extension domain.
// Two panels - one in extension domain and one in non-extension domain.
EXPECT_TRUE(WaitForTabsAndPopups(browser(), 2, num_popups, num_panels));
// Wait on test messages to make sure the pages loaded.
for (size_t i = 0; i < listeners.size(); ++i)
ASSERT_TRUE(listeners[i]->WaitUntilSatisfied());
UninstallExtension(extension->id());
// Wait for the tabs and popups in non-extension domain to stay open.
// Expect everything else, including panels, to close.
num_popups -= 1;
#if defined(USE_ASH_PANELS)
if (!base::CommandLine::ForCurrentProcess()->HasSwitch(
switches::kEnablePanels)) {
// On Ash, new panel windows open as popup windows instead, so there are 2
// extension domain popups that will close (instead of 1 popup on non-Ash).
num_popups -= 1;
}
#endif
#if defined(USE_ASH)
#if !defined(OS_WIN)
// On linux ash we close all popup applications when closing its extension.
num_popups = 0;
#endif
#endif
EXPECT_TRUE(WaitForTabsAndPopups(browser(), 1, num_popups, 0));
}
// This test isn't applicable on Chrome OS, which automatically reloads crashed
// pages.
#if !defined(OS_CHROMEOS)
IN_PROC_BROWSER_TEST_F(WindowOpenPanelTest, ClosePanelsOnExtensionCrash) {
#if defined(USE_ASH_PANELS)
// On Ash, new panel windows open as popup windows instead.
int num_popups = 4;
int num_panels = 0;
#else
int num_popups = 2;
int num_panels = 2;
#endif
ASSERT_TRUE(StartEmbeddedTestServer());
// Setup listeners to wait on strings we expect the extension pages to send.
std::vector<std::string> test_strings;
test_strings.push_back("content_tab");
if (num_panels)
test_strings.push_back("content_panel");
test_strings.push_back("content_popup");
ScopedVector<ExtensionTestMessageListener> listeners;
for (size_t i = 0; i < test_strings.size(); ++i) {
listeners.push_back(
new ExtensionTestMessageListener(test_strings[i], false));
}
const extensions::Extension* extension = LoadExtension(
test_data_dir_.AppendASCII("window_open").AppendASCII(
"close_panels_on_uninstall"));
ASSERT_TRUE(extension);
// Two tabs. One in extension domain and one in non-extension domain.
// Two popups - one in extension domain and one in non-extension domain.
// Two panels - one in extension domain and one in non-extension domain.
EXPECT_TRUE(WaitForTabsAndPopups(browser(), 2, num_popups, num_panels));
// Wait on test messages to make sure the pages loaded.
for (size_t i = 0; i < listeners.size(); ++i)
ASSERT_TRUE(listeners[i]->WaitUntilSatisfied());
// Crash the extension.
extensions::ExtensionHost* extension_host =
extensions::ProcessManager::Get(browser()->profile())
->GetBackgroundHostForExtension(extension->id());
ASSERT_TRUE(extension_host);
extension_host->render_process_host()->Shutdown(content::RESULT_CODE_KILLED,
false);
WaitForExtensionCrash(extension->id());
// Only expect panels to close. The rest stay open to show a sad-tab.
EXPECT_TRUE(WaitForTabsAndPopups(browser(), 2, num_popups, 0));
}
#endif // !defined(OS_CHROMEOS)
#if defined(USE_ASH_PANELS)
// This test is not applicable on Ash. The modified window.open behavior only
// applies to non-Ash panel windows.
#define MAYBE_WindowOpenFromPanel DISABLED_WindowOpenFromPanel
#else
#define MAYBE_WindowOpenFromPanel WindowOpenFromPanel
#endif
IN_PROC_BROWSER_TEST_F(WindowOpenPanelTest, MAYBE_WindowOpenFromPanel) {
ASSERT_TRUE(StartEmbeddedTestServer());
// Load the extension that will open a panel which then calls window.open.
ASSERT_TRUE(LoadExtension(test_data_dir_.AppendASCII("window_open").
AppendASCII("panel_window_open")));
// Expect one panel (opened by extension) and one tab (from the panel calling
// window.open). Panels modify the WindowOpenDisposition in window.open
// to always open in a tab.
EXPECT_TRUE(WaitForTabsAndPopups(browser(), 1, 0, 1));
}
IN_PROC_BROWSER_TEST_F(ExtensionApiTest, DISABLED_WindowOpener) {
ASSERT_TRUE(RunExtensionTest("window_open/opener")) << message_;
}
#if defined(OS_MACOSX)
// Extension popup windows are incorrectly sized on OSX, crbug.com/225601
#define MAYBE_WindowOpenSized DISABLED_WindowOpenSized
#else
#define MAYBE_WindowOpenSized WindowOpenSized
#endif
// Ensure that the width and height properties of a window opened with
// chrome.windows.create match the creation parameters. See crbug.com/173831.
IN_PROC_BROWSER_TEST_F(ExtensionApiTest, MAYBE_WindowOpenSized) {
ASSERT_TRUE(RunExtensionTest("window_open/window_size")) << message_;
EXPECT_TRUE(WaitForTabsAndPopups(browser(), 0, 1, 0));
}
// Tests that an extension page can call window.open to an extension URL and
// the new window has extension privileges.
IN_PROC_BROWSER_TEST_F(ExtensionBrowserTest, WindowOpenExtension) {
ASSERT_TRUE(LoadExtension(
test_data_dir_.AppendASCII("uitest").AppendASCII("window_open")));
GURL start_url(std::string(extensions::kExtensionScheme) +
url::kStandardSchemeSeparator +
last_loaded_extension_id() + "/test.html");
ui_test_utils::NavigateToURL(browser(), start_url);
WebContents* newtab = NULL;
ASSERT_NO_FATAL_FAILURE(
OpenWindow(browser()->tab_strip_model()->GetActiveWebContents(),
start_url.Resolve("newtab.html"), true, &newtab));
bool result = false;
ASSERT_TRUE(content::ExecuteScriptAndExtractBool(newtab, "testExtensionApi()",
&result));
EXPECT_TRUE(result);
}
// Tests that if an extension page calls window.open to an invalid extension
// URL, the browser doesn't crash.
IN_PROC_BROWSER_TEST_F(ExtensionBrowserTest, WindowOpenInvalidExtension) {
ASSERT_TRUE(LoadExtension(
test_data_dir_.AppendASCII("uitest").AppendASCII("window_open")));
GURL start_url(std::string(extensions::kExtensionScheme) +
url::kStandardSchemeSeparator +
last_loaded_extension_id() + "/test.html");
ui_test_utils::NavigateToURL(browser(), start_url);
ASSERT_NO_FATAL_FAILURE(
OpenWindow(browser()->tab_strip_model()->GetActiveWebContents(),
GURL("chrome-extension://thisissurelynotavalidextensionid/newtab.html"),
false, NULL));
// If we got to this point, we didn't crash, so we're good.
}
// Tests that calling window.open from the newtab page to an extension URL
// gives the new window extension privileges - even though the opening page
// does not have extension privileges, we break the script connection, so
// there is no privilege leak.
IN_PROC_BROWSER_TEST_F(ExtensionBrowserTest, WindowOpenNoPrivileges) {
ASSERT_TRUE(LoadExtension(
test_data_dir_.AppendASCII("uitest").AppendASCII("window_open")));
ui_test_utils::NavigateToURL(browser(), GURL("about:blank"));
WebContents* newtab = NULL;
ASSERT_NO_FATAL_FAILURE(
OpenWindow(browser()->tab_strip_model()->GetActiveWebContents(),
GURL(std::string(extensions::kExtensionScheme) +
url::kStandardSchemeSeparator +
last_loaded_extension_id() + "/newtab.html"),
false,
&newtab));
// Extension API should succeed.
bool result = false;
ASSERT_TRUE(content::ExecuteScriptAndExtractBool(newtab, "testExtensionApi()",
&result));
EXPECT_TRUE(result);
}
|