1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
|
// Copyright 2014 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "base/command_line.h"
#include "chrome/browser/password_manager/chrome_password_manager_client.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/autofill/password_generation_popup_observer.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
#include "chrome/test/base/in_process_browser_test.h"
#include "chrome/test/base/ui_test_utils.h"
#include "components/autofill/core/browser/autofill_test_utils.h"
#include "components/autofill/core/common/autofill_switches.h"
#include "components/password_manager/core/browser/password_generation_manager.h"
#include "content/public/browser/render_view_host.h"
#include "content/public/browser/web_contents.h"
#include "content/public/test/browser_test_utils.h"
#include "net/test/embedded_test_server/embedded_test_server.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "ui/events/keycodes/keyboard_codes.h"
namespace {
class TestPopupObserver : public autofill::PasswordGenerationPopupObserver {
public:
TestPopupObserver()
: popup_showing_(false),
password_visible_(false) {}
virtual ~TestPopupObserver() {}
void OnPopupShown(bool password_visible) override {
popup_showing_ = true;
password_visible_ = password_visible;
}
void OnPopupHidden() override { popup_showing_ = false; }
bool popup_showing() { return popup_showing_; }
bool password_visible() { return password_visible_; }
private:
bool popup_showing_;
bool password_visible_;
};
} // namespace
class PasswordGenerationInteractiveTest : public InProcessBrowserTest {
public:
void SetUpCommandLine(base::CommandLine* command_line) override {
// Make sure the feature is enabled.
command_line->AppendSwitch(autofill::switches::kEnablePasswordGeneration);
// Don't require ping from autofill or blacklist checking.
command_line->AppendSwitch(
autofill::switches::kLocalHeuristicsOnlyForPasswordGeneration);
}
void SetUpOnMainThread() override {
// Disable Autofill requesting access to AddressBook data. This will cause
// the tests to hang on Mac.
autofill::test::DisableSystemServices(browser()->profile()->GetPrefs());
// Set observer for popup.
ChromePasswordManagerClient* client =
ChromePasswordManagerClient::FromWebContents(GetWebContents());
client->SetTestObserver(&observer_);
ASSERT_TRUE(embedded_test_server()->InitializeAndWaitUntilReady());
GURL url = embedded_test_server()->GetURL("/password/signup_form.html");
ui_test_utils::NavigateToURL(browser(), url);
}
void TearDownOnMainThread() override {
// Clean up UI.
ChromePasswordManagerClient* client =
ChromePasswordManagerClient::FromWebContents(GetWebContents());
client->HidePasswordGenerationPopup();
}
content::WebContents* GetWebContents() {
return browser()->tab_strip_model()->GetActiveWebContents();
}
content::RenderViewHost* GetRenderViewHost() {
return GetWebContents()->GetRenderViewHost();
}
std::string GetFieldValue(const std::string& field_id) {
std::string value;
EXPECT_TRUE(content::ExecuteScriptAndExtractString(
GetRenderViewHost(),
"window.domAutomationController.send("
" document.getElementById('" + field_id + "').value);",
&value));
return value;
}
std::string GetFocusedElement() {
std::string focused_element;
EXPECT_TRUE(content::ExecuteScriptAndExtractString(
GetRenderViewHost(),
"window.domAutomationController.send("
" document.activeElement.id)",
&focused_element));
return focused_element;
}
void FocusPasswordField() {
ASSERT_TRUE(content::ExecuteScript(
GetRenderViewHost(),
"document.getElementById('password_field').focus()"));
}
void SendKeyToPopup(ui::KeyboardCode key) {
content::NativeWebKeyboardEvent event;
event.windowsKeyCode = key;
event.type = blink::WebKeyboardEvent::RawKeyDown;
GetRenderViewHost()->ForwardKeyboardEvent(event);
}
bool GenerationPopupShowing() {
return observer_.popup_showing() && observer_.password_visible();
}
bool EditingPopupShowing() {
return observer_.popup_showing() && !observer_.password_visible();
}
private:
TestPopupObserver observer_;
};
#if defined(USE_AURA)
// Enabled on these platforms.
// Disabled due to flakiness, see http://crbug.com/407998
#define MAYBE_PopupShownAndPasswordSelected \
DISABLED_PopupShownAndPasswordSelected
#define MAYBE_PopupShownAndDismissed DISABLED_PopupShownAndDismissed
#define MAYBE_PopupShownAndDismissedByScrolling \
DISABLED_PopupShownAndDismissedByScrolling
#else
// Popup not enabled for these platforms yet.
#define MAYBE_PopupShownAndPasswordSelected \
DISABLED_PopupShownAndPasswordSelected
#define MAYBE_PopupShownAndDismissed DISABLED_PopupShownAndDismissed
#define MAYBE_PopupShownAndDismissedByScrolling \
DISABLED_PopupShownAndDismissedByScrolling
#endif
IN_PROC_BROWSER_TEST_F(PasswordGenerationInteractiveTest,
MAYBE_PopupShownAndPasswordSelected) {
FocusPasswordField();
EXPECT_TRUE(GenerationPopupShowing());
SendKeyToPopup(ui::VKEY_DOWN);
SendKeyToPopup(ui::VKEY_RETURN);
// Selecting the password should fill the field and move focus to the
// submit button.
EXPECT_FALSE(GetFieldValue("password_field").empty());
EXPECT_FALSE(GenerationPopupShowing());
EXPECT_FALSE(EditingPopupShowing());
EXPECT_EQ("input_submit_button", GetFocusedElement());
// Re-focusing the password field should show the editing popup.
FocusPasswordField();
EXPECT_TRUE(EditingPopupShowing());
}
IN_PROC_BROWSER_TEST_F(PasswordGenerationInteractiveTest,
MAYBE_PopupShownAndDismissed) {
FocusPasswordField();
EXPECT_TRUE(GenerationPopupShowing());
SendKeyToPopup(ui::VKEY_ESCAPE);
// Popup is dismissed.
EXPECT_FALSE(GenerationPopupShowing());
}
IN_PROC_BROWSER_TEST_F(PasswordGenerationInteractiveTest,
MAYBE_PopupShownAndDismissedByScrolling) {
FocusPasswordField();
EXPECT_TRUE(GenerationPopupShowing());
ASSERT_TRUE(content::ExecuteScript(GetRenderViewHost(),
"window.scrollTo(100, 0);"));
EXPECT_FALSE(GenerationPopupShowing());
}
|
