1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460
|
// Copyright (c) 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "base/basictypes.h"
#include "base/bind.h"
#include "base/bind_helpers.h"
#include "base/files/file_util.h"
#include "base/files/scoped_temp_dir.h"
#include "base/prefs/pref_service.h"
#include "base/run_loop.h"
#include "base/stl_util.h"
#include "base/strings/string_util.h"
#include "base/strings/stringprintf.h"
#include "base/strings/utf_string_conversions.h"
#include "base/time/time.h"
#include "chrome/browser/password_manager/password_store_x.h"
#include "chrome/test/base/testing_browser_process.h"
#include "components/password_manager/core/browser/password_form_data.h"
#include "components/password_manager/core/browser/password_store_change.h"
#include "components/password_manager/core/browser/password_store_consumer.h"
#include "components/password_manager/core/common/password_manager_pref_names.h"
#include "content/public/browser/browser_thread.h"
#include "content/public/test/test_browser_thread_bundle.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
using autofill::PasswordForm;
using password_manager::ContainsAllPasswordForms;
using password_manager::PasswordStoreChange;
using password_manager::PasswordStoreChangeList;
using testing::_;
using testing::ElementsAreArray;
using testing::WithArg;
typedef std::vector<PasswordForm*> VectorOfForms;
namespace {
class MockPasswordStoreConsumer
: public password_manager::PasswordStoreConsumer {
public:
MOCK_METHOD1(OnGetPasswordStoreResults,
void(const std::vector<PasswordForm*>&));
};
class MockPasswordStoreObserver
: public password_manager::PasswordStore::Observer {
public:
MOCK_METHOD1(OnLoginsChanged,
void(const password_manager::PasswordStoreChangeList& changes));
};
class FailingBackend : public PasswordStoreX::NativeBackend {
public:
bool Init() override { return true; }
PasswordStoreChangeList AddLogin(const PasswordForm& form) override {
return PasswordStoreChangeList();
}
bool UpdateLogin(const PasswordForm& form,
PasswordStoreChangeList* changes) override {
return false;
}
bool RemoveLogin(const PasswordForm& form) override { return false; }
bool RemoveLoginsCreatedBetween(
base::Time delete_begin,
base::Time delete_end,
password_manager::PasswordStoreChangeList* changes) override {
return false;
}
bool RemoveLoginsSyncedBetween(
base::Time delete_begin,
base::Time delete_end,
password_manager::PasswordStoreChangeList* changes) override {
return false;
}
bool GetLogins(const PasswordForm& form, PasswordFormList* forms) override {
return false;
}
bool GetAutofillableLogins(PasswordFormList* forms) override { return false; }
bool GetBlacklistLogins(PasswordFormList* forms) override { return false; }
};
class MockBackend : public PasswordStoreX::NativeBackend {
public:
bool Init() override { return true; }
PasswordStoreChangeList AddLogin(const PasswordForm& form) override {
all_forms_.push_back(form);
PasswordStoreChange change(PasswordStoreChange::ADD, form);
return PasswordStoreChangeList(1, change);
}
bool UpdateLogin(const PasswordForm& form,
PasswordStoreChangeList* changes) override {
for (size_t i = 0; i < all_forms_.size(); ++i)
if (CompareForms(all_forms_[i], form, true)) {
all_forms_[i] = form;
changes->push_back(PasswordStoreChange(PasswordStoreChange::UPDATE,
form));
}
return true;
}
bool RemoveLogin(const PasswordForm& form) override {
for (size_t i = 0; i < all_forms_.size(); ++i)
if (CompareForms(all_forms_[i], form, false))
erase(i--);
return true;
}
bool RemoveLoginsCreatedBetween(
base::Time delete_begin,
base::Time delete_end,
password_manager::PasswordStoreChangeList* changes) override {
for (size_t i = 0; i < all_forms_.size(); ++i) {
if (delete_begin <= all_forms_[i].date_created &&
(delete_end.is_null() || all_forms_[i].date_created < delete_end))
erase(i--);
}
return true;
}
bool RemoveLoginsSyncedBetween(
base::Time delete_begin,
base::Time delete_end,
password_manager::PasswordStoreChangeList* changes) override {
DCHECK(changes);
for (size_t i = 0; i < all_forms_.size(); ++i) {
if (delete_begin <= all_forms_[i].date_synced &&
(delete_end.is_null() || all_forms_[i].date_synced < delete_end)) {
changes->push_back(password_manager::PasswordStoreChange(
password_manager::PasswordStoreChange::REMOVE, all_forms_[i]));
erase(i--);
}
}
return true;
}
bool GetLogins(const PasswordForm& form, PasswordFormList* forms) override {
for (size_t i = 0; i < all_forms_.size(); ++i)
if (all_forms_[i].signon_realm == form.signon_realm)
forms->push_back(new PasswordForm(all_forms_[i]));
return true;
}
bool GetAutofillableLogins(PasswordFormList* forms) override {
for (size_t i = 0; i < all_forms_.size(); ++i)
if (!all_forms_[i].blacklisted_by_user)
forms->push_back(new PasswordForm(all_forms_[i]));
return true;
}
bool GetBlacklistLogins(PasswordFormList* forms) override {
for (size_t i = 0; i < all_forms_.size(); ++i)
if (all_forms_[i].blacklisted_by_user)
forms->push_back(new PasswordForm(all_forms_[i]));
return true;
}
private:
void erase(size_t index) {
if (index < all_forms_.size() - 1)
all_forms_[index] = all_forms_[all_forms_.size() - 1];
all_forms_.pop_back();
}
bool CompareForms(const PasswordForm& a, const PasswordForm& b, bool update) {
// An update check doesn't care about the submit element.
if (!update && a.submit_element != b.submit_element)
return false;
return a.origin == b.origin &&
a.password_element == b.password_element &&
a.signon_realm == b.signon_realm &&
a.username_element == b.username_element &&
a.username_value == b.username_value;
}
std::vector<PasswordForm> all_forms_;
};
class MockLoginDatabaseReturn {
public:
MOCK_METHOD1(OnLoginDatabaseQueryDone,
void(const std::vector<PasswordForm*>&));
};
void LoginDatabaseQueryCallback(password_manager::LoginDatabase* login_db,
bool autofillable,
MockLoginDatabaseReturn* mock_return) {
std::vector<PasswordForm*> forms;
if (autofillable)
login_db->GetAutofillableLogins(&forms);
else
login_db->GetBlacklistLogins(&forms);
mock_return->OnLoginDatabaseQueryDone(forms);
}
// Generate |count| expected logins, either auto-fillable or blacklisted.
void InitExpectedForms(bool autofillable, size_t count, VectorOfForms* forms) {
const char* domain = autofillable ? "example" : "blacklisted";
for (size_t i = 0; i < count; ++i) {
std::string realm = base::StringPrintf("http://%zu.%s.com", i, domain);
std::string origin = base::StringPrintf("http://%zu.%s.com/origin",
i, domain);
std::string action = base::StringPrintf("http://%zu.%s.com/action",
i, domain);
password_manager::PasswordFormData data = {
PasswordForm::SCHEME_HTML,
realm.c_str(),
origin.c_str(),
action.c_str(),
L"submit_element",
L"username_element",
L"password_element",
autofillable ? L"username_value" : NULL,
autofillable ? L"password_value" : NULL,
autofillable,
false,
static_cast<double>(i + 1)};
forms->push_back(CreatePasswordFormFromData(data));
}
}
} // anonymous namespace
enum BackendType {
NO_BACKEND,
FAILING_BACKEND,
WORKING_BACKEND
};
class PasswordStoreXTest : public testing::TestWithParam<BackendType> {
protected:
void SetUp() override {
ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());
login_db_.reset(new password_manager::LoginDatabase());
ASSERT_TRUE(login_db_->Init(temp_dir_.path().Append("login_test")));
}
void TearDown() override { base::RunLoop().RunUntilIdle(); }
PasswordStoreX::NativeBackend* GetBackend() {
switch (GetParam()) {
case FAILING_BACKEND:
return new FailingBackend();
case WORKING_BACKEND:
return new MockBackend();
default:
return NULL;
}
}
content::TestBrowserThreadBundle thread_bundle_;
scoped_ptr<password_manager::LoginDatabase> login_db_;
base::ScopedTempDir temp_dir_;
};
ACTION(STLDeleteElements0) {
STLDeleteContainerPointers(arg0.begin(), arg0.end());
}
TEST_P(PasswordStoreXTest, Notifications) {
scoped_refptr<PasswordStoreX> store(
new PasswordStoreX(base::MessageLoopProxy::current(),
base::MessageLoopProxy::current(),
login_db_.release(),
GetBackend()));
store->Init(syncer::SyncableService::StartSyncFlare());
password_manager::PasswordFormData form_data = {
PasswordForm::SCHEME_HTML, "http://bar.example.com",
"http://bar.example.com/origin", "http://bar.example.com/action",
L"submit_element", L"username_element",
L"password_element", L"username_value",
L"password_value", true,
false, 1};
scoped_ptr<PasswordForm> form(CreatePasswordFormFromData(form_data));
MockPasswordStoreObserver observer;
store->AddObserver(&observer);
const PasswordStoreChange expected_add_changes[] = {
PasswordStoreChange(PasswordStoreChange::ADD, *form),
};
EXPECT_CALL(
observer,
OnLoginsChanged(ElementsAreArray(expected_add_changes)));
// Adding a login should trigger a notification.
store->AddLogin(*form);
// The PasswordStore schedules tasks to run on the DB thread. Wait for them
// to complete.
base::RunLoop().RunUntilIdle();
// Change the password.
form->password_value = base::ASCIIToUTF16("a different password");
const PasswordStoreChange expected_update_changes[] = {
PasswordStoreChange(PasswordStoreChange::UPDATE, *form),
};
EXPECT_CALL(
observer,
OnLoginsChanged(ElementsAreArray(expected_update_changes)));
// Updating the login with the new password should trigger a notification.
store->UpdateLogin(*form);
// Wait for PasswordStore to send execute.
base::RunLoop().RunUntilIdle();
const PasswordStoreChange expected_delete_changes[] = {
PasswordStoreChange(PasswordStoreChange::REMOVE, *form),
};
EXPECT_CALL(
observer,
OnLoginsChanged(ElementsAreArray(expected_delete_changes)));
// Deleting the login should trigger a notification.
store->RemoveLogin(*form);
// Wait for PasswordStore to execute.
base::RunLoop().RunUntilIdle();
store->RemoveObserver(&observer);
store->Shutdown();
}
TEST_P(PasswordStoreXTest, NativeMigration) {
VectorOfForms expected_autofillable;
InitExpectedForms(true, 50, &expected_autofillable);
VectorOfForms expected_blacklisted;
InitExpectedForms(false, 50, &expected_blacklisted);
// Get the initial size of the login DB file, before we populate it.
// This will be used later to make sure it gets back to this size.
const base::FilePath login_db_file = temp_dir_.path().Append("login_test");
base::File::Info db_file_start_info;
ASSERT_TRUE(base::GetFileInfo(login_db_file, &db_file_start_info));
password_manager::LoginDatabase* login_db = login_db_.get();
// Populate the login DB with logins that should be migrated.
for (VectorOfForms::iterator it = expected_autofillable.begin();
it != expected_autofillable.end(); ++it) {
login_db->AddLogin(**it);
}
for (VectorOfForms::iterator it = expected_blacklisted.begin();
it != expected_blacklisted.end(); ++it) {
login_db->AddLogin(**it);
}
// Get the new size of the login DB file. We expect it to be larger.
base::File::Info db_file_full_info;
ASSERT_TRUE(base::GetFileInfo(login_db_file, &db_file_full_info));
EXPECT_GT(db_file_full_info.size, db_file_start_info.size);
// Initializing the PasswordStore shouldn't trigger a native migration (yet).
scoped_refptr<PasswordStoreX> store(
new PasswordStoreX(base::MessageLoopProxy::current(),
base::MessageLoopProxy::current(),
login_db_.release(),
GetBackend()));
store->Init(syncer::SyncableService::StartSyncFlare());
MockPasswordStoreConsumer consumer;
// The autofillable forms should have been migrated to the native backend.
EXPECT_CALL(consumer,
OnGetPasswordStoreResults(
ContainsAllPasswordForms(expected_autofillable)))
.WillOnce(WithArg<0>(STLDeleteElements0()));
store->GetAutofillableLogins(&consumer);
base::RunLoop().RunUntilIdle();
// The blacklisted forms should have been migrated to the native backend.
EXPECT_CALL(consumer,
OnGetPasswordStoreResults(ContainsAllPasswordForms(expected_blacklisted)))
.WillOnce(WithArg<0>(STLDeleteElements0()));
store->GetBlacklistLogins(&consumer);
base::RunLoop().RunUntilIdle();
VectorOfForms empty;
MockLoginDatabaseReturn ld_return;
if (GetParam() == WORKING_BACKEND) {
// No autofillable logins should be left in the login DB.
EXPECT_CALL(ld_return,
OnLoginDatabaseQueryDone(ContainsAllPasswordForms(empty)));
} else {
// The autofillable logins should still be in the login DB.
EXPECT_CALL(ld_return,
OnLoginDatabaseQueryDone(
ContainsAllPasswordForms(expected_autofillable)))
.WillOnce(WithArg<0>(STLDeleteElements0()));
}
LoginDatabaseQueryCallback(login_db, true, &ld_return);
// Wait for the login DB methods to execute.
base::RunLoop().RunUntilIdle();
if (GetParam() == WORKING_BACKEND) {
// Likewise, no blacklisted logins should be left in the login DB.
EXPECT_CALL(ld_return,
OnLoginDatabaseQueryDone(ContainsAllPasswordForms(empty)));
} else {
// The blacklisted logins should still be in the login DB.
EXPECT_CALL(ld_return,
OnLoginDatabaseQueryDone(
ContainsAllPasswordForms(expected_blacklisted)))
.WillOnce(WithArg<0>(STLDeleteElements0()));
}
LoginDatabaseQueryCallback(login_db, false, &ld_return);
// Wait for the login DB methods to execute.
base::RunLoop().RunUntilIdle();
if (GetParam() == WORKING_BACKEND) {
// If the migration succeeded, then not only should there be no logins left
// in the login DB, but also the file should have been deleted and then
// recreated. We approximate checking for this by checking that the file
// size is equal to the size before we populated it, even though it was
// larger after populating it.
base::File::Info db_file_end_info;
ASSERT_TRUE(base::GetFileInfo(login_db_file, &db_file_end_info));
EXPECT_EQ(db_file_start_info.size, db_file_end_info.size);
}
STLDeleteElements(&expected_autofillable);
STLDeleteElements(&expected_blacklisted);
store->Shutdown();
}
INSTANTIATE_TEST_CASE_P(NoBackend,
PasswordStoreXTest,
testing::Values(NO_BACKEND));
INSTANTIATE_TEST_CASE_P(FailingBackend,
PasswordStoreXTest,
testing::Values(FAILING_BACKEND));
INSTANTIATE_TEST_CASE_P(WorkingBackend,
PasswordStoreXTest,
testing::Values(WORKING_BACKEND));
|