1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384
|
// Copyright (c) 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include <string>
#include <vector>
#include "base/bind.h"
#include "base/json/json_reader.h"
#include "base/memory/scoped_ptr.h"
#include "base/prefs/pref_service.h"
#include "base/strings/stringprintf.h"
#include "base/strings/utf_string_conversions.h"
#include "base/values.h"
#include "chrome/browser/spellchecker/spelling_service_client.h"
#include "chrome/common/pref_names.h"
#include "chrome/common/spellcheck_result.h"
#include "chrome/test/base/testing_profile.h"
#include "content/public/test/test_browser_thread_bundle.h"
#include "net/base/load_flags.h"
#include "net/url_request/test_url_fetcher_factory.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace {
// A mock URL fetcher used in the TestingSpellingServiceClient class. This class
// verifies JSON-RPC requests when the SpellingServiceClient class sends them to
// the Spelling service. This class also verifies the SpellingServiceClient
// class does not either send cookies to the Spelling service or accept cookies
// from it.
class TestSpellingURLFetcher : public net::TestURLFetcher {
public:
TestSpellingURLFetcher(int id,
const GURL& url,
net::URLFetcherDelegate* d,
int version,
const std::string& text,
const std::string& language,
int status,
const std::string& response)
: net::TestURLFetcher(0, url, d),
version_(base::StringPrintf("v%d", version)),
language_(language.empty() ? std::string("en") : language),
text_(text) {
set_response_code(status);
SetResponseString(response);
}
~TestSpellingURLFetcher() override {}
void SetUploadData(const std::string& upload_content_type,
const std::string& upload_content) override {
// Verify the given content type is JSON. (The Spelling service returns an
// internal server error when this content type is not JSON.)
EXPECT_EQ("application/json", upload_content_type);
// Parse the JSON to be sent to the service, and verify its parameters.
scoped_ptr<base::DictionaryValue> value(static_cast<base::DictionaryValue*>(
base::JSONReader::Read(upload_content,
base::JSON_ALLOW_TRAILING_COMMAS)));
ASSERT_TRUE(!!value.get());
std::string method;
EXPECT_TRUE(value->GetString("method", &method));
EXPECT_EQ("spelling.check", method);
std::string version;
EXPECT_TRUE(value->GetString("apiVersion", &version));
EXPECT_EQ(version_, version);
std::string text;
EXPECT_TRUE(value->GetString("params.text", &text));
EXPECT_EQ(text_, text);
std::string language;
EXPECT_TRUE(value->GetString("params.language", &language));
EXPECT_EQ(language_, language);
ASSERT_TRUE(GetExpectedCountry(language, &country_));
std::string country;
EXPECT_TRUE(value->GetString("params.originCountry", &country));
EXPECT_EQ(country_, country);
net::TestURLFetcher::SetUploadData(upload_content_type, upload_content);
}
void Start() override {
// Verify that this client does not either send cookies to the Spelling
// service or accept cookies from it.
EXPECT_EQ(net::LOAD_DO_NOT_SEND_COOKIES | net::LOAD_DO_NOT_SAVE_COOKIES,
GetLoadFlags());
}
private:
bool GetExpectedCountry(const std::string& language, std::string* country) {
static const struct {
const char* language;
const char* country;
} kCountries[] = {
{"af", "ZAF"},
{"en", "USA"},
};
for (size_t i = 0; i < arraysize(kCountries); ++i) {
if (!language.compare(kCountries[i].language)) {
country->assign(kCountries[i].country);
return true;
}
}
return false;
}
std::string version_;
std::string language_;
std::string country_;
std::string text_;
};
// A class derived from the SpellingServiceClient class used by the
// SpellingServiceClientTest class. This class overrides CreateURLFetcher so
// this test can use TestSpellingURLFetcher. This class also lets tests access
// the ParseResponse method.
class TestingSpellingServiceClient : public SpellingServiceClient {
public:
TestingSpellingServiceClient()
: request_type_(0),
response_status_(0),
success_(false),
fetcher_(NULL) {
}
~TestingSpellingServiceClient() override {}
void SetHTTPRequest(int type,
const std::string& text,
const std::string& language) {
request_type_ = type;
request_text_ = text;
request_language_ = language;
}
void SetHTTPResponse(int status, const char* data) {
response_status_ = status;
response_data_.assign(data);
}
void SetExpectedTextCheckResult(bool success, const char* text) {
success_ = success;
corrected_text_.assign(base::UTF8ToUTF16(text));
}
void CallOnURLFetchComplete() {
ASSERT_TRUE(!!fetcher_);
fetcher_->delegate()->OnURLFetchComplete(fetcher_);
fetcher_ = NULL;
}
void VerifyResponse(bool success,
const base::string16& request_text,
const std::vector<SpellCheckResult>& results) {
EXPECT_EQ(success_, success);
base::string16 text(base::UTF8ToUTF16(request_text_));
EXPECT_EQ(text, request_text);
for (std::vector<SpellCheckResult>::const_iterator it = results.begin();
it != results.end(); ++it) {
text.replace(it->location, it->length, it->replacement);
}
EXPECT_EQ(corrected_text_, text);
}
bool ParseResponseSuccess(const std::string& data) {
std::vector<SpellCheckResult> results;
return ParseResponse(data, &results);
}
private:
net::URLFetcher* CreateURLFetcher(const GURL& url) override {
EXPECT_EQ("https://www.googleapis.com/rpc", url.spec());
fetcher_ = new TestSpellingURLFetcher(0, url, this,
request_type_, request_text_,
request_language_,
response_status_, response_data_);
return fetcher_;
}
int request_type_;
std::string request_text_;
std::string request_language_;
int response_status_;
std::string response_data_;
bool success_;
base::string16 corrected_text_;
TestSpellingURLFetcher* fetcher_; // weak
};
// A test class used for testing the SpellingServiceClient class. This class
// implements a callback function used by the SpellingServiceClient class to
// monitor the class calls the callback with expected results.
class SpellingServiceClientTest : public testing::Test {
public:
void OnTextCheckComplete(int tag,
bool success,
const base::string16& text,
const std::vector<SpellCheckResult>& results) {
client_.VerifyResponse(success, text, results);
}
protected:
content::TestBrowserThreadBundle thread_bundle_;
TestingSpellingServiceClient client_;
TestingProfile profile_;
};
} // namespace
// Verifies that SpellingServiceClient::RequestTextCheck() creates a JSON
// request sent to the Spelling service as we expect. This test also verifies
// that it parses a JSON response from the service and calls the callback
// function. To avoid sending JSON-RPC requests to the service, this test uses a
// custom TestURLFecher class (TestSpellingURLFetcher) which calls
// SpellingServiceClient::OnURLFetchComplete() with the parameters set by this
// test. This test also uses a custom callback function that replaces all
// misspelled words with ones suggested by the service so this test can compare
// the corrected text with the expected results. (If there are not any
// misspelled words, |corrected_text| should be equal to |request_text|.)
TEST_F(SpellingServiceClientTest, RequestTextCheck) {
static const struct {
const char* request_text;
SpellingServiceClient::ServiceType request_type;
int response_status;
const char* response_data;
bool success;
const char* corrected_text;
const char* language;
} kTests[] = {
{
"",
SpellingServiceClient::SUGGEST,
500,
"",
false,
"",
"af",
}, {
"chromebook",
SpellingServiceClient::SUGGEST,
200,
"{}",
true,
"chromebook",
"af",
}, {
"chrombook",
SpellingServiceClient::SUGGEST,
200,
"{\n"
" \"result\": {\n"
" \"spellingCheckResponse\": {\n"
" \"misspellings\": [{\n"
" \"charStart\": 0,\n"
" \"charLength\": 9,\n"
" \"suggestions\": [{ \"suggestion\": \"chromebook\" }],\n"
" \"canAutoCorrect\": false\n"
" }]\n"
" }\n"
" }\n"
"}",
true,
"chromebook",
"af",
}, {
"",
SpellingServiceClient::SPELLCHECK,
500,
"",
false,
"",
"en",
}, {
"I have been to USA.",
SpellingServiceClient::SPELLCHECK,
200,
"{}",
true,
"I have been to USA.",
"en",
}, {
"I have bean to USA.",
SpellingServiceClient::SPELLCHECK,
200,
"{\n"
" \"result\": {\n"
" \"spellingCheckResponse\": {\n"
" \"misspellings\": [{\n"
" \"charStart\": 7,\n"
" \"charLength\": 4,\n"
" \"suggestions\": [{ \"suggestion\": \"been\" }],\n"
" \"canAutoCorrect\": false\n"
" }]\n"
" }\n"
" }\n"
"}",
true,
"I have been to USA.",
"en",
},
};
PrefService* pref = profile_.GetPrefs();
pref->SetBoolean(prefs::kEnableContinuousSpellcheck, true);
pref->SetBoolean(prefs::kSpellCheckUseSpellingService, true);
for (size_t i = 0; i < arraysize(kTests); ++i) {
client_.SetHTTPRequest(kTests[i].request_type, kTests[i].request_text,
kTests[i].language);
client_.SetHTTPResponse(kTests[i].response_status, kTests[i].response_data);
client_.SetExpectedTextCheckResult(kTests[i].success,
kTests[i].corrected_text);
pref->SetString(prefs::kSpellCheckDictionary, kTests[i].language);
client_.RequestTextCheck(
&profile_,
kTests[i].request_type,
base::ASCIIToUTF16(kTests[i].request_text),
base::Bind(&SpellingServiceClientTest::OnTextCheckComplete,
base::Unretained(this), 0));
client_.CallOnURLFetchComplete();
}
}
// Verify that SpellingServiceClient::IsAvailable() returns true only when it
// can send suggest requests or spellcheck requests.
TEST_F(SpellingServiceClientTest, AvailableServices) {
const SpellingServiceClient::ServiceType kSuggest =
SpellingServiceClient::SUGGEST;
const SpellingServiceClient::ServiceType kSpellcheck =
SpellingServiceClient::SPELLCHECK;
// When a user disables spellchecking or prevent using the Spelling service,
// this function should return false both for suggestions and for spellcheck.
PrefService* pref = profile_.GetPrefs();
pref->SetBoolean(prefs::kEnableContinuousSpellcheck, false);
pref->SetBoolean(prefs::kSpellCheckUseSpellingService, false);
EXPECT_FALSE(client_.IsAvailable(&profile_, kSuggest));
EXPECT_FALSE(client_.IsAvailable(&profile_, kSpellcheck));
pref->SetBoolean(prefs::kEnableContinuousSpellcheck, true);
pref->SetBoolean(prefs::kSpellCheckUseSpellingService, true);
// For locales supported by the SpellCheck service, this function returns
// false for suggestions and true for spellcheck. (The comment in
// SpellingServiceClient::IsAvailable() describes why this function returns
// false for suggestions.) If there is no language set, then we
// do not allow any remote.
pref->SetString(prefs::kSpellCheckDictionary, std::string());
EXPECT_FALSE(client_.IsAvailable(&profile_, kSuggest));
EXPECT_FALSE(client_.IsAvailable(&profile_, kSpellcheck));
#if !defined(OS_MACOSX)
static const char* kSupported[] = {
"en-AU", "en-CA", "en-GB", "en-US",
};
// If spellcheck is allowed, then suggest is not since spellcheck is a
// superset of suggest.
for (size_t i = 0; i < arraysize(kSupported); ++i) {
pref->SetString(prefs::kSpellCheckDictionary, kSupported[i]);
EXPECT_FALSE(client_.IsAvailable(&profile_, kSuggest));
EXPECT_TRUE(client_.IsAvailable(&profile_, kSpellcheck));
}
// This function returns true for suggestions for all and false for
// spellcheck for unsupported locales.
static const char* kUnsupported[] = {
"af-ZA", "bg-BG", "ca-ES", "cs-CZ", "da-DK", "de-DE", "el-GR", "es-ES",
"et-EE", "fo-FO", "fr-FR", "he-IL", "hi-IN", "hr-HR", "hu-HU", "id-ID",
"it-IT", "lt-LT", "lv-LV", "nb-NO", "nl-NL", "pl-PL", "pt-BR", "pt-PT",
"ro-RO", "ru-RU", "sk-SK", "sl-SI", "sh", "sr", "sv-SE", "tr-TR",
"uk-UA", "vi-VN",
};
for (size_t i = 0; i < arraysize(kUnsupported); ++i) {
pref->SetString(prefs::kSpellCheckDictionary, kUnsupported[i]);
EXPECT_TRUE(client_.IsAvailable(&profile_, kSuggest));
EXPECT_FALSE(client_.IsAvailable(&profile_, kSpellcheck));
}
#endif // !defined(OS_MACOSX)
}
// Verify that an error in JSON response from spelling service will result in
// ParseResponse returning false.
TEST_F(SpellingServiceClientTest, ResponseErrorTest) {
EXPECT_TRUE(client_.ParseResponseSuccess("{\"result\": {}}"));
EXPECT_FALSE(client_.ParseResponseSuccess("{\"error\": {}}"));
}
|