1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
|
// Copyright 2013 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "base/command_line.h"
#include "base/files/file_path.h"
#include "base/memory/scoped_ptr.h"
#include "base/prefs/pref_registry_simple.h"
#include "base/prefs/pref_service.h"
#include "base/prefs/pref_service_factory.h"
#include "base/prefs/testing_pref_store.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/profiles/profiles_state.h"
#include "chrome/browser/ui/app_list/app_list_service.h"
#include "chrome/browser/ui/app_list/app_list_service_impl.h"
#include "chrome/browser/ui/app_list/test/fake_profile.h"
#include "chrome/browser/ui/app_list/test/fake_profile_store.h"
#include "chrome/common/chrome_constants.h"
#include "chrome/common/chrome_switches.h"
#include "chrome/common/pref_names.h"
#include "testing/gtest/include/gtest/gtest.h"
class TestingAppListServiceImpl : public AppListServiceImpl {
public:
TestingAppListServiceImpl(const base::CommandLine& command_line,
PrefService* local_state,
scoped_ptr<ProfileStore> profile_store)
: AppListServiceImpl(command_line, local_state, profile_store.Pass()),
showing_for_profile_(NULL),
destroy_app_list_call_count_(0) {}
Profile* showing_for_profile() const {
return showing_for_profile_;
}
int destroy_app_list_call_count() const {
return destroy_app_list_call_count_;
}
void PerformStartupChecks(Profile* profile) {
AppListServiceImpl::PerformStartupChecks(profile);
}
// AppListService overrides:
Profile* GetCurrentAppListProfile() override {
// We don't return showing_for_profile_ here because that is only defined if
// the app list is visible.
return NULL;
}
void CreateForProfile(Profile* requested_profile) override {}
void ShowForProfile(Profile* requested_profile) override {
showing_for_profile_ = requested_profile;
RecordAppListLaunch();
}
void ShowForCustomLauncherPage(Profile* profile) override {}
void DismissAppList() override { showing_for_profile_ = NULL; }
bool IsAppListVisible() const override { return !!showing_for_profile_; }
gfx::NativeWindow GetAppListWindow() override { return NULL; }
AppListControllerDelegate* GetControllerDelegate() override { return NULL; }
// AppListServiceImpl overrides:
void DestroyAppList() override { ++destroy_app_list_call_count_; }
private:
Profile* showing_for_profile_;
int destroy_app_list_call_count_;
DISALLOW_COPY_AND_ASSIGN(TestingAppListServiceImpl);
};
class AppListServiceUnitTest : public testing::Test {
public:
AppListServiceUnitTest() {}
void SetUp() override {
SetupWithCommandLine(base::CommandLine(base::CommandLine::NO_PROGRAM));
}
protected:
void SetupWithCommandLine(const base::CommandLine& command_line) {
user_data_dir_ = base::FilePath(FILE_PATH_LITERAL("udd"));
profile1_.reset(
new FakeProfile("p1", user_data_dir_.AppendASCII("profile1")));
profile2_.reset(
new FakeProfile("p2", user_data_dir_.AppendASCII("profile2")));
PrefRegistrySimple* pref_registry = new PrefRegistrySimple;
AppListService::RegisterPrefs(pref_registry);
profiles::RegisterPrefs(pref_registry);
base::PrefServiceFactory factory;
factory.set_user_prefs(make_scoped_refptr(new TestingPrefStore));
local_state_ = factory.Create(pref_registry).Pass();
profile_store_ = new FakeProfileStore(user_data_dir_);
service_.reset(new TestingAppListServiceImpl(
command_line,
local_state_.get(),
scoped_ptr<ProfileStore>(profile_store_)));
}
void EnableAppList() {
service_->EnableAppList(profile1_.get(),
AppListService::ENABLE_VIA_COMMAND_LINE);
}
base::FilePath user_data_dir_;
scoped_ptr<PrefService> local_state_;
FakeProfileStore* profile_store_;
scoped_ptr<TestingAppListServiceImpl> service_;
scoped_ptr<FakeProfile> profile1_;
scoped_ptr<FakeProfile> profile2_;
DISALLOW_COPY_AND_ASSIGN(AppListServiceUnitTest);
};
TEST_F(AppListServiceUnitTest, EnablingStateIsPersisted) {
EXPECT_FALSE(local_state_->GetBoolean(prefs::kAppLauncherHasBeenEnabled));
EnableAppList();
EXPECT_TRUE(local_state_->GetBoolean(prefs::kAppLauncherHasBeenEnabled));
EXPECT_EQ(profile1_->GetPath(), user_data_dir_.Append(
local_state_->GetFilePath(prefs::kAppListProfile)));
}
TEST_F(AppListServiceUnitTest, ShowingForProfileLoadsAProfile) {
profile_store_->LoadProfile(profile1_.get());
EnableAppList();
service_->Show();
EXPECT_EQ(profile1_.get(), service_->showing_for_profile());
EXPECT_TRUE(service_->IsAppListVisible());
}
TEST_F(AppListServiceUnitTest, RemovedProfileResetsToInitialProfile) {
EnableAppList();
profile_store_->RemoveProfile(profile1_.get());
base::FilePath initial_profile_path =
user_data_dir_.AppendASCII(chrome::kInitialProfile);
EXPECT_EQ(initial_profile_path,
service_->GetProfilePath(profile_store_->GetUserDataDir()));
}
TEST_F(AppListServiceUnitTest,
RemovedProfileResetsToLastUsedProfileIfExists) {
local_state_->SetString(prefs::kProfileLastUsed, "last-used");
EnableAppList();
profile_store_->RemoveProfile(profile1_.get());
base::FilePath last_used_profile_path =
user_data_dir_.AppendASCII("last-used");
EXPECT_EQ(last_used_profile_path,
service_->GetProfilePath(profile_store_->GetUserDataDir()));
// For this test, the AppListViewDelegate is not created because the
// app list is never shown, so there is nothing to destroy.
EXPECT_EQ(0, service_->destroy_app_list_call_count());
}
TEST_F(AppListServiceUnitTest, SwitchingProfilesPersists) {
profile_store_->LoadProfile(profile1_.get());
profile_store_->LoadProfile(profile2_.get());
EnableAppList();
service_->SetProfilePath(profile2_->GetPath());
service_->Show();
EXPECT_EQ(profile2_.get(), service_->showing_for_profile());
EXPECT_EQ(profile2_->GetPath(),
service_->GetProfilePath(profile_store_->GetUserDataDir()));
service_->SetProfilePath(profile1_->GetPath());
EXPECT_EQ(profile1_->GetPath(),
service_->GetProfilePath(profile_store_->GetUserDataDir()));
}
TEST_F(AppListServiceUnitTest, EnableViaCommandLineFlag) {
base::CommandLine command_line(base::CommandLine::NO_PROGRAM);
command_line.AppendSwitch(switches::kEnableAppList);
SetupWithCommandLine(command_line);
service_->PerformStartupChecks(profile1_.get());
EXPECT_TRUE(local_state_->GetBoolean(prefs::kAppLauncherHasBeenEnabled));
}
TEST_F(AppListServiceUnitTest, DisableViaCommandLineFlag) {
base::CommandLine command_line(base::CommandLine::NO_PROGRAM);
command_line.AppendSwitch(switches::kResetAppListInstallState);
SetupWithCommandLine(command_line);
service_->PerformStartupChecks(profile1_.get());
EXPECT_FALSE(local_state_->GetBoolean(prefs::kAppLauncherHasBeenEnabled));
}
TEST_F(AppListServiceUnitTest, UMAPrefStates) {
EXPECT_FALSE(local_state_->GetBoolean(prefs::kAppLauncherHasBeenEnabled));
EXPECT_EQ(AppListService::ENABLE_NOT_RECORDED,
local_state_->GetInteger(prefs::kAppListEnableMethod));
EXPECT_EQ(0, local_state_->GetInt64(prefs::kAppListEnableTime));
service_->EnableAppList(profile1_.get(),
AppListService::ENABLE_FOR_APP_INSTALL);
// After enable, method and time should be recorded.
EXPECT_TRUE(local_state_->GetBoolean(prefs::kAppLauncherHasBeenEnabled));
EXPECT_EQ(AppListService::ENABLE_FOR_APP_INSTALL,
local_state_->GetInteger(prefs::kAppListEnableMethod));
EXPECT_NE(0, local_state_->GetInt64(prefs::kAppListEnableTime));
service_->ShowForProfile(profile1_.get());
// After a regular "show", time should be cleared, so UMA is not re-recorded.
EXPECT_EQ(AppListService::ENABLE_FOR_APP_INSTALL,
local_state_->GetInteger(prefs::kAppListEnableMethod));
EXPECT_EQ(0, local_state_->GetInt64(prefs::kAppListEnableTime));
// A second enable should be a no-op.
service_->EnableAppList(profile1_.get(),
AppListService::ENABLE_FOR_APP_INSTALL);
EXPECT_EQ(AppListService::ENABLE_FOR_APP_INSTALL,
local_state_->GetInteger(prefs::kAppListEnableMethod));
EXPECT_EQ(0, local_state_->GetInt64(prefs::kAppListEnableTime));
// An app install auto-show here should keep the recorded enable method.
service_->ShowForAppInstall(profile1_.get(), "", false);
EXPECT_EQ(AppListService::ENABLE_FOR_APP_INSTALL,
local_state_->GetInteger(prefs::kAppListEnableMethod));
// Clear the enable state, so we can enable again.
local_state_->SetBoolean(prefs::kAppLauncherHasBeenEnabled, false);
service_->EnableAppList(profile1_.get(),
AppListService::ENABLE_FOR_APP_INSTALL);
EXPECT_EQ(AppListService::ENABLE_FOR_APP_INSTALL,
local_state_->GetInteger(prefs::kAppListEnableMethod));
EXPECT_NE(0, local_state_->GetInt64(prefs::kAppListEnableTime));
// An auto-show here should update the enable method to prevent recording it
// as ENABLE_FOR_APP_INSTALL.
service_->ShowForAppInstall(profile1_.get(), "", false);
EXPECT_EQ(AppListService::ENABLE_SHOWN_UNDISCOVERED,
local_state_->GetInteger(prefs::kAppListEnableMethod));
}
|
