1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592
|
// Copyright 2013 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "base/command_line.h"
#include "base/files/file_path.h"
#include "base/message_loop/message_loop.h"
#include "base/run_loop.h"
#include "base/strings/utf_string_conversions.h"
#include "chrome/browser/chrome_notification_types.h"
#include "chrome/browser/content_settings/tab_specific_content_settings.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/search_engines/template_url_service_factory.h"
#include "chrome/browser/ui/blocked_content/popup_blocker_tab_helper.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_commands.h"
#include "chrome/browser/ui/browser_finder.h"
#include "chrome/browser/ui/browser_list.h"
#include "chrome/browser/ui/browser_window.h"
#include "chrome/browser/ui/location_bar/location_bar.h"
#include "chrome/browser/ui/omnibox/omnibox_edit_model.h"
#include "chrome/browser/ui/omnibox/omnibox_view.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
#include "chrome/common/chrome_paths.h"
#include "chrome/common/chrome_switches.h"
#include "chrome/test/base/in_process_browser_test.h"
#include "chrome/test/base/test_switches.h"
#include "chrome/test/base/ui_test_utils.h"
#include "components/app_modal/javascript_app_modal_dialog.h"
#include "components/app_modal/native_app_modal_dialog.h"
#include "components/content_settings/core/browser/host_content_settings_map.h"
#include "components/omnibox/autocomplete_match.h"
#include "components/omnibox/autocomplete_result.h"
#include "content/public/browser/navigation_controller.h"
#include "content/public/browser/notification_registrar.h"
#include "content/public/browser/notification_service.h"
#include "content/public/browser/render_frame_host.h"
#include "content/public/browser/web_contents.h"
#include "content/public/browser/web_contents_observer.h"
#include "content/public/common/url_constants.h"
#include "content/public/test/browser_test_utils.h"
#include "content/public/test/test_navigation_observer.h"
#include "net/dns/mock_host_resolver.h"
#include "net/test/embedded_test_server/embedded_test_server.h"
#include "testing/gtest/include/gtest/gtest.h"
using content::WebContents;
namespace {
// Counts the number of RenderViewHosts created.
class CountRenderViewHosts : public content::NotificationObserver {
public:
CountRenderViewHosts()
: count_(0) {
registrar_.Add(this,
content::NOTIFICATION_WEB_CONTENTS_RENDER_VIEW_HOST_CREATED,
content::NotificationService::AllSources());
}
~CountRenderViewHosts() override {}
int GetRenderViewHostCreatedCount() const { return count_; }
private:
void Observe(int type,
const content::NotificationSource& source,
const content::NotificationDetails& details) override {
count_++;
}
content::NotificationRegistrar registrar_;
int count_;
DISALLOW_COPY_AND_ASSIGN(CountRenderViewHosts);
};
class CloseObserver : public content::WebContentsObserver {
public:
explicit CloseObserver(WebContents* contents)
: content::WebContentsObserver(contents) {}
void Wait() {
close_loop_.Run();
}
void WebContentsDestroyed() override { close_loop_.Quit(); }
private:
base::RunLoop close_loop_;
DISALLOW_COPY_AND_ASSIGN(CloseObserver);
};
class BrowserActivationObserver : public chrome::BrowserListObserver {
public:
explicit BrowserActivationObserver(chrome::HostDesktopType desktop_type)
: browser_(chrome::FindLastActiveWithHostDesktopType(desktop_type)),
observed_(false) {
BrowserList::AddObserver(this);
}
~BrowserActivationObserver() override { BrowserList::RemoveObserver(this); }
void WaitForActivation() {
if (observed_)
return;
message_loop_runner_ = new content::MessageLoopRunner;
message_loop_runner_->Run();
}
private:
// chrome::BrowserListObserver:
void OnBrowserSetLastActive(Browser* browser) override {
if (browser == browser_)
return;
if (browser->host_desktop_type() != browser_->host_desktop_type())
return;
observed_ = true;
if (message_loop_runner_.get() && message_loop_runner_->loop_running())
message_loop_runner_->Quit();
}
Browser* browser_;
bool observed_;
scoped_refptr<content::MessageLoopRunner> message_loop_runner_;
DISALLOW_COPY_AND_ASSIGN(BrowserActivationObserver);
};
class PopupBlockerBrowserTest : public InProcessBrowserTest {
public:
PopupBlockerBrowserTest() {}
~PopupBlockerBrowserTest() override {}
void SetUpOnMainThread() override {
InProcessBrowserTest::SetUpOnMainThread();
host_resolver()->AddRule("*", "127.0.0.1");
ASSERT_TRUE(embedded_test_server()->InitializeAndWaitUntilReady());
}
int GetBlockedContentsCount() {
// Do a round trip to the renderer first to flush any in-flight IPCs to
// create a to-be-blocked window.
WebContents* tab = browser()->tab_strip_model()->GetActiveWebContents();
CHECK(content::ExecuteScript(tab, std::string()));
PopupBlockerTabHelper* popup_blocker_helper =
PopupBlockerTabHelper::FromWebContents(tab);
return popup_blocker_helper->GetBlockedPopupsCount();
}
enum WhatToExpect {
ExpectPopup,
ExpectTab
};
enum ShouldCheckTitle {
CheckTitle,
DontCheckTitle
};
void NavigateAndCheckPopupShown(const GURL& url,
WhatToExpect what_to_expect) {
content::WindowedNotificationObserver observer(
chrome::NOTIFICATION_TAB_ADDED,
content::NotificationService::AllSources());
ui_test_utils::NavigateToURL(browser(), url);
observer.Wait();
if (what_to_expect == ExpectPopup) {
ASSERT_EQ(2u,
chrome::GetBrowserCount(browser()->profile(),
browser()->host_desktop_type()));
} else {
ASSERT_EQ(1u,
chrome::GetBrowserCount(browser()->profile(),
browser()->host_desktop_type()));
ASSERT_EQ(2, browser()->tab_strip_model()->count());
// Check that we always create foreground tabs.
ASSERT_EQ(1, browser()->tab_strip_model()->active_index());
}
ASSERT_EQ(0, GetBlockedContentsCount());
}
// Navigates to the test indicated by |test_name| using |browser| which is
// expected to try to open a popup. Verifies that the popup was blocked and
// then opens the blocked popup. Once the popup stopped loading, verifies
// that the title of the page is "PASS" if |check_title| is set.
//
// If |what_to_expect| is ExpectPopup, the popup is expected to open a new
// window, or a background tab if it is false.
//
// Returns the WebContents of the launched popup.
WebContents* RunCheckTest(Browser* browser,
const std::string& test_name,
WhatToExpect what_to_expect,
ShouldCheckTitle check_title) {
GURL url(embedded_test_server()->GetURL(test_name));
CountRenderViewHosts counter;
ui_test_utils::NavigateToURL(browser, url);
// Since the popup blocker blocked the window.open, there should be only one
// tab.
EXPECT_EQ(1u, chrome::GetBrowserCount(browser->profile(),
browser->host_desktop_type()));
EXPECT_EQ(1, browser->tab_strip_model()->count());
WebContents* web_contents =
browser->tab_strip_model()->GetActiveWebContents();
EXPECT_EQ(url, web_contents->GetURL());
// And no new RVH created.
EXPECT_EQ(0, counter.GetRenderViewHostCreatedCount());
content::WindowedNotificationObserver observer(
chrome::NOTIFICATION_TAB_ADDED,
content::NotificationService::AllSources());
ui_test_utils::BrowserAddedObserver browser_observer;
// Launch the blocked popup.
PopupBlockerTabHelper* popup_blocker_helper =
PopupBlockerTabHelper::FromWebContents(web_contents);
if (!popup_blocker_helper->GetBlockedPopupsCount()) {
content::WindowedNotificationObserver observer(
chrome::NOTIFICATION_WEB_CONTENT_SETTINGS_CHANGED,
content::NotificationService::AllSources());
observer.Wait();
}
EXPECT_EQ(1u, popup_blocker_helper->GetBlockedPopupsCount());
std::map<int32, GURL> blocked_requests =
popup_blocker_helper->GetBlockedPopupRequests();
std::map<int32, GURL>::const_iterator iter = blocked_requests.begin();
popup_blocker_helper->ShowBlockedPopup(iter->first);
observer.Wait();
Browser* new_browser;
if (what_to_expect == ExpectPopup) {
new_browser = browser_observer.WaitForSingleNewBrowser();
web_contents = new_browser->tab_strip_model()->GetActiveWebContents();
} else {
new_browser = browser;
EXPECT_EQ(2, browser->tab_strip_model()->count());
// Check that we always create foreground tabs.
EXPECT_EQ(1, browser->tab_strip_model()->active_index());
web_contents = browser->tab_strip_model()->GetWebContentsAt(1);
}
if (check_title == CheckTitle) {
// Check that the check passed.
base::string16 expected_title(base::ASCIIToUTF16("PASS"));
content::TitleWatcher title_watcher(web_contents, expected_title);
EXPECT_EQ(expected_title, title_watcher.WaitAndGetTitle());
}
return web_contents;
}
private:
DISALLOW_COPY_AND_ASSIGN(PopupBlockerBrowserTest);
};
IN_PROC_BROWSER_TEST_F(PopupBlockerBrowserTest,
BlockWebContentsCreation) {
#if defined(OS_WIN) && defined(USE_ASH)
// Disable this test in Metro+Ash for now (http://crbug.com/262796).
if (base::CommandLine::ForCurrentProcess()->HasSwitch(
switches::kAshBrowserTests))
return;
#endif
RunCheckTest(
browser(),
"/popup_blocker/popup-blocked-to-post-blank.html",
ExpectTab,
DontCheckTitle);
}
IN_PROC_BROWSER_TEST_F(PopupBlockerBrowserTest,
BlockWebContentsCreationIncognito) {
#if defined(OS_WIN) && defined(USE_ASH)
// Disable this test in Metro+Ash for now (http://crbug.com/262796).
if (base::CommandLine::ForCurrentProcess()->HasSwitch(
switches::kAshBrowserTests))
return;
#endif
RunCheckTest(
CreateIncognitoBrowser(),
"/popup_blocker/popup-blocked-to-post-blank.html",
ExpectTab,
DontCheckTitle);
}
IN_PROC_BROWSER_TEST_F(PopupBlockerBrowserTest,
PopupBlockedFakeClickOnAnchor) {
#if defined(OS_WIN) && defined(USE_ASH)
// Disable this test in Metro+Ash for now (http://crbug.com/262796).
if (base::CommandLine::ForCurrentProcess()->HasSwitch(
switches::kAshBrowserTests))
return;
#endif
RunCheckTest(
browser(),
"/popup_blocker/popup-fake-click-on-anchor.html",
ExpectTab,
DontCheckTitle);
}
IN_PROC_BROWSER_TEST_F(PopupBlockerBrowserTest,
PopupBlockedFakeClickOnAnchorNoTarget) {
#if defined(OS_WIN) && defined(USE_ASH)
// Disable this test in Metro+Ash for now (http://crbug.com/262796).
if (base::CommandLine::ForCurrentProcess()->HasSwitch(
switches::kAshBrowserTests))
return;
#endif
RunCheckTest(
browser(),
"/popup_blocker/popup-fake-click-on-anchor2.html",
ExpectTab,
DontCheckTitle);
}
IN_PROC_BROWSER_TEST_F(PopupBlockerBrowserTest, MultiplePopups) {
GURL url(embedded_test_server()->GetURL("/popup_blocker/popup-many.html"));
ui_test_utils::NavigateToURL(browser(), url);
ASSERT_EQ(2, GetBlockedContentsCount());
}
// Verify that popups are launched on browser back button.
IN_PROC_BROWSER_TEST_F(PopupBlockerBrowserTest,
AllowPopupThroughContentSetting) {
GURL url(embedded_test_server()->GetURL(
"/popup_blocker/popup-blocked-to-post-blank.html"));
browser()->profile()->GetHostContentSettingsMap()
->SetContentSetting(ContentSettingsPattern::FromURL(url),
ContentSettingsPattern::Wildcard(),
CONTENT_SETTINGS_TYPE_POPUPS,
std::string(),
CONTENT_SETTING_ALLOW);
NavigateAndCheckPopupShown(url, ExpectTab);
}
// Verify that content settings are applied based on the top-level frame URL.
IN_PROC_BROWSER_TEST_F(PopupBlockerBrowserTest,
AllowPopupThroughContentSettingIFrame) {
GURL url(embedded_test_server()->GetURL("/popup_blocker/popup-frames.html"));
browser()->profile()->GetHostContentSettingsMap()
->SetContentSetting(ContentSettingsPattern::FromURL(url),
ContentSettingsPattern::Wildcard(),
CONTENT_SETTINGS_TYPE_POPUPS,
std::string(),
CONTENT_SETTING_ALLOW);
// Popup from the iframe should be allowed since the top-level URL is
// whitelisted.
NavigateAndCheckPopupShown(url, ExpectTab);
// Whitelist iframe URL instead.
GURL::Replacements replace_host;
std::string host_str("www.a.com"); // Must stay in scope with replace_host
replace_host.SetHostStr(host_str);
GURL frame_url(embedded_test_server()
->GetURL("/popup_blocker/popup-frames-iframe.html")
.ReplaceComponents(replace_host));
browser()->profile()->GetHostContentSettingsMap()->ClearSettingsForOneType(
CONTENT_SETTINGS_TYPE_POPUPS);
browser()->profile()->GetHostContentSettingsMap()
->SetContentSetting(ContentSettingsPattern::FromURL(frame_url),
ContentSettingsPattern::Wildcard(),
CONTENT_SETTINGS_TYPE_POPUPS,
std::string(),
CONTENT_SETTING_ALLOW);
// Popup should be blocked.
ui_test_utils::NavigateToURL(browser(), url);
ASSERT_EQ(1, GetBlockedContentsCount());
}
IN_PROC_BROWSER_TEST_F(PopupBlockerBrowserTest,
PopupsLaunchWhenTabIsClosed) {
base::CommandLine::ForCurrentProcess()->AppendSwitch(
switches::kDisablePopupBlocking);
GURL url(
embedded_test_server()->GetURL("/popup_blocker/popup-on-unload.html"));
ui_test_utils::NavigateToURL(browser(), url);
NavigateAndCheckPopupShown(embedded_test_server()->GetURL("/popup_blocker/"),
ExpectPopup);
}
// Verify that when you unblock popup, the popup shows in history and omnibox.
IN_PROC_BROWSER_TEST_F(PopupBlockerBrowserTest,
UnblockedPopupShowsInHistoryAndOmnibox) {
base::CommandLine::ForCurrentProcess()->AppendSwitch(
switches::kDisablePopupBlocking);
GURL url(embedded_test_server()->GetURL(
"/popup_blocker/popup-blocked-to-post-blank.html"));
NavigateAndCheckPopupShown(url, ExpectTab);
std::string search_string =
"data:text/html,<title>Popup Success!</title>you should not see this "
"message if popup blocker is enabled";
ui_test_utils::HistoryEnumerator history(browser()->profile());
std::vector<GURL>& history_urls = history.urls();
ASSERT_EQ(2u, history_urls.size());
ASSERT_EQ(GURL(search_string), history_urls[0]);
ASSERT_EQ(url, history_urls[1]);
TemplateURLService* service = TemplateURLServiceFactory::GetForProfile(
browser()->profile());
ui_test_utils::WaitForTemplateURLServiceToLoad(service);
LocationBar* location_bar = browser()->window()->GetLocationBar();
ui_test_utils::SendToOmniboxAndSubmit(location_bar, search_string);
OmniboxEditModel* model = location_bar->GetOmniboxView()->model();
EXPECT_EQ(GURL(search_string), model->CurrentMatch(NULL).destination_url);
EXPECT_EQ(base::ASCIIToUTF16(search_string),
model->CurrentMatch(NULL).contents);
}
// This test fails on linux AURA with this change
// https://codereview.chromium.org/23903056
// BUG=https://code.google.com/p/chromium/issues/detail?id=295299
// TODO(ananta). Debug and fix this test.
#if defined(USE_AURA) && defined(OS_LINUX)
#define MAYBE_WindowFeatures DISABLED_WindowFeatures
#else
#define MAYBE_WindowFeatures WindowFeatures
#endif
IN_PROC_BROWSER_TEST_F(PopupBlockerBrowserTest, MAYBE_WindowFeatures) {
WebContents* popup =
RunCheckTest(browser(),
"/popup_blocker/popup-window-open.html",
ExpectPopup,
DontCheckTitle);
// Check that the new popup has (roughly) the requested size.
gfx::Size window_size = popup->GetContainerBounds().size();
EXPECT_TRUE(349 <= window_size.width() && window_size.width() <= 351);
EXPECT_TRUE(249 <= window_size.height() && window_size.height() <= 251);
}
IN_PROC_BROWSER_TEST_F(PopupBlockerBrowserTest, CorrectReferrer) {
RunCheckTest(browser(),
"/popup_blocker/popup-referrer.html",
ExpectTab,
CheckTitle);
}
IN_PROC_BROWSER_TEST_F(PopupBlockerBrowserTest, WindowFeaturesBarProps) {
RunCheckTest(browser(),
"/popup_blocker/popup-windowfeatures.html",
ExpectPopup,
CheckTitle);
}
IN_PROC_BROWSER_TEST_F(PopupBlockerBrowserTest, SessionStorage) {
RunCheckTest(browser(),
"/popup_blocker/popup-sessionstorage.html",
ExpectTab,
CheckTitle);
}
IN_PROC_BROWSER_TEST_F(PopupBlockerBrowserTest, Opener) {
RunCheckTest(browser(),
"/popup_blocker/popup-opener.html",
ExpectTab,
CheckTitle);
}
// Tests that the popup can still close itself after navigating. This tests that
// the openedByDOM bit is preserved across blocked popups.
IN_PROC_BROWSER_TEST_F(PopupBlockerBrowserTest, ClosableAfterNavigation) {
// Open a popup.
WebContents* popup =
RunCheckTest(browser(),
"/popup_blocker/popup-opener.html",
ExpectTab,
CheckTitle);
// Navigate it elsewhere.
content::TestNavigationObserver nav_observer(popup);
popup->GetMainFrame()->ExecuteJavaScript(
base::UTF8ToUTF16("location.href = '/empty.html'"));
nav_observer.Wait();
// Have it close itself.
CloseObserver close_observer(popup);
popup->GetMainFrame()->ExecuteJavaScript(
base::UTF8ToUTF16("window.close()"));
close_observer.Wait();
}
IN_PROC_BROWSER_TEST_F(PopupBlockerBrowserTest, OpenerSuppressed) {
RunCheckTest(browser(),
"/popup_blocker/popup-openersuppressed.html",
ExpectTab,
CheckTitle);
}
IN_PROC_BROWSER_TEST_F(PopupBlockerBrowserTest, ShiftClick) {
RunCheckTest(
browser(),
"/popup_blocker/popup-fake-click-on-anchor3.html",
ExpectPopup,
CheckTitle);
}
IN_PROC_BROWSER_TEST_F(PopupBlockerBrowserTest, WebUI) {
WebContents* popup =
RunCheckTest(browser(),
"/popup_blocker/popup-webui.html",
ExpectTab,
DontCheckTitle);
// Check that the new popup displays about:blank.
EXPECT_EQ(GURL(url::kAboutBlankURL), popup->GetURL());
}
// Verify that the renderer can't DOS the browser by creating arbitrarily many
// popups.
IN_PROC_BROWSER_TEST_F(PopupBlockerBrowserTest, DenialOfService) {
GURL url(embedded_test_server()->GetURL("/popup_blocker/popup-dos.html"));
ui_test_utils::NavigateToURL(browser(), url);
ASSERT_EQ(25, GetBlockedContentsCount());
}
// Verify that an onunload popup does not show up for about:blank.
IN_PROC_BROWSER_TEST_F(PopupBlockerBrowserTest, Regress427477) {
ui_test_utils::NavigateToURL(browser(), GURL(chrome::kChromeUINewTabURL));
ui_test_utils::NavigateToURL(browser(), GURL(url::kAboutBlankURL));
GURL url(
embedded_test_server()->GetURL("/popup_blocker/popup-on-unload.html"));
ui_test_utils::NavigateToURL(browser(), url);
WebContents* tab = browser()->tab_strip_model()->GetActiveWebContents();
tab->GetController().GoBack();
content::WaitForLoadStop(tab);
ASSERT_EQ(1u, chrome::GetBrowserCount(browser()->profile(),
browser()->host_desktop_type()));
ASSERT_EQ(1, browser()->tab_strip_model()->count());
// The popup from the unload event handler should not show up for about:blank.
ASSERT_EQ(0, GetBlockedContentsCount());
}
// Verify that app modal prompts can't be used to create pop unders.
IN_PROC_BROWSER_TEST_F(PopupBlockerBrowserTest, ModalPopUnder) {
WebContents* tab = browser()->tab_strip_model()->GetActiveWebContents();
GURL url(
embedded_test_server()->GetURL("/popup_blocker/popup-window-open.html"));
browser()->profile()->GetHostContentSettingsMap()->SetContentSetting(
ContentSettingsPattern::FromURL(url), ContentSettingsPattern::Wildcard(),
CONTENT_SETTINGS_TYPE_POPUPS, std::string(), CONTENT_SETTING_ALLOW);
NavigateAndCheckPopupShown(url, ExpectPopup);
Browser* popup_browser =
chrome::FindLastActiveWithHostDesktopType(browser()->host_desktop_type());
ASSERT_NE(popup_browser, browser());
// Showing an alert will raise the tab over the popup.
tab->GetMainFrame()->ExecuteJavaScript(base::UTF8ToUTF16("alert()"));
app_modal::AppModalDialog* dialog = ui_test_utils::WaitForAppModalDialog();
// Verify that after the dialog was closed, the popup is in front again.
ASSERT_TRUE(dialog->IsJavaScriptModalDialog());
app_modal::JavaScriptAppModalDialog* js_dialog =
static_cast<app_modal::JavaScriptAppModalDialog*>(dialog);
BrowserActivationObserver activation_observer(browser()->host_desktop_type());
js_dialog->native_dialog()->AcceptAppModalDialog();
if (popup_browser != chrome::FindLastActiveWithHostDesktopType(
popup_browser->host_desktop_type())) {
activation_observer.WaitForActivation();
}
ASSERT_EQ(popup_browser, chrome::FindLastActiveWithHostDesktopType(
popup_browser->host_desktop_type()));
}
} // namespace
|