1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
|
// Copyright 2013 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_commands.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
#include "chrome/test/base/browser_with_test_window_test.h"
#include "content/public/browser/site_instance.h"
#include "content/public/browser/web_contents.h"
#include "content/public/test/web_contents_tester.h"
// Both tests below require a tab strip, so skip the file entirely on platforms
// without one.
#if !defined(OS_ANDROID) && !defined(OS_IOS)
using content::SiteInstance;
using content::WebContents;
using content::WebContentsTester;
class BrowserUnitTest : public BrowserWithTestWindowTest {
public:
BrowserUnitTest() {}
~BrowserUnitTest() override {}
// Caller owns the memory.
WebContents* CreateTestWebContents() {
return WebContentsTester::CreateTestWebContents(
profile(), SiteInstance::Create(profile()));
}
private:
DISALLOW_COPY_AND_ASSIGN(BrowserUnitTest);
};
// Ensure crashed tabs are not reloaded when selected. crbug.com/232323
TEST_F(BrowserUnitTest, ReloadCrashedTab) {
TabStripModel* tab_strip_model = browser()->tab_strip_model();
// Start with a single foreground tab. |tab_strip_model| owns the memory.
WebContents* contents1 = CreateTestWebContents();
tab_strip_model->AppendWebContents(contents1, true);
WebContentsTester::For(contents1)->NavigateAndCommit(GURL("about:blank"));
WebContentsTester::For(contents1)->TestSetIsLoading(false);
EXPECT_TRUE(tab_strip_model->IsTabSelected(0));
EXPECT_FALSE(contents1->IsLoading());
// Add a second tab in the background.
WebContents* contents2 = CreateTestWebContents();
tab_strip_model->AppendWebContents(contents2, false);
WebContentsTester::For(contents2)->NavigateAndCommit(GURL("about:blank"));
WebContentsTester::For(contents2)->TestSetIsLoading(false);
EXPECT_EQ(2, browser()->tab_strip_model()->count());
EXPECT_TRUE(tab_strip_model->IsTabSelected(0));
EXPECT_FALSE(contents2->IsLoading());
// Simulate the second tab crashing.
contents2->SetIsCrashed(base::TERMINATION_STATUS_PROCESS_CRASHED, -1);
EXPECT_TRUE(contents2->IsCrashed());
// Selecting the second tab does not cause a load or clear the crash.
tab_strip_model->ActivateTabAt(1, true);
EXPECT_TRUE(tab_strip_model->IsTabSelected(1));
EXPECT_FALSE(contents2->IsLoading());
EXPECT_TRUE(contents2->IsCrashed());
}
class BrowserBookmarkBarTest : public BrowserWithTestWindowTest {
public:
BrowserBookmarkBarTest() {}
~BrowserBookmarkBarTest() override {}
protected:
BookmarkBar::State window_bookmark_bar_state() const {
return static_cast<BookmarkBarStateTestBrowserWindow*>(
browser()->window())->bookmark_bar_state();
}
// BrowserWithTestWindowTest:
void SetUp() override {
BrowserWithTestWindowTest::SetUp();
static_cast<BookmarkBarStateTestBrowserWindow*>(
browser()->window())->set_browser(browser());
}
BrowserWindow* CreateBrowserWindow() override {
return new BookmarkBarStateTestBrowserWindow();
}
private:
class BookmarkBarStateTestBrowserWindow : public TestBrowserWindow {
public:
BookmarkBarStateTestBrowserWindow()
: browser_(NULL),
bookmark_bar_state_(BookmarkBar::HIDDEN) {}
~BookmarkBarStateTestBrowserWindow() override {}
void set_browser(Browser* browser) { browser_ = browser; }
BookmarkBar::State bookmark_bar_state() const {
return bookmark_bar_state_;
}
private:
// TestBrowserWindow:
void BookmarkBarStateChanged(
BookmarkBar::AnimateChangeType change_type) override {
bookmark_bar_state_ = browser_->bookmark_bar_state();
TestBrowserWindow::BookmarkBarStateChanged(change_type);
}
void OnActiveTabChanged(content::WebContents* old_contents,
content::WebContents* new_contents,
int index,
int reason) override {
bookmark_bar_state_ = browser_->bookmark_bar_state();
TestBrowserWindow::OnActiveTabChanged(old_contents, new_contents, index,
reason);
}
Browser* browser_; // Weak ptr.
BookmarkBar::State bookmark_bar_state_;
DISALLOW_COPY_AND_ASSIGN(BookmarkBarStateTestBrowserWindow);
};
DISALLOW_COPY_AND_ASSIGN(BrowserBookmarkBarTest);
};
// Ensure bookmark bar states in Browser and BrowserWindow are in sync after
// Browser::ActiveTabChanged() calls BrowserWindow::OnActiveTabChanged().
TEST_F(BrowserBookmarkBarTest, StateOnActiveTabChanged) {
ASSERT_EQ(BookmarkBar::HIDDEN, browser()->bookmark_bar_state());
ASSERT_EQ(BookmarkBar::HIDDEN, window_bookmark_bar_state());
GURL ntp_url("chrome://newtab");
GURL non_ntp_url("http://foo");
// Open a tab to NTP.
AddTab(browser(), ntp_url);
EXPECT_EQ(BookmarkBar::DETACHED, browser()->bookmark_bar_state());
EXPECT_EQ(BookmarkBar::DETACHED, window_bookmark_bar_state());
// Navigate 1st tab to a non-NTP URL.
NavigateAndCommitActiveTab(non_ntp_url);
EXPECT_EQ(BookmarkBar::HIDDEN, browser()->bookmark_bar_state());
EXPECT_EQ(BookmarkBar::HIDDEN, window_bookmark_bar_state());
// Open a tab to NTP at index 0.
AddTab(browser(), ntp_url);
EXPECT_EQ(BookmarkBar::DETACHED, browser()->bookmark_bar_state());
EXPECT_EQ(BookmarkBar::DETACHED, window_bookmark_bar_state());
// Activate the 2nd tab which is non-NTP.
browser()->tab_strip_model()->ActivateTabAt(1, true);
EXPECT_EQ(BookmarkBar::HIDDEN, browser()->bookmark_bar_state());
EXPECT_EQ(BookmarkBar::HIDDEN, window_bookmark_bar_state());
// Toggle bookmark bar while 2nd tab (non-NTP) is active.
chrome::ToggleBookmarkBar(browser());
EXPECT_EQ(BookmarkBar::SHOW, browser()->bookmark_bar_state());
EXPECT_EQ(BookmarkBar::SHOW, window_bookmark_bar_state());
// Activate the 1st tab which is NTP.
browser()->tab_strip_model()->ActivateTabAt(0, true);
EXPECT_EQ(BookmarkBar::SHOW, browser()->bookmark_bar_state());
EXPECT_EQ(BookmarkBar::SHOW, window_bookmark_bar_state());
// Activate the 2nd tab which is non-NTP.
browser()->tab_strip_model()->ActivateTabAt(1, true);
EXPECT_EQ(BookmarkBar::SHOW, browser()->bookmark_bar_state());
EXPECT_EQ(BookmarkBar::SHOW, window_bookmark_bar_state());
}
#endif // !defined(OS_ANDROID) && !defined(OS_IOS)
|
