1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334 1335 1336 1337 1338 1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351 1352 1353 1354 1355 1356 1357 1358 1359 1360 1361 1362 1363 1364 1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377 1378 1379 1380 1381 1382 1383 1384 1385 1386 1387 1388 1389 1390 1391 1392 1393 1394 1395 1396 1397 1398 1399 1400 1401 1402 1403 1404 1405 1406 1407 1408 1409 1410 1411 1412 1413 1414 1415 1416 1417 1418 1419 1420 1421 1422 1423 1424 1425 1426 1427 1428 1429 1430 1431 1432 1433 1434 1435 1436 1437 1438 1439 1440 1441 1442 1443 1444 1445 1446 1447 1448 1449 1450 1451 1452 1453 1454 1455 1456 1457 1458 1459 1460 1461 1462 1463 1464 1465 1466 1467 1468 1469 1470 1471 1472 1473 1474 1475 1476 1477 1478 1479 1480 1481 1482 1483 1484 1485 1486 1487 1488 1489 1490 1491 1492 1493 1494 1495 1496 1497 1498 1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509 1510 1511 1512 1513 1514 1515 1516 1517 1518 1519 1520 1521 1522 1523 1524 1525 1526 1527 1528 1529 1530 1531 1532 1533 1534 1535 1536 1537 1538 1539 1540 1541 1542 1543 1544 1545 1546 1547 1548 1549 1550 1551 1552 1553 1554 1555 1556 1557 1558 1559 1560 1561 1562 1563 1564 1565 1566 1567 1568 1569 1570 1571 1572 1573 1574 1575 1576 1577 1578 1579 1580 1581 1582 1583 1584 1585 1586 1587 1588 1589 1590 1591 1592 1593 1594 1595 1596 1597 1598 1599 1600 1601 1602 1603 1604 1605 1606 1607 1608 1609 1610 1611 1612 1613 1614 1615 1616 1617 1618 1619 1620 1621 1622 1623 1624 1625 1626 1627 1628 1629 1630 1631 1632 1633 1634 1635 1636 1637 1638 1639 1640 1641 1642 1643 1644 1645 1646 1647 1648 1649
|
// Copyright (c) 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "base/basictypes.h"
#include "base/mac/scoped_nsobject.h"
#include "base/strings/utf_string_conversions.h"
#include "chrome/browser/bookmarks/bookmark_model_factory.h"
#import "chrome/browser/ui/cocoa/bookmarks/bookmark_bar_constants.h"
#import "chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.h"
#import "chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_button_cell.h"
#import "chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.h"
#import "chrome/browser/ui/cocoa/bookmarks/bookmark_bar_unittest_helper.h"
#include "chrome/browser/ui/cocoa/cocoa_profile_test.h"
#import "chrome/browser/ui/cocoa/cocoa_test_helper.h"
#import "chrome/browser/ui/cocoa/view_resizer_pong.h"
#include "chrome/test/base/testing_profile.h"
#include "components/bookmarks/browser/bookmark_model.h"
#include "components/bookmarks/test/bookmark_test_helpers.h"
#include "testing/gtest/include/gtest/gtest.h"
#import "testing/gtest_mac.h"
#include "testing/platform_test.h"
#include "ui/base/cocoa/animation_utils.h"
#include <cmath>
using base::ASCIIToUTF16;
namespace {
const int kLotsOfNodesCount = 150;
// Deletes the bookmark corresponding to |button|.
void DeleteBookmark(BookmarkButton* button, Profile* profile) {
const BookmarkNode* node = [button bookmarkNode];
if (node) {
BookmarkModel* model = BookmarkModelFactory::GetForProfile(profile);
model->Remove(node->parent(), node->parent()->GetIndexOf(node));
}
}
} // namespace
// Add a redirect to make testing easier.
@interface BookmarkBarFolderController(MakeTestingEasier)
- (void)validateMenuSpacing;
@end
@implementation BookmarkBarFolderController(MakeTestingEasier)
// Utility function to verify that the buttons in this folder are all
// evenly spaced in a progressive manner.
- (void)validateMenuSpacing {
BOOL firstButton = YES;
CGFloat lastVerticalOffset = 0.0;
for (BookmarkButton* button in [self buttons]) {
if (firstButton) {
firstButton = NO;
lastVerticalOffset = [button frame].origin.y;
} else {
CGFloat nextVerticalOffset = [button frame].origin.y;
EXPECT_CGFLOAT_EQ(lastVerticalOffset -
bookmarks::kBookmarkFolderButtonHeight,
nextVerticalOffset);
lastVerticalOffset = nextVerticalOffset;
}
}
}
@end
// Don't use a high window level when running unit tests -- it'll
// interfere with anything else you are working on.
// For testing.
@interface BookmarkBarFolderControllerNoLevel : BookmarkBarFolderController
@end
@implementation BookmarkBarFolderControllerNoLevel
- (void)configureWindowLevel {
// Intentionally empty.
}
@end
@interface BookmarkBarFolderControllerPong : BookmarkBarFolderController {
BOOL childFolderWillShow_;
BOOL childFolderWillClose_;
}
@property (nonatomic, readonly) BOOL childFolderWillShow;
@property (nonatomic, readonly) BOOL childFolderWillClose;
@end
@implementation BookmarkBarFolderControllerPong
@synthesize childFolderWillShow = childFolderWillShow_;
@synthesize childFolderWillClose = childFolderWillClose_;
- (void)childFolderWillShow:(id<BookmarkButtonControllerProtocol>)child {
childFolderWillShow_ = YES;
}
- (void)childFolderWillClose:(id<BookmarkButtonControllerProtocol>)child {
childFolderWillClose_ = YES;
}
// We don't have a real BookmarkBarController as our parent root so
// we fake this one out.
- (void)closeAllBookmarkFolders {
[self closeBookmarkFolder:self];
}
@end
// Redirect certain calls so they can be seen by tests.
@interface BookmarkBarControllerChildFolderRedirect : BookmarkBarController {
BookmarkBarFolderController* childFolderDelegate_;
}
@property (nonatomic, assign) BookmarkBarFolderController* childFolderDelegate;
@end
@implementation BookmarkBarControllerChildFolderRedirect
@synthesize childFolderDelegate = childFolderDelegate_;
- (void)childFolderWillShow:(id<BookmarkButtonControllerProtocol>)child {
[childFolderDelegate_ childFolderWillShow:child];
}
- (void)childFolderWillClose:(id<BookmarkButtonControllerProtocol>)child {
[childFolderDelegate_ childFolderWillClose:child];
}
@end
class BookmarkBarFolderControllerTest : public CocoaProfileTest {
public:
base::scoped_nsobject<BookmarkBarControllerChildFolderRedirect> bar_;
const BookmarkNode* folderA_; // Owned by model.
const BookmarkNode* longTitleNode_; // Owned by model.
void SetUp() override {
CocoaProfileTest::SetUp();
ASSERT_TRUE(profile());
CreateModel();
}
void CreateModel() {
BookmarkModel* model = BookmarkModelFactory::GetForProfile(profile());
const BookmarkNode* parent = model->bookmark_bar_node();
const BookmarkNode* folderA = model->AddFolder(parent,
parent->child_count(),
ASCIIToUTF16("folder"));
folderA_ = folderA;
model->AddFolder(parent, parent->child_count(),
ASCIIToUTF16("sibbling folder"));
const BookmarkNode* folderB = model->AddFolder(folderA,
folderA->child_count(),
ASCIIToUTF16("subfolder 1"));
model->AddFolder(folderA,
folderA->child_count(),
ASCIIToUTF16("subfolder 2"));
model->AddURL(folderA, folderA->child_count(), ASCIIToUTF16("title a"),
GURL("http://www.google.com/a"));
longTitleNode_ = model->AddURL(
folderA, folderA->child_count(),
ASCIIToUTF16("title super duper long long whoa momma title you betcha"),
GURL("http://www.google.com/b"));
model->AddURL(folderB, folderB->child_count(), ASCIIToUTF16("t"),
GURL("http://www.google.com/c"));
bar_.reset(
[[BookmarkBarControllerChildFolderRedirect alloc]
initWithBrowser:browser()
initialWidth:300
delegate:nil
resizeDelegate:nil]);
[bar_ loaded:model];
// Make parent frame for bookmark bar then open it.
NSRect frame = [[test_window() contentView] frame];
frame = NSMakeRect(frame.origin.x,
frame.size.height - chrome::kNTPBookmarkBarHeight,
frame.size.width, chrome::kNTPBookmarkBarHeight);
NSView* fakeToolbarView = [[[NSView alloc] initWithFrame:frame]
autorelease];
[[test_window() contentView] addSubview:fakeToolbarView];
[fakeToolbarView addSubview:[bar_ view]];
[bar_ setBookmarkBarEnabled:YES];
}
// Remove the bookmark with the long title.
void RemoveLongTitleNode() {
BookmarkModel* model = BookmarkModelFactory::GetForProfile(profile());
model->Remove(longTitleNode_->parent(),
longTitleNode_->parent()->GetIndexOf(longTitleNode_));
}
// Add LOTS of nodes to our model if needed (e.g. scrolling).
// Returns the number of nodes added.
int AddLotsOfNodes() {
BookmarkModel* model = BookmarkModelFactory::GetForProfile(profile());
for (int i = 0; i < kLotsOfNodesCount; i++) {
model->AddURL(folderA_, folderA_->child_count(),
ASCIIToUTF16("repeated title"),
GURL("http://www.google.com/repeated/url"));
}
return kLotsOfNodesCount;
}
// Return a simple BookmarkBarFolderController.
BookmarkBarFolderControllerPong* SimpleBookmarkBarFolderController() {
BookmarkButton* parentButton = [[bar_ buttons] objectAtIndex:0];
BookmarkBarFolderControllerPong* c =
[[BookmarkBarFolderControllerPong alloc]
initWithParentButton:parentButton
parentController:nil
barController:bar_
profile:profile()];
[c window]; // Force nib load.
return c;
}
};
TEST_F(BookmarkBarFolderControllerTest, InitCreateAndDelete) {
base::scoped_nsobject<BookmarkBarFolderController> bbfc;
bbfc.reset(SimpleBookmarkBarFolderController());
// Make sure none of the buttons overlap, that all are inside
// the content frame, and their cells are of the proper class.
NSArray* buttons = [bbfc buttons];
EXPECT_TRUE([buttons count]);
for (unsigned int i = 0; i < ([buttons count]-1); i++) {
EXPECT_FALSE(NSContainsRect([[buttons objectAtIndex:i] frame],
[[buttons objectAtIndex:i+1] frame]));
}
Class cellClass = [BookmarkBarFolderButtonCell class];
for (BookmarkButton* button in buttons) {
NSRect r = [[bbfc folderView] convertRect:[button frame] fromView:button];
// TODO(jrg): remove this adjustment.
NSRect bigger = NSInsetRect([[bbfc folderView] frame], -2, 0);
EXPECT_TRUE(NSContainsRect(bigger, r));
EXPECT_TRUE([[button cell] isKindOfClass:cellClass]);
}
// Confirm folder buttons have no tooltip. The important thing
// really is that we insure folders and non-folders are treated
// differently; not sure of any other generic way to do this.
for (BookmarkButton* button in buttons) {
if ([button isFolder])
EXPECT_FALSE([button toolTip]);
else
EXPECT_TRUE([button toolTip]);
}
}
// Make sure closing of the window releases the controller.
// (e.g. valgrind shouldn't complain if we do this).
TEST_F(BookmarkBarFolderControllerTest, ReleaseOnClose) {
base::scoped_nsobject<BookmarkBarFolderController> bbfc;
bbfc.reset(SimpleBookmarkBarFolderController());
EXPECT_TRUE(bbfc.get());
[bbfc retain]; // stop the scoped_nsobject from doing anything
[[bbfc window] close]; // trigger an autorelease of bbfc.get()
}
TEST_F(BookmarkBarFolderControllerTest, BasicPosition) {
BookmarkButton* parentButton = [[bar_ buttons] objectAtIndex:0];
EXPECT_TRUE(parentButton);
// If parent is a BookmarkBarController, grow down.
base::scoped_nsobject<BookmarkBarFolderController> bbfc;
bbfc.reset([[BookmarkBarFolderController alloc]
initWithParentButton:parentButton
parentController:nil
barController:bar_
profile:profile()]);
[bbfc window];
NSPoint pt = [bbfc windowTopLeftForWidth:0 height:100]; // screen coords
NSPoint buttonOriginInWindow =
[parentButton convertRect:[parentButton bounds]
toView:nil].origin;
NSPoint buttonOriginInScreen =
[[parentButton window] convertBaseToScreen:buttonOriginInWindow];
// Within margin
EXPECT_LE(std::abs(pt.x - buttonOriginInScreen.x),
bookmarks::kBookmarkMenuOverlap + 1);
EXPECT_LE(std::abs(pt.y - buttonOriginInScreen.y),
bookmarks::kBookmarkMenuOverlap + 1);
// Make sure we see the window shift left if it spills off the screen
pt = [bbfc windowTopLeftForWidth:0 height:100];
NSPoint shifted = [bbfc windowTopLeftForWidth:9999999 height:100];
EXPECT_LT(shifted.x, pt.x);
// If parent is a BookmarkBarFolderController, grow right.
base::scoped_nsobject<BookmarkBarFolderController> bbfc2;
bbfc2.reset([[BookmarkBarFolderController alloc]
initWithParentButton:[[bbfc buttons] objectAtIndex:0]
parentController:bbfc.get()
barController:bar_
profile:profile()]);
[bbfc2 window];
pt = [bbfc2 windowTopLeftForWidth:0 height:100];
// We're now overlapping the window a bit.
EXPECT_EQ(pt.x, NSMaxX([[bbfc.get() window] frame]) -
bookmarks::kBookmarkMenuOverlap);
}
// Confirm we grow right until end of screen, then start growing left
// until end of screen again, then right.
TEST_F(BookmarkBarFolderControllerTest, PositionRightLeftRight) {
BookmarkModel* model = BookmarkModelFactory::GetForProfile(profile());
const BookmarkNode* parent = model->bookmark_bar_node();
const BookmarkNode* folder = parent;
const int count = 100;
int i;
// Make some super duper deeply nested folders.
for (i = 0; i < count; i++) {
folder = model->AddFolder(folder, 0, ASCIIToUTF16("nested folder"));
}
// Setup initial state for opening all folders.
folder = parent;
BookmarkButton* parentButton = [[bar_ buttons] objectAtIndex:0];
BookmarkBarFolderController* parentController = nil;
EXPECT_TRUE(parentButton);
// Open them all.
base::scoped_nsobject<NSMutableArray> folder_controller_array;
folder_controller_array.reset([[NSMutableArray array] retain]);
for (i=0; i<count; i++) {
BookmarkBarFolderControllerNoLevel* bbfcl =
[[BookmarkBarFolderControllerNoLevel alloc]
initWithParentButton:parentButton
parentController:parentController
barController:bar_
profile:profile()];
[folder_controller_array addObject:bbfcl];
[bbfcl autorelease];
[bbfcl window];
parentController = bbfcl;
parentButton = [[bbfcl buttons] objectAtIndex:0];
}
// Make vector of all x positions.
std::vector<CGFloat> leftPositions;
for (i=0; i<count; i++) {
CGFloat x = [[[folder_controller_array objectAtIndex:i] window]
frame].origin.x;
leftPositions.push_back(x);
}
// Make sure the first few grow right.
for (i=0; i<3; i++)
EXPECT_TRUE(leftPositions[i+1] > leftPositions[i]);
// Look for the first "grow left".
while (leftPositions[i] > leftPositions[i-1])
i++;
// Confirm the next few also grow left.
int j;
for (j=i; j<i+3; j++)
EXPECT_TRUE(leftPositions[j+1] < leftPositions[j]);
i = j;
// Finally, confirm we see a "grow right" once more.
while (leftPositions[i] < leftPositions[i-1])
i++;
// (No need to EXPECT a final "grow right"; if we didn't find one
// we'd get a C++ array bounds exception).
}
TEST_F(BookmarkBarFolderControllerTest, DropDestination) {
base::scoped_nsobject<BookmarkBarFolderController> bbfc;
bbfc.reset(SimpleBookmarkBarFolderController());
EXPECT_TRUE(bbfc.get());
// Confirm "off the top" and "off the bottom" match no buttons.
NSPoint p = NSMakePoint(NSMidX([[bbfc folderView] frame]), 10000);
EXPECT_FALSE([bbfc buttonForDroppingOnAtPoint:p]);
EXPECT_TRUE([bbfc shouldShowIndicatorShownForPoint:p]);
p = NSMakePoint(NSMidX([[bbfc folderView] frame]), -1);
EXPECT_FALSE([bbfc buttonForDroppingOnAtPoint:p]);
EXPECT_TRUE([bbfc shouldShowIndicatorShownForPoint:p]);
// Confirm "right in the center" (give or take a pixel) is a match,
// and confirm "just barely in the button" is not. Anything more
// specific seems likely to be tweaked. We don't loop over all
// buttons because the scroll view makes them not visible.
for (BookmarkButton* button in [bbfc buttons]) {
CGFloat x = NSMidX([button frame]);
CGFloat y = NSMidY([button frame]);
// Somewhere near the center: a match (but only if a folder!)
if ([button isFolder]) {
EXPECT_EQ(button,
[bbfc buttonForDroppingOnAtPoint:NSMakePoint(x-1, y+1)]);
EXPECT_EQ(button,
[bbfc buttonForDroppingOnAtPoint:NSMakePoint(x+1, y-1)]);
EXPECT_FALSE([bbfc shouldShowIndicatorShownForPoint:NSMakePoint(x, y)]);;
} else {
// If not a folder we don't drop into it.
EXPECT_FALSE([bbfc buttonForDroppingOnAtPoint:NSMakePoint(x-1, y+1)]);
EXPECT_FALSE([bbfc buttonForDroppingOnAtPoint:NSMakePoint(x+1, y-1)]);
EXPECT_TRUE([bbfc shouldShowIndicatorShownForPoint:NSMakePoint(x, y)]);;
}
}
}
TEST_F(BookmarkBarFolderControllerTest, OpenFolder) {
base::scoped_nsobject<BookmarkBarFolderController> bbfc;
bbfc.reset(SimpleBookmarkBarFolderController());
EXPECT_TRUE(bbfc.get());
EXPECT_FALSE([bbfc folderController]);
BookmarkButton* button = [[bbfc buttons] objectAtIndex:0];
[bbfc openBookmarkFolderFromButton:button];
id controller = [bbfc folderController];
EXPECT_TRUE(controller);
EXPECT_EQ([controller parentButton], button);
// Click the same one --> it gets closed.
[bbfc openBookmarkFolderFromButton:[[bbfc buttons] objectAtIndex:0]];
EXPECT_FALSE([bbfc folderController]);
// Open a new one --> change.
[bbfc openBookmarkFolderFromButton:[[bbfc buttons] objectAtIndex:1]];
EXPECT_NE(controller, [bbfc folderController]);
EXPECT_NE([[bbfc folderController] parentButton], button);
// Close it --> all gone!
[bbfc closeBookmarkFolder:nil];
EXPECT_FALSE([bbfc folderController]);
}
TEST_F(BookmarkBarFolderControllerTest, DeleteOpenFolder) {
base::scoped_nsobject<BookmarkBarFolderController> parent_controller(
SimpleBookmarkBarFolderController());
// Open a folder.
EXPECT_FALSE([parent_controller folderController]);
BookmarkButton* button = [[parent_controller buttons] objectAtIndex:0];
[parent_controller openBookmarkFolderFromButton:button];
EXPECT_EQ([[parent_controller folderController] parentButton], button);
// Delete the folder's button - the folder should close.
[parent_controller removeButton:0 animate:NO];
EXPECT_FALSE([parent_controller folderController]);
}
TEST_F(BookmarkBarFolderControllerTest, ChildFolderCallbacks) {
base::scoped_nsobject<BookmarkBarFolderControllerPong> bbfc;
bbfc.reset(SimpleBookmarkBarFolderController());
EXPECT_TRUE(bbfc.get());
[bar_ setChildFolderDelegate:bbfc.get()];
EXPECT_FALSE([bbfc childFolderWillShow]);
[bbfc openBookmarkFolderFromButton:[[bbfc buttons] objectAtIndex:0]];
EXPECT_TRUE([bbfc childFolderWillShow]);
EXPECT_FALSE([bbfc childFolderWillClose]);
[bbfc closeBookmarkFolder:nil];
EXPECT_TRUE([bbfc childFolderWillClose]);
[bar_ setChildFolderDelegate:nil];
}
// Make sure bookmark folders have variable widths.
TEST_F(BookmarkBarFolderControllerTest, ChildFolderWidth) {
base::scoped_nsobject<BookmarkBarFolderController> bbfc;
bbfc.reset(SimpleBookmarkBarFolderController());
EXPECT_TRUE(bbfc.get());
[bbfc showWindow:bbfc.get()];
CGFloat wideWidth = NSWidth([[bbfc window] frame]);
RemoveLongTitleNode();
bbfc.reset(SimpleBookmarkBarFolderController());
EXPECT_TRUE(bbfc.get());
CGFloat thinWidth = NSWidth([[bbfc window] frame]);
// Make sure window size changed as expected.
EXPECT_GT(wideWidth, thinWidth);
}
// Simple scrolling tests.
// Currently flaky due to a changed definition of the correct menu boundaries.
TEST_F(BookmarkBarFolderControllerTest, DISABLED_SimpleScroll) {
base::scoped_nsobject<BookmarkBarFolderController> bbfc;
NSRect screenFrame = [[NSScreen mainScreen] visibleFrame];
CGFloat screenHeight = NSHeight(screenFrame);
int nodecount = AddLotsOfNodes();
bbfc.reset(SimpleBookmarkBarFolderController());
EXPECT_TRUE(bbfc.get());
[bbfc showWindow:bbfc.get()];
NSWindow* window = [bbfc window];
// The window should be shorter than the screen but reach exactly to the
// bottom of the screen since it's scrollable.
EXPECT_LT(NSHeight([window frame]), screenHeight);
EXPECT_CGFLOAT_EQ(0.0, [window frame].origin.y);
// Initially, should show scroll-up but not scroll-down.
EXPECT_TRUE([bbfc canScrollUp]);
EXPECT_FALSE([bbfc canScrollDown]);
// Scroll up a bit. Make sure the window has gotten bigger each time.
// Also, for each scroll, make sure our hit test finds a new button
// (to confirm the content area changed).
NSView* savedHit = nil;
NSScrollView* scrollView = [bbfc scrollView];
// Find the next-to-last button showing at the bottom of the window and
// use its center for hit testing.
BookmarkButton* targetButton = nil;
NSPoint scrollPoint = [scrollView documentVisibleRect].origin;
for (BookmarkButton* button in [bbfc buttons]) {
NSRect buttonFrame = [button frame];
buttonFrame.origin.y -= scrollPoint.y;
if (buttonFrame.origin.y < 0.0)
break;
targetButton = button;
}
EXPECT_TRUE(targetButton != nil);
NSPoint hitPoint = [targetButton frame].origin;
hitPoint.x += 50.0;
hitPoint.y += (bookmarks::kBookmarkFolderButtonHeight / 2.0) - scrollPoint.y;
hitPoint = [targetButton convertPoint:hitPoint toView:scrollView];
for (int i = 0; i < 3; i++) {
CGFloat height = NSHeight([window frame]);
[bbfc performOneScroll:60];
EXPECT_GT(NSHeight([window frame]), height);
NSView* hit = [scrollView hitTest:hitPoint];
// We should hit a bookmark button.
EXPECT_TRUE([[hit className] isEqualToString:@"BookmarkButton"]);
EXPECT_NE(hit, savedHit);
savedHit = hit;
}
// Keep scrolling up; make sure we never get bigger than the screen.
// Also confirm we never scroll the window off the screen.
bool bothAtOnce = false;
while ([bbfc canScrollUp]) {
[bbfc performOneScroll:60];
EXPECT_TRUE(NSContainsRect([[NSScreen mainScreen] frame], [window frame]));
// Make sure, sometime during our scroll, we have the ability to
// scroll in either direction.
if ([bbfc canScrollUp] &&
[bbfc canScrollDown])
bothAtOnce = true;
}
EXPECT_TRUE(bothAtOnce);
// Once we've scrolled to the end, our only option should be to scroll back.
EXPECT_FALSE([bbfc canScrollUp]);
EXPECT_TRUE([bbfc canScrollDown]);
NSRect wholeScreenRect = [[NSScreen mainScreen] frame];
// Now scroll down and make sure the window size does not change.
// Also confirm we never scroll the window off the screen the other
// way.
for (int i = 0; i < nodecount+50; ++i) {
[bbfc performOneScroll:-60];
// Once we can no longer scroll down the window height changes.
if (![bbfc canScrollDown])
break;
EXPECT_TRUE(NSContainsRect(wholeScreenRect, [window frame]));
}
EXPECT_GT(NSHeight(wholeScreenRect), NSHeight([window frame]));
EXPECT_TRUE(NSContainsRect(wholeScreenRect, [window frame]));
}
// Folder menu sizing and placement while deleting bookmarks
// and scrolling tests.
TEST_F(BookmarkBarFolderControllerTest, MenuPlacementWhileScrollingDeleting) {
base::scoped_nsobject<BookmarkBarFolderController> bbfc;
AddLotsOfNodes();
bbfc.reset(SimpleBookmarkBarFolderController());
[bbfc showWindow:bbfc.get()];
NSWindow* menuWindow = [bbfc window];
BookmarkBarFolderController* folder = [bar_ folderController];
NSArray* buttons = [folder buttons];
// Before scrolling any, delete a bookmark and make sure the window top has
// not moved. Pick a button which is near the top and visible.
CGFloat oldTop = [menuWindow frame].origin.y + NSHeight([menuWindow frame]);
BookmarkButton* button = [buttons objectAtIndex:3];
DeleteBookmark(button, profile());
CGFloat newTop = [menuWindow frame].origin.y + NSHeight([menuWindow frame]);
EXPECT_CGFLOAT_EQ(oldTop, newTop);
// Scroll so that both the top and bottom scroll arrows show, make sure
// the top of the window has moved up, then delete a visible button and
// make sure the top has not moved.
oldTop = newTop;
const CGFloat scrollOneBookmark = bookmarks::kBookmarkFolderButtonHeight +
bookmarks::kBookmarkVerticalPadding;
NSUInteger buttonCounter = 0;
NSUInteger extraButtonLimit = 3;
while (![bbfc canScrollDown] || extraButtonLimit > 0) {
[bbfc performOneScroll:scrollOneBookmark];
++buttonCounter;
if ([bbfc canScrollDown])
--extraButtonLimit;
}
newTop = [menuWindow frame].origin.y + NSHeight([menuWindow frame]);
EXPECT_NE(oldTop, newTop);
oldTop = newTop;
button = [buttons objectAtIndex:buttonCounter + 3];
DeleteBookmark(button, profile());
newTop = [menuWindow frame].origin.y + NSHeight([menuWindow frame]);
EXPECT_CGFLOAT_EQ(oldTop, newTop);
// Scroll so that the top scroll arrow is no longer showing, make sure
// the top of the window has not moved, then delete a visible button and
// make sure the top has not moved.
while ([bbfc canScrollDown]) {
[bbfc performOneScroll:-scrollOneBookmark];
--buttonCounter;
}
button = [buttons objectAtIndex:buttonCounter + 3];
DeleteBookmark(button, profile());
newTop = [menuWindow frame].origin.y + NSHeight([menuWindow frame]);
EXPECT_CGFLOAT_EQ(oldTop - bookmarks::kScrollWindowVerticalMargin, newTop);
}
// Make sure that we return the correct browser window.
TEST_F(BookmarkBarFolderControllerTest, BrowserWindow) {
base::scoped_nsobject<BookmarkBarFolderController> controller(
SimpleBookmarkBarFolderController());
EXPECT_EQ([bar_ browserWindow], [controller browserWindow]);
}
@interface FakedDragInfo : NSObject {
@public
NSPoint dropLocation_;
NSDragOperation sourceMask_;
}
@property (nonatomic, assign) NSPoint dropLocation;
- (void)setDraggingSourceOperationMask:(NSDragOperation)mask;
@end
@implementation FakedDragInfo
@synthesize dropLocation = dropLocation_;
- (id)init {
if ((self = [super init])) {
dropLocation_ = NSZeroPoint;
sourceMask_ = NSDragOperationMove;
}
return self;
}
// NSDraggingInfo protocol functions.
- (id)draggingPasteboard {
return self;
}
- (id)draggingSource {
return self;
}
- (NSDragOperation)draggingSourceOperationMask {
return sourceMask_;
}
- (NSPoint)draggingLocation {
return dropLocation_;
}
// Other functions.
- (void)setDraggingSourceOperationMask:(NSDragOperation)mask {
sourceMask_ = mask;
}
@end
class BookmarkBarFolderControllerMenuTest : public CocoaProfileTest {
public:
base::scoped_nsobject<NSView> parent_view_;
base::scoped_nsobject<ViewResizerPong> resizeDelegate_;
base::scoped_nsobject<BookmarkBarController> bar_;
void SetUp() override {
CocoaProfileTest::SetUp();
ASSERT_TRUE(browser());
resizeDelegate_.reset([[ViewResizerPong alloc] init]);
NSRect parent_frame = NSMakeRect(0, 0, 800, 50);
parent_view_.reset([[NSView alloc] initWithFrame:parent_frame]);
[parent_view_ setHidden:YES];
bar_.reset([[BookmarkBarController alloc]
initWithBrowser:browser()
initialWidth:NSWidth(parent_frame)
delegate:nil
resizeDelegate:resizeDelegate_.get()]);
InstallAndToggleBar(bar_.get());
}
void InstallAndToggleBar(BookmarkBarController* bar) {
// Force loading of the nib.
[bar view];
// Awkwardness to look like we've been installed.
[parent_view_ addSubview:[bar view]];
NSRect frame = [[[bar view] superview] frame];
frame.origin.y = 400;
[[[bar view] superview] setFrame:frame];
// Make sure it's on in a window so viewDidMoveToWindow is called
[[test_window() contentView] addSubview:parent_view_];
// Make sure it's open so certain things aren't no-ops.
[bar updateState:BookmarkBar::SHOW
changeType:BookmarkBar::DONT_ANIMATE_STATE_CHANGE];
}
};
TEST_F(BookmarkBarFolderControllerMenuTest, DragMoveBarBookmarkToFolder) {
WithNoAnimation at_all;
BookmarkModel* model = BookmarkModelFactory::GetForProfile(profile());
const BookmarkNode* root = model->bookmark_bar_node();
const std::string model_string("1b 2f:[ 2f1b 2f2f:[ 2f2f1b 2f2f2b "
"2f2f3b ] 2f3b ] 3b 4f:[ 4f1f:[ 4f1f1b 4f1f2b 4f1f3b ] 4f2f:[ 4f2f1b "
"4f2f2b 4f2f3b ] 4f3f:[ 4f3f1b 4f3f2b 4f3f3b ] ] 5b ");
bookmarks::test::AddNodesFromModelString(model, root, model_string);
// Validate initial model.
std::string actualModelString = bookmarks::test::ModelStringFromNode(root);
EXPECT_EQ(model_string, actualModelString);
// Pop up a folder menu and drag in a button from the bar.
BookmarkButton* toFolder = [bar_ buttonWithTitleEqualTo:@"2f"];
NSRect oldToFolderFrame = [toFolder frame];
[[toFolder target] performSelector:@selector(openBookmarkFolderFromButton:)
withObject:toFolder];
BookmarkBarFolderController* folderController = [bar_ folderController];
EXPECT_TRUE(folderController);
NSWindow* toWindow = [folderController window];
EXPECT_TRUE(toWindow);
NSRect oldToWindowFrame = [toWindow frame];
// Drag a bar button onto a bookmark (i.e. not a folder) in a folder
// so it should end up below the target bookmark.
BookmarkButton* draggedButton = [bar_ buttonWithTitleEqualTo:@"1b"];
ASSERT_TRUE(draggedButton);
CGFloat horizontalShift =
NSWidth([draggedButton frame]) + bookmarks::kBookmarkHorizontalPadding;
BookmarkButton* targetButton =
[folderController buttonWithTitleEqualTo:@"2f1b"];
ASSERT_TRUE(targetButton);
[folderController dragButton:draggedButton
to:[targetButton center]
copy:NO];
// The button should have landed just after "2f1b".
const std::string expected_string("2f:[ 2f1b 1b 2f2f:[ 2f2f1b "
"2f2f2b 2f2f3b ] 2f3b ] 3b 4f:[ 4f1f:[ 4f1f1b 4f1f2b 4f1f3b ] 4f2f:[ "
"4f2f1b 4f2f2b 4f2f3b ] 4f3f:[ 4f3f1b 4f3f2b 4f3f3b ] ] 5b ");
EXPECT_EQ(expected_string, bookmarks::test::ModelStringFromNode(root));
// Verify the window still appears by looking for its controller.
EXPECT_TRUE([bar_ folderController]);
// Gather the new frames.
NSRect newToFolderFrame = [toFolder frame];
NSRect newToWindowFrame = [toWindow frame];
// The toFolder should have shifted left horizontally but not vertically.
NSRect expectedToFolderFrame =
NSOffsetRect(oldToFolderFrame, -horizontalShift, 0);
EXPECT_NSRECT_EQ(expectedToFolderFrame, newToFolderFrame);
// The toWindow should have shifted left horizontally, down vertically,
// and grown vertically.
NSRect expectedToWindowFrame = oldToWindowFrame;
expectedToWindowFrame.origin.x -= horizontalShift;
expectedToWindowFrame.origin.y -= bookmarks::kBookmarkFolderButtonHeight;
expectedToWindowFrame.size.height += bookmarks::kBookmarkFolderButtonHeight;
EXPECT_NSRECT_EQ(expectedToWindowFrame, newToWindowFrame);
// Check button spacing.
[folderController validateMenuSpacing];
// Move the button back to the bar at the beginning.
draggedButton = [folderController buttonWithTitleEqualTo:@"1b"];
ASSERT_TRUE(draggedButton);
targetButton = [bar_ buttonWithTitleEqualTo:@"2f"];
ASSERT_TRUE(targetButton);
[bar_ dragButton:draggedButton
to:[targetButton left]
copy:NO];
EXPECT_EQ(model_string, bookmarks::test::ModelStringFromNode(root));
// Don't check the folder window since it's not supposed to be showing.
}
TEST_F(BookmarkBarFolderControllerMenuTest, DragCopyBarBookmarkToFolder) {
BookmarkModel* model = BookmarkModelFactory::GetForProfile(profile());
const BookmarkNode* root = model->bookmark_bar_node();
const std::string model_string("1b 2f:[ 2f1b 2f2f:[ 2f2f1b 2f2f2b "
"2f2f3b ] 2f3b ] 3b 4f:[ 4f1f:[ 4f1f1b 4f1f2b 4f1f3b ] 4f2f:[ 4f2f1b "
"4f2f2b 4f2f3b ] 4f3f:[ 4f3f1b 4f3f2b 4f3f3b ] ] 5b ");
bookmarks::test::AddNodesFromModelString(model, root, model_string);
// Validate initial model.
std::string actualModelString = bookmarks::test::ModelStringFromNode(root);
EXPECT_EQ(model_string, actualModelString);
// Pop up a folder menu and copy in a button from the bar.
BookmarkButton* toFolder = [bar_ buttonWithTitleEqualTo:@"2f"];
ASSERT_TRUE(toFolder);
NSRect oldToFolderFrame = [toFolder frame];
[[toFolder target] performSelector:@selector(openBookmarkFolderFromButton:)
withObject:toFolder];
BookmarkBarFolderController* folderController = [bar_ folderController];
EXPECT_TRUE(folderController);
NSWindow* toWindow = [folderController window];
EXPECT_TRUE(toWindow);
NSRect oldToWindowFrame = [toWindow frame];
// Drag a bar button onto a bookmark (i.e. not a folder) in a folder
// so it should end up below the target bookmark.
BookmarkButton* draggedButton = [bar_ buttonWithTitleEqualTo:@"1b"];
ASSERT_TRUE(draggedButton);
BookmarkButton* targetButton =
[folderController buttonWithTitleEqualTo:@"2f1b"];
ASSERT_TRUE(targetButton);
[folderController dragButton:draggedButton
to:[targetButton center]
copy:YES];
// The button should have landed just after "2f1b".
const std::string expected_1("1b 2f:[ 2f1b 1b 2f2f:[ 2f2f1b "
"2f2f2b 2f2f3b ] 2f3b ] 3b 4f:[ 4f1f:[ 4f1f1b 4f1f2b 4f1f3b ] 4f2f:[ "
"4f2f1b 4f2f2b 4f2f3b ] 4f3f:[ 4f3f1b 4f3f2b 4f3f3b ] ] 5b ");
EXPECT_EQ(expected_1, bookmarks::test::ModelStringFromNode(root));
// Gather the new frames.
NSRect newToFolderFrame = [toFolder frame];
NSRect newToWindowFrame = [toWindow frame];
// The toFolder should have shifted.
EXPECT_NSRECT_EQ(oldToFolderFrame, newToFolderFrame);
// The toWindow should have shifted down vertically and grown vertically.
NSRect expectedToWindowFrame = oldToWindowFrame;
expectedToWindowFrame.origin.y -= bookmarks::kBookmarkFolderButtonHeight;
expectedToWindowFrame.size.height += bookmarks::kBookmarkFolderButtonHeight;
EXPECT_NSRECT_EQ(expectedToWindowFrame, newToWindowFrame);
// Copy the button back to the bar after "3b".
draggedButton = [folderController buttonWithTitleEqualTo:@"1b"];
ASSERT_TRUE(draggedButton);
targetButton = [bar_ buttonWithTitleEqualTo:@"4f"];
ASSERT_TRUE(targetButton);
[bar_ dragButton:draggedButton
to:[targetButton left]
copy:YES];
const std::string expected_2("1b 2f:[ 2f1b 1b 2f2f:[ 2f2f1b "
"2f2f2b 2f2f3b ] 2f3b ] 3b 1b 4f:[ 4f1f:[ 4f1f1b 4f1f2b 4f1f3b ] 4f2f:[ "
"4f2f1b 4f2f2b 4f2f3b ] 4f3f:[ 4f3f1b 4f3f2b 4f3f3b ] ] 5b ");
EXPECT_EQ(expected_2, bookmarks::test::ModelStringFromNode(root));
}
TEST_F(BookmarkBarFolderControllerMenuTest, DragMoveBarBookmarkToSubfolder) {
BookmarkModel* model = BookmarkModelFactory::GetForProfile(profile());
const BookmarkNode* root = model->bookmark_bar_node();
const std::string model_string("1b 2f:[ 2f1b 2f2f:[ 2f2f1b 2f2f2b "
"2f2f3b ] 2f3b ] 3b 4f:[ 4f1f:[ 4f1f1b 4f1f2b 4f1f3b ] 4f2f:[ 4f2f1b "
"4f2f2b 4f2f3b ] 4f3f:[ 4f3f1b 4f3f2b 4f3f3b ] ] 5b ");
bookmarks::test::AddNodesFromModelString(model, root, model_string);
// Validate initial model.
std::string actualModelString = bookmarks::test::ModelStringFromNode(root);
EXPECT_EQ(model_string, actualModelString);
// Pop up a folder menu and a subfolder menu.
BookmarkButton* toFolder = [bar_ buttonWithTitleEqualTo:@"4f"];
ASSERT_TRUE(toFolder);
[[toFolder target] performSelector:@selector(openBookmarkFolderFromButton:)
withObject:toFolder];
BookmarkBarFolderController* folderController = [bar_ folderController];
EXPECT_TRUE(folderController);
NSWindow* toWindow = [folderController window];
EXPECT_TRUE(toWindow);
NSRect oldToWindowFrame = [toWindow frame];
BookmarkButton* toSubfolder =
[folderController buttonWithTitleEqualTo:@"4f2f"];
ASSERT_TRUE(toSubfolder);
[[toSubfolder target] performSelector:@selector(openBookmarkFolderFromButton:)
withObject:toSubfolder];
BookmarkBarFolderController* subfolderController =
[folderController folderController];
EXPECT_TRUE(subfolderController);
NSWindow* toSubwindow = [subfolderController window];
EXPECT_TRUE(toSubwindow);
NSRect oldToSubwindowFrame = [toSubwindow frame];
// Drag a bar button onto a bookmark (i.e. not a folder) in a folder
// so it should end up below the target bookmark.
BookmarkButton* draggedButton = [bar_ buttonWithTitleEqualTo:@"5b"];
ASSERT_TRUE(draggedButton);
BookmarkButton* targetButton =
[subfolderController buttonWithTitleEqualTo:@"4f2f3b"];
ASSERT_TRUE(targetButton);
[subfolderController dragButton:draggedButton
to:[targetButton center]
copy:NO];
// The button should have landed just after "2f".
const std::string expected_string("1b 2f:[ 2f1b 2f2f:[ 2f2f1b "
"2f2f2b 2f2f3b ] 2f3b ] 3b 4f:[ 4f1f:[ 4f1f1b 4f1f2b 4f1f3b ] 4f2f:[ "
"4f2f1b 4f2f2b 4f2f3b 5b ] 4f3f:[ 4f3f1b 4f3f2b 4f3f3b ] ] ");
EXPECT_EQ(expected_string, bookmarks::test::ModelStringFromNode(root));
// Check button spacing.
[folderController validateMenuSpacing];
[subfolderController validateMenuSpacing];
// Check the window layouts. The folder window should not have changed,
// but the subfolder window should have shifted vertically and grown.
NSRect newToWindowFrame = [toWindow frame];
EXPECT_NSRECT_EQ(oldToWindowFrame, newToWindowFrame);
NSRect newToSubwindowFrame = [toSubwindow frame];
NSRect expectedToSubwindowFrame = oldToSubwindowFrame;
expectedToSubwindowFrame.origin.y -= bookmarks::kBookmarkFolderButtonHeight;
expectedToSubwindowFrame.size.height +=
bookmarks::kBookmarkFolderButtonHeight;
EXPECT_NSRECT_EQ(expectedToSubwindowFrame, newToSubwindowFrame);
}
TEST_F(BookmarkBarFolderControllerMenuTest, DragMoveWithinFolder) {
BookmarkModel* model = BookmarkModelFactory::GetForProfile(profile());
const BookmarkNode* root = model->bookmark_bar_node();
const std::string model_string("1b 2f:[ 2f1b 2f2f:[ 2f2f1b 2f2f2b "
"2f2f3b ] 2f3b ] 3b 4f:[ 4f1f:[ 4f1f1b 4f1f2b 4f1f3b ] 4f2f:[ 4f2f1b "
"4f2f2b 4f2f3b ] 4f3f:[ 4f3f1b 4f3f2b 4f3f3b ] ] 5b ");
bookmarks::test::AddNodesFromModelString(model, root, model_string);
// Validate initial model.
std::string actualModelString = bookmarks::test::ModelStringFromNode(root);
EXPECT_EQ(model_string, actualModelString);
// Pop up a folder menu.
BookmarkButton* toFolder = [bar_ buttonWithTitleEqualTo:@"4f"];
ASSERT_TRUE(toFolder);
[[toFolder target] performSelector:@selector(openBookmarkFolderFromButton:)
withObject:toFolder];
BookmarkBarFolderController* folderController = [bar_ folderController];
EXPECT_TRUE(folderController);
NSWindow* toWindow = [folderController window];
EXPECT_TRUE(toWindow);
NSRect oldToWindowFrame = [toWindow frame];
// Drag a folder button to the top within the same parent.
BookmarkButton* draggedButton =
[folderController buttonWithTitleEqualTo:@"4f2f"];
ASSERT_TRUE(draggedButton);
BookmarkButton* targetButton =
[folderController buttonWithTitleEqualTo:@"4f1f"];
ASSERT_TRUE(targetButton);
[folderController dragButton:draggedButton
to:[targetButton top]
copy:NO];
// The button should have landed above "4f1f".
const std::string expected_string("1b 2f:[ 2f1b 2f2f:[ 2f2f1b "
"2f2f2b 2f2f3b ] 2f3b ] 3b 4f:[ 4f2f:[ 4f2f1b 4f2f2b 4f2f3b ] "
"4f1f:[ 4f1f1b 4f1f2b 4f1f3b ] 4f3f:[ 4f3f1b 4f3f2b 4f3f3b ] ] 5b ");
EXPECT_EQ(expected_string, bookmarks::test::ModelStringFromNode(root));
// The window should not have gone away.
EXPECT_TRUE([bar_ folderController]);
// The folder window should not have changed.
NSRect newToWindowFrame = [toWindow frame];
EXPECT_NSRECT_EQ(oldToWindowFrame, newToWindowFrame);
// Check button spacing.
[folderController validateMenuSpacing];
}
TEST_F(BookmarkBarFolderControllerMenuTest, DragParentOntoChild) {
BookmarkModel* model = BookmarkModelFactory::GetForProfile(profile());
const BookmarkNode* root = model->bookmark_bar_node();
const std::string model_string("1b 2f:[ 2f1b 2f2f:[ 2f2f1b 2f2f2b "
"2f2f3b ] 2f3b ] 3b 4f:[ 4f1f:[ 4f1f1b 4f1f2b 4f1f3b ] 4f2f:[ 4f2f1b "
"4f2f2b 4f2f3b ] 4f3f:[ 4f3f1b 4f3f2b 4f3f3b ] ] 5b ");
bookmarks::test::AddNodesFromModelString(model, root, model_string);
// Validate initial model.
std::string actualModelString = bookmarks::test::ModelStringFromNode(root);
EXPECT_EQ(model_string, actualModelString);
// Pop up a folder menu.
BookmarkButton* toFolder = [bar_ buttonWithTitleEqualTo:@"4f"];
ASSERT_TRUE(toFolder);
[[toFolder target] performSelector:@selector(openBookmarkFolderFromButton:)
withObject:toFolder];
BookmarkBarFolderController* folderController = [bar_ folderController];
EXPECT_TRUE(folderController);
NSWindow* toWindow = [folderController window];
EXPECT_TRUE(toWindow);
// Drag a folder button to one of its children.
BookmarkButton* draggedButton = [bar_ buttonWithTitleEqualTo:@"4f"];
ASSERT_TRUE(draggedButton);
BookmarkButton* targetButton =
[folderController buttonWithTitleEqualTo:@"4f3f"];
ASSERT_TRUE(targetButton);
[folderController dragButton:draggedButton
to:[targetButton top]
copy:NO];
// The model should not have changed.
EXPECT_EQ(model_string, bookmarks::test::ModelStringFromNode(root));
// Check button spacing.
[folderController validateMenuSpacing];
}
TEST_F(BookmarkBarFolderControllerMenuTest, DragMoveChildToParent) {
BookmarkModel* model = BookmarkModelFactory::GetForProfile(profile());
const BookmarkNode* root = model->bookmark_bar_node();
const std::string model_string("1b 2f:[ 2f1b 2f2f:[ 2f2f1b 2f2f2b "
"2f2f3b ] 2f3b ] 3b 4f:[ 4f1f:[ 4f1f1b 4f1f2b 4f1f3b ] 4f2f:[ 4f2f1b "
"4f2f2b 4f2f3b ] 4f3f:[ 4f3f1b 4f3f2b 4f3f3b ] ] 5b ");
bookmarks::test::AddNodesFromModelString(model, root, model_string);
// Validate initial model.
std::string actualModelString = bookmarks::test::ModelStringFromNode(root);
EXPECT_EQ(model_string, actualModelString);
// Pop up a folder menu and a subfolder menu.
BookmarkButton* toFolder = [bar_ buttonWithTitleEqualTo:@"4f"];
ASSERT_TRUE(toFolder);
[[toFolder target] performSelector:@selector(openBookmarkFolderFromButton:)
withObject:toFolder];
BookmarkBarFolderController* folderController = [bar_ folderController];
EXPECT_TRUE(folderController);
BookmarkButton* toSubfolder =
[folderController buttonWithTitleEqualTo:@"4f2f"];
ASSERT_TRUE(toSubfolder);
[[toSubfolder target] performSelector:@selector(openBookmarkFolderFromButton:)
withObject:toSubfolder];
BookmarkBarFolderController* subfolderController =
[folderController folderController];
EXPECT_TRUE(subfolderController);
// Drag a subfolder bookmark to the parent folder.
BookmarkButton* draggedButton =
[subfolderController buttonWithTitleEqualTo:@"4f2f3b"];
ASSERT_TRUE(draggedButton);
BookmarkButton* targetButton =
[folderController buttonWithTitleEqualTo:@"4f2f"];
ASSERT_TRUE(targetButton);
[folderController dragButton:draggedButton
to:[targetButton top]
copy:NO];
// The button should have landed above "4f2f".
const std::string expected_string("1b 2f:[ 2f1b 2f2f:[ 2f2f1b 2f2f2b "
"2f2f3b ] 2f3b ] 3b 4f:[ 4f1f:[ 4f1f1b 4f1f2b 4f1f3b ] 4f2f3b 4f2f:[ "
"4f2f1b 4f2f2b ] 4f3f:[ 4f3f1b 4f3f2b 4f3f3b ] ] 5b ");
EXPECT_EQ(expected_string, bookmarks::test::ModelStringFromNode(root));
// Check button spacing.
[folderController validateMenuSpacing];
// The window should not have gone away.
EXPECT_TRUE([bar_ folderController]);
// The subfolder should have gone away.
EXPECT_FALSE([folderController folderController]);
}
TEST_F(BookmarkBarFolderControllerMenuTest, DragWindowResizing) {
BookmarkModel* model = BookmarkModelFactory::GetForProfile(profile());
const BookmarkNode* root = model->bookmark_bar_node();
const std::string model_string(
"a b:[ b1 b2 b3 ] reallyReallyLongBookmarkName c ");
bookmarks::test::AddNodesFromModelString(model, root, model_string);
// Validate initial model.
std::string actualModelString = bookmarks::test::ModelStringFromNode(root);
EXPECT_EQ(model_string, actualModelString);
// Pop up a folder menu.
BookmarkButton* toFolder = [bar_ buttonWithTitleEqualTo:@"b"];
ASSERT_TRUE(toFolder);
[[toFolder target] performSelector:@selector(openBookmarkFolderFromButton:)
withObject:toFolder];
BookmarkBarFolderController* folderController = [bar_ folderController];
EXPECT_TRUE(folderController);
NSWindow* toWindow = [folderController window];
EXPECT_TRUE(toWindow);
CGFloat oldWidth = NSWidth([toWindow frame]);
// Drag the bookmark with a long name to the folder.
BookmarkButton* draggedButton =
[bar_ buttonWithTitleEqualTo:@"reallyReallyLongBookmarkName"];
ASSERT_TRUE(draggedButton);
BookmarkButton* targetButton =
[folderController buttonWithTitleEqualTo:@"b1"];
ASSERT_TRUE(targetButton);
[folderController dragButton:draggedButton
to:[targetButton center]
copy:NO];
// Verify the model change.
const std::string expected_string(
"a b:[ b1 reallyReallyLongBookmarkName b2 b3 ] c ");
EXPECT_EQ(expected_string, bookmarks::test::ModelStringFromNode(root));
// Verify the window grew. Just test a reasonable width gain.
CGFloat newWidth = NSWidth([toWindow frame]);
EXPECT_LT(oldWidth + 30.0, newWidth);
}
TEST_F(BookmarkBarFolderControllerMenuTest, MoveRemoveAddButtons) {
BookmarkModel* model = BookmarkModelFactory::GetForProfile(profile());
const BookmarkNode* root = model->bookmark_bar_node();
const std::string model_string("1b 2f:[ 2f1b 2f2b 2f3b ] 3b 4b ");
bookmarks::test::AddNodesFromModelString(model, root, model_string);
// Validate initial model.
std::string actualModelString = bookmarks::test::ModelStringFromNode(root);
EXPECT_EQ(model_string, actualModelString);
// Pop up a folder menu.
BookmarkButton* toFolder = [bar_ buttonWithTitleEqualTo:@"2f"];
ASSERT_TRUE(toFolder);
[[toFolder target] performSelector:@selector(openBookmarkFolderFromButton:)
withObject:toFolder];
BookmarkBarFolderController* folder = [bar_ folderController];
EXPECT_TRUE(folder);
// Remember how many buttons are showing.
NSArray* buttons = [folder buttons];
NSUInteger oldDisplayedButtons = [buttons count];
// Move a button around a bit.
[folder moveButtonFromIndex:0 toIndex:2];
EXPECT_NSEQ(@"2f2b", [[buttons objectAtIndex:0] title]);
EXPECT_NSEQ(@"2f3b", [[buttons objectAtIndex:1] title]);
EXPECT_NSEQ(@"2f1b", [[buttons objectAtIndex:2] title]);
EXPECT_EQ(oldDisplayedButtons, [buttons count]);
[folder moveButtonFromIndex:2 toIndex:0];
EXPECT_NSEQ(@"2f1b", [[buttons objectAtIndex:0] title]);
EXPECT_NSEQ(@"2f2b", [[buttons objectAtIndex:1] title]);
EXPECT_NSEQ(@"2f3b", [[buttons objectAtIndex:2] title]);
EXPECT_EQ(oldDisplayedButtons, [buttons count]);
// Add a couple of buttons.
const BookmarkNode* node = root->GetChild(2); // Purloin an existing node.
[folder addButtonForNode:node atIndex:0];
EXPECT_NSEQ(@"3b", [[buttons objectAtIndex:0] title]);
EXPECT_NSEQ(@"2f1b", [[buttons objectAtIndex:1] title]);
EXPECT_NSEQ(@"2f2b", [[buttons objectAtIndex:2] title]);
EXPECT_NSEQ(@"2f3b", [[buttons objectAtIndex:3] title]);
EXPECT_EQ(oldDisplayedButtons + 1, [buttons count]);
node = root->GetChild(3);
[folder addButtonForNode:node atIndex:-1];
EXPECT_NSEQ(@"3b", [[buttons objectAtIndex:0] title]);
EXPECT_NSEQ(@"2f1b", [[buttons objectAtIndex:1] title]);
EXPECT_NSEQ(@"2f2b", [[buttons objectAtIndex:2] title]);
EXPECT_NSEQ(@"2f3b", [[buttons objectAtIndex:3] title]);
EXPECT_NSEQ(@"4b", [[buttons objectAtIndex:4] title]);
EXPECT_EQ(oldDisplayedButtons + 2, [buttons count]);
// Remove a couple of buttons.
[folder removeButton:4 animate:NO];
[folder removeButton:1 animate:NO];
EXPECT_NSEQ(@"3b", [[buttons objectAtIndex:0] title]);
EXPECT_NSEQ(@"2f2b", [[buttons objectAtIndex:1] title]);
EXPECT_NSEQ(@"2f3b", [[buttons objectAtIndex:2] title]);
EXPECT_EQ(oldDisplayedButtons, [buttons count]);
// Check button spacing.
[folder validateMenuSpacing];
}
TEST_F(BookmarkBarFolderControllerMenuTest, RemoveLastButtonOtherBookmarks) {
BookmarkModel* model = BookmarkModelFactory::GetForProfile(profile());
const BookmarkNode* otherBookmarks = model->other_node();
BookmarkButton* otherButton = [bar_ otherBookmarksButton];
ASSERT_TRUE(otherButton);
// Open the folder to get the folderController_.
[[otherButton target] openBookmarkFolderFromButton:otherButton];
BookmarkBarFolderController* folder = [bar_ folderController];
EXPECT_TRUE(folder);
// Initially there is only (empty) placeholder button, hence buttonCount
// should be 1.
NSArray* buttons = [folder buttons];
EXPECT_TRUE(buttons);
EXPECT_EQ(1U, [buttons count]);
// Add a new bookmark into 'Other bookmarks' folder.
model->AddURL(otherBookmarks, otherBookmarks->child_count(),
ASCIIToUTF16("TheOther"),
GURL("http://www.other.com"));
// buttonCount still should be 1, as we remove the (empty) placeholder button
// when adding a new button to an empty folder.
EXPECT_EQ(1U, [buttons count]);
// Now we have only 1 button; remove it so that 'Other bookmarks' folder
// is hidden.
[folder removeButton:0 animate:NO];
EXPECT_EQ(0U, [buttons count]);
// 'Other bookmarks' folder gets closed once we remove the last button. Hence
// folderController_ should be NULL.
EXPECT_FALSE([bar_ folderController]);
}
TEST_F(BookmarkBarFolderControllerMenuTest, ControllerForNode) {
BookmarkModel* model = BookmarkModelFactory::GetForProfile(profile());
const BookmarkNode* root = model->bookmark_bar_node();
const std::string model_string("1b 2f:[ 2f1b 2f2b ] 3b ");
bookmarks::test::AddNodesFromModelString(model, root, model_string);
// Validate initial model.
std::string actualModelString = bookmarks::test::ModelStringFromNode(root);
EXPECT_EQ(model_string, actualModelString);
// Find the main bar controller.
const void* expectedController = bar_;
const void* actualController = [bar_ controllerForNode:root];
EXPECT_EQ(expectedController, actualController);
// Pop up the folder menu.
BookmarkButton* targetFolder = [bar_ buttonWithTitleEqualTo:@"2f"];
ASSERT_TRUE(targetFolder);
[[targetFolder target]
performSelector:@selector(openBookmarkFolderFromButton:)
withObject:targetFolder];
BookmarkBarFolderController* folder = [bar_ folderController];
EXPECT_TRUE(folder);
// Find the folder controller using the folder controller.
const BookmarkNode* targetNode = root->GetChild(1);
expectedController = folder;
actualController = [bar_ controllerForNode:targetNode];
EXPECT_EQ(expectedController, actualController);
// Find the folder controller from the bar.
actualController = [folder controllerForNode:targetNode];
EXPECT_EQ(expectedController, actualController);
}
TEST_F(BookmarkBarFolderControllerMenuTest, MenuSizingAndScrollArrows) {
BookmarkModel* model = BookmarkModelFactory::GetForProfile(profile());
const BookmarkNode* root = model->bookmark_bar_node();
const std::string model_string("1b 2b 3b ");
bookmarks::test::AddNodesFromModelString(model, root, model_string);
// Validate initial model.
std::string actualModelString = bookmarks::test::ModelStringFromNode(root);
EXPECT_EQ(model_string, actualModelString);
const BookmarkNode* parent = model->bookmark_bar_node();
const BookmarkNode* folder = model->AddFolder(parent,
parent->child_count(),
ASCIIToUTF16("BIG"));
// Pop open the new folder window and verify it has one (empty) item.
BookmarkButton* button = [bar_ buttonWithTitleEqualTo:@"BIG"];
[[button target] performSelector:@selector(openBookmarkFolderFromButton:)
withObject:button];
BookmarkBarFolderController* folderController = [bar_ folderController];
EXPECT_TRUE(folderController);
NSWindow* folderWindow = [folderController window];
EXPECT_TRUE(folderWindow);
CGFloat expectedHeight = (CGFloat)bookmarks::kBookmarkFolderButtonHeight +
(2*bookmarks::kBookmarkVerticalPadding);
NSRect windowFrame = [folderWindow frame];
CGFloat windowHeight = NSHeight(windowFrame);
EXPECT_CGFLOAT_EQ(expectedHeight, windowHeight);
EXPECT_FALSE([folderController canScrollUp]);
EXPECT_FALSE([folderController canScrollDown]);
// Now add a real bookmark and reopen.
model->AddURL(folder, folder->child_count(), ASCIIToUTF16("a"),
GURL("http://a.com/"));
folderController = [bar_ folderController];
EXPECT_TRUE(folderController);
NSView* folderView = [folderController folderView];
EXPECT_TRUE(folderView);
NSRect menuFrame = [folderView frame];
NSView* visibleView = [folderController visibleView];
NSRect visibleFrame = [visibleView frame];
NSScrollView* scrollView = [folderController scrollView];
NSRect scrollFrame = [scrollView frame];
// Determine the margins between the scroll frame and the visible frame.
CGFloat widthDelta = NSWidth(visibleFrame) - NSWidth(scrollFrame);
CGFloat menuHeight = NSHeight(menuFrame);
EXPECT_CGFLOAT_EQ(expectedHeight, menuHeight);
CGFloat scrollerWidth = NSWidth(scrollFrame);
button = [folderController buttonWithTitleEqualTo:@"a"];
CGFloat buttonWidth = NSWidth([button frame]);
EXPECT_CGFLOAT_EQ(scrollerWidth, buttonWidth);
CGFloat visibleWidth = NSWidth(visibleFrame);
EXPECT_CGFLOAT_EQ(visibleWidth - widthDelta, buttonWidth);
EXPECT_LT(scrollerWidth, NSWidth([folderView frame]));
// Add a wider bookmark and make sure the button widths match.
int reallyWideButtonNumber = folder->child_count();
model->AddURL(folder, reallyWideButtonNumber,
ASCIIToUTF16("A really, really, really, really, really, "
"really long name"),
GURL("http://www.google.com/a"));
BookmarkButton* bigButton =
[folderController buttonWithTitleEqualTo:
@"A really, really, really, really, really, really long name"];
EXPECT_TRUE(bigButton);
CGFloat buttonWidthB = NSWidth([bigButton frame]);
EXPECT_LT(buttonWidth, buttonWidthB);
// Add a bunch of bookmarks until the window becomes scrollable, then check
// for a scroll up arrow.
NSUInteger tripWire = 0; // Prevent a runaway.
while (![folderController canScrollUp] && ++tripWire < 1000) {
model->AddURL(folder, folder->child_count(), ASCIIToUTF16("B"),
GURL("http://b.com/"));
}
EXPECT_TRUE([folderController canScrollUp]);
// Remove one bookmark and make sure the scroll down arrow has been removed.
// We'll remove the really long node so we can see if the buttons get resized.
scrollerWidth = NSWidth([folderView frame]);
buttonWidth = NSWidth([button frame]);
model->Remove(folder, reallyWideButtonNumber);
EXPECT_FALSE([folderController canScrollUp]);
EXPECT_FALSE([folderController canScrollDown]);
// Check the size. It should have reduced.
EXPECT_GT(scrollerWidth, NSWidth([folderView frame]));
EXPECT_GT(buttonWidth, NSWidth([button frame]));
// Check button spacing.
[folderController validateMenuSpacing];
}
// See http://crbug.com/46101
TEST_F(BookmarkBarFolderControllerMenuTest, HoverThenDeleteBookmark) {
BookmarkModel* model = BookmarkModelFactory::GetForProfile(profile());
const BookmarkNode* root = model->bookmark_bar_node();
const BookmarkNode* folder = model->AddFolder(root,
root->child_count(),
ASCIIToUTF16("BIG"));
for (int i = 0; i < kLotsOfNodesCount; i++)
model->AddURL(folder, folder->child_count(), ASCIIToUTF16("kid"),
GURL("http://kid.com/smile"));
// Pop open the new folder window and hover one of its kids.
BookmarkButton* button = [bar_ buttonWithTitleEqualTo:@"BIG"];
[[button target] performSelector:@selector(openBookmarkFolderFromButton:)
withObject:button];
BookmarkBarFolderController* bbfc = [bar_ folderController];
NSArray* buttons = [bbfc buttons];
// Hover over a button and verify that it is now known.
button = [buttons objectAtIndex:3];
BookmarkButton* buttonThatMouseIsIn = [bbfc buttonThatMouseIsIn];
EXPECT_FALSE(buttonThatMouseIsIn);
[bbfc mouseEnteredButton:button event:nil];
buttonThatMouseIsIn = [bbfc buttonThatMouseIsIn];
EXPECT_EQ(button, buttonThatMouseIsIn);
// Delete the bookmark and verify that it is now not known.
model->Remove(folder, 3);
buttonThatMouseIsIn = [bbfc buttonThatMouseIsIn];
EXPECT_FALSE(buttonThatMouseIsIn);
}
// Just like a BookmarkBarFolderController but intercedes when providing
// pasteboard drag data.
@interface BookmarkBarFolderControllerDragData : BookmarkBarFolderController {
const BookmarkNode* dragDataNode_; // Weak
}
- (void)setDragDataNode:(const BookmarkNode*)node;
@end
@implementation BookmarkBarFolderControllerDragData
- (id)initWithParentButton:(BookmarkButton*)button
parentController:(BookmarkBarFolderController*)parentController
barController:(BookmarkBarController*)barController
profile:(Profile*)profile {
if ((self = [super initWithParentButton:button
parentController:parentController
barController:barController
profile:profile])) {
dragDataNode_ = NULL;
}
return self;
}
- (void)setDragDataNode:(const BookmarkNode*)node {
dragDataNode_ = node;
}
- (std::vector<const BookmarkNode*>)retrieveBookmarkNodeData {
std::vector<const BookmarkNode*> dragDataNodes;
if(dragDataNode_) {
dragDataNodes.push_back(dragDataNode_);
}
return dragDataNodes;
}
@end
TEST_F(BookmarkBarFolderControllerMenuTest, DragBookmarkData) {
BookmarkModel* model = BookmarkModelFactory::GetForProfile(profile());
const BookmarkNode* root = model->bookmark_bar_node();
const std::string model_string("1b 2f:[ 2f1b 2f2f:[ 2f2f1b 2f2f2b 2f2f3b ] "
"2f3b ] 3b 4b ");
bookmarks::test::AddNodesFromModelString(model, root, model_string);
const BookmarkNode* other = model->other_node();
const std::string other_string("O1b O2b O3f:[ O3f1b O3f2f ] "
"O4f:[ O4f1b O4f2f ] 05b ");
bookmarks::test::AddNodesFromModelString(model, other, other_string);
// Validate initial model.
std::string actual = bookmarks::test::ModelStringFromNode(root);
EXPECT_EQ(model_string, actual);
actual = bookmarks::test::ModelStringFromNode(other);
EXPECT_EQ(other_string, actual);
// Pop open a folder.
BookmarkButton* button = [bar_ buttonWithTitleEqualTo:@"2f"];
base::scoped_nsobject<BookmarkBarFolderControllerDragData> folderController;
folderController.reset([[BookmarkBarFolderControllerDragData alloc]
initWithParentButton:button
parentController:nil
barController:bar_
profile:profile()]);
BookmarkButton* targetButton =
[folderController buttonWithTitleEqualTo:@"2f1b"];
ASSERT_TRUE(targetButton);
// Gen up some dragging data.
const BookmarkNode* newNode = other->GetChild(2);
[folderController setDragDataNode:newNode];
base::scoped_nsobject<FakedDragInfo> dragInfo([[FakedDragInfo alloc] init]);
[dragInfo setDropLocation:[targetButton top]];
[folderController dragBookmarkData:(id<NSDraggingInfo>)dragInfo.get()];
// Verify the model.
const std::string expected("1b 2f:[ O3f:[ O3f1b O3f2f ] 2f1b 2f2f:[ 2f2f1b "
"2f2f2b 2f2f3b ] 2f3b ] 3b 4b ");
actual = bookmarks::test::ModelStringFromNode(root);
EXPECT_EQ(expected, actual);
// Now drag over a folder button.
targetButton = [folderController buttonWithTitleEqualTo:@"2f2f"];
ASSERT_TRUE(targetButton);
newNode = other->GetChild(2); // Should be O4f.
EXPECT_EQ(newNode->GetTitle(), ASCIIToUTF16("O4f"));
[folderController setDragDataNode:newNode];
[dragInfo setDropLocation:[targetButton center]];
[folderController dragBookmarkData:(id<NSDraggingInfo>)dragInfo.get()];
// Verify the model.
const std::string expectedA("1b 2f:[ O3f:[ O3f1b O3f2f ] 2f1b 2f2f:[ "
"2f2f1b 2f2f2b 2f2f3b O4f:[ O4f1b O4f2f ] ] "
"2f3b ] 3b 4b ");
actual = bookmarks::test::ModelStringFromNode(root);
EXPECT_EQ(expectedA, actual);
// Check button spacing.
[folderController validateMenuSpacing];
}
TEST_F(BookmarkBarFolderControllerMenuTest, DragBookmarkDataToTrash) {
BookmarkModel* model = BookmarkModelFactory::GetForProfile(profile());
const BookmarkNode* root = model->bookmark_bar_node();
const std::string model_string("1b 2f:[ 2f1b 2f2f:[ 2f2f1b 2f2f2b 2f2f3b ] "
"2f3b ] 3b 4b ");
bookmarks::test::AddNodesFromModelString(model, root, model_string);
// Validate initial model.
std::string actual = bookmarks::test::ModelStringFromNode(root);
EXPECT_EQ(model_string, actual);
const BookmarkNode* folderNode = root->GetChild(1);
int oldFolderChildCount = folderNode->child_count();
// Pop open a folder.
BookmarkButton* button = [bar_ buttonWithTitleEqualTo:@"2f"];
base::scoped_nsobject<BookmarkBarFolderControllerDragData> folderController;
folderController.reset([[BookmarkBarFolderControllerDragData alloc]
initWithParentButton:button
parentController:nil
barController:bar_
profile:profile()]);
// Drag a button to the trash.
BookmarkButton* buttonToDelete =
[folderController buttonWithTitleEqualTo:@"2f1b"];
ASSERT_TRUE(buttonToDelete);
EXPECT_TRUE([folderController canDragBookmarkButtonToTrash:buttonToDelete]);
[folderController didDragBookmarkToTrash:buttonToDelete];
// There should be one less button in the folder.
int newFolderChildCount = folderNode->child_count();
EXPECT_EQ(oldFolderChildCount - 1, newFolderChildCount);
// Verify the model.
const std::string expected("1b 2f:[ 2f2f:[ 2f2f1b 2f2f2b 2f2f3b ] "
"2f3b ] 3b 4b ");
actual = bookmarks::test::ModelStringFromNode(root);
EXPECT_EQ(expected, actual);
// Check button spacing.
[folderController validateMenuSpacing];
}
TEST_F(BookmarkBarFolderControllerMenuTest, AddURLs) {
BookmarkModel* model = BookmarkModelFactory::GetForProfile(profile());
const BookmarkNode* root = model->bookmark_bar_node();
const std::string model_string("1b 2f:[ 2f1b 2f2f:[ 2f2f1b 2f2f2b 2f2f3b ] "
"2f3b ] 3b 4b ");
bookmarks::test::AddNodesFromModelString(model, root, model_string);
// Validate initial model.
std::string actual = bookmarks::test::ModelStringFromNode(root);
EXPECT_EQ(model_string, actual);
// Pop open a folder.
BookmarkButton* button = [bar_ buttonWithTitleEqualTo:@"2f"];
[[button target] performSelector:@selector(openBookmarkFolderFromButton:)
withObject:button];
BookmarkBarFolderController* folderController = [bar_ folderController];
EXPECT_TRUE(folderController);
NSArray* buttons = [folderController buttons];
EXPECT_TRUE(buttons);
// Remember how many buttons are showing.
int oldDisplayedButtons = [buttons count];
BookmarkButton* targetButton =
[folderController buttonWithTitleEqualTo:@"2f1b"];
ASSERT_TRUE(targetButton);
NSArray* urls = [NSArray arrayWithObjects: @"http://www.a.com/",
@"http://www.b.com/", nil];
NSArray* titles = [NSArray arrayWithObjects: @"SiteA", @"SiteB", nil];
[folderController addURLs:urls withTitles:titles at:[targetButton top]];
// There should two more buttons in the folder.
int newDisplayedButtons = [buttons count];
EXPECT_EQ(oldDisplayedButtons + 2, newDisplayedButtons);
// Verify the model.
const std::string expected("1b 2f:[ SiteA SiteB 2f1b 2f2f:[ 2f2f1b 2f2f2b "
"2f2f3b ] 2f3b ] 3b 4b ");
actual = bookmarks::test::ModelStringFromNode(root);
EXPECT_EQ(expected, actual);
// Check button spacing.
[folderController validateMenuSpacing];
}
TEST_F(BookmarkBarFolderControllerMenuTest, DropPositionIndicator) {
BookmarkModel* model = BookmarkModelFactory::GetForProfile(profile());
const BookmarkNode* root = model->bookmark_bar_node();
const std::string model_string("1b 2f:[ 2f1b 2f2f:[ 2f2f1b 2f2f2b 2f2f3b ] "
"2f3b ] 3b 4b ");
bookmarks::test::AddNodesFromModelString(model, root, model_string);
// Validate initial model.
std::string actual = bookmarks::test::ModelStringFromNode(root);
EXPECT_EQ(model_string, actual);
// Pop open the folder.
BookmarkButton* button = [bar_ buttonWithTitleEqualTo:@"2f"];
[[button target] performSelector:@selector(openBookmarkFolderFromButton:)
withObject:button];
BookmarkBarFolderController* folder = [bar_ folderController];
EXPECT_TRUE(folder);
// Test a series of points starting at the top of the folder.
const CGFloat yOffset = 0.5 * bookmarks::kBookmarkVerticalPadding;
BookmarkButton* targetButton = [folder buttonWithTitleEqualTo:@"2f1b"];
ASSERT_TRUE(targetButton);
NSPoint targetPoint = [targetButton top];
CGFloat pos = [folder indicatorPosForDragToPoint:targetPoint];
EXPECT_CGFLOAT_EQ(targetPoint.y + yOffset, pos);
pos = [folder indicatorPosForDragToPoint:[targetButton bottom]];
targetButton = [folder buttonWithTitleEqualTo:@"2f2f"];
EXPECT_CGFLOAT_EQ([targetButton top].y + yOffset, pos);
pos = [folder indicatorPosForDragToPoint:NSMakePoint(10,0)];
targetButton = [folder buttonWithTitleEqualTo:@"2f3b"];
EXPECT_CGFLOAT_EQ([targetButton bottom].y - yOffset, pos);
}
@interface BookmarkBarControllerNoDelete : BookmarkBarController
- (IBAction)deleteBookmark:(id)sender;
@end
@implementation BookmarkBarControllerNoDelete
- (IBAction)deleteBookmark:(id)sender {
// NOP
}
@end
class BookmarkBarFolderControllerClosingTest : public
BookmarkBarFolderControllerMenuTest {
public:
void SetUp() override {
BookmarkBarFolderControllerMenuTest::SetUp();
ASSERT_TRUE(browser());
bar_.reset([[BookmarkBarControllerNoDelete alloc]
initWithBrowser:browser()
initialWidth:NSWidth([parent_view_ frame])
delegate:nil
resizeDelegate:resizeDelegate_.get()]);
InstallAndToggleBar(bar_.get());
}
};
TEST_F(BookmarkBarFolderControllerClosingTest, DeleteClosesFolder) {
BookmarkModel* model = BookmarkModelFactory::GetForProfile(profile());
const BookmarkNode* root = model->bookmark_bar_node();
const std::string model_string("1b 2f:[ 2f1b 2f2f:[ 2f2f1b 2f2f2b ] "
"2f3b ] 3b ");
bookmarks::test::AddNodesFromModelString(model, root, model_string);
// Validate initial model.
std::string actualModelString = bookmarks::test::ModelStringFromNode(root);
EXPECT_EQ(model_string, actualModelString);
// Open the folder menu and submenu.
BookmarkButton* target = [bar_ buttonWithTitleEqualTo:@"2f"];
ASSERT_TRUE(target);
[[target target] performSelector:@selector(openBookmarkFolderFromButton:)
withObject:target];
BookmarkBarFolderController* folder = [bar_ folderController];
EXPECT_TRUE(folder);
BookmarkButton* subTarget = [folder buttonWithTitleEqualTo:@"2f2f"];
ASSERT_TRUE(subTarget);
[[subTarget target] performSelector:@selector(openBookmarkFolderFromButton:)
withObject:subTarget];
BookmarkBarFolderController* subFolder = [folder folderController];
EXPECT_TRUE(subFolder);
// Delete the folder node and verify the window closed down by looking
// for its controller again.
DeleteBookmark([folder parentButton], profile());
EXPECT_FALSE([folder folderController]);
}
// TODO(jrg): draggingEntered: and draggingExited: trigger timers so
// they are hard to test. Factor out "fire timers" into routines
// which can be overridden to fire immediately to make behavior
// confirmable.
// There is a similar problem with mouseEnteredButton: and
// mouseExitedButton:.
|