1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
|
// Copyright 2013 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#import "chrome/browser/ui/cocoa/extensions/extension_action_context_menu_controller.h"
#include "base/files/file_path.h"
#include "base/json/json_file_value_serializer.h"
#include "base/prefs/pref_service.h"
#include "chrome/browser/extensions/browser_action_test_util.h"
#include "chrome/browser/extensions/extension_action.h"
#include "chrome/browser/extensions/extension_action_manager.h"
#include "chrome/browser/extensions/extension_browsertest.h"
#include "chrome/browser/extensions/extension_tab_util.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/cocoa/browser_window_cocoa.h"
#include "chrome/browser/ui/cocoa/browser_window_controller.h"
#import "chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h"
#import "chrome/browser/ui/cocoa/run_loop_testing.h"
#include "chrome/browser/ui/cocoa/toolbar/toolbar_controller.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
#include "chrome/common/chrome_paths.h"
#include "chrome/common/pref_names.h"
#include "chrome/grit/generated_resources.h"
#include "content/public/browser/devtools_agent_host.h"
#include "content/public/test/test_utils.h"
#include "extensions/common/extension.h"
#include "ui/base/l10n/l10n_util_mac.h"
using extensions::Extension;
namespace {
NSMenuItem* GetInspectItem(NSMenu* menu) {
return [menu itemWithTitle:
l10n_util::GetNSStringWithFixup(IDS_EXTENSION_ACTION_INSPECT_POPUP)];
}
} // namespace
class ExtensionActionContextMenuControllerTest : public ExtensionBrowserTest {
public:
ExtensionActionContextMenuControllerTest() : extension_(NULL), action_(NULL) {
}
protected:
void SetupPageAction() {
extension_ = InstallExtension(
test_data_dir_.AppendASCII("browsertest")
.AppendASCII("page_action_popup"),
1);
EXPECT_TRUE(extension_);
extensions::ExtensionActionManager* action_manager =
extensions::ExtensionActionManager::Get(browser()->profile());
action_ = action_manager->GetPageAction(*extension_);
EXPECT_TRUE(action_);
content::WebContents* contents =
browser()->tab_strip_model()->GetActiveWebContents();
action_->SetIsVisible(extensions::ExtensionTabUtil::GetTabId(contents),
true);
BrowserWindowCocoa* window =
static_cast<BrowserWindowCocoa*>(browser()->window());
ToolbarController* toolbarController =
[window->cocoa_controller() toolbarController];
LocationBarViewMac* locationBarView =
[toolbarController locationBarBridge];
locationBarView->Update(NULL);
}
const Extension* extension_;
ExtensionAction* action_;
};
IN_PROC_BROWSER_TEST_F(ExtensionActionContextMenuControllerTest, BasicTest) {
SetupPageAction();
base::scoped_nsobject<ExtensionActionContextMenuController> controller(
[[ExtensionActionContextMenuController alloc] initWithExtension:extension_
browser:browser()
extensionAction:action_]);
PrefService* service = browser()->profile()->GetPrefs();
bool original = service->GetBoolean(prefs::kExtensionsUIDeveloperMode);
service->SetBoolean(prefs::kExtensionsUIDeveloperMode, true);
base::scoped_nsobject<NSMenu> menu([[NSMenu alloc] initWithTitle:@""]);
[controller populateMenu:menu];
EXPECT_GT([menu numberOfItems], 0);
EXPECT_TRUE(GetInspectItem(menu));
service->SetBoolean(prefs::kExtensionsUIDeveloperMode, false);
[menu removeAllItems];
[controller populateMenu:menu];
EXPECT_GT([menu numberOfItems], 0);
EXPECT_FALSE(GetInspectItem(menu));
service->SetBoolean(prefs::kExtensionsUIDeveloperMode, original);
}
// Test that browser action context menus work. Browser actions have their
// menus created during browser initialization, when there is no tab. This
// test simulates that and checks the menu is operational.
IN_PROC_BROWSER_TEST_F(ExtensionActionContextMenuControllerTest,
BrowserAction) {
extension_ =
InstallExtension(test_data_dir_.AppendASCII("browsertest").AppendASCII(
"browser_action_popup"),
1);
EXPECT_TRUE(extension_);
extensions::ExtensionActionManager* action_manager =
extensions::ExtensionActionManager::Get(browser()->profile());
action_ = action_manager->GetBrowserAction(*extension_);
EXPECT_TRUE(action_);
Browser* empty_browser(
new Browser(Browser::CreateParams(browser()->profile(),
browser()->host_desktop_type())));
base::scoped_nsobject<ExtensionActionContextMenuController> controller(
[[ExtensionActionContextMenuController alloc]
initWithExtension:extension_
browser:empty_browser
extensionAction:action_]);
base::scoped_nsobject<NSMenu> menu([[NSMenu alloc] initWithTitle:@""]);
[controller populateMenu:menu];
EXPECT_GT([menu numberOfItems], 0);
// Close the empty browser. Can't just free it directly because there are
// dangling references in the various native controllers that must be
// cleaned up first.
NSWindow* window = empty_browser->window()->GetNativeWindow();
BrowserWindowController* wc =
[BrowserWindowController browserWindowControllerForWindow:window];
ASSERT_TRUE(wc != NULL);
[wc destroyBrowser];
// Wait for the browser to be fully destroyed, so that the browsertest doesn't
// also try to close it.
base::RunLoop().RunUntilIdle();
chrome::testing::NSRunLoopRunAllPending();
}
namespace {
class DevToolsAttachedObserver {
public:
DevToolsAttachedObserver(const base::Closure& callback)
: callback_(callback),
devtools_callback_(base::Bind(
&DevToolsAttachedObserver::OnDevToolsStateChanged,
base::Unretained(this))) {
content::DevToolsAgentHost::AddAgentStateCallback(devtools_callback_);
}
~DevToolsAttachedObserver() {
content::DevToolsAgentHost::RemoveAgentStateCallback(devtools_callback_);
}
void OnDevToolsStateChanged(content::DevToolsAgentHost*, bool attached) {
if (attached)
callback_.Run();
}
private:
base::Closure callback_;
base::Callback<void(content::DevToolsAgentHost*, bool)> devtools_callback_;
DISALLOW_COPY_AND_ASSIGN(DevToolsAttachedObserver);
};
} // namespace
IN_PROC_BROWSER_TEST_F(
ExtensionActionContextMenuControllerTest, DISABLED_RunInspectPopup) {
SetupPageAction();
base::scoped_nsobject<ExtensionActionContextMenuController> controller(
[[ExtensionActionContextMenuController alloc] initWithExtension:extension_
browser:browser()
extensionAction:action_]);
PrefService* service = browser()->profile()->GetPrefs();
bool original = service->GetBoolean(prefs::kExtensionsUIDeveloperMode);
service->SetBoolean(prefs::kExtensionsUIDeveloperMode, true);
base::scoped_nsobject<NSMenu> menu([[NSMenu alloc] initWithTitle:@""]);
[controller populateMenu:menu];
EXPECT_GT([menu numberOfItems], 0);
NSMenuItem* inspectItem = GetInspectItem(menu);
EXPECT_TRUE(inspectItem);
scoped_refptr<content::MessageLoopRunner> loop_runner(
new content::MessageLoopRunner);
DevToolsAttachedObserver observer(loop_runner->QuitClosure());
[NSApp sendAction:[inspectItem action]
to:[inspectItem target]
from:inspectItem];
loop_runner->Run();
service->SetBoolean(prefs::kExtensionsUIDeveloperMode, original);
}
|
