1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
|
// Copyright (c) 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#import <Cocoa/Cocoa.h>
#import "base/mac/scoped_nsobject.h"
#include "base/strings/sys_string_conversions.h"
#include "base/strings/utf_string_conversions.h"
#import "chrome/browser/extensions/extension_install_prompt.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/cocoa/cocoa_profile_test.h"
#import "chrome/browser/ui/cocoa/extensions/extension_install_prompt_test_utils.h"
#import "chrome/browser/ui/cocoa/extensions/extension_install_view_controller.h"
#include "extensions/common/extension.h"
#include "testing/gtest/include/gtest/gtest.h"
#import "testing/gtest_mac.h"
using extensions::Extension;
// Base class for our tests.
class ExtensionInstallViewControllerTest : public CocoaProfileTest {
public:
ExtensionInstallViewControllerTest() {
extension_ = chrome::LoadInstallPromptExtension();
}
protected:
scoped_refptr<extensions::Extension> extension_;
};
// Test that we can load the two kinds of prompts correctly, that the outlets
// are hooked up, and that the dialog calls cancel when cancel is pressed.
TEST_F(ExtensionInstallViewControllerTest, BasicsNormalCancel) {
chrome::MockExtensionInstallPromptDelegate delegate;
scoped_refptr<ExtensionInstallPrompt::Prompt> prompt =
chrome::BuildExtensionInstallPrompt(extension_.get());
ExtensionInstallPrompt::PermissionsType type =
ExtensionInstallPrompt::PermissionsType::REGULAR_PERMISSIONS;
std::vector<base::string16> permissions;
permissions.push_back(base::UTF8ToUTF16("warning 1"));
prompt->SetPermissions(permissions, type);
// No details provided with this permission.
std::vector<base::string16> details;
details.push_back(base::string16());
prompt->SetPermissionsDetails(details, type);
base::scoped_nsobject<ExtensionInstallViewController> controller(
[[ExtensionInstallViewController alloc] initWithProfile:profile()
navigator:browser()
delegate:&delegate
prompt:prompt]);
[controller view]; // Force nib load.
// Test the right nib loaded.
EXPECT_NSEQ(@"ExtensionInstallPrompt", [controller nibName]);
// Check all the controls.
// Make sure everything is non-nil, and that the fields that are
// auto-translated don't start with a caret (that would indicate that they
// were not translated).
EXPECT_TRUE([controller iconView]);
EXPECT_TRUE([[controller iconView] image]);
EXPECT_TRUE([controller titleField]);
EXPECT_NE(0u, [[[controller titleField] stringValue] length]);
NSOutlineView* outlineView = [controller outlineView];
EXPECT_TRUE(outlineView);
EXPECT_EQ(2, [outlineView numberOfRows]);
EXPECT_NSEQ(base::SysUTF16ToNSString(prompt->GetPermission(0, type)),
[[outlineView dataSource] outlineView:outlineView
objectValueForTableColumn:nil
byItem:[outlineView itemAtRow:1]]);
EXPECT_TRUE([controller cancelButton]);
EXPECT_NE(0u, [[[controller cancelButton] stringValue] length]);
EXPECT_NE('^', [[[controller cancelButton] stringValue] characterAtIndex:0]);
EXPECT_TRUE([controller okButton]);
EXPECT_NE(0u, [[[controller okButton] stringValue] length]);
EXPECT_NE('^', [[[controller okButton] stringValue] characterAtIndex:0]);
// Test that cancel calls our delegate.
[controller cancel:nil];
EXPECT_EQ(1, delegate.abort_count());
EXPECT_EQ(0, delegate.proceed_count());
}
TEST_F(ExtensionInstallViewControllerTest, BasicsNormalOK) {
chrome::MockExtensionInstallPromptDelegate delegate;
scoped_refptr<ExtensionInstallPrompt::Prompt> prompt =
chrome::BuildExtensionInstallPrompt(extension_.get());
ExtensionInstallPrompt::PermissionsType type =
ExtensionInstallPrompt::PermissionsType::REGULAR_PERMISSIONS;
std::vector<base::string16> permissions;
permissions.push_back(base::UTF8ToUTF16("warning 1"));
prompt->SetPermissions(permissions, type);
// No details provided with this permission.
std::vector<base::string16> details;
details.push_back(base::string16());
prompt->SetPermissionsDetails(details, type);
base::scoped_nsobject<ExtensionInstallViewController> controller(
[[ExtensionInstallViewController alloc] initWithProfile:profile()
navigator:browser()
delegate:&delegate
prompt:prompt]);
[controller view]; // Force nib load.
[controller ok:nil];
EXPECT_EQ(0, delegate.abort_count());
EXPECT_EQ(1, delegate.proceed_count());
}
// Test that controls get repositioned when there are two warnings vs one
// warning.
TEST_F(ExtensionInstallViewControllerTest, MultipleWarnings) {
chrome::MockExtensionInstallPromptDelegate delegate1;
chrome::MockExtensionInstallPromptDelegate delegate2;
scoped_refptr<ExtensionInstallPrompt::Prompt> one_warning_prompt =
chrome::BuildExtensionInstallPrompt(extension_.get());
ExtensionInstallPrompt::PermissionsType type =
ExtensionInstallPrompt::PermissionsType::REGULAR_PERMISSIONS;
std::vector<base::string16> permissions;
permissions.push_back(base::UTF8ToUTF16("warning 1"));
one_warning_prompt->SetPermissions(permissions, type);
// No details provided with this permission.
std::vector<base::string16> details;
details.push_back(base::string16());
one_warning_prompt->SetPermissionsDetails(details, type);
scoped_refptr<ExtensionInstallPrompt::Prompt> two_warnings_prompt =
chrome::BuildExtensionInstallPrompt(extension_.get());
permissions.push_back(base::UTF8ToUTF16("warning 2"));
two_warnings_prompt->SetPermissions(permissions, type);
// No details provided with this permission.
details.push_back(base::string16());
two_warnings_prompt->SetPermissionsDetails(details, type);
base::scoped_nsobject<ExtensionInstallViewController> controller1(
[[ExtensionInstallViewController alloc]
initWithProfile:profile()
navigator:browser()
delegate:&delegate1
prompt:one_warning_prompt]);
[controller1 view]; // Force nib load.
base::scoped_nsobject<ExtensionInstallViewController> controller2(
[[ExtensionInstallViewController alloc]
initWithProfile:profile()
navigator:browser()
delegate:&delegate2
prompt:two_warnings_prompt]);
[controller2 view]; // Force nib load.
// Test control positioning. We don't test exact positioning because we don't
// want this to depend on string details and localization. But we do know the
// relative effect that adding a second warning should have on the layout.
ASSERT_LT([[controller1 view] frame].size.height,
[[controller2 view] frame].size.height);
ASSERT_LT([[controller1 view] frame].size.height,
[[controller2 view] frame].size.height);
}
// Test that we can load the skinny prompt correctly, and that the outlets are
// are hooked up.
TEST_F(ExtensionInstallViewControllerTest, BasicsSkinny) {
chrome::MockExtensionInstallPromptDelegate delegate;
// No warnings should trigger skinny prompt.
scoped_refptr<ExtensionInstallPrompt::Prompt> no_warnings_prompt =
chrome::BuildExtensionInstallPrompt(extension_.get());
base::scoped_nsobject<ExtensionInstallViewController> controller(
[[ExtensionInstallViewController alloc]
initWithProfile:profile()
navigator:browser()
delegate:&delegate
prompt:no_warnings_prompt]);
[controller view]; // Force nib load.
// Test the right nib loaded.
EXPECT_NSEQ(@"ExtensionInstallPromptNoWarnings", [controller nibName]);
// Check all the controls.
// In the skinny prompt, only the icon, title and buttons are non-nill.
// Everything else is nil.
EXPECT_TRUE([controller iconView]);
EXPECT_TRUE([[controller iconView] image]);
EXPECT_TRUE([controller titleField]);
EXPECT_NE(0u, [[[controller titleField] stringValue] length]);
EXPECT_TRUE([controller cancelButton]);
EXPECT_NE(0u, [[[controller cancelButton] stringValue] length]);
EXPECT_NE('^', [[[controller cancelButton] stringValue] characterAtIndex:0]);
EXPECT_TRUE([controller okButton]);
EXPECT_NE(0u, [[[controller okButton] stringValue] length]);
EXPECT_NE('^', [[[controller okButton] stringValue] characterAtIndex:0]);
EXPECT_FALSE([controller outlineView]);
}
// Test that we can load the inline prompt correctly, and that the outlets are
// are hooked up.
TEST_F(ExtensionInstallViewControllerTest, BasicsInline) {
chrome::MockExtensionInstallPromptDelegate delegate;
// No warnings should trigger skinny prompt.
scoped_refptr<ExtensionInstallPrompt::Prompt> inline_prompt =
new ExtensionInstallPrompt::Prompt(
ExtensionInstallPrompt::INLINE_INSTALL_PROMPT);
inline_prompt->SetWebstoreData("1,000", true, 3.5, 200);
inline_prompt->set_extension(extension_.get());
inline_prompt->set_icon(chrome::LoadInstallPromptIcon());
base::scoped_nsobject<ExtensionInstallViewController> controller(
[[ExtensionInstallViewController alloc] initWithProfile:profile()
navigator:browser()
delegate:&delegate
prompt:inline_prompt]);
[controller view]; // Force nib load.
// Test the right nib loaded.
EXPECT_NSEQ(@"ExtensionInstallPromptWebstoreData", [controller nibName]);
// Check all the controls.
EXPECT_TRUE([controller iconView]);
EXPECT_TRUE([[controller iconView] image]);
EXPECT_TRUE([controller titleField]);
EXPECT_NE(0u, [[[controller titleField] stringValue] length]);
EXPECT_TRUE([controller cancelButton]);
EXPECT_NE(0u, [[[controller cancelButton] stringValue] length]);
EXPECT_NE('^', [[[controller cancelButton] stringValue] characterAtIndex:0]);
EXPECT_TRUE([controller okButton]);
EXPECT_NE(0u, [[[controller okButton] stringValue] length]);
EXPECT_NE('^', [[[controller okButton] stringValue] characterAtIndex:0]);
EXPECT_TRUE([controller ratingStars]);
EXPECT_EQ(5u, [[[controller ratingStars] subviews] count]);
EXPECT_TRUE([controller ratingCountField]);
EXPECT_NE(0u, [[[controller ratingCountField] stringValue] length]);
EXPECT_TRUE([controller userCountField]);
EXPECT_NE(0u, [[[controller userCountField] stringValue] length]);
EXPECT_TRUE([controller storeLinkButton]);
EXPECT_NE(0u, [[[controller storeLinkButton] stringValue] length]);
EXPECT_NE('^',
[[[controller storeLinkButton] stringValue] characterAtIndex:0]);
// Though we have no permissions warnings, these should still be hooked up,
// just invisible.
EXPECT_TRUE([controller outlineView]);
EXPECT_TRUE([[[controller outlineView] enclosingScrollView] isHidden]);
EXPECT_TRUE([controller warningsSeparator]);
EXPECT_TRUE([[controller warningsSeparator] isHidden]);
}
TEST_F(ExtensionInstallViewControllerTest, PostInstallPermissionsPrompt) {
chrome::MockExtensionInstallPromptDelegate delegate;
scoped_refptr<ExtensionInstallPrompt::Prompt> prompt =
chrome::BuildExtensionPostInstallPermissionsPrompt(extension_.get());
ExtensionInstallPrompt::PermissionsType type =
ExtensionInstallPrompt::PermissionsType::REGULAR_PERMISSIONS;
std::vector<base::string16> permissions;
permissions.push_back(base::UTF8ToUTF16("warning 1"));
prompt->SetPermissions(permissions, type);
// No details provided with this permission.
std::vector<base::string16> details;
details.push_back(base::string16());
prompt->SetPermissionsDetails(details, type);
base::scoped_nsobject<ExtensionInstallViewController> controller(
[[ExtensionInstallViewController alloc] initWithProfile:profile()
navigator:browser()
delegate:&delegate
prompt:prompt]);
[controller view]; // Force nib load.
EXPECT_TRUE([controller cancelButton]);
EXPECT_FALSE([controller okButton]);
[controller cancel:nil];
EXPECT_EQ(1, delegate.abort_count());
}
// Test that permission details show up.
TEST_F(ExtensionInstallViewControllerTest, PermissionsDetails) {
chrome::MockExtensionInstallPromptDelegate delegate;
scoped_refptr<ExtensionInstallPrompt::Prompt> prompt =
chrome::BuildExtensionInstallPrompt(extension_.get());
ExtensionInstallPrompt::PermissionsType type =
ExtensionInstallPrompt::PermissionsType::REGULAR_PERMISSIONS;
std::vector<base::string16> permissions;
permissions.push_back(base::UTF8ToUTF16("warning 1"));
std::vector<base::string16> permissions_details;
permissions_details.push_back(base::UTF8ToUTF16("Detail 1"));
prompt->SetPermissions(permissions, type);
prompt->SetPermissionsDetails(permissions_details, type);
prompt->SetIsShowingDetails(
ExtensionInstallPrompt::PERMISSIONS_DETAILS, 0, true);
base::scoped_nsobject<ExtensionInstallViewController> controller(
[[ExtensionInstallViewController alloc] initWithProfile:profile()
navigator:browser()
delegate:&delegate
prompt:prompt]);
[controller view]; // Force nib load.
NSOutlineView* outlineView = [controller outlineView];
EXPECT_TRUE(outlineView);
EXPECT_EQ(4, [outlineView numberOfRows]);
EXPECT_NSEQ(base::SysUTF16ToNSString(prompt->GetPermissionsDetails(0, type)),
[[outlineView dataSource] outlineView:outlineView
objectValueForTableColumn:nil
byItem:[outlineView itemAtRow:2]]);
}
|
