1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356
|
// Copyright (c) 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#import <Cocoa/Cocoa.h>
#include <vector>
#include "base/memory/ref_counted_memory.h"
#include "base/memory/scoped_ptr.h"
#include "base/strings/string_util.h"
#include "base/strings/sys_string_conversions.h"
#include "base/strings/utf_string_conversions.h"
#include "chrome/app/chrome_command_ids.h"
#include "chrome/browser/sessions/persistent_tab_restore_service.h"
#include "chrome/browser/ui/cocoa/cocoa_profile_test.h"
#include "chrome/browser/ui/cocoa/history_menu_bridge.h"
#include "chrome/test/base/testing_profile.h"
#include "components/favicon_base/favicon_types.h"
#include "components/sessions/serialized_navigation_entry_test_helper.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
#import "testing/gtest_mac.h"
#include "third_party/skia/include/core/SkBitmap.h"
#include "ui/gfx/codec/png_codec.h"
namespace {
class MockTRS : public PersistentTabRestoreService {
public:
MockTRS(Profile* profile) : PersistentTabRestoreService(profile, NULL) {}
MOCK_CONST_METHOD0(entries, const TabRestoreService::Entries&());
};
class MockBridge : public HistoryMenuBridge {
public:
MockBridge(Profile* profile)
: HistoryMenuBridge(profile),
menu_([[NSMenu alloc] initWithTitle:@"History"]) {}
NSMenu* HistoryMenu() override { return menu_.get(); }
private:
base::scoped_nsobject<NSMenu> menu_;
};
class HistoryMenuBridgeTest : public CocoaProfileTest {
public:
void SetUp() override {
CocoaProfileTest::SetUp();
profile()->CreateFaviconService();
bridge_.reset(new MockBridge(profile()));
}
// We are a friend of HistoryMenuBridge (and have access to
// protected methods), but none of the classes generated by TEST_F()
// are. Wraps common commands.
void ClearMenuSection(NSMenu* menu,
NSInteger tag) {
bridge_->ClearMenuSection(menu, tag);
}
void AddItemToBridgeMenu(HistoryMenuBridge::HistoryItem* item,
NSMenu* menu,
NSInteger tag,
NSInteger index) {
bridge_->AddItemToMenu(item, menu, tag, index);
}
NSMenuItem* AddItemToMenu(NSMenu* menu,
NSString* title,
SEL selector,
int tag) {
NSMenuItem* item = [[[NSMenuItem alloc] initWithTitle:title action:NULL
keyEquivalent:@""] autorelease];
[item setTag:tag];
if (selector) {
[item setAction:selector];
[item setTarget:bridge_->controller_.get()];
}
[menu addItem:item];
return item;
}
HistoryMenuBridge::HistoryItem* CreateItem(const base::string16& title) {
HistoryMenuBridge::HistoryItem* item =
new HistoryMenuBridge::HistoryItem();
item->title = title;
item->url = GURL(title);
return item;
}
MockTRS::Tab CreateSessionTab(const std::string& url,
const std::string& title) {
MockTRS::Tab tab;
tab.current_navigation_index = 0;
tab.navigations.push_back(
sessions::SerializedNavigationEntryTestHelper::CreateNavigation(
url, title));
return tab;
}
void GetFaviconForHistoryItem(HistoryMenuBridge::HistoryItem* item) {
bridge_->GetFaviconForHistoryItem(item);
}
void GotFaviconData(HistoryMenuBridge::HistoryItem* item,
const favicon_base::FaviconImageResult& image_result) {
bridge_->GotFaviconData(item, image_result);
}
scoped_ptr<MockBridge> bridge_;
};
// Edge case test for clearing until the end of a menu.
TEST_F(HistoryMenuBridgeTest, ClearHistoryMenuUntilEnd) {
NSMenu* menu = [[[NSMenu alloc] initWithTitle:@"history foo"] autorelease];
AddItemToMenu(menu, @"HEADER", NULL, HistoryMenuBridge::kVisitedTitle);
NSInteger tag = HistoryMenuBridge::kVisited;
AddItemToMenu(menu, @"alpha", @selector(openHistoryMenuItem:), tag);
AddItemToMenu(menu, @"bravo", @selector(openHistoryMenuItem:), tag);
AddItemToMenu(menu, @"charlie", @selector(openHistoryMenuItem:), tag);
AddItemToMenu(menu, @"delta", @selector(openHistoryMenuItem:), tag);
ClearMenuSection(menu, HistoryMenuBridge::kVisited);
EXPECT_EQ(1, [menu numberOfItems]);
EXPECT_NSEQ(@"HEADER",
[[menu itemWithTag:HistoryMenuBridge::kVisitedTitle] title]);
}
// Skip menu items that are not hooked up to |-openHistoryMenuItem:|.
TEST_F(HistoryMenuBridgeTest, ClearHistoryMenuSkipping) {
NSMenu* menu = [[[NSMenu alloc] initWithTitle:@"history foo"] autorelease];
AddItemToMenu(menu, @"HEADER", NULL, HistoryMenuBridge::kVisitedTitle);
NSInteger tag = HistoryMenuBridge::kVisited;
AddItemToMenu(menu, @"alpha", @selector(openHistoryMenuItem:), tag);
AddItemToMenu(menu, @"bravo", @selector(openHistoryMenuItem:), tag);
AddItemToMenu(menu, @"TITLE", NULL, HistoryMenuBridge::kRecentlyClosedTitle);
AddItemToMenu(menu, @"charlie", @selector(openHistoryMenuItem:), tag);
ClearMenuSection(menu, tag);
EXPECT_EQ(2, [menu numberOfItems]);
EXPECT_NSEQ(@"HEADER",
[[menu itemWithTag:HistoryMenuBridge::kVisitedTitle] title]);
EXPECT_NSEQ(@"TITLE",
[[menu itemAtIndex:1] title]);
}
// Edge case test for clearing an empty menu.
TEST_F(HistoryMenuBridgeTest, ClearHistoryMenuEmpty) {
NSMenu* menu = [[[NSMenu alloc] initWithTitle:@"history foo"] autorelease];
AddItemToMenu(menu, @"HEADER", NULL, HistoryMenuBridge::kVisited);
ClearMenuSection(menu, HistoryMenuBridge::kVisited);
EXPECT_EQ(1, [menu numberOfItems]);
EXPECT_NSEQ(@"HEADER",
[[menu itemWithTag:HistoryMenuBridge::kVisited] title]);
}
// Test that AddItemToMenu() properly adds HistoryItem objects as menus.
TEST_F(HistoryMenuBridgeTest, AddItemToMenu) {
NSMenu* menu = [[[NSMenu alloc] initWithTitle:@"history foo"] autorelease];
const base::string16 short_url = base::ASCIIToUTF16("http://foo/");
const base::string16 long_url = base::ASCIIToUTF16(
"http://super-duper-long-url--."
"that.cannot.possibly.fit.even-in-80-columns"
"or.be.reasonably-displayed-in-a-menu"
"without.looking-ridiculous.com/"); // 140 chars total
// HistoryItems are owned by the HistoryMenuBridge when AddItemToBridgeMenu()
// is called, which places them into the |menu_item_map_|, which owns them.
HistoryMenuBridge::HistoryItem* item1 = CreateItem(short_url);
AddItemToBridgeMenu(item1, menu, 100, 0);
HistoryMenuBridge::HistoryItem* item2 = CreateItem(long_url);
AddItemToBridgeMenu(item2, menu, 101, 1);
EXPECT_EQ(2, [menu numberOfItems]);
EXPECT_EQ(@selector(openHistoryMenuItem:), [[menu itemAtIndex:0] action]);
EXPECT_EQ(@selector(openHistoryMenuItem:), [[menu itemAtIndex:1] action]);
EXPECT_EQ(100, [[menu itemAtIndex:0] tag]);
EXPECT_EQ(101, [[menu itemAtIndex:1] tag]);
// Make sure a short title looks fine
NSString* s = [[menu itemAtIndex:0] title];
EXPECT_EQ(base::SysNSStringToUTF16(s), short_url);
// Make sure a super-long title gets trimmed
s = [[menu itemAtIndex:0] title];
EXPECT_TRUE([s length] < long_url.length());
// Confirm tooltips and confirm they are not trimmed (like the item
// name might be). Add tolerance for URL fixer-upping;
// e.g. http://foo becomes http://foo/)
EXPECT_GE([[[menu itemAtIndex:0] toolTip] length], (2*short_url.length()-5));
EXPECT_GE([[[menu itemAtIndex:1] toolTip] length], (2*long_url.length()-5));
}
// Test that the menu is created for a set of simple tabs.
TEST_F(HistoryMenuBridgeTest, RecentlyClosedTabs) {
scoped_ptr<MockTRS> trs(new MockTRS(profile()));
MockTRS::Entries entries;
MockTRS::Tab tab1 = CreateSessionTab("http://google.com", "Google");
tab1.id = 24;
entries.push_back(&tab1);
MockTRS::Tab tab2 = CreateSessionTab("http://apple.com", "Apple");
tab2.id = 42;
entries.push_back(&tab2);
using ::testing::ReturnRef;
EXPECT_CALL(*trs.get(), entries()).WillOnce(ReturnRef(entries));
bridge_->TabRestoreServiceChanged(trs.get());
NSMenu* menu = bridge_->HistoryMenu();
ASSERT_EQ(2U, [[menu itemArray] count]);
NSMenuItem* item1 = [menu itemAtIndex:0];
MockBridge::HistoryItem* hist1 = bridge_->HistoryItemForMenuItem(item1);
EXPECT_TRUE(hist1);
EXPECT_EQ(24, hist1->session_id);
EXPECT_NSEQ(@"Google", [item1 title]);
NSMenuItem* item2 = [menu itemAtIndex:1];
MockBridge::HistoryItem* hist2 = bridge_->HistoryItemForMenuItem(item2);
EXPECT_TRUE(hist2);
EXPECT_EQ(42, hist2->session_id);
EXPECT_NSEQ(@"Apple", [item2 title]);
}
// Test that the menu is created for a mix of windows and tabs.
TEST_F(HistoryMenuBridgeTest, RecentlyClosedTabsAndWindows) {
scoped_ptr<MockTRS> trs(new MockTRS(profile()));
MockTRS::Entries entries;
MockTRS::Tab tab1 = CreateSessionTab("http://google.com", "Google");
tab1.id = 24;
entries.push_back(&tab1);
MockTRS::Window win1;
win1.id = 30;
win1.tabs.push_back(CreateSessionTab("http://foo.com", "foo"));
win1.tabs[0].id = 31;
win1.tabs.push_back(CreateSessionTab("http://bar.com", "bar"));
win1.tabs[1].id = 32;
entries.push_back(&win1);
MockTRS::Tab tab2 = CreateSessionTab("http://apple.com", "Apple");
tab2.id = 42;
entries.push_back(&tab2);
MockTRS::Window win2;
win2.id = 50;
win2.tabs.push_back(CreateSessionTab("http://magic.com", "magic"));
win2.tabs[0].id = 51;
win2.tabs.push_back(CreateSessionTab("http://goats.com", "goats"));
win2.tabs[1].id = 52;
win2.tabs.push_back(CreateSessionTab("http://teleporter.com", "teleporter"));
win2.tabs[1].id = 53;
entries.push_back(&win2);
using ::testing::ReturnRef;
EXPECT_CALL(*trs.get(), entries()).WillOnce(ReturnRef(entries));
bridge_->TabRestoreServiceChanged(trs.get());
NSMenu* menu = bridge_->HistoryMenu();
ASSERT_EQ(4U, [[menu itemArray] count]);
NSMenuItem* item1 = [menu itemAtIndex:0];
MockBridge::HistoryItem* hist1 = bridge_->HistoryItemForMenuItem(item1);
EXPECT_TRUE(hist1);
EXPECT_EQ(24, hist1->session_id);
EXPECT_NSEQ(@"Google", [item1 title]);
NSMenuItem* item2 = [menu itemAtIndex:1];
MockBridge::HistoryItem* hist2 = bridge_->HistoryItemForMenuItem(item2);
EXPECT_TRUE(hist2);
EXPECT_EQ(30, hist2->session_id);
EXPECT_EQ(2U, hist2->tabs.size());
// Do not test menu item title because it is localized.
NSMenu* submenu1 = [item2 submenu];
EXPECT_EQ(4U, [[submenu1 itemArray] count]);
// Do not test Restore All Tabs because it is localiced.
EXPECT_TRUE([[submenu1 itemAtIndex:1] isSeparatorItem]);
EXPECT_NSEQ(@"foo", [[submenu1 itemAtIndex:2] title]);
EXPECT_NSEQ(@"bar", [[submenu1 itemAtIndex:3] title]);
NSMenuItem* item3 = [menu itemAtIndex:2];
MockBridge::HistoryItem* hist3 = bridge_->HistoryItemForMenuItem(item3);
EXPECT_TRUE(hist3);
EXPECT_EQ(42, hist3->session_id);
EXPECT_NSEQ(@"Apple", [item3 title]);
NSMenuItem* item4 = [menu itemAtIndex:3];
MockBridge::HistoryItem* hist4 = bridge_->HistoryItemForMenuItem(item4);
EXPECT_TRUE(hist4);
EXPECT_EQ(50, hist4->session_id);
EXPECT_EQ(3U, hist4->tabs.size());
// Do not test menu item title because it is localized.
NSMenu* submenu2 = [item4 submenu];
EXPECT_EQ(5U, [[submenu2 itemArray] count]);
// Do not test Restore All Tabs because it is localiced.
EXPECT_TRUE([[submenu2 itemAtIndex:1] isSeparatorItem]);
EXPECT_NSEQ(@"magic", [[submenu2 itemAtIndex:2] title]);
EXPECT_NSEQ(@"goats", [[submenu2 itemAtIndex:3] title]);
EXPECT_NSEQ(@"teleporter", [[submenu2 itemAtIndex:4] title]);
}
// Tests that we properly request an icon from the FaviconService.
TEST_F(HistoryMenuBridgeTest, GetFaviconForHistoryItem) {
// Create a fake item.
HistoryMenuBridge::HistoryItem item;
item.title = base::ASCIIToUTF16("Title");
item.url = GURL("http://google.com");
// Request the icon.
GetFaviconForHistoryItem(&item);
// Make sure the item was modified properly.
EXPECT_TRUE(item.icon_requested);
EXPECT_NE(base::CancelableTaskTracker::kBadTaskId, item.icon_task_id);
}
TEST_F(HistoryMenuBridgeTest, GotFaviconData) {
// Create a dummy bitmap.
SkBitmap bitmap;
bitmap.allocN32Pixels(25, 25);
bitmap.eraseARGB(255, 255, 0, 0);
// Set up the HistoryItem.
HistoryMenuBridge::HistoryItem item;
item.menu_item.reset([[NSMenuItem alloc] init]);
GetFaviconForHistoryItem(&item);
// Pretend to be called back.
favicon_base::FaviconImageResult image_result;
image_result.image = gfx::Image::CreateFrom1xBitmap(bitmap);
GotFaviconData(&item, image_result);
// Make sure the callback works.
EXPECT_FALSE(item.icon_requested);
EXPECT_TRUE(item.icon.get());
EXPECT_TRUE([item.menu_item image]);
}
} // namespace
|