1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268
|
// Copyright 2014 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/ui/views/extensions/extension_install_dialog_view.h"
#include "base/strings/utf_string_conversions.h"
#include "chrome/browser/extensions/extension_browsertest.h"
#include "chrome/browser/extensions/extension_icon_manager.h"
#include "chrome/browser/extensions/extension_install_prompt.h"
#include "chrome/browser/extensions/extension_install_prompt_experiment.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
#include "chrome/browser/ui/webui/extensions/extension_settings_handler.h"
#include "chrome/common/extensions/extension_test_util.h"
#include "components/constrained_window/constrained_window_views.h"
#include "content/public/browser/browser_thread.h"
#include "content/public/test/test_utils.h"
#include "extensions/common/extension.h"
#include "extensions/common/permissions/permissions_data.h"
#include "extensions/common/test_util.h"
#include "ui/views/controls/scroll_view.h"
#include "ui/views/view.h"
#include "ui/views/widget/widget.h"
// A simple delegate implementation that counts the number of times
// |InstallUIProceed| and |InstallUIAbort| are called.
class MockExtensionInstallPromptDelegate
: public ExtensionInstallPrompt::Delegate {
public:
MockExtensionInstallPromptDelegate()
: proceed_count_(0),
abort_count_(0) {}
// ExtensionInstallPrompt::Delegate overrides.
void InstallUIProceed() override;
void InstallUIAbort(bool user_initiated) override;
int proceed_count() { return proceed_count_; }
int abort_count() { return abort_count_; }
protected:
int proceed_count_;
int abort_count_;
};
void MockExtensionInstallPromptDelegate::InstallUIProceed() {
++proceed_count_;
}
void MockExtensionInstallPromptDelegate::InstallUIAbort(bool user_initiated) {
++abort_count_;
}
// This lets us construct the parent for the prompt we're constructing in our
// tests.
class MockExtensionInstallPrompt : public ExtensionInstallPrompt {
public:
explicit MockExtensionInstallPrompt(content::WebContents* web_contents)
: ExtensionInstallPrompt(web_contents), prompt_(NULL) {}
~MockExtensionInstallPrompt() override {}
void set_prompt(ExtensionInstallPrompt::Prompt* prompt) {
prompt_ = prompt;
}
ExtensionInstallPrompt::Prompt* get_prompt() {
return prompt_;
}
private:
ExtensionInstallPrompt::Prompt* prompt_;
};
class ExtensionInstallDialogViewTestBase : public ExtensionBrowserTest {
protected:
explicit ExtensionInstallDialogViewTestBase(
ExtensionInstallPrompt::PromptType prompt_type);
~ExtensionInstallDialogViewTestBase() override {}
void SetUpOnMainThread() override;
ExtensionInstallPrompt::Prompt* prompt() { return prompt_.get(); }
content::WebContents* web_contents() { return web_contents_; }
MockExtensionInstallPromptDelegate* delegate() { return &delegate_; }
void SetPromptPermissions(std::vector<base::string16> permissions);
void SetPromptDetails(std::vector<base::string16> details);
void SetPromptRetainedFiles(std::vector<base::FilePath> files);
private:
const extensions::Extension* extension_;
MockExtensionInstallPrompt* install_prompt_;
scoped_refptr<ExtensionInstallPrompt::Prompt> prompt_;
content::WebContents* web_contents_;
MockExtensionInstallPromptDelegate delegate_;
DISALLOW_COPY_AND_ASSIGN(ExtensionInstallDialogViewTestBase);
};
ExtensionInstallDialogViewTestBase::ExtensionInstallDialogViewTestBase(
ExtensionInstallPrompt::PromptType prompt_type)
: extension_(NULL),
install_prompt_(NULL),
prompt_(new ExtensionInstallPrompt::Prompt(prompt_type)),
web_contents_(NULL) {
}
void ExtensionInstallDialogViewTestBase::SetUpOnMainThread() {
ExtensionBrowserTest::SetUpOnMainThread();
extension_ = ExtensionBrowserTest::LoadExtension(test_data_dir_.AppendASCII(
"install_prompt/permissions_scrollbar_regression"));
web_contents_ = browser()->tab_strip_model()->GetWebContentsAt(0);
install_prompt_ = new MockExtensionInstallPrompt(web_contents_);
install_prompt_->set_prompt(prompt_.get());
prompt_->set_experiment(ExtensionInstallPromptExperiment::ControlGroup());
prompt_->set_extension(extension_);
scoped_ptr<ExtensionIconManager> icon_manager(new ExtensionIconManager());
const SkBitmap icon_bitmap = icon_manager->GetIcon(extension_->id());
gfx::Image icon = gfx::Image::CreateFrom1xBitmap(icon_bitmap);
prompt_->set_icon(icon);
this->SetPromptPermissions(std::vector<base::string16>());
this->SetPromptDetails(std::vector<base::string16>());
this->SetPromptRetainedFiles(std::vector<base::FilePath>());
}
void ExtensionInstallDialogViewTestBase::SetPromptPermissions(
std::vector<base::string16> permissions) {
prompt_->SetPermissions(permissions,
ExtensionInstallPrompt::REGULAR_PERMISSIONS);
}
void ExtensionInstallDialogViewTestBase::SetPromptDetails(
std::vector<base::string16> details) {
prompt_->SetPermissionsDetails(details,
ExtensionInstallPrompt::REGULAR_PERMISSIONS);
}
void ExtensionInstallDialogViewTestBase::SetPromptRetainedFiles(
std::vector<base::FilePath> files) {
prompt_->set_retained_files(files);
}
class ScrollbarTest : public ExtensionInstallDialogViewTestBase {
protected:
ScrollbarTest();
~ScrollbarTest() override {}
bool IsScrollbarVisible();
private:
DISALLOW_COPY_AND_ASSIGN(ScrollbarTest);
};
ScrollbarTest::ScrollbarTest()
: ExtensionInstallDialogViewTestBase(
ExtensionInstallPrompt::PERMISSIONS_PROMPT) {
}
bool ScrollbarTest::IsScrollbarVisible() {
ExtensionInstallDialogView* dialog = new ExtensionInstallDialogView(
profile(),
web_contents(),
delegate(),
prompt());
// Create the modal view around the install dialog view.
views::Widget* modal = constrained_window::CreateBrowserModalDialogViews(
dialog, web_contents()->GetTopLevelNativeWindow());
modal->Show();
content::RunAllBlockingPoolTasksUntilIdle();
// Check if the vertical scrollbar is visible.
return dialog->scroll_view()->vertical_scroll_bar()->visible();
}
// Tests that a scrollbar _is_ shown for an excessively long extension
// install prompt.
IN_PROC_BROWSER_TEST_F(ScrollbarTest, LongPromptScrollbar) {
base::string16 permission_string(base::ASCIIToUTF16("Test"));
std::vector<base::string16> permissions;
std::vector<base::string16> details;
for (int i = 0; i < 20; i++) {
permissions.push_back(permission_string);
details.push_back(base::string16());
}
this->SetPromptPermissions(permissions);
this->SetPromptDetails(details);
ASSERT_TRUE(IsScrollbarVisible()) << "Scrollbar is not visible";
}
// Tests that a scrollbar isn't shown for this regression case.
// See crbug.com/385570 for details.
IN_PROC_BROWSER_TEST_F(ScrollbarTest, ScrollbarRegression) {
base::string16 permission_string(base::ASCIIToUTF16(
"Read and modify your data on *.facebook.com"));
std::vector<base::string16> permissions;
permissions.push_back(permission_string);
this->SetPromptPermissions(permissions);
std::vector<base::string16> details;
details.push_back(base::string16());
this->SetPromptDetails(details);
ASSERT_FALSE(IsScrollbarVisible()) << "Scrollbar is visible";
}
class ExtensionInstallDialogViewTest
: public ExtensionInstallDialogViewTestBase {
protected:
ExtensionInstallDialogViewTest()
: ExtensionInstallDialogViewTestBase(
ExtensionInstallPrompt::INSTALL_PROMPT) {}
~ExtensionInstallDialogViewTest() override {}
private:
DISALLOW_COPY_AND_ASSIGN(ExtensionInstallDialogViewTest);
};
// Verifies that the delegate is notified when the user selects to accept or
// cancel the install.
IN_PROC_BROWSER_TEST_F(ExtensionInstallDialogViewTest, NotifyDelegate) {
{
// The user confirms the install.
MockExtensionInstallPromptDelegate delegate;
scoped_ptr<ExtensionInstallDialogView> dialog(
new ExtensionInstallDialogView(
profile(), web_contents(), &delegate, prompt()));
views::DialogDelegateView* delegate_view = dialog.get();
delegate_view->Accept();
delegate_view->OnClosed();
dialog.reset();
EXPECT_EQ(0, delegate.abort_count());
EXPECT_EQ(1, delegate.proceed_count());
}
{
// The user cancels the install.
MockExtensionInstallPromptDelegate delegate;
scoped_ptr<ExtensionInstallDialogView> dialog(
new ExtensionInstallDialogView(
profile(), web_contents(), &delegate, prompt()));
views::DialogDelegateView* delegate_view = dialog.get();
delegate_view->Cancel();
delegate_view->OnClosed();
dialog.reset();
EXPECT_EQ(1, delegate.abort_count());
EXPECT_EQ(0, delegate.proceed_count());
}
{
// Corner case: Dialog is closed without the user explicitly choosing to
// proceed or cancel.
MockExtensionInstallPromptDelegate delegate;
scoped_ptr<ExtensionInstallDialogView> dialog(
new ExtensionInstallDialogView(
profile(), web_contents(), &delegate, prompt()));
dialog.reset();
EXPECT_EQ(1, delegate.abort_count());
EXPECT_EQ(0, delegate.proceed_count());
}
}
|