1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
|
// Copyright 2014 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "cc/layers/layer.h"
#include "content/browser/android/overscroll_refresh.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "ui/android/resources/resource_manager.h"
namespace content {
class OverscrollRefreshTest : public OverscrollRefreshClient,
public ui::ResourceManager,
public testing::Test {
public:
OverscrollRefreshTest()
: refresh_triggered_(false), still_refreshing_(false) {}
// OverscrollRefreshClient implementation.
void TriggerRefresh() override {
refresh_triggered_ = true;
still_refreshing_ = true;
}
bool IsStillRefreshing() const override { return still_refreshing_; }
// ResourceManager implementation.
base::android::ScopedJavaLocalRef<jobject> GetJavaObject() override {
return base::android::ScopedJavaLocalRef<jobject>();
}
Resource* GetResource(ui::AndroidResourceType res_type, int res_id) override {
return nullptr;
}
void PreloadResource(ui::AndroidResourceType res_type, int res_id) override {}
bool GetAndResetRefreshTriggered() {
bool triggered = refresh_triggered_;
refresh_triggered_ = false;
return triggered;
}
void PullBeyondActivationThreshold(OverscrollRefresh* effect) {
for (int i = 0; i < OverscrollRefresh::kMinPullsToActivate; ++i)
EXPECT_TRUE(effect->WillHandleScrollUpdate(gfx::Vector2dF(0, 100)));
}
protected:
scoped_ptr<OverscrollRefresh> CreateEffect() {
const float kDragTargetPixels = 100;
const bool kMirror = false;
scoped_ptr<OverscrollRefresh> effect(
new OverscrollRefresh(this, this, kDragTargetPixels, kMirror));
const gfx::SizeF kViewportSize(512, 512);
const gfx::Vector2dF kScrollOffset;
const bool kOverflowYHidden = false;
effect->UpdateDisplay(kViewportSize, kScrollOffset, kOverflowYHidden);
return effect.Pass();
}
void SignalRefreshCompleted() { still_refreshing_ = false; }
private:
bool refresh_triggered_;
bool still_refreshing_;
};
TEST_F(OverscrollRefreshTest, Basic) {
scoped_ptr<OverscrollRefresh> effect = CreateEffect();
EXPECT_FALSE(effect->IsActive());
EXPECT_FALSE(effect->IsAwaitingScrollUpdateAck());
effect->OnScrollBegin();
EXPECT_FALSE(effect->IsActive());
EXPECT_TRUE(effect->IsAwaitingScrollUpdateAck());
// The initial scroll should not be consumed, as it should first be offered
// to content.
gfx::Vector2dF scroll_up(0, 10);
EXPECT_FALSE(effect->WillHandleScrollUpdate(scroll_up));
EXPECT_FALSE(effect->IsActive());
EXPECT_TRUE(effect->IsAwaitingScrollUpdateAck());
// The unconsumed, overscrolling scroll will trigger the effect->
effect->OnScrollUpdateAck(false);
EXPECT_TRUE(effect->IsActive());
EXPECT_FALSE(effect->IsAwaitingScrollUpdateAck());
// Further scrolls will be consumed.
EXPECT_TRUE(effect->WillHandleScrollUpdate(gfx::Vector2dF(0, 50)));
EXPECT_TRUE(effect->IsActive());
// Even scrolls in the down direction should be consumed.
EXPECT_TRUE(effect->WillHandleScrollUpdate(gfx::Vector2dF(0, -50)));
EXPECT_TRUE(effect->IsActive());
// Feed enough scrolls to the effect to exceeds the threshold.
PullBeyondActivationThreshold(effect.get());
EXPECT_TRUE(effect->IsActive());
// Ending the scroll while beyond the threshold should trigger a refresh.
gfx::Vector2dF zero_velocity;
EXPECT_FALSE(GetAndResetRefreshTriggered());
effect->OnScrollEnd(zero_velocity);
EXPECT_TRUE(effect->IsActive());
EXPECT_TRUE(GetAndResetRefreshTriggered());
SignalRefreshCompleted();
// Ensure animation doesn't explode.
base::TimeTicks initial_time = base::TimeTicks::Now();
base::TimeTicks current_time = initial_time;
scoped_refptr<cc::Layer> layer = cc::Layer::Create();
while (effect->Animate(current_time, layer.get()))
current_time += base::TimeDelta::FromMilliseconds(16);
// The effect should terminate in a timely fashion.
EXPECT_GT(current_time.ToInternalValue(), initial_time.ToInternalValue());
EXPECT_LE(
current_time.ToInternalValue(),
(initial_time + base::TimeDelta::FromSeconds(10)).ToInternalValue());
EXPECT_FALSE(effect->IsActive());
}
TEST_F(OverscrollRefreshTest, AnimationTerminatesEvenIfRefreshNeverTerminates) {
scoped_ptr<OverscrollRefresh> effect = CreateEffect();
effect->OnScrollBegin();
ASSERT_FALSE(effect->WillHandleScrollUpdate(gfx::Vector2dF(0, 10)));
ASSERT_TRUE(effect->IsAwaitingScrollUpdateAck());
effect->OnScrollUpdateAck(false);
ASSERT_TRUE(effect->IsActive());
PullBeyondActivationThreshold(effect.get());
ASSERT_TRUE(effect->IsActive());
effect->OnScrollEnd(gfx::Vector2dF(0, 0));
ASSERT_TRUE(GetAndResetRefreshTriggered());
// Verify that the animation terminates even if the triggered refresh
// action never terminates (i.e., |still_refreshing_| is always true).
base::TimeTicks initial_time = base::TimeTicks::Now();
base::TimeTicks current_time = initial_time;
scoped_refptr<cc::Layer> layer = cc::Layer::Create();
while (effect->Animate(current_time, layer.get()))
current_time += base::TimeDelta::FromMilliseconds(16);
EXPECT_GT(current_time.ToInternalValue(), initial_time.ToInternalValue());
EXPECT_LE(
current_time.ToInternalValue(),
(initial_time + base::TimeDelta::FromSeconds(10)).ToInternalValue());
EXPECT_FALSE(effect->IsActive());
}
TEST_F(OverscrollRefreshTest, NotTriggeredIfBelowThreshold) {
scoped_ptr<OverscrollRefresh> effect = CreateEffect();
effect->OnScrollBegin();
ASSERT_FALSE(effect->WillHandleScrollUpdate(gfx::Vector2dF(0, 10)));
ASSERT_TRUE(effect->IsAwaitingScrollUpdateAck());
effect->OnScrollUpdateAck(false);
ASSERT_TRUE(effect->IsActive());
// Terminating the pull before it exceeds the threshold will prevent refresh.
EXPECT_TRUE(effect->WillHandleScrollUpdate(gfx::Vector2dF(0, 10)));
effect->OnScrollEnd(gfx::Vector2dF());
EXPECT_FALSE(GetAndResetRefreshTriggered());
}
TEST_F(OverscrollRefreshTest, NotTriggeredIfInitialYOffsetIsNotZero) {
scoped_ptr<OverscrollRefresh> effect = CreateEffect();
// A positive y scroll offset at the start of scroll will prevent activation,
// even if the subsequent scroll overscrolls upward.
gfx::SizeF viewport_size(512, 512);
gfx::Vector2dF nonzero_offset(0, 10);
bool overflow_y_hidden = false;
effect->UpdateDisplay(viewport_size, nonzero_offset, overflow_y_hidden);
effect->OnScrollBegin();
ASSERT_FALSE(effect->WillHandleScrollUpdate(gfx::Vector2dF(0, 10)));
EXPECT_FALSE(effect->IsActive());
EXPECT_FALSE(effect->IsAwaitingScrollUpdateAck());
effect->OnScrollUpdateAck(false);
EXPECT_FALSE(effect->IsActive());
EXPECT_FALSE(effect->IsAwaitingScrollUpdateAck());
EXPECT_FALSE(effect->WillHandleScrollUpdate(gfx::Vector2dF(0, 500)));
effect->OnScrollEnd(gfx::Vector2dF());
EXPECT_FALSE(GetAndResetRefreshTriggered());
}
TEST_F(OverscrollRefreshTest, NotTriggeredIfOverflowYHidden) {
scoped_ptr<OverscrollRefresh> effect = CreateEffect();
// "overflow-y: hidden" on the root layer will prevent activation,
// even if the subsequent scroll overscrolls upward.
gfx::SizeF viewport_size(512, 512);
gfx::Vector2dF zero_offset;
bool overflow_y_hidden = true;
effect->UpdateDisplay(viewport_size, zero_offset, overflow_y_hidden);
effect->OnScrollBegin();
ASSERT_FALSE(effect->WillHandleScrollUpdate(gfx::Vector2dF(0, 10)));
EXPECT_FALSE(effect->IsActive());
EXPECT_FALSE(effect->IsAwaitingScrollUpdateAck());
effect->OnScrollUpdateAck(false);
EXPECT_FALSE(effect->IsActive());
EXPECT_FALSE(effect->IsAwaitingScrollUpdateAck());
EXPECT_FALSE(effect->WillHandleScrollUpdate(gfx::Vector2dF(0, 500)));
effect->OnScrollEnd(gfx::Vector2dF());
EXPECT_FALSE(GetAndResetRefreshTriggered());
}
TEST_F(OverscrollRefreshTest, NotTriggeredIfInitialScrollDownward) {
scoped_ptr<OverscrollRefresh> effect = CreateEffect();
effect->OnScrollBegin();
// A downward initial scroll will prevent activation, even if the subsequent
// scroll overscrolls upward.
ASSERT_FALSE(effect->WillHandleScrollUpdate(gfx::Vector2dF(0, -10)));
EXPECT_FALSE(effect->IsActive());
EXPECT_FALSE(effect->IsAwaitingScrollUpdateAck());
effect->OnScrollUpdateAck(false);
EXPECT_FALSE(effect->IsActive());
EXPECT_FALSE(effect->IsAwaitingScrollUpdateAck());
EXPECT_FALSE(effect->WillHandleScrollUpdate(gfx::Vector2dF(0, 500)));
effect->OnScrollEnd(gfx::Vector2dF());
EXPECT_FALSE(GetAndResetRefreshTriggered());
}
TEST_F(OverscrollRefreshTest, NotTriggeredIfInitialScrollOrTouchConsumed) {
scoped_ptr<OverscrollRefresh> effect = CreateEffect();
effect->OnScrollBegin();
ASSERT_FALSE(effect->WillHandleScrollUpdate(gfx::Vector2dF(0, 10)));
ASSERT_TRUE(effect->IsAwaitingScrollUpdateAck());
// Consumption of the initial touchmove or scroll should prevent future
// activation.
effect->OnScrollUpdateAck(true);
EXPECT_FALSE(effect->IsActive());
EXPECT_FALSE(effect->IsAwaitingScrollUpdateAck());
EXPECT_FALSE(effect->WillHandleScrollUpdate(gfx::Vector2dF(0, 500)));
effect->OnScrollUpdateAck(false);
EXPECT_FALSE(effect->IsActive());
EXPECT_FALSE(effect->IsAwaitingScrollUpdateAck());
EXPECT_FALSE(effect->WillHandleScrollUpdate(gfx::Vector2dF(0, 500)));
effect->OnScrollEnd(gfx::Vector2dF());
EXPECT_FALSE(GetAndResetRefreshTriggered());
}
TEST_F(OverscrollRefreshTest, NotTriggeredIfInitialScrollsJanked) {
scoped_ptr<OverscrollRefresh> effect = CreateEffect();
effect->OnScrollBegin();
ASSERT_FALSE(effect->WillHandleScrollUpdate(gfx::Vector2dF(0, 10)));
ASSERT_TRUE(effect->IsAwaitingScrollUpdateAck());
effect->OnScrollUpdateAck(false);
ASSERT_TRUE(effect->IsActive());
// It should take more than just one or two large scrolls to trigger,
// mitigating likelihood of jank triggering the effect->
EXPECT_TRUE(effect->WillHandleScrollUpdate(gfx::Vector2dF(0, 500)));
EXPECT_TRUE(effect->WillHandleScrollUpdate(gfx::Vector2dF(0, 500)));
effect->OnScrollEnd(gfx::Vector2dF());
EXPECT_FALSE(GetAndResetRefreshTriggered());
}
TEST_F(OverscrollRefreshTest, NotTriggeredIfFlungDownward) {
scoped_ptr<OverscrollRefresh> effect = CreateEffect();
effect->OnScrollBegin();
ASSERT_FALSE(effect->WillHandleScrollUpdate(gfx::Vector2dF(0, 10)));
ASSERT_TRUE(effect->IsAwaitingScrollUpdateAck());
effect->OnScrollUpdateAck(false);
ASSERT_TRUE(effect->IsActive());
// Ensure the pull exceeds the necessary threshold.
PullBeyondActivationThreshold(effect.get());
ASSERT_TRUE(effect->IsActive());
// Terminating the pull with a down-directed fling should prevent triggering.
effect->OnScrollEnd(gfx::Vector2dF(0, -1000));
EXPECT_FALSE(GetAndResetRefreshTriggered());
}
TEST_F(OverscrollRefreshTest, NotTriggeredIfReleasedWithoutActivation) {
scoped_ptr<OverscrollRefresh> effect = CreateEffect();
effect->OnScrollBegin();
ASSERT_FALSE(effect->WillHandleScrollUpdate(gfx::Vector2dF(0, 10)));
ASSERT_TRUE(effect->IsAwaitingScrollUpdateAck());
effect->OnScrollUpdateAck(false);
ASSERT_TRUE(effect->IsActive());
// Ensure the pull exceeds the necessary threshold.
PullBeyondActivationThreshold(effect.get());
ASSERT_TRUE(effect->IsActive());
// An early release should prevent the refresh action from firing.
effect->ReleaseWithoutActivation();
effect->OnScrollEnd(gfx::Vector2dF());
EXPECT_FALSE(GetAndResetRefreshTriggered());
// The early release should trigger a dismissal animation.
EXPECT_TRUE(effect->IsActive());
base::TimeTicks initial_time = base::TimeTicks::Now();
base::TimeTicks current_time = initial_time;
scoped_refptr<cc::Layer> layer = cc::Layer::Create();
while (effect->Animate(current_time, layer.get()))
current_time += base::TimeDelta::FromMilliseconds(16);
EXPECT_GT(current_time.ToInternalValue(), initial_time.ToInternalValue());
EXPECT_FALSE(effect->IsActive());
EXPECT_FALSE(GetAndResetRefreshTriggered());
}
} // namespace content
|
