1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348
|
// Copyright (c) 2013 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "ui/views/controls/native/native_view_host_aura.h"
#include "base/basictypes.h"
#include "base/memory/scoped_ptr.h"
#include "ui/aura/client/aura_constants.h"
#include "ui/aura/window.h"
#include "ui/base/cursor/cursor.h"
#include "ui/views/controls/native/native_view_host.h"
#include "ui/views/controls/native/native_view_host_test_base.h"
#include "ui/views/view.h"
#include "ui/views/view_constants_aura.h"
#include "ui/views/widget/widget.h"
namespace views {
// Observer watching for window visibility and bounds change events. This is
// used to verify that the child and clipping window operations are done in the
// right order.
class NativeViewHostWindowObserver : public aura::WindowObserver {
public:
enum EventType {
EVENT_NONE,
EVENT_SHOWN,
EVENT_HIDDEN,
EVENT_BOUNDS_CHANGED,
};
struct EventDetails {
EventType type;
aura::Window* window;
gfx::Rect bounds;
bool operator!=(const EventDetails& rhs) {
return type != rhs.type || window != rhs.window || bounds != rhs.bounds;
}
};
NativeViewHostWindowObserver() {}
~NativeViewHostWindowObserver() override {}
const std::vector<EventDetails>& events() const { return events_; }
// aura::WindowObserver overrides
void OnWindowVisibilityChanged(aura::Window* window, bool visible) override {
EventDetails event;
event.type = visible ? EVENT_SHOWN : EVENT_HIDDEN;
event.window = window;
event.bounds = window->GetBoundsInRootWindow();
// Dedupe events as a single Hide() call can result in several
// notifications.
if (events_.size() == 0u || events_.back() != event)
events_.push_back(event);
}
void OnWindowBoundsChanged(aura::Window* window,
const gfx::Rect& old_bounds,
const gfx::Rect& new_bounds) override {
EventDetails event;
event.type = EVENT_BOUNDS_CHANGED;
event.window = window;
event.bounds = window->GetBoundsInRootWindow();
events_.push_back(event);
}
private:
std::vector<EventDetails> events_;
gfx::Rect bounds_at_visibility_changed_;
DISALLOW_COPY_AND_ASSIGN(NativeViewHostWindowObserver);
};
class NativeViewHostAuraTest : public test::NativeViewHostTestBase {
public:
NativeViewHostAuraTest() {
}
NativeViewHostAura* native_host() {
return static_cast<NativeViewHostAura*>(GetNativeWrapper());
}
Widget* child() {
return child_.get();
}
aura::Window* clipping_window() { return &(native_host()->clipping_window_); }
void CreateHost() {
CreateTopLevel();
CreateTestingHost();
child_.reset(CreateChildForHost(toplevel()->GetNativeView(),
toplevel()->GetRootView(),
new View,
host()));
}
private:
scoped_ptr<Widget> child_;
DISALLOW_COPY_AND_ASSIGN(NativeViewHostAuraTest);
};
// Verifies NativeViewHostAura stops observing native view on destruction.
TEST_F(NativeViewHostAuraTest, StopObservingNativeViewOnDestruct) {
CreateHost();
aura::Window* child_win = child()->GetNativeView();
NativeViewHostAura* aura_host = native_host();
EXPECT_TRUE(child_win->HasObserver(aura_host));
DestroyHost();
EXPECT_FALSE(child_win->HasObserver(aura_host));
}
// Tests that the kHostViewKey is correctly set and cleared.
TEST_F(NativeViewHostAuraTest, HostViewPropertyKey) {
// Create the NativeViewHost and attach a NativeView.
CreateHost();
aura::Window* child_win = child()->GetNativeView();
EXPECT_EQ(host(), child_win->GetProperty(views::kHostViewKey));
EXPECT_EQ(host()->GetWidget()->GetNativeView(),
child_win->GetProperty(aura::client::kHostWindowKey));
EXPECT_EQ(host(), clipping_window()->GetProperty(views::kHostViewKey));
host()->Detach();
EXPECT_FALSE(child_win->GetProperty(views::kHostViewKey));
EXPECT_FALSE(child_win->GetProperty(aura::client::kHostWindowKey));
EXPECT_TRUE(clipping_window()->GetProperty(views::kHostViewKey));
host()->Attach(child_win);
EXPECT_EQ(host(), child_win->GetProperty(views::kHostViewKey));
EXPECT_EQ(host()->GetWidget()->GetNativeView(),
child_win->GetProperty(aura::client::kHostWindowKey));
EXPECT_EQ(host(), clipping_window()->GetProperty(views::kHostViewKey));
DestroyHost();
EXPECT_FALSE(child_win->GetProperty(views::kHostViewKey));
EXPECT_FALSE(child_win->GetProperty(aura::client::kHostWindowKey));
}
// Tests that the NativeViewHost reports the cursor set on its native view.
TEST_F(NativeViewHostAuraTest, CursorForNativeView) {
CreateHost();
toplevel()->SetCursor(ui::kCursorHand);
child()->SetCursor(ui::kCursorWait);
ui::MouseEvent move_event(ui::ET_MOUSE_MOVED, gfx::Point(0, 0),
gfx::Point(0, 0), 0, 0);
EXPECT_EQ(ui::kCursorWait, host()->GetCursor(move_event).native_type());
DestroyHost();
}
// Test that destroying the top level widget before destroying the attached
// NativeViewHost works correctly. Specifically the associated NVH should be
// destroyed and there shouldn't be any errors.
TEST_F(NativeViewHostAuraTest, DestroyWidget) {
ResetHostDestroyedCount();
CreateHost();
ReleaseHost();
EXPECT_EQ(0, host_destroyed_count());
DestroyTopLevel();
EXPECT_EQ(1, host_destroyed_count());
}
// Test that the fast resize path places the clipping and content windows were
// they are supposed to be.
TEST_F(NativeViewHostAuraTest, FastResizePath) {
CreateHost();
toplevel()->SetBounds(gfx::Rect(20, 20, 100, 100));
// Without fast resize, the clipping window should size to the native view
// with the native view positioned at the origin of the clipping window and
// the clipping window positioned where the native view was requested.
host()->set_fast_resize(false);
native_host()->ShowWidget(5, 10, 100, 100);
EXPECT_EQ(gfx::Rect(0, 0, 100, 100).ToString(),
host()->native_view()->bounds().ToString());
EXPECT_EQ(gfx::Rect(5, 10, 100, 100).ToString(),
clipping_window()->bounds().ToString());
// With fast resize, the native view should remain the same size but be
// clipped the requested size.
host()->set_fast_resize(true);
native_host()->ShowWidget(10, 25, 50, 50);
EXPECT_EQ(gfx::Rect(0, 0, 100, 100).ToString(),
host()->native_view()->bounds().ToString());
EXPECT_EQ(gfx::Rect(10, 25, 50, 50).ToString(),
clipping_window()->bounds().ToString());
// Turning off fast resize should make the native view start resizing again.
host()->set_fast_resize(false);
native_host()->ShowWidget(10, 25, 50, 50);
EXPECT_EQ(gfx::Rect(0, 0, 50, 50).ToString(),
host()->native_view()->bounds().ToString());
EXPECT_EQ(gfx::Rect(10, 25, 50, 50).ToString(),
clipping_window()->bounds().ToString());
DestroyHost();
}
// Test installing and uninstalling a clip.
TEST_F(NativeViewHostAuraTest, InstallClip) {
CreateHost();
toplevel()->SetBounds(gfx::Rect(20, 20, 100, 100));
// Without a clip, the clipping window should always be positioned at the
// requested coordinates with the native view positioned at the origin of the
// clipping window.
native_host()->ShowWidget(10, 20, 100, 100);
EXPECT_EQ(gfx::Rect(0, 0, 100, 100).ToString(),
host()->native_view()->bounds().ToString());
EXPECT_EQ(gfx::Rect(10, 20, 100, 100).ToString(),
clipping_window()->bounds().ToString());
// Clip to the bottom right quarter of the native view.
native_host()->InstallClip(60, 70, 50, 50);
native_host()->ShowWidget(10, 20, 100, 100);
EXPECT_EQ(gfx::Rect(-50, -50, 100, 100).ToString(),
host()->native_view()->bounds().ToString());
EXPECT_EQ(gfx::Rect(60, 70, 50, 50).ToString(),
clipping_window()->bounds().ToString());
// Clip to the center of the native view.
native_host()->InstallClip(35, 45, 50, 50);
native_host()->ShowWidget(10, 20, 100, 100);
EXPECT_EQ(gfx::Rect(-25, -25, 100, 100).ToString(),
host()->native_view()->bounds().ToString());
EXPECT_EQ(gfx::Rect(35, 45, 50, 50).ToString(),
clipping_window()->bounds().ToString());
// Uninstalling the clip should make the clipping window match the native view
// again.
native_host()->UninstallClip();
native_host()->ShowWidget(10, 20, 100, 100);
EXPECT_EQ(gfx::Rect(0, 0, 100, 100).ToString(),
host()->native_view()->bounds().ToString());
EXPECT_EQ(gfx::Rect(10, 20, 100, 100).ToString(),
clipping_window()->bounds().ToString());
DestroyHost();
}
// Ensure native view is parented to the root window after detaching. This is
// a regression test for http://crbug.com/389261.
TEST_F(NativeViewHostAuraTest, ParentAfterDetach) {
CreateHost();
aura::Window* child_win = child()->GetNativeView();
aura::Window* root_window = child_win->GetRootWindow();
aura::WindowTreeHost* child_win_tree_host = child_win->GetHost();
host()->Detach();
EXPECT_EQ(root_window, child_win->GetRootWindow());
EXPECT_EQ(child_win_tree_host, child_win->GetHost());
DestroyHost();
}
// Ensure the clipping window is hidden before setting the native view's bounds.
// This is a regression test for http://crbug.com/388699.
TEST_F(NativeViewHostAuraTest, RemoveClippingWindowOrder) {
CreateHost();
toplevel()->SetBounds(gfx::Rect(20, 20, 100, 100));
native_host()->ShowWidget(10, 20, 100, 100);
NativeViewHostWindowObserver test_observer;
clipping_window()->AddObserver(&test_observer);
child()->GetNativeView()->AddObserver(&test_observer);
host()->Detach();
ASSERT_EQ(3u, test_observer.events().size());
EXPECT_EQ(NativeViewHostWindowObserver::EVENT_HIDDEN,
test_observer.events()[0].type);
EXPECT_EQ(clipping_window(), test_observer.events()[0].window);
EXPECT_EQ(NativeViewHostWindowObserver::EVENT_BOUNDS_CHANGED,
test_observer.events()[1].type);
EXPECT_EQ(child()->GetNativeView(), test_observer.events()[1].window);
EXPECT_EQ(NativeViewHostWindowObserver::EVENT_HIDDEN,
test_observer.events()[2].type);
EXPECT_EQ(child()->GetNativeView(), test_observer.events()[2].window);
clipping_window()->RemoveObserver(&test_observer);
child()->GetNativeView()->RemoveObserver(&test_observer);
DestroyHost();
}
// Ensure the native view receives the correct bounds notification when it is
// attached. This is a regression test for https://crbug.com/399420.
TEST_F(NativeViewHostAuraTest, Attach) {
CreateHost();
host()->Detach();
child()->GetNativeView()->SetBounds(gfx::Rect(0, 0, 0, 0));
toplevel()->SetBounds(gfx::Rect(0, 0, 100, 100));
host()->SetBounds(10, 10, 80, 80);
NativeViewHostWindowObserver test_observer;
child()->GetNativeView()->AddObserver(&test_observer);
host()->Attach(child()->GetNativeView());
ASSERT_EQ(3u, test_observer.events().size());
EXPECT_EQ(NativeViewHostWindowObserver::EVENT_BOUNDS_CHANGED,
test_observer.events()[0].type);
EXPECT_EQ(child()->GetNativeView(), test_observer.events()[0].window);
EXPECT_EQ(gfx::Rect(10, 10, 80, 80).ToString(),
test_observer.events()[0].bounds.ToString());
EXPECT_EQ(NativeViewHostWindowObserver::EVENT_SHOWN,
test_observer.events()[1].type);
EXPECT_EQ(child()->GetNativeView(), test_observer.events()[1].window);
EXPECT_EQ(gfx::Rect(10, 10, 80, 80).ToString(),
test_observer.events()[1].bounds.ToString());
EXPECT_EQ(NativeViewHostWindowObserver::EVENT_SHOWN,
test_observer.events()[2].type);
EXPECT_EQ(clipping_window(), test_observer.events()[2].window);
EXPECT_EQ(gfx::Rect(10, 10, 80, 80).ToString(),
test_observer.events()[2].bounds.ToString());
child()->GetNativeView()->RemoveObserver(&test_observer);
DestroyHost();
}
// Ensure the clipping window is hidden with the native view. This is a
// regression test for https://crbug.com/408877.
TEST_F(NativeViewHostAuraTest, SimpleShowAndHide) {
CreateHost();
toplevel()->SetBounds(gfx::Rect(20, 20, 100, 100));
toplevel()->Show();
host()->SetBounds(10, 10, 80, 80);
EXPECT_TRUE(clipping_window()->IsVisible());
EXPECT_TRUE(child()->IsVisible());
host()->SetVisible(false);
EXPECT_FALSE(clipping_window()->IsVisible());
EXPECT_FALSE(child()->IsVisible());
DestroyHost();
DestroyTopLevel();
}
} // namespace views
|