1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426
|
// Copyright 2014 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "ui/wm/core/transient_window_manager.h"
#include "ui/aura/client/window_tree_client.h"
#include "ui/aura/test/aura_test_base.h"
#include "ui/aura/test/test_windows.h"
#include "ui/aura/window.h"
#include "ui/wm/core/transient_window_observer.h"
#include "ui/wm/core/window_util.h"
#include "ui/wm/core/wm_state.h"
using aura::Window;
using aura::test::ChildWindowIDsAsString;
using aura::test::CreateTestWindowWithId;
namespace wm {
class TestTransientWindowObserver : public TransientWindowObserver {
public:
TestTransientWindowObserver() : add_count_(0), remove_count_(0) {
}
~TestTransientWindowObserver() override {}
int add_count() const { return add_count_; }
int remove_count() const { return remove_count_; }
// TransientWindowObserver overrides:
void OnTransientChildAdded(Window* window, Window* transient) override {
add_count_++;
}
void OnTransientChildRemoved(Window* window, Window* transient) override {
remove_count_++;
}
private:
int add_count_;
int remove_count_;
DISALLOW_COPY_AND_ASSIGN(TestTransientWindowObserver);
};
class TransientWindowManagerTest : public aura::test::AuraTestBase {
public:
TransientWindowManagerTest() {}
~TransientWindowManagerTest() override {}
void SetUp() override {
AuraTestBase::SetUp();
wm_state_.reset(new wm::WMState);
}
void TearDown() override {
wm_state_.reset();
AuraTestBase::TearDown();
}
protected:
// Creates a transient window that is transient to |parent|.
Window* CreateTransientChild(int id, Window* parent) {
Window* window = new Window(NULL);
window->set_id(id);
window->SetType(ui::wm::WINDOW_TYPE_NORMAL);
window->Init(aura::WINDOW_LAYER_TEXTURED);
AddTransientChild(parent, window);
aura::client::ParentWindowWithContext(window, root_window(), gfx::Rect());
return window;
}
private:
scoped_ptr<wm::WMState> wm_state_;
DISALLOW_COPY_AND_ASSIGN(TransientWindowManagerTest);
};
// Various assertions for transient children.
TEST_F(TransientWindowManagerTest, TransientChildren) {
scoped_ptr<Window> parent(CreateTestWindowWithId(0, root_window()));
scoped_ptr<Window> w1(CreateTestWindowWithId(1, parent.get()));
scoped_ptr<Window> w3(CreateTestWindowWithId(3, parent.get()));
Window* w2 = CreateTestWindowWithId(2, parent.get());
// w2 is now owned by w1.
AddTransientChild(w1.get(), w2);
// Stack w1 at the top (end), this should force w2 to be last (on top of w1).
parent->StackChildAtTop(w1.get());
ASSERT_EQ(3u, parent->children().size());
EXPECT_EQ(w2, parent->children().back());
// Destroy w1, which should also destroy w3 (since it's a transient child).
w1.reset();
w2 = NULL;
ASSERT_EQ(1u, parent->children().size());
EXPECT_EQ(w3.get(), parent->children()[0]);
w1.reset(CreateTestWindowWithId(4, parent.get()));
w2 = CreateTestWindowWithId(5, w3.get());
AddTransientChild(w1.get(), w2);
parent->StackChildAtTop(w3.get());
// Stack w1 at the top (end), this shouldn't affect w2 since it has a
// different parent.
parent->StackChildAtTop(w1.get());
ASSERT_EQ(2u, parent->children().size());
EXPECT_EQ(w3.get(), parent->children()[0]);
EXPECT_EQ(w1.get(), parent->children()[1]);
// Hiding parent should hide transient children.
EXPECT_TRUE(w2->IsVisible());
w1->Hide();
EXPECT_FALSE(w2->IsVisible());
// And they should stay hidden even after the parent became visible.
w1->Show();
EXPECT_FALSE(w2->IsVisible());
// Hidden transient child should stay hidden regardless of
// parent's visibility.
w2->Hide();
EXPECT_FALSE(w2->IsVisible());
w1->Hide();
EXPECT_FALSE(w2->IsVisible());
w1->Show();
EXPECT_FALSE(w2->IsVisible());
// Transient child can be shown even if the transient parent is hidden.
w1->Hide();
EXPECT_FALSE(w2->IsVisible());
w2->Show();
EXPECT_TRUE(w2->IsVisible());
w1->Show();
EXPECT_TRUE(w2->IsVisible());
// When the parent_controls_visibility is true, TransientWindowManager
// controls the children's visibility. It stays invisible even if
// Window::Show() is called, and gets shown when the parent becomes visible.
wm::TransientWindowManager::Get(w2)->set_parent_controls_visibility(true);
w1->Hide();
EXPECT_FALSE(w2->IsVisible());
w2->Show();
EXPECT_FALSE(w2->IsVisible());
w1->Show();
EXPECT_TRUE(w2->IsVisible());
// Hiding a transient child that is hidden by the transient parent
// is not currently handled and will be shown anyway.
w1->Hide();
EXPECT_FALSE(w2->IsVisible());
w2->Hide();
EXPECT_FALSE(w2->IsVisible());
w1->Show();
EXPECT_TRUE(w2->IsVisible());
}
// Tests that transient children are stacked as a unit when using stack above.
TEST_F(TransientWindowManagerTest, TransientChildrenGroupAbove) {
scoped_ptr<Window> parent(CreateTestWindowWithId(0, root_window()));
scoped_ptr<Window> w1(CreateTestWindowWithId(1, parent.get()));
Window* w11 = CreateTestWindowWithId(11, parent.get());
scoped_ptr<Window> w2(CreateTestWindowWithId(2, parent.get()));
Window* w21 = CreateTestWindowWithId(21, parent.get());
Window* w211 = CreateTestWindowWithId(211, parent.get());
Window* w212 = CreateTestWindowWithId(212, parent.get());
Window* w213 = CreateTestWindowWithId(213, parent.get());
Window* w22 = CreateTestWindowWithId(22, parent.get());
ASSERT_EQ(8u, parent->children().size());
// w11 is now owned by w1.
AddTransientChild(w1.get(), w11);
// w21 is now owned by w2.
AddTransientChild(w2.get(), w21);
// w22 is now owned by w2.
AddTransientChild(w2.get(), w22);
// w211 is now owned by w21.
AddTransientChild(w21, w211);
// w212 is now owned by w21.
AddTransientChild(w21, w212);
// w213 is now owned by w21.
AddTransientChild(w21, w213);
EXPECT_EQ("1 11 2 21 211 212 213 22", ChildWindowIDsAsString(parent.get()));
// Stack w1 at the top (end), this should force w11 to be last (on top of w1).
parent->StackChildAtTop(w1.get());
EXPECT_EQ(w11, parent->children().back());
EXPECT_EQ("2 21 211 212 213 22 1 11", ChildWindowIDsAsString(parent.get()));
// This tests that the order in children_ array rather than in
// transient_children_ array is used when reinserting transient children.
// If transient_children_ array was used '22' would be following '21'.
parent->StackChildAtTop(w2.get());
EXPECT_EQ(w22, parent->children().back());
EXPECT_EQ("1 11 2 21 211 212 213 22", ChildWindowIDsAsString(parent.get()));
parent->StackChildAbove(w11, w2.get());
EXPECT_EQ(w11, parent->children().back());
EXPECT_EQ("2 21 211 212 213 22 1 11", ChildWindowIDsAsString(parent.get()));
parent->StackChildAbove(w21, w1.get());
EXPECT_EQ(w22, parent->children().back());
EXPECT_EQ("1 11 2 21 211 212 213 22", ChildWindowIDsAsString(parent.get()));
parent->StackChildAbove(w21, w22);
EXPECT_EQ(w213, parent->children().back());
EXPECT_EQ("1 11 2 22 21 211 212 213", ChildWindowIDsAsString(parent.get()));
parent->StackChildAbove(w11, w21);
EXPECT_EQ(w11, parent->children().back());
EXPECT_EQ("2 22 21 211 212 213 1 11", ChildWindowIDsAsString(parent.get()));
parent->StackChildAbove(w213, w21);
EXPECT_EQ(w11, parent->children().back());
EXPECT_EQ("2 22 21 213 211 212 1 11", ChildWindowIDsAsString(parent.get()));
// No change when stacking a transient parent above its transient child.
parent->StackChildAbove(w21, w211);
EXPECT_EQ(w11, parent->children().back());
EXPECT_EQ("2 22 21 213 211 212 1 11", ChildWindowIDsAsString(parent.get()));
// This tests that the order in children_ array rather than in
// transient_children_ array is used when reinserting transient children.
// If transient_children_ array was used '22' would be following '21'.
parent->StackChildAbove(w2.get(), w1.get());
EXPECT_EQ(w212, parent->children().back());
EXPECT_EQ("1 11 2 22 21 213 211 212", ChildWindowIDsAsString(parent.get()));
parent->StackChildAbove(w11, w213);
EXPECT_EQ(w11, parent->children().back());
EXPECT_EQ("2 22 21 213 211 212 1 11", ChildWindowIDsAsString(parent.get()));
}
// Tests that transient children are stacked as a unit when using stack below.
TEST_F(TransientWindowManagerTest, TransientChildrenGroupBelow) {
scoped_ptr<Window> parent(CreateTestWindowWithId(0, root_window()));
scoped_ptr<Window> w1(CreateTestWindowWithId(1, parent.get()));
Window* w11 = CreateTestWindowWithId(11, parent.get());
scoped_ptr<Window> w2(CreateTestWindowWithId(2, parent.get()));
Window* w21 = CreateTestWindowWithId(21, parent.get());
Window* w211 = CreateTestWindowWithId(211, parent.get());
Window* w212 = CreateTestWindowWithId(212, parent.get());
Window* w213 = CreateTestWindowWithId(213, parent.get());
Window* w22 = CreateTestWindowWithId(22, parent.get());
ASSERT_EQ(8u, parent->children().size());
// w11 is now owned by w1.
AddTransientChild(w1.get(), w11);
// w21 is now owned by w2.
AddTransientChild(w2.get(), w21);
// w22 is now owned by w2.
AddTransientChild(w2.get(), w22);
// w211 is now owned by w21.
AddTransientChild(w21, w211);
// w212 is now owned by w21.
AddTransientChild(w21, w212);
// w213 is now owned by w21.
AddTransientChild(w21, w213);
EXPECT_EQ("1 11 2 21 211 212 213 22", ChildWindowIDsAsString(parent.get()));
// Stack w2 at the bottom, this should force w11 to be last (on top of w1).
// This also tests that the order in children_ array rather than in
// transient_children_ array is used when reinserting transient children.
// If transient_children_ array was used '22' would be following '21'.
parent->StackChildAtBottom(w2.get());
EXPECT_EQ(w11, parent->children().back());
EXPECT_EQ("2 21 211 212 213 22 1 11", ChildWindowIDsAsString(parent.get()));
parent->StackChildAtBottom(w1.get());
EXPECT_EQ(w22, parent->children().back());
EXPECT_EQ("1 11 2 21 211 212 213 22", ChildWindowIDsAsString(parent.get()));
parent->StackChildBelow(w21, w1.get());
EXPECT_EQ(w11, parent->children().back());
EXPECT_EQ("2 21 211 212 213 22 1 11", ChildWindowIDsAsString(parent.get()));
parent->StackChildBelow(w11, w2.get());
EXPECT_EQ(w22, parent->children().back());
EXPECT_EQ("1 11 2 21 211 212 213 22", ChildWindowIDsAsString(parent.get()));
parent->StackChildBelow(w22, w21);
EXPECT_EQ(w213, parent->children().back());
EXPECT_EQ("1 11 2 22 21 211 212 213", ChildWindowIDsAsString(parent.get()));
parent->StackChildBelow(w21, w11);
EXPECT_EQ(w11, parent->children().back());
EXPECT_EQ("2 22 21 211 212 213 1 11", ChildWindowIDsAsString(parent.get()));
parent->StackChildBelow(w213, w211);
EXPECT_EQ(w11, parent->children().back());
EXPECT_EQ("2 22 21 213 211 212 1 11", ChildWindowIDsAsString(parent.get()));
// No change when stacking a transient parent below its transient child.
parent->StackChildBelow(w21, w211);
EXPECT_EQ(w11, parent->children().back());
EXPECT_EQ("2 22 21 213 211 212 1 11", ChildWindowIDsAsString(parent.get()));
parent->StackChildBelow(w1.get(), w2.get());
EXPECT_EQ(w212, parent->children().back());
EXPECT_EQ("1 11 2 22 21 213 211 212", ChildWindowIDsAsString(parent.get()));
parent->StackChildBelow(w213, w11);
EXPECT_EQ(w11, parent->children().back());
EXPECT_EQ("2 22 21 213 211 212 1 11", ChildWindowIDsAsString(parent.get()));
}
// Tests that transient windows are stacked properly when created.
TEST_F(TransientWindowManagerTest, StackUponCreation) {
scoped_ptr<Window> window0(CreateTestWindowWithId(0, root_window()));
scoped_ptr<Window> window1(CreateTestWindowWithId(1, root_window()));
scoped_ptr<Window> window2(CreateTransientChild(2, window0.get()));
EXPECT_EQ("0 2 1", ChildWindowIDsAsString(root_window()));
}
// Tests that windows are restacked properly after a call to AddTransientChild()
// or RemoveTransientChild().
TEST_F(TransientWindowManagerTest, RestackUponAddOrRemoveTransientChild) {
scoped_ptr<Window> windows[4];
for (int i = 0; i < 4; i++)
windows[i].reset(CreateTestWindowWithId(i, root_window()));
EXPECT_EQ("0 1 2 3", ChildWindowIDsAsString(root_window()));
AddTransientChild(windows[0].get(), windows[2].get());
EXPECT_EQ("0 2 1 3", ChildWindowIDsAsString(root_window()));
AddTransientChild(windows[0].get(), windows[3].get());
EXPECT_EQ("0 2 3 1", ChildWindowIDsAsString(root_window()));
RemoveTransientChild(windows[0].get(), windows[2].get());
EXPECT_EQ("0 3 2 1", ChildWindowIDsAsString(root_window()));
RemoveTransientChild(windows[0].get(), windows[3].get());
EXPECT_EQ("0 3 2 1", ChildWindowIDsAsString(root_window()));
}
namespace {
// Used by NotifyDelegateAfterDeletingTransients. Adds a string to a vector when
// OnWindowDestroyed() is invoked so that destruction order can be verified.
class DestroyedTrackingDelegate : public aura::test::TestWindowDelegate {
public:
explicit DestroyedTrackingDelegate(const std::string& name,
std::vector<std::string>* results)
: name_(name),
results_(results) {}
void OnWindowDestroyed(aura::Window* window) override {
results_->push_back(name_);
}
private:
const std::string name_;
std::vector<std::string>* results_;
DISALLOW_COPY_AND_ASSIGN(DestroyedTrackingDelegate);
};
} // namespace
// Verifies the delegate is notified of destruction after transients are
// destroyed.
TEST_F(TransientWindowManagerTest, NotifyDelegateAfterDeletingTransients) {
std::vector<std::string> destruction_order;
DestroyedTrackingDelegate parent_delegate("parent", &destruction_order);
scoped_ptr<Window> parent(new Window(&parent_delegate));
parent->Init(aura::WINDOW_LAYER_NOT_DRAWN);
DestroyedTrackingDelegate transient_delegate("transient", &destruction_order);
Window* transient = new Window(&transient_delegate); // Owned by |parent|.
transient->Init(aura::WINDOW_LAYER_NOT_DRAWN);
AddTransientChild(parent.get(), transient);
parent.reset();
ASSERT_EQ(2u, destruction_order.size());
EXPECT_EQ("transient", destruction_order[0]);
EXPECT_EQ("parent", destruction_order[1]);
}
TEST_F(TransientWindowManagerTest,
StackTransientsLayersRelativeToOtherTransients) {
// Create a window with several transients, then a couple windows on top.
scoped_ptr<Window> window1(CreateTestWindowWithId(1, root_window()));
scoped_ptr<Window> window11(CreateTransientChild(11, window1.get()));
scoped_ptr<Window> window12(CreateTransientChild(12, window1.get()));
scoped_ptr<Window> window13(CreateTransientChild(13, window1.get()));
EXPECT_EQ("1 11 12 13", ChildWindowIDsAsString(root_window()));
// Stack 11 above 12.
root_window()->StackChildAbove(window11.get(), window12.get());
EXPECT_EQ("1 12 11 13", ChildWindowIDsAsString(root_window()));
// Stack 13 below 12.
root_window()->StackChildBelow(window13.get(), window12.get());
EXPECT_EQ("1 13 12 11", ChildWindowIDsAsString(root_window()));
// Stack 11 above 1.
root_window()->StackChildAbove(window11.get(), window1.get());
EXPECT_EQ("1 11 13 12", ChildWindowIDsAsString(root_window()));
// Stack 12 below 13.
root_window()->StackChildBelow(window12.get(), window13.get());
EXPECT_EQ("1 11 12 13", ChildWindowIDsAsString(root_window()));
}
// Verifies TransientWindowObserver is notified appropriately.
TEST_F(TransientWindowManagerTest, TransientWindowObserverNotified) {
scoped_ptr<Window> parent(CreateTestWindowWithId(0, root_window()));
scoped_ptr<Window> w1(CreateTestWindowWithId(1, parent.get()));
TestTransientWindowObserver test_observer;
TransientWindowManager::Get(parent.get())->AddObserver(&test_observer);
AddTransientChild(parent.get(), w1.get());
EXPECT_EQ(1, test_observer.add_count());
EXPECT_EQ(0, test_observer.remove_count());
RemoveTransientChild(parent.get(), w1.get());
EXPECT_EQ(1, test_observer.add_count());
EXPECT_EQ(1, test_observer.remove_count());
TransientWindowManager::Get(parent.get())->RemoveObserver(&test_observer);
}
} // namespace wm
|