1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
|
// Copyright 2016 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/component_updater/origin_trials_component_installer.h"
#include <string>
#include <utility>
#include "base/files/file_path.h"
#include "base/files/scoped_temp_dir.h"
#include "base/memory/ptr_util.h"
#include "base/values.h"
#include "base/version.h"
#include "chrome/browser/browser_process.h"
#include "chrome/common/pref_names.h"
#include "chrome/test/base/scoped_testing_local_state.h"
#include "chrome/test/base/testing_browser_process.h"
#include "components/prefs/scoped_user_pref_update.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "testing/platform_test.h"
namespace {
// Mirror the constants used in the component installer. Do not share the
// constants, as want to catch inadvertent changes in the tests. The keys will
// will be generated server-side, so any changes need to be intentional and
// coordinated.
static const char kManifestOriginTrialsKey[] = "origin-trials";
static const char kManifestPublicKeyPath[] = "origin-trials.public-key";
static const char kManifestDisabledFeaturesPath[] =
"origin-trials.disabled-features";
static const char kTestUpdateVersion[] = "1.0";
static const char kExistingPublicKey[] = "existing public key";
static const char kNewPublicKey[] = "new public key";
static const char kExistingDisabledFeature[] = "already disabled";
static const std::vector<std::string> kExistingDisabledFeatures = {
kExistingDisabledFeature};
static const char kNewDisabledFeature1[] = "newly disabled 1";
static const char kNewDisabledFeature2[] = "newly disabled 2";
static const std::vector<std::string> kNewDisabledFeatures = {
kNewDisabledFeature1, kNewDisabledFeature2};
} // namespace
namespace component_updater {
class OriginTrialsComponentInstallerTest : public PlatformTest {
public:
OriginTrialsComponentInstallerTest()
: testing_local_state_(TestingBrowserProcess::GetGlobal()) {}
void SetUp() override {
PlatformTest::SetUp();
ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());
traits_.reset(new OriginTrialsComponentInstallerTraits());
}
void LoadUpdates(std::unique_ptr<base::DictionaryValue> manifest) {
if (!manifest) {
manifest = base::MakeUnique<base::DictionaryValue>();
manifest->SetString(kManifestOriginTrialsKey, "");
}
ASSERT_TRUE(traits_->VerifyInstallation(*manifest, temp_dir_.GetPath()));
const base::Version expected_version(kTestUpdateVersion);
traits_->ComponentReady(expected_version, temp_dir_.GetPath(),
std::move(manifest));
}
void AddDisabledFeaturesToPrefs(const std::vector<std::string>& features) {
base::ListValue disabled_feature_list;
disabled_feature_list.AppendStrings(features);
ListPrefUpdate update(local_state(), prefs::kOriginTrialDisabledFeatures);
update->Swap(&disabled_feature_list);
}
void CheckDisabledFeaturesPrefs(const std::vector<std::string>& features) {
ASSERT_FALSE(features.empty());
ASSERT_TRUE(
local_state()->HasPrefPath(prefs::kOriginTrialDisabledFeatures));
const base::ListValue* disabled_feature_list =
local_state()->GetList(prefs::kOriginTrialDisabledFeatures);
ASSERT_TRUE(disabled_feature_list);
ASSERT_EQ(features.size(), disabled_feature_list->GetSize());
std::string disabled_feature;
for (size_t i = 0; i < features.size(); ++i) {
const bool found = disabled_feature_list->GetString(i, &disabled_feature);
EXPECT_TRUE(found) << "Entry not found or not a string at index " << i;
if (!found) {
continue;
}
EXPECT_EQ(features[i], disabled_feature)
<< "Feature lists differ at index " << i;
}
}
PrefService* local_state() { return g_browser_process->local_state(); }
protected:
base::ScopedTempDir temp_dir_;
ScopedTestingLocalState testing_local_state_;
std::unique_ptr<ComponentInstallerTraits> traits_;
private:
DISALLOW_COPY_AND_ASSIGN(OriginTrialsComponentInstallerTest);
};
TEST_F(OriginTrialsComponentInstallerTest,
PublicKeyResetToDefaultWhenOverrideMissing) {
local_state()->Set(prefs::kOriginTrialPublicKey,
base::StringValue(kExistingPublicKey));
ASSERT_EQ(kExistingPublicKey,
local_state()->GetString(prefs::kOriginTrialPublicKey));
// Load with empty section in manifest
LoadUpdates(nullptr);
EXPECT_FALSE(local_state()->HasPrefPath(prefs::kOriginTrialPublicKey));
}
TEST_F(OriginTrialsComponentInstallerTest, PublicKeySetWhenOverrideExists) {
ASSERT_FALSE(local_state()->HasPrefPath(prefs::kOriginTrialPublicKey));
auto manifest = base::MakeUnique<base::DictionaryValue>();
manifest->SetString(kManifestPublicKeyPath, kNewPublicKey);
LoadUpdates(std::move(manifest));
EXPECT_EQ(kNewPublicKey,
local_state()->GetString(prefs::kOriginTrialPublicKey));
}
TEST_F(OriginTrialsComponentInstallerTest,
DisabledFeaturesResetToDefaultWhenListMissing) {
AddDisabledFeaturesToPrefs(kExistingDisabledFeatures);
ASSERT_TRUE(local_state()->HasPrefPath(prefs::kOriginTrialDisabledFeatures));
// Load with empty section in manifest
LoadUpdates(nullptr);
EXPECT_FALSE(local_state()->HasPrefPath(prefs::kOriginTrialDisabledFeatures));
}
TEST_F(OriginTrialsComponentInstallerTest,
DisabledFeaturesResetToDefaultWhenListEmpty) {
AddDisabledFeaturesToPrefs(kExistingDisabledFeatures);
ASSERT_TRUE(local_state()->HasPrefPath(prefs::kOriginTrialDisabledFeatures));
auto manifest = base::MakeUnique<base::DictionaryValue>();
auto disabled_feature_list = base::MakeUnique<base::ListValue>();
manifest->Set(kManifestDisabledFeaturesPath,
std::move(disabled_feature_list));
LoadUpdates(std::move(manifest));
EXPECT_FALSE(local_state()->HasPrefPath(prefs::kOriginTrialDisabledFeatures));
}
TEST_F(OriginTrialsComponentInstallerTest, DisabledFeaturesSetWhenListExists) {
ASSERT_FALSE(local_state()->HasPrefPath(prefs::kOriginTrialDisabledFeatures));
auto manifest = base::MakeUnique<base::DictionaryValue>();
auto disabled_feature_list = base::MakeUnique<base::ListValue>();
disabled_feature_list->AppendString(kNewDisabledFeature1);
manifest->Set(kManifestDisabledFeaturesPath,
std::move(disabled_feature_list));
LoadUpdates(std::move(manifest));
std::vector<std::string> features = {kNewDisabledFeature1};
CheckDisabledFeaturesPrefs(features);
}
TEST_F(OriginTrialsComponentInstallerTest,
DisabledFeaturesReplacedWhenListExists) {
AddDisabledFeaturesToPrefs(kExistingDisabledFeatures);
ASSERT_TRUE(local_state()->HasPrefPath(prefs::kOriginTrialDisabledFeatures));
auto manifest = base::MakeUnique<base::DictionaryValue>();
auto disabled_feature_list = base::MakeUnique<base::ListValue>();
disabled_feature_list->AppendStrings(kNewDisabledFeatures);
manifest->Set(kManifestDisabledFeaturesPath,
std::move(disabled_feature_list));
LoadUpdates(std::move(manifest));
CheckDisabledFeaturesPrefs(kNewDisabledFeatures);
}
} // namespace component_updater
|
