1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434
|
// Copyright 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "base/compiler_specific.h"
#include "base/macros.h"
#include "base/memory/scoped_vector.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/sync/test/integration/bookmarks_helper.h"
#include "chrome/browser/sync/test/integration/migration_waiter.h"
#include "chrome/browser/sync/test/integration/migration_watcher.h"
#include "chrome/browser/sync/test/integration/preferences_helper.h"
#include "chrome/browser/sync/test/integration/profile_sync_service_harness.h"
#include "chrome/browser/sync/test/integration/sync_test.h"
#include "chrome/common/pref_names.h"
#include "components/browser_sync/profile_sync_service.h"
#include "components/prefs/scoped_user_pref_update.h"
#include "components/translate/core/browser/translate_prefs.h"
using bookmarks_helper::AddURL;
using bookmarks_helper::IndexedURL;
using bookmarks_helper::IndexedURLTitle;
using preferences_helper::BooleanPrefMatches;
using preferences_helper::ChangeBooleanPref;
namespace {
// Utility functions to make a model type set out of a small number of
// model types.
syncer::ModelTypeSet MakeSet(syncer::ModelType type) {
return syncer::ModelTypeSet(type);
}
syncer::ModelTypeSet MakeSet(syncer::ModelType type1,
syncer::ModelType type2) {
return syncer::ModelTypeSet(type1, type2);
}
// An ordered list of model types sets to migrate. Used by
// RunMigrationTest().
typedef std::deque<syncer::ModelTypeSet> MigrationList;
// Utility functions to make a MigrationList out of a small number of
// model types / model type sets.
MigrationList MakeList(syncer::ModelTypeSet model_types) {
return MigrationList(1, model_types);
}
MigrationList MakeList(syncer::ModelTypeSet model_types1,
syncer::ModelTypeSet model_types2) {
MigrationList migration_list;
migration_list.push_back(model_types1);
migration_list.push_back(model_types2);
return migration_list;
}
MigrationList MakeList(syncer::ModelType type) {
return MakeList(MakeSet(type));
}
MigrationList MakeList(syncer::ModelType type1,
syncer::ModelType type2) {
return MakeList(MakeSet(type1), MakeSet(type2));
}
class MigrationTest : public SyncTest {
public:
explicit MigrationTest(TestType test_type) : SyncTest(test_type) {}
~MigrationTest() override {}
enum TriggerMethod { MODIFY_PREF, MODIFY_BOOKMARK, TRIGGER_NOTIFICATION };
// Set up sync for all profiles and initialize all MigrationWatchers. This
// helps ensure that all migration events are captured, even if they were to
// occur before a test calls AwaitMigration for a specific profile.
bool SetupSync() override {
if (!SyncTest::SetupSync())
return false;
for (int i = 0; i < num_clients(); ++i) {
MigrationWatcher* watcher = new MigrationWatcher(GetClient(i));
migration_watchers_.push_back(watcher);
}
return true;
}
syncer::ModelTypeSet GetPreferredDataTypes() {
// ProfileSyncService must already have been created before we can call
// GetPreferredDataTypes().
DCHECK(GetSyncService(0));
syncer::ModelTypeSet preferred_data_types =
GetSyncService(0)->GetPreferredDataTypes();
preferred_data_types.RemoveAll(syncer::ProxyTypes());
// Supervised user data types will be "unready" during this test, so we
// should not request that they be migrated.
preferred_data_types.Remove(syncer::SUPERVISED_USER_SETTINGS);
preferred_data_types.Remove(syncer::SUPERVISED_USER_WHITELISTS);
// Autofill wallet will be unready during this test, so we should not
// request that it be migrated.
preferred_data_types.Remove(syncer::AUTOFILL_WALLET_DATA);
preferred_data_types.Remove(syncer::AUTOFILL_WALLET_METADATA);
// Arc package will be unready during this test, so we should not request
// that it be migrated.
preferred_data_types.Remove(syncer::ARC_PACKAGE);
// Make sure all clients have the same preferred data types.
for (int i = 1; i < num_clients(); ++i) {
const syncer::ModelTypeSet other_preferred_data_types =
GetSyncService(i)->GetPreferredDataTypes();
EXPECT_EQ(other_preferred_data_types, preferred_data_types);
}
return preferred_data_types;
}
// Returns a MigrationList with every enabled data type in its own
// set.
MigrationList GetPreferredDataTypesList() {
MigrationList migration_list;
const syncer::ModelTypeSet preferred_data_types =
GetPreferredDataTypes();
for (syncer::ModelTypeSet::Iterator it =
preferred_data_types.First(); it.Good(); it.Inc()) {
migration_list.push_back(MakeSet(it.Get()));
}
return migration_list;
}
// Trigger a migration for the given types with the given method.
void TriggerMigration(syncer::ModelTypeSet model_types,
TriggerMethod trigger_method) {
switch (trigger_method) {
case MODIFY_PREF:
// Unlike MODIFY_BOOKMARK, MODIFY_PREF doesn't cause a
// notification to happen (since model association on a
// boolean pref clobbers the local value), so it doesn't work
// for anything but single-client tests.
ASSERT_EQ(1, num_clients());
ASSERT_TRUE(BooleanPrefMatches(prefs::kShowHomeButton));
ChangeBooleanPref(0, prefs::kShowHomeButton);
break;
case MODIFY_BOOKMARK:
ASSERT_TRUE(AddURL(0, IndexedURLTitle(0), GURL(IndexedURL(0))));
break;
case TRIGGER_NOTIFICATION:
TriggerNotification(model_types);
break;
default:
ADD_FAILURE();
}
}
// Block until all clients have completed migration for the given
// types.
void AwaitMigration(syncer::ModelTypeSet migrate_types) {
for (int i = 0; i < num_clients(); ++i) {
ASSERT_TRUE(
MigrationWaiter(migrate_types, migration_watchers_[i]).Wait());
}
}
// Makes sure migration works with the given migration list and
// trigger method.
void RunMigrationTest(const MigrationList& migration_list,
TriggerMethod trigger_method) {
// If we have only one client, turn off notifications to avoid the
// possibility of spurious sync cycles.
bool do_test_without_notifications =
(trigger_method != TRIGGER_NOTIFICATION && num_clients() == 1);
if (do_test_without_notifications) {
DisableNotifications();
}
// Make sure migration hasn't been triggered prematurely.
for (int i = 0; i < num_clients(); ++i) {
ASSERT_TRUE(migration_watchers_[i]->GetMigratedTypes().Empty());
}
// Phase 1: Trigger the migrations on the server.
for (MigrationList::const_iterator it = migration_list.begin();
it != migration_list.end(); ++it) {
TriggerMigrationDoneError(*it);
}
// Phase 2: Trigger each migration individually and wait for it to
// complete. (Multiple migrations may be handled by each
// migration cycle, but there's no guarantee of that, so we have
// to trigger each migration individually.)
for (MigrationList::const_iterator it = migration_list.begin();
it != migration_list.end(); ++it) {
TriggerMigration(*it, trigger_method);
AwaitMigration(*it);
}
// Phase 3: Wait for all clients to catch up.
//
// AwaitQuiescence() will not succeed when notifications are disabled. We
// can safely avoid calling it because we know that, in the single client
// case, there is no one else to wait for.
//
// TODO(rlarocque, 97780): Remove the if condition when the test harness
// supports calling AwaitQuiescence() when notifications are disabled.
if (!do_test_without_notifications) {
AwaitQuiescence();
}
// TODO(rlarocque): It should be possible to re-enable notifications
// here, but doing so makes some windows tests flaky.
}
private:
// Used to keep track of the migration progress for each sync client.
ScopedVector<MigrationWatcher> migration_watchers_;
DISALLOW_COPY_AND_ASSIGN(MigrationTest);
};
class MigrationSingleClientTest : public MigrationTest {
public:
MigrationSingleClientTest() : MigrationTest(SINGLE_CLIENT_LEGACY) {}
~MigrationSingleClientTest() override {}
void RunSingleClientMigrationTest(const MigrationList& migration_list,
TriggerMethod trigger_method) {
ASSERT_TRUE(SetupSync());
RunMigrationTest(migration_list, trigger_method);
}
private:
DISALLOW_COPY_AND_ASSIGN(MigrationSingleClientTest);
};
// The simplest possible migration tests -- a single data type.
IN_PROC_BROWSER_TEST_F(MigrationSingleClientTest, PrefsOnlyModifyPref) {
RunSingleClientMigrationTest(MakeList(syncer::PREFERENCES), MODIFY_PREF);
}
IN_PROC_BROWSER_TEST_F(MigrationSingleClientTest, PrefsOnlyModifyBookmark) {
RunSingleClientMigrationTest(MakeList(syncer::PREFERENCES),
MODIFY_BOOKMARK);
}
IN_PROC_BROWSER_TEST_F(MigrationSingleClientTest,
PrefsOnlyTriggerNotification) {
RunSingleClientMigrationTest(MakeList(syncer::PREFERENCES),
TRIGGER_NOTIFICATION);
}
// Nigori is handled specially, so we test that separately.
IN_PROC_BROWSER_TEST_F(MigrationSingleClientTest, NigoriOnly) {
RunSingleClientMigrationTest(MakeList(syncer::PREFERENCES),
TRIGGER_NOTIFICATION);
}
// A little more complicated -- two data types.
IN_PROC_BROWSER_TEST_F(MigrationSingleClientTest, BookmarksPrefsIndividually) {
RunSingleClientMigrationTest(
MakeList(syncer::BOOKMARKS, syncer::PREFERENCES),
MODIFY_PREF);
}
IN_PROC_BROWSER_TEST_F(MigrationSingleClientTest, BookmarksPrefsBoth) {
RunSingleClientMigrationTest(
MakeList(MakeSet(syncer::BOOKMARKS, syncer::PREFERENCES)),
MODIFY_BOOKMARK);
}
// Two data types with one being nigori.
// See crbug.com/124480.
IN_PROC_BROWSER_TEST_F(MigrationSingleClientTest,
DISABLED_PrefsNigoriIndividiaully) {
RunSingleClientMigrationTest(
MakeList(syncer::PREFERENCES, syncer::NIGORI),
TRIGGER_NOTIFICATION);
}
IN_PROC_BROWSER_TEST_F(MigrationSingleClientTest, PrefsNigoriBoth) {
RunSingleClientMigrationTest(
MakeList(MakeSet(syncer::PREFERENCES, syncer::NIGORI)),
MODIFY_PREF);
}
// The whole shebang -- all data types.
// http://crbug.com/403778
IN_PROC_BROWSER_TEST_F(MigrationSingleClientTest,
DISABLED_AllTypesIndividually) {
ASSERT_TRUE(SetupClients());
RunSingleClientMigrationTest(GetPreferredDataTypesList(), MODIFY_BOOKMARK);
}
// http://crbug.com/403778
IN_PROC_BROWSER_TEST_F(MigrationSingleClientTest,
DISABLED_AllTypesIndividuallyTriggerNotification) {
ASSERT_TRUE(SetupClients());
RunSingleClientMigrationTest(GetPreferredDataTypesList(),
TRIGGER_NOTIFICATION);
}
IN_PROC_BROWSER_TEST_F(MigrationSingleClientTest, AllTypesAtOnce) {
ASSERT_TRUE(SetupClients());
RunSingleClientMigrationTest(MakeList(GetPreferredDataTypes()),
MODIFY_PREF);
}
IN_PROC_BROWSER_TEST_F(MigrationSingleClientTest,
AllTypesAtOnceTriggerNotification) {
ASSERT_TRUE(SetupClients());
RunSingleClientMigrationTest(MakeList(GetPreferredDataTypes()),
TRIGGER_NOTIFICATION);
}
// All data types plus nigori.
// See crbug.com/124480.
IN_PROC_BROWSER_TEST_F(MigrationSingleClientTest,
DISABLED_AllTypesWithNigoriIndividually) {
ASSERT_TRUE(SetupClients());
MigrationList migration_list = GetPreferredDataTypesList();
migration_list.push_front(MakeSet(syncer::NIGORI));
RunSingleClientMigrationTest(migration_list, MODIFY_BOOKMARK);
}
IN_PROC_BROWSER_TEST_F(MigrationSingleClientTest, AllTypesWithNigoriAtOnce) {
ASSERT_TRUE(SetupClients());
syncer::ModelTypeSet all_types = GetPreferredDataTypes();
all_types.Put(syncer::NIGORI);
RunSingleClientMigrationTest(MakeList(all_types), MODIFY_PREF);
}
class MigrationTwoClientTest : public MigrationTest {
public:
MigrationTwoClientTest() : MigrationTest(TWO_CLIENT_LEGACY) {}
~MigrationTwoClientTest() override {}
// Helper function that verifies that preferences sync still works.
void VerifyPrefSync() {
ASSERT_TRUE(BooleanPrefMatches(prefs::kShowHomeButton));
ChangeBooleanPref(0, prefs::kShowHomeButton);
ASSERT_TRUE(GetClient(0)->AwaitMutualSyncCycleCompletion(GetClient(1)));
ASSERT_TRUE(BooleanPrefMatches(prefs::kShowHomeButton));
}
void RunTwoClientMigrationTest(const MigrationList& migration_list,
TriggerMethod trigger_method) {
ASSERT_TRUE(SetupSync());
// Make sure pref sync works before running the migration test.
VerifyPrefSync();
RunMigrationTest(migration_list, trigger_method);
// Make sure pref sync still works after running the migration
// test.
VerifyPrefSync();
}
private:
DISALLOW_COPY_AND_ASSIGN(MigrationTwoClientTest);
};
// Easiest possible test of migration errors: triggers a server
// migration on one datatype, then modifies some other datatype.
IN_PROC_BROWSER_TEST_F(MigrationTwoClientTest, MigratePrefsThenModifyBookmark) {
RunTwoClientMigrationTest(MakeList(syncer::PREFERENCES),
MODIFY_BOOKMARK);
}
// Triggers a server migration on two datatypes, then makes a local
// modification to one of them.
IN_PROC_BROWSER_TEST_F(MigrationTwoClientTest,
MigratePrefsAndBookmarksThenModifyBookmark) {
RunTwoClientMigrationTest(
MakeList(syncer::PREFERENCES, syncer::BOOKMARKS),
MODIFY_BOOKMARK);
}
// Migrate every datatype in sequence; the catch being that the server
// will only tell the client about the migrations one at a time.
// TODO(rsimha): This test takes longer than 60 seconds, and will cause tree
// redness due to sharding.
// Re-enable this test after syncer::kInitialBackoffShortRetrySeconds is reduced
// to zero.
IN_PROC_BROWSER_TEST_F(MigrationTwoClientTest,
DISABLED_MigrationHellWithoutNigori) {
ASSERT_TRUE(SetupClients());
MigrationList migration_list = GetPreferredDataTypesList();
// Let the first nudge be a datatype that's neither prefs nor
// bookmarks.
migration_list.push_front(MakeSet(syncer::THEMES));
RunTwoClientMigrationTest(migration_list, MODIFY_BOOKMARK);
}
// See crbug.com/124480.
IN_PROC_BROWSER_TEST_F(MigrationTwoClientTest,
DISABLED_MigrationHellWithNigori) {
ASSERT_TRUE(SetupClients());
MigrationList migration_list = GetPreferredDataTypesList();
// Let the first nudge be a datatype that's neither prefs nor
// bookmarks.
migration_list.push_front(MakeSet(syncer::THEMES));
// Pop off one so that we don't migrate all data types; the syncer
// freaks out if we do that (see http://crbug.com/94882).
ASSERT_GE(migration_list.size(), 2u);
ASSERT_NE(MakeSet(syncer::NIGORI), migration_list.back());
migration_list.back() = MakeSet(syncer::NIGORI);
RunTwoClientMigrationTest(migration_list, MODIFY_BOOKMARK);
}
class MigrationReconfigureTest : public MigrationTwoClientTest {
public:
MigrationReconfigureTest() {}
void SetUpCommandLine(base::CommandLine* cl) override {
AddTestSwitches(cl);
// Do not add optional datatypes.
}
~MigrationReconfigureTest() override {}
private:
DISALLOW_COPY_AND_ASSIGN(MigrationReconfigureTest);
};
} // namespace
|