1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825
|
// Copyright 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#import "chrome/browser/ui/cocoa/browser_window_controller.h"
#include <memory>
#include "base/mac/mac_util.h"
#import "base/mac/scoped_nsobject.h"
#include "chrome/app/chrome_command_ids.h"
#include "chrome/browser/chrome_notification_types.h"
#include "chrome/browser/ui/browser_list.h"
#include "chrome/browser/ui/browser_window.h"
#include "chrome/browser/ui/cocoa/find_bar/find_bar_bridge.h"
#import "chrome/browser/ui/cocoa/fast_resize_view.h"
#include "chrome/browser/ui/cocoa/tabs/tab_strip_view.h"
#include "chrome/browser/ui/cocoa/test/cocoa_profile_test.h"
#include "chrome/browser/ui/cocoa/test/run_loop_testing.h"
#import "chrome/browser/ui/cocoa/toolbar/toolbar_controller.h"
#include "chrome/common/pref_names.h"
#include "chrome/test/base/testing_profile.h"
#include "components/bookmarks/common/bookmark_pref_names.h"
#include "components/prefs/pref_service.h"
#include "content/public/browser/notification_service.h"
#include "content/public/test/test_utils.h"
#include "testing/gmock/include/gmock/gmock.h"
#import "testing/gtest_mac.h"
#import "third_party/ocmock/OCMock/OCMock.h"
#import "ui/base/test/scoped_fake_nswindow_fullscreen.h"
using ::testing::Return;
@interface BrowserWindowController (JustForTesting)
// Already defined in BWC.
- (void)saveWindowPositionIfNeeded;
- (void)layoutSubviews;
@end
@interface BrowserWindowController (ExposedForTesting)
// Implementations are below.
- (NSView*)infoBarContainerView;
- (NSView*)toolbarView;
- (NSView*)bookmarkView;
- (BOOL)bookmarkBarVisible;
@end
@implementation BrowserWindowController (ExposedForTesting)
- (NSView*)infoBarContainerView {
return [infoBarContainerController_ view];
}
- (NSView*)toolbarView {
return [toolbarController_ view];
}
- (NSView*)bookmarkView {
return [bookmarkBarController_ view];
}
- (NSView*)findBarView {
return [findBarCocoaController_ view];
}
- (BOOL)bookmarkBarVisible {
return [bookmarkBarController_ isVisible];
}
@end
class BrowserWindowControllerTest : public CocoaProfileTest {
public:
void SetUp() override {
CocoaProfileTest::SetUp();
ASSERT_TRUE(browser());
controller_ = [[BrowserWindowController alloc] initWithBrowser:browser()
takeOwnership:NO];
}
void TearDown() override {
[controller_ close];
CocoaProfileTest::TearDown();
}
public:
BrowserWindowController* controller_;
};
TEST_F(BrowserWindowControllerTest, TestSaveWindowPosition) {
PrefService* prefs = profile()->GetPrefs();
ASSERT_TRUE(prefs != NULL);
// Check to make sure there is no existing pref for window placement.
const base::DictionaryValue* browser_window_placement =
prefs->GetDictionary(prefs::kBrowserWindowPlacement);
ASSERT_TRUE(browser_window_placement);
EXPECT_TRUE(browser_window_placement->empty());
// Ask the window to save its position, then check that a preference
// exists.
BrowserList::SetLastActive(browser());
[controller_ saveWindowPositionIfNeeded];
browser_window_placement =
prefs->GetDictionary(prefs::kBrowserWindowPlacement);
ASSERT_TRUE(browser_window_placement);
EXPECT_FALSE(browser_window_placement->empty());
}
TEST_F(BrowserWindowControllerTest, TestFullScreenWindow) {
// Confirm that |-createFullscreenWindow| doesn't return nil.
// See BrowserWindowFullScreenControllerTest for more fullscreen tests.
EXPECT_TRUE([controller_ createFullscreenWindow]);
}
TEST_F(BrowserWindowControllerTest, TestNormal) {
// Force the bookmark bar to be shown.
profile()->GetPrefs()->SetBoolean(bookmarks::prefs::kShowBookmarkBar, true);
[controller_ browserWindow]->BookmarkBarStateChanged(
BookmarkBar::DONT_ANIMATE_STATE_CHANGE);
// Make sure a normal BrowserWindowController is, uh, normal.
EXPECT_TRUE([controller_ isTabbedWindow]);
EXPECT_TRUE([controller_ hasTabStrip]);
EXPECT_FALSE([controller_ hasTitleBar]);
EXPECT_TRUE([controller_ isBookmarkBarVisible]);
// And make sure a controller for a pop-up window is not normal.
// popup_browser will be owned by its window.
Browser* popup_browser(
new Browser(Browser::CreateParams(Browser::TYPE_POPUP, profile())));
NSWindow* cocoaWindow = popup_browser->window()->GetNativeWindow();
BrowserWindowController* controller =
static_cast<BrowserWindowController*>([cocoaWindow windowController]);
ASSERT_TRUE([controller isKindOfClass:[BrowserWindowController class]]);
EXPECT_FALSE([controller isTabbedWindow]);
EXPECT_FALSE([controller hasTabStrip]);
EXPECT_TRUE([controller hasTitleBar]);
EXPECT_FALSE([controller isBookmarkBarVisible]);
[controller close];
}
TEST_F(BrowserWindowControllerTest, TestSetBounds) {
// Create a normal browser with bounds smaller than the minimum.
Browser::CreateParams params(Browser::TYPE_TABBED, profile());
params.initial_bounds = gfx::Rect(0, 0, 50, 50);
Browser* browser = new Browser(params);
NSWindow* cocoaWindow = browser->window()->GetNativeWindow();
BrowserWindowController* controller =
static_cast<BrowserWindowController*>([cocoaWindow windowController]);
ASSERT_TRUE([controller isTabbedWindow]);
BrowserWindow* browser_window = [controller browserWindow];
EXPECT_EQ(browser_window, browser->window());
gfx::Rect bounds = browser_window->GetBounds();
EXPECT_EQ(400, bounds.width());
EXPECT_EQ(272, bounds.height());
// Try to set the bounds smaller than the minimum.
browser_window->SetBounds(gfx::Rect(0, 0, 50, 50));
bounds = browser_window->GetBounds();
EXPECT_EQ(400, bounds.width());
EXPECT_EQ(272, bounds.height());
[controller close];
}
TEST_F(BrowserWindowControllerTest, TestSetBoundsPopup) {
// Create a popup with bounds smaller than the minimum.
Browser::CreateParams params(Browser::TYPE_POPUP, profile());
params.initial_bounds = gfx::Rect(0, 0, 50, 50);
Browser* browser = new Browser(params);
NSWindow* cocoaWindow = browser->window()->GetNativeWindow();
BrowserWindowController* controller =
static_cast<BrowserWindowController*>([cocoaWindow windowController]);
ASSERT_FALSE([controller isTabbedWindow]);
BrowserWindow* browser_window = [controller browserWindow];
EXPECT_EQ(browser_window, browser->window());
gfx::Rect bounds = browser_window->GetBounds();
EXPECT_EQ(100, bounds.width());
EXPECT_EQ(122, bounds.height());
// Try to set the bounds smaller than the minimum.
browser_window->SetBounds(gfx::Rect(0, 0, 50, 50));
bounds = browser_window->GetBounds();
EXPECT_EQ(100, bounds.width());
EXPECT_EQ(122, bounds.height());
[controller close];
}
TEST_F(BrowserWindowControllerTest, TestTheme) {
[controller_ userChangedTheme];
}
TEST_F(BrowserWindowControllerTest, BookmarkBarControllerIndirection) {
EXPECT_FALSE([controller_ isBookmarkBarVisible]);
// Explicitly show the bar. Can't use chrome::ToggleBookmarkBarWhenVisible()
// because of the notification issues.
profile()->GetPrefs()->SetBoolean(bookmarks::prefs::kShowBookmarkBar, true);
[controller_ browserWindow]->BookmarkBarStateChanged(
BookmarkBar::DONT_ANIMATE_STATE_CHANGE);
EXPECT_TRUE([controller_ isBookmarkBarVisible]);
}
TEST_F(BrowserWindowControllerTest, BookmarkBarToggleRespectMinWindowHeight) {
Browser::CreateParams params(Browser::TYPE_TABBED, profile());
params.initial_bounds = gfx::Rect(0, 0, 50, 280);
Browser* browser = new Browser(params);
NSWindow* cocoaWindow = browser->window()->GetNativeWindow();
BrowserWindowController* controller =
static_cast<BrowserWindowController*>([cocoaWindow windowController]);
BrowserWindow* browser_window = [controller browserWindow];
gfx::Rect bounds = browser_window->GetBounds();
EXPECT_EQ(280, bounds.height());
// Try to set the bounds smaller than the minimum.
// Explicitly show the bar. Can't use chrome::ToggleBookmarkBarWhenVisible()
// because of the notification issues.
[controller adjustWindowHeightBy:-20];
bounds = browser_window->GetBounds();
EXPECT_EQ(272, bounds.height());
[controller close];
}
#if 0
// TODO(jrg): This crashes trying to create the BookmarkBarController, adding
// an observer to the BookmarkModel.
TEST_F(BrowserWindowControllerTest, TestIncognitoWidthSpace) {
std::unique_ptr<TestingProfile> incognito_profile(new TestingProfile());
incognito_profile->set_off_the_record(true);
std::unique_ptr<Browser> browser(
new Browser(Browser::CreateParams(incognito_profile.get())));
controller_.reset([[BrowserWindowController alloc]
initWithBrowser:browser.get()
takeOwnership:NO]);
NSRect tabFrame = [[controller_ tabStripView] frame];
[controller_ installIncognitoBadge];
NSRect newTabFrame = [[controller_ tabStripView] frame];
EXPECT_GT(tabFrame.size.width, newTabFrame.size.width);
controller_.release();
}
#endif
namespace {
// Returns the frame of the view in window coordinates.
NSRect FrameInWindowForView(NSView* view) {
return [[view superview] convertRect:[view frame] toView:nil];
}
// Whether the view's frame is within the bounds of the superview.
BOOL ViewContainmentValid(NSView* view) {
if (NSIsEmptyRect([view frame]))
return YES;
return NSContainsRect([[view superview] bounds], [view frame]);
}
// Checks the view hierarchy rooted at |view| to ensure that each view is
// properly contained.
BOOL ViewHierarchyContainmentValid(NSView* view) {
// TODO(erikchen): Fix these views to have correct containment.
// http://crbug.com/397665.
if ([view isKindOfClass:NSClassFromString(@"DownloadShelfView")])
return YES;
if ([view isKindOfClass:NSClassFromString(@"BookmarkBarToolbarView")])
return YES;
if ([view isKindOfClass:NSClassFromString(@"BrowserActionsContainerView")])
return YES;
if (!ViewContainmentValid(view)) {
LOG(ERROR) << "View violates containment: " <<
[[view description] UTF8String];
return NO;
}
for (NSView* subview in [view subviews]) {
BOOL result = ViewHierarchyContainmentValid(subview);
if (!result)
return NO;
}
return YES;
}
// Verifies that the toolbar, infobar, tab content area, and download shelf
// completely fill the area under the tabstrip.
void CheckViewPositions(BrowserWindowController* controller) {
EXPECT_TRUE(ViewHierarchyContainmentValid([[controller window] contentView]));
NSRect contentView = FrameInWindowForView([[controller window] contentView]);
NSRect tabstrip = FrameInWindowForView([controller tabStripView]);
NSRect toolbar = FrameInWindowForView([controller toolbarView]);
NSRect infobar = FrameInWindowForView([controller infoBarContainerView]);
NSRect tabContent = FrameInWindowForView([controller tabContentArea]);
NSRect download = NSZeroRect;
if ([[[controller downloadShelf] view] superview])
download = [[[controller downloadShelf] view] frame];
EXPECT_EQ(NSMinY(contentView), NSMinY(download));
EXPECT_EQ(NSMaxY(download), NSMinY(tabContent));
EXPECT_EQ(NSMaxY(tabContent), NSMinY(infobar));
// Bookmark bar frame is random memory when hidden.
if ([controller bookmarkBarVisible]) {
NSRect bookmark = [[controller bookmarkView] frame];
EXPECT_EQ(NSMaxY(infobar), NSMinY(bookmark));
EXPECT_EQ(NSMaxY(bookmark), NSMinY(toolbar));
EXPECT_FALSE([[controller bookmarkView] isHidden]);
} else {
EXPECT_EQ(NSMaxY(infobar), NSMinY(toolbar));
EXPECT_TRUE([[controller bookmarkView] isHidden]);
}
// Toolbar should start immediately under the tabstrip, but the tabstrip is
// not necessarily fixed with respect to the content view.
EXPECT_EQ(NSMinY(tabstrip), NSMaxY(toolbar));
}
} // end namespace
TEST_F(BrowserWindowControllerTest, TestAdjustWindowHeight) {
NSWindow* window = [controller_ window];
NSRect workarea = [[window screen] visibleFrame];
// Place the window well above the bottom of the screen and try to adjust its
// height. It should change appropriately (and only downwards). Then get it to
// shrink by the same amount; it should return to its original state.
NSRect initialFrame = NSMakeRect(workarea.origin.x, workarea.origin.y + 100,
200, 280);
[window setFrame:initialFrame display:YES];
[controller_ resetWindowGrowthState];
[controller_ adjustWindowHeightBy:40];
NSRect finalFrame = [window frame];
EXPECT_NSNE(finalFrame, initialFrame);
EXPECT_FLOAT_EQ(NSMaxY(finalFrame), NSMaxY(initialFrame));
EXPECT_FLOAT_EQ(NSHeight(finalFrame), NSHeight(initialFrame) + 40);
[controller_ adjustWindowHeightBy:-40];
finalFrame = [window frame];
EXPECT_FLOAT_EQ(NSMaxY(finalFrame), NSMaxY(initialFrame));
EXPECT_FLOAT_EQ(NSHeight(finalFrame), NSHeight(initialFrame));
// Place the window at the bottom of the screen and try again. Its height
// should still change, but it should not grow down below the work area; it
// should instead move upwards. Then shrink it and make sure it goes back to
// the way it was.
initialFrame = NSMakeRect(workarea.origin.x, workarea.origin.y, 200, 280);
[window setFrame:initialFrame display:YES];
[controller_ resetWindowGrowthState];
[controller_ adjustWindowHeightBy:40];
finalFrame = [window frame];
EXPECT_NSNE(finalFrame, initialFrame);
EXPECT_FLOAT_EQ(NSMinY(finalFrame), NSMinY(initialFrame));
EXPECT_FLOAT_EQ(NSHeight(finalFrame), NSHeight(initialFrame) + 40);
[controller_ adjustWindowHeightBy:-40];
finalFrame = [window frame];
EXPECT_FLOAT_EQ(NSMinY(finalFrame), NSMinY(initialFrame));
EXPECT_FLOAT_EQ(NSHeight(finalFrame), NSHeight(initialFrame));
// Put the window slightly offscreen and try again. The height should not
// change this time.
initialFrame = NSMakeRect(workarea.origin.x - 10, 0, 200, 280);
[window setFrame:initialFrame display:YES];
[controller_ resetWindowGrowthState];
[controller_ adjustWindowHeightBy:40];
EXPECT_NSEQ([window frame], initialFrame);
[controller_ adjustWindowHeightBy:-40];
EXPECT_NSEQ([window frame], initialFrame);
// Make the window the same size as the workarea. Resizing both larger and
// smaller should have no effect.
[window setFrame:workarea display:YES];
[controller_ resetWindowGrowthState];
[controller_ adjustWindowHeightBy:40];
EXPECT_NSEQ([window frame], workarea);
[controller_ adjustWindowHeightBy:-40];
EXPECT_NSEQ([window frame], workarea);
// Make the window smaller than the workarea and place it near the bottom of
// the workarea. The window should grow down until it hits the bottom and
// then continue to grow up. Then shrink it, and it should return to where it
// was.
initialFrame = NSMakeRect(workarea.origin.x, workarea.origin.y + 5,
200, 280);
[window setFrame:initialFrame display:YES];
[controller_ resetWindowGrowthState];
[controller_ adjustWindowHeightBy:40];
finalFrame = [window frame];
EXPECT_FLOAT_EQ(NSMinY(workarea), NSMinY(finalFrame));
EXPECT_FLOAT_EQ(NSHeight(finalFrame), NSHeight(initialFrame) + 40);
[controller_ adjustWindowHeightBy:-40];
finalFrame = [window frame];
EXPECT_FLOAT_EQ(NSMinY(initialFrame), NSMinY(finalFrame));
EXPECT_FLOAT_EQ(NSHeight(initialFrame), NSHeight(finalFrame));
// Inset the window slightly from the workarea. It should not grow to be
// larger than the workarea. Shrink it; it should return to where it started.
initialFrame = NSInsetRect(workarea, 0, 5);
[window setFrame:initialFrame display:YES];
[controller_ resetWindowGrowthState];
[controller_ adjustWindowHeightBy:40];
finalFrame = [window frame];
EXPECT_FLOAT_EQ(NSMinY(workarea), NSMinY(finalFrame));
EXPECT_FLOAT_EQ(NSHeight(workarea), NSHeight(finalFrame));
[controller_ adjustWindowHeightBy:-40];
finalFrame = [window frame];
EXPECT_FLOAT_EQ(NSMinY(initialFrame), NSMinY(finalFrame));
EXPECT_FLOAT_EQ(NSHeight(initialFrame), NSHeight(finalFrame));
// Place the window at the bottom of the screen and grow; it should grow
// upwards. Move the window off the bottom, then shrink. It should then shrink
// from the bottom.
initialFrame = NSMakeRect(workarea.origin.x, workarea.origin.y, 200, 280);
[window setFrame:initialFrame display:YES];
[controller_ resetWindowGrowthState];
[controller_ adjustWindowHeightBy:40];
finalFrame = [window frame];
EXPECT_NSNE(finalFrame, initialFrame);
EXPECT_FLOAT_EQ(NSMinY(finalFrame), NSMinY(initialFrame));
EXPECT_FLOAT_EQ(NSHeight(finalFrame), NSHeight(initialFrame) + 40);
NSPoint oldOrigin = initialFrame.origin;
NSPoint newOrigin = NSMakePoint(oldOrigin.x, oldOrigin.y + 10);
[window setFrameOrigin:newOrigin];
initialFrame = [window frame];
EXPECT_FLOAT_EQ(NSMinY(initialFrame), oldOrigin.y + 10);
[controller_ adjustWindowHeightBy:-40];
finalFrame = [window frame];
EXPECT_FLOAT_EQ(NSMinY(finalFrame), NSMinY(initialFrame) + 40);
EXPECT_FLOAT_EQ(NSHeight(finalFrame), NSHeight(initialFrame) - 40);
// Do the "inset" test above, but using multiple calls to
// |-adjustWindowHeightBy|; the result should be the same.
initialFrame = NSInsetRect(workarea, 0, 5);
[window setFrame:initialFrame display:YES];
[controller_ resetWindowGrowthState];
for (int i = 0; i < 8; i++)
[controller_ adjustWindowHeightBy:5];
finalFrame = [window frame];
EXPECT_FLOAT_EQ(NSMinY(workarea), NSMinY(finalFrame));
EXPECT_FLOAT_EQ(NSHeight(workarea), NSHeight(finalFrame));
for (int i = 0; i < 8; i++)
[controller_ adjustWindowHeightBy:-5];
finalFrame = [window frame];
EXPECT_FLOAT_EQ(NSMinY(initialFrame), NSMinY(finalFrame));
EXPECT_FLOAT_EQ(NSHeight(initialFrame), NSHeight(finalFrame));
}
// Test to make sure resizing and relaying-out subviews works correctly.
TEST_F(BrowserWindowControllerTest, TestResizeViews) {
TabStripView* tabstrip = [controller_ tabStripView];
NSView* contentView = [[tabstrip window] contentView];
NSView* toolbar = [controller_ toolbarView];
NSView* infobar = [controller_ infoBarContainerView];
// We need to muck with the views a bit to put us in a consistent state before
// we start resizing. In particular, we need to move the tab strip to be
// immediately above the content area, since we layout views to be directly
// under the tab strip.
NSRect tabstripFrame = [tabstrip frame];
tabstripFrame.origin.y = NSMaxY([contentView frame]);
[tabstrip setFrame:tabstripFrame];
// Make the download shelf and set its initial height to 0.
[controller_ createAndAddDownloadShelf];
NSView* download = [[controller_ downloadShelf] view];
NSRect downloadFrame = [download frame];
downloadFrame.size.height = 0;
[download setFrame:downloadFrame];
// Force a layout and check each view's frame.
[controller_ layoutSubviews];
CheckViewPositions(controller_);
// Expand the infobar to 60px and recheck
[controller_ resizeView:infobar newHeight:60];
CheckViewPositions(controller_);
// Expand the toolbar to 64px and recheck
[controller_ resizeView:toolbar newHeight:64];
CheckViewPositions(controller_);
// Add a 30px download shelf and recheck
[controller_ resizeView:download newHeight:30];
CheckViewPositions(controller_);
// Shrink the infobar to 0px and toolbar to 39px and recheck
[controller_ resizeView:infobar newHeight:0];
[controller_ resizeView:toolbar newHeight:39];
CheckViewPositions(controller_);
}
TEST_F(BrowserWindowControllerTest, TestResizeViewsWithBookmarkBar) {
// Force a display of the bookmark bar.
profile()->GetPrefs()->SetBoolean(bookmarks::prefs::kShowBookmarkBar, true);
[controller_ browserWindow]->BookmarkBarStateChanged(
BookmarkBar::DONT_ANIMATE_STATE_CHANGE);
TabStripView* tabstrip = [controller_ tabStripView];
NSView* contentView = [[tabstrip window] contentView];
NSView* toolbar = [controller_ toolbarView];
NSView* bookmark = [controller_ bookmarkView];
NSView* infobar = [controller_ infoBarContainerView];
// We need to muck with the views a bit to put us in a consistent state before
// we start resizing. In particular, we need to move the tab strip to be
// immediately above the content area, since we layout views to be directly
// under the tab strip.
NSRect tabstripFrame = [tabstrip frame];
tabstripFrame.origin.y = NSMaxY([contentView frame]);
[tabstrip setFrame:tabstripFrame];
// The download shelf is created lazily. Force-create it and set its initial
// height to 0.
[controller_ createAndAddDownloadShelf];
NSView* download = [[controller_ downloadShelf] view];
NSRect downloadFrame = [download frame];
downloadFrame.size.height = 0;
[download setFrame:downloadFrame];
// Force a layout and check each view's frame.
[controller_ layoutSubviews];
CheckViewPositions(controller_);
// Add the bookmark bar and recheck.
[controller_ resizeView:bookmark newHeight:40];
CheckViewPositions(controller_);
// Expand the infobar to 60px and recheck
[controller_ resizeView:infobar newHeight:60];
CheckViewPositions(controller_);
// Expand the toolbar to 64px and recheck
[controller_ resizeView:toolbar newHeight:64];
CheckViewPositions(controller_);
// Add a 30px download shelf and recheck
[controller_ resizeView:download newHeight:30];
CheckViewPositions(controller_);
// Remove the bookmark bar and recheck
profile()->GetPrefs()->SetBoolean(bookmarks::prefs::kShowBookmarkBar, false);
[controller_ browserWindow]->BookmarkBarStateChanged(
BookmarkBar::DONT_ANIMATE_STATE_CHANGE);
[controller_ resizeView:bookmark newHeight:0];
CheckViewPositions(controller_);
// Shrink the infobar to 0px and toolbar to 39px and recheck
[controller_ resizeView:infobar newHeight:0];
[controller_ resizeView:toolbar newHeight:39];
CheckViewPositions(controller_);
}
// Make sure, by default, the bookmark bar and the toolbar are the same width.
TEST_F(BrowserWindowControllerTest, BookmarkBarIsSameWidth) {
// Set the pref to the bookmark bar is visible when the toolbar is
// first created.
profile()->GetPrefs()->SetBoolean(bookmarks::prefs::kShowBookmarkBar, true);
// Make sure the bookmark bar is the same width as the toolbar
NSView* bookmarkBarView = [controller_ bookmarkView];
NSView* toolbarView = [controller_ toolbarView];
EXPECT_EQ([toolbarView frame].size.width,
[bookmarkBarView frame].size.width);
}
TEST_F(BrowserWindowControllerTest, TestTopRightForBubble) {
// The bookmark bubble must be attached to a lit and visible star.
[controller_ setStarredState:YES];
NSPoint p = [controller_ bookmarkBubblePoint]; // Window coordinates.
NSRect all = [[controller_ window] frame]; // Screen coordinates.
// As a sanity check make sure the point is vaguely in the top right
// of the window.
EXPECT_GT(p.y, all.size.height / 2);
EXPECT_GT(p.x, all.size.width / 2);
}
// By the "zoom frame", we mean what Apple calls the "standard frame".
TEST_F(BrowserWindowControllerTest, TestZoomFrame) {
NSWindow* window = [controller_ window];
ASSERT_TRUE(window);
NSRect screenFrame = [[window screen] visibleFrame];
ASSERT_FALSE(NSIsEmptyRect(screenFrame));
// Minimum zoomed width is the larger of 60% of available horizontal space or
// 60% of available vertical space, subject to available horizontal space.
CGFloat minZoomWidth =
std::min(std::max((CGFloat)0.6 * screenFrame.size.width,
(CGFloat)0.6 * screenFrame.size.height),
screenFrame.size.width);
// |testFrame| is the size of the window we start out with, and |zoomFrame| is
// the one returned by |-windowWillUseStandardFrame:defaultFrame:|.
NSRect testFrame;
NSRect zoomFrame;
// 1. Test a case where it zooms the window both horizontally and vertically,
// and only moves it vertically. "+ 32", etc. are just arbitrary constants
// used to check that the window is moved properly and not just to the origin;
// they should be small enough to not shove windows off the screen.
testFrame.size.width = 0.5 * minZoomWidth;
testFrame.size.height = 0.5 * screenFrame.size.height;
testFrame.origin.x = screenFrame.origin.x + 32; // See above.
testFrame.origin.y = screenFrame.origin.y + 23;
[window setFrame:testFrame display:NO];
zoomFrame = [controller_ windowWillUseStandardFrame:window
defaultFrame:screenFrame];
EXPECT_LE(minZoomWidth, zoomFrame.size.width);
EXPECT_EQ(screenFrame.size.height, zoomFrame.size.height);
EXPECT_EQ(testFrame.origin.x, zoomFrame.origin.x);
EXPECT_EQ(screenFrame.origin.y, zoomFrame.origin.y);
// 2. Test a case where it zooms the window only horizontally, and only moves
// it horizontally.
testFrame.size.width = 0.5 * minZoomWidth;
testFrame.size.height = screenFrame.size.height;
testFrame.origin.x = screenFrame.origin.x + screenFrame.size.width -
testFrame.size.width;
testFrame.origin.y = screenFrame.origin.y;
[window setFrame:testFrame display:NO];
zoomFrame = [controller_ windowWillUseStandardFrame:window
defaultFrame:screenFrame];
EXPECT_LE(minZoomWidth, zoomFrame.size.width);
EXPECT_EQ(screenFrame.size.height, zoomFrame.size.height);
EXPECT_EQ(screenFrame.origin.x + screenFrame.size.width -
zoomFrame.size.width, zoomFrame.origin.x);
EXPECT_EQ(screenFrame.origin.y, zoomFrame.origin.y);
// 3. Test a case where it zooms the window only vertically, and only moves it
// vertically.
testFrame.size.width = std::min((CGFloat)1.1 * minZoomWidth,
screenFrame.size.width);
testFrame.size.height = 0.3 * screenFrame.size.height;
testFrame.origin.x = screenFrame.origin.x + 32; // See above (in 1.).
testFrame.origin.y = screenFrame.origin.y + 123;
[window setFrame:testFrame display:NO];
zoomFrame = [controller_ windowWillUseStandardFrame:window
defaultFrame:screenFrame];
// Use the actual width of the window frame, since it's subject to rounding.
EXPECT_EQ([window frame].size.width, zoomFrame.size.width);
EXPECT_EQ(screenFrame.size.height, zoomFrame.size.height);
EXPECT_EQ(testFrame.origin.x, zoomFrame.origin.x);
EXPECT_EQ(screenFrame.origin.y, zoomFrame.origin.y);
// 4. Test a case where zooming should do nothing (i.e., we're already at a
// zoomed frame).
testFrame.size.width = std::min((CGFloat)1.1 * minZoomWidth,
screenFrame.size.width);
testFrame.size.height = screenFrame.size.height;
testFrame.origin.x = screenFrame.origin.x + 32; // See above (in 1.).
testFrame.origin.y = screenFrame.origin.y;
[window setFrame:testFrame display:NO];
zoomFrame = [controller_ windowWillUseStandardFrame:window
defaultFrame:screenFrame];
// Use the actual width of the window frame, since it's subject to rounding.
EXPECT_EQ([window frame].size.width, zoomFrame.size.width);
EXPECT_EQ(screenFrame.size.height, zoomFrame.size.height);
EXPECT_EQ(testFrame.origin.x, zoomFrame.origin.x);
EXPECT_EQ(screenFrame.origin.y, zoomFrame.origin.y);
}
TEST_F(BrowserWindowControllerTest, TestFindBarOnTop) {
FindBarBridge bridge(NULL);
[controller_ addFindBar:bridge.find_bar_cocoa_controller()];
// Test that the Z-order of the find bar is on top of everything.
NSArray* subviews = [controller_.chromeContentView subviews];
NSUInteger findBar_index =
[subviews indexOfObject:[controller_ findBarView]];
EXPECT_NE(static_cast<NSUInteger>(NSNotFound), findBar_index);
NSUInteger toolbar_index =
[subviews indexOfObject:[controller_ toolbarView]];
EXPECT_NE(static_cast<NSUInteger>(NSNotFound), toolbar_index);
NSUInteger bookmark_index =
[subviews indexOfObject:[controller_ bookmarkView]];
EXPECT_NE(static_cast<NSUInteger>(NSNotFound), bookmark_index);
EXPECT_GT(findBar_index, toolbar_index);
EXPECT_GT(findBar_index, bookmark_index);
}
// Verify that hit testing works correctly when the bookmark bar overlaps
// web contents.
TEST_F(BrowserWindowControllerTest, BookmarkBarHitTest) {
profile()->GetPrefs()->SetBoolean(bookmarks::prefs::kShowBookmarkBar, true);
[controller_ browserWindow]->BookmarkBarStateChanged(
BookmarkBar::DONT_ANIMATE_STATE_CHANGE);
NSView* bookmarkView = [controller_ bookmarkView];
NSView* contentView = [[controller_ window] contentView];
NSPoint point = [bookmarkView convertPoint:NSMakePoint(1, 1)
toView:[contentView superview]];
EXPECT_TRUE([[contentView hitTest:point] isDescendantOf:bookmarkView]);
}
// Check that when the window becomes/resigns main, the tab strip's background
// view is redrawn.
TEST_F(BrowserWindowControllerTest, TabStripBackgroundViewRedrawTest) {
NSView* view = controller_.tabStripBackgroundView;
id partial_mock = [OCMockObject partialMockForObject:view];
[[partial_mock expect] setNeedsDisplay:YES];
[[NSNotificationCenter defaultCenter]
postNotificationName:NSWindowDidBecomeMainNotification
object:controller_.window];
[partial_mock verify];
[[partial_mock expect] setNeedsDisplay:YES];
[[NSNotificationCenter defaultCenter]
postNotificationName:NSWindowDidResignMainNotification
object:controller_.window];
[partial_mock verify];
}
@interface BrowserWindowControllerFakeFullscreen : BrowserWindowController {
@private
// We release the window ourselves, so we don't have to rely on the unittest
// doing it for us.
base::scoped_nsobject<NSWindow> testFullscreenWindow_;
}
@end
class BrowserWindowFullScreenControllerTest : public CocoaProfileTest {
public:
void SetUp() override {
CocoaProfileTest::SetUp();
ASSERT_TRUE(browser());
controller_ =
[[BrowserWindowControllerFakeFullscreen alloc] initWithBrowser:browser()
takeOwnership:NO];
}
void TearDown() override {
[controller_ close];
CocoaProfileTest::TearDown();
}
public:
BrowserWindowController* controller_;
};
// Check if the window is front most or if one of its child windows (such
// as a status bubble) is front most.
static bool IsFrontWindow(NSWindow* window) {
NSWindow* frontmostWindow = [[NSApp orderedWindows] objectAtIndex:0];
return [frontmostWindow isEqual:window] ||
[[frontmostWindow parentWindow] isEqual:window];
}
void WaitForFullScreenTransition() {
content::WindowedNotificationObserver observer(
chrome::NOTIFICATION_FULLSCREEN_CHANGED,
content::NotificationService::AllSources());
observer.Wait();
}
// http://crbug.com/53586
TEST_F(BrowserWindowFullScreenControllerTest, TestFullscreen) {
ui::test::ScopedFakeNSWindowFullscreen fake_fullscreen;
[controller_ showWindow:nil];
EXPECT_FALSE([controller_ isInAnyFullscreenMode]);
[controller_ enterBrowserFullscreen];
WaitForFullScreenTransition();
EXPECT_TRUE([controller_ isInAnyFullscreenMode]);
[controller_ exitAnyFullscreen];
WaitForFullScreenTransition();
EXPECT_FALSE([controller_ isInAnyFullscreenMode]);
}
// If this test fails, it is usually a sign that the bots have some sort of
// problem (such as a modal dialog up). This tests is a very useful canary, so
// please do not mark it as flaky without first verifying that there are no bot
// problems.
// http://crbug.com/53586
TEST_F(BrowserWindowFullScreenControllerTest, TestActivate) {
ui::test::ScopedFakeNSWindowFullscreen fake_fullscreen;
[controller_ showWindow:nil];
EXPECT_FALSE([controller_ isInAnyFullscreenMode]);
[controller_ activate];
chrome::testing::NSRunLoopRunAllPending();
EXPECT_TRUE(IsFrontWindow([controller_ window]));
[controller_ enterBrowserFullscreen];
WaitForFullScreenTransition();
[controller_ activate];
chrome::testing::NSRunLoopRunAllPending();
// We have to cleanup after ourselves by unfullscreening.
[controller_ exitAnyFullscreen];
WaitForFullScreenTransition();
}
@implementation BrowserWindowControllerFakeFullscreen
// Override |-createFullscreenWindow| to return a dummy window. This isn't
// needed to pass the test, but because the dummy window is only 100x100, it
// prevents the real fullscreen window from flashing up and taking over the
// whole screen. We have to return an actual window because |-layoutSubviews|
// looks at the window's frame.
- (NSWindow*)createFullscreenWindow {
if (testFullscreenWindow_.get())
return testFullscreenWindow_.get();
testFullscreenWindow_.reset(
[[NSWindow alloc] initWithContentRect:NSMakeRect(0,0,400,400)
styleMask:NSBorderlessWindowMask
backing:NSBackingStoreBuffered
defer:NO]);
[[testFullscreenWindow_ contentView] setWantsLayer:YES];
return testFullscreenWindow_.get();
}
@end
/* TODO(???): test other methods of BrowserWindowController */
|