1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
|
// Copyright (c) 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "base/mac/scoped_nsobject.h"
#import "chrome/browser/ui/cocoa/clickhold_button_cell.h"
#import "chrome/browser/ui/cocoa/menu_button.h"
#import "chrome/browser/ui/cocoa/test/cocoa_test_helper.h"
@interface MenuButtonTestDelegate : NSObject<NSMenuDelegate> {
@private
base::scoped_nsobject<NSMenu> menu_;
BOOL open_;
BOOL didOpen_;
}
- (BOOL)isOpen;
- (BOOL)didOpen;
@end
@implementation MenuButtonTestDelegate
- (id)initWithMenu:(NSMenu*)menu {
if ((self = [super init])) {
menu_.reset([menu retain]);
}
return self;
}
- (BOOL)isOpen {
return open_;
}
- (BOOL)didOpen {
return didOpen_;
}
- (void)menuWillOpen:(NSMenu*)menu {
EXPECT_EQ(menu_.get(), menu);
EXPECT_FALSE(open_);
open_ = YES;
didOpen_ = YES;
NSArray* modes = [NSArray arrayWithObjects:NSEventTrackingRunLoopMode,
NSDefaultRunLoopMode,
nil];
[menu performSelector:@selector(cancelTracking)
withObject:nil
afterDelay:0.1
inModes:modes];
}
- (void)menuDidClose:(NSMenu*)menu {
EXPECT_EQ(menu_.get(), menu);
EXPECT_TRUE(open_);
open_ = NO;
}
@end
namespace {
class MenuButtonTest : public CocoaTest {
public:
MenuButtonTest() {
NSRect frame = NSMakeRect(0, 0, 50, 30);
base::scoped_nsobject<MenuButton> button(
[[MenuButton alloc] initWithFrame:frame]);
button_ = button.get();
base::scoped_nsobject<ClickHoldButtonCell> cell(
[[ClickHoldButtonCell alloc] initTextCell:@"Testing"]);
[button_ setCell:cell.get()];
[[test_window() contentView] addSubview:button_];
}
NSMenu* CreateMenu() {
NSMenu* menu = [[NSMenu alloc] initWithTitle:@""];
[menu insertItemWithTitle:@"" action:nil keyEquivalent:@"" atIndex:0];
[menu insertItemWithTitle:@"foo" action:nil keyEquivalent:@"" atIndex:1];
[menu insertItemWithTitle:@"bar" action:nil keyEquivalent:@"" atIndex:2];
[menu insertItemWithTitle:@"baz" action:nil keyEquivalent:@"" atIndex:3];
return menu;
}
NSEvent* MouseEvent(NSEventType eventType) {
NSPoint location;
if (button_)
location = [button_ frame].origin;
else
location.x = location.y = 0;
NSGraphicsContext* context = [NSGraphicsContext currentContext];
NSEvent* event = [NSEvent mouseEventWithType:eventType
location:location
modifierFlags:0
timestamp:0
windowNumber:[test_window() windowNumber]
context:context
eventNumber:0
clickCount:1
pressure:1.0F];
return event;
}
MenuButton* button_;
};
TEST_VIEW(MenuButtonTest, button_);
// Test assigning a menu, again mostly to ensure nothing leaks or crashes.
TEST_F(MenuButtonTest, MenuAssign) {
base::scoped_nsobject<NSMenu> menu(CreateMenu());
ASSERT_TRUE(menu.get());
[button_ setAttachedMenu:menu];
EXPECT_TRUE([button_ attachedMenu]);
}
TEST_F(MenuButtonTest, OpenOnClick) {
base::scoped_nsobject<NSMenu> menu(CreateMenu());
ASSERT_TRUE(menu.get());
base::scoped_nsobject<MenuButtonTestDelegate> delegate(
[[MenuButtonTestDelegate alloc] initWithMenu:menu.get()]);
ASSERT_TRUE(delegate.get());
[menu setDelegate:delegate.get()];
[button_ setAttachedMenu:menu];
[button_ setOpenMenuOnClick:YES];
EXPECT_FALSE([delegate isOpen]);
EXPECT_FALSE([delegate didOpen]);
// Should open the menu.
[button_ performClick:nil];
EXPECT_TRUE([delegate didOpen]);
EXPECT_FALSE([delegate isOpen]);
}
// Test classic Mac menu behavior.
TEST_F(MenuButtonTest, DISABLED_OpenOnClickAndHold) {
base::scoped_nsobject<NSMenu> menu(CreateMenu());
ASSERT_TRUE(menu.get());
base::scoped_nsobject<MenuButtonTestDelegate> delegate(
[[MenuButtonTestDelegate alloc] initWithMenu:menu.get()]);
ASSERT_TRUE(delegate.get());
[menu setDelegate:delegate.get()];
[button_ setAttachedMenu:menu];
[button_ setOpenMenuOnClick:YES];
EXPECT_FALSE([delegate isOpen]);
EXPECT_FALSE([delegate didOpen]);
// Should open the menu.
NSEvent* event = MouseEvent(NSLeftMouseDown);
[test_window() sendEvent:event];
EXPECT_TRUE([delegate didOpen]);
EXPECT_FALSE([delegate isOpen]);
}
TEST_F(MenuButtonTest, OpenOnRightClick) {
base::scoped_nsobject<NSMenu> menu(CreateMenu());
ASSERT_TRUE(menu.get());
base::scoped_nsobject<MenuButtonTestDelegate> delegate(
[[MenuButtonTestDelegate alloc] initWithMenu:menu.get()]);
ASSERT_TRUE(delegate.get());
[menu setDelegate:delegate.get()];
[button_ setAttachedMenu:menu];
[button_ setOpenMenuOnClick:YES];
// Right click is enabled.
[button_ setOpenMenuOnRightClick:YES];
EXPECT_FALSE([delegate isOpen]);
EXPECT_FALSE([delegate didOpen]);
// Should open the menu.
NSEvent* event = MouseEvent(NSRightMouseDown);
[button_ rightMouseDown:event];
EXPECT_TRUE([delegate didOpen]);
EXPECT_FALSE([delegate isOpen]);
}
TEST_F(MenuButtonTest, DontOpenOnRightClickWithoutSetRightClick) {
base::scoped_nsobject<NSMenu> menu(CreateMenu());
ASSERT_TRUE(menu.get());
base::scoped_nsobject<MenuButtonTestDelegate> delegate(
[[MenuButtonTestDelegate alloc] initWithMenu:menu.get()]);
ASSERT_TRUE(delegate.get());
[menu setDelegate:delegate.get()];
[button_ setAttachedMenu:menu];
[button_ setOpenMenuOnClick:YES];
EXPECT_FALSE([delegate isOpen]);
EXPECT_FALSE([delegate didOpen]);
// Should not open the menu.
NSEvent* event = MouseEvent(NSRightMouseDown);
[button_ rightMouseDown:event];
EXPECT_FALSE([delegate didOpen]);
EXPECT_FALSE([delegate isOpen]);
// Should open the menu in this case.
[button_ performClick:nil];
EXPECT_TRUE([delegate didOpen]);
EXPECT_FALSE([delegate isOpen]);
}
TEST_F(MenuButtonTest, OpenOnAccessibilityPerformAction) {
base::scoped_nsobject<NSMenu> menu(CreateMenu());
ASSERT_TRUE(menu.get());
base::scoped_nsobject<MenuButtonTestDelegate> delegate(
[[MenuButtonTestDelegate alloc] initWithMenu:menu.get()]);
ASSERT_TRUE(delegate.get());
[menu setDelegate:delegate.get()];
[button_ setAttachedMenu:menu];
NSCell* buttonCell = [button_ cell];
EXPECT_FALSE([delegate isOpen]);
EXPECT_FALSE([delegate didOpen]);
[button_ setOpenMenuOnClick:YES];
// NSAccessibilityShowMenuAction should not be available but
// NSAccessibilityPressAction should.
NSArray* actionNames = [buttonCell accessibilityActionNames];
EXPECT_FALSE([actionNames containsObject:NSAccessibilityShowMenuAction]);
EXPECT_TRUE([actionNames containsObject:NSAccessibilityPressAction]);
[button_ setOpenMenuOnClick:NO];
// NSAccessibilityPressAction should not be the one used to open the menu now.
actionNames = [buttonCell accessibilityActionNames];
EXPECT_TRUE([actionNames containsObject:NSAccessibilityShowMenuAction]);
EXPECT_TRUE([actionNames containsObject:NSAccessibilityPressAction]);
[buttonCell accessibilityPerformAction:NSAccessibilityShowMenuAction];
EXPECT_TRUE([delegate didOpen]);
EXPECT_FALSE([delegate isOpen]);
}
TEST_F(MenuButtonTest, OpenOnAccessibilityPerformActionWithSetRightClick) {
base::scoped_nsobject<NSMenu> menu(CreateMenu());
ASSERT_TRUE(menu.get());
base::scoped_nsobject<MenuButtonTestDelegate> delegate(
[[MenuButtonTestDelegate alloc] initWithMenu:menu.get()]);
ASSERT_TRUE(delegate.get());
[menu setDelegate:delegate.get()];
[button_ setAttachedMenu:menu];
NSCell* buttonCell = [button_ cell];
EXPECT_FALSE([delegate isOpen]);
EXPECT_FALSE([delegate didOpen]);
[button_ setOpenMenuOnClick:YES];
// Command to open the menu should not be available.
NSArray* actionNames = [buttonCell accessibilityActionNames];
EXPECT_FALSE([actionNames containsObject:NSAccessibilityShowMenuAction]);
[button_ setOpenMenuOnRightClick:YES];
// Command to open the menu should now become available.
actionNames = [buttonCell accessibilityActionNames];
EXPECT_TRUE([actionNames containsObject:NSAccessibilityShowMenuAction]);
[button_ setOpenMenuOnClick:NO];
// Command should still be available, even when both click + hold and right
// click are turned on.
actionNames = [buttonCell accessibilityActionNames];
EXPECT_TRUE([actionNames containsObject:NSAccessibilityShowMenuAction]);
[buttonCell accessibilityPerformAction:NSAccessibilityShowMenuAction];
EXPECT_TRUE([delegate didOpen]);
EXPECT_FALSE([delegate isOpen]);
}
} // namespace
|
