1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
|
// Copyright 2016 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "base/command_line.h"
#include "base/logging.h"
#include "base/memory/ptr_util.h"
#include "base/path_service.h"
#include "base/values.h"
#include "chrome/browser/extensions/extension_service.h"
#include "chrome/browser/extensions/extension_service_test_with_install.h"
#include "chrome/browser/extensions/extension_web_ui_override_registrar.h"
#include "chrome/browser/extensions/ntp_overridden_bubble_delegate.h"
#include "chrome/browser/extensions/suspicious_extension_bubble_delegate.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/extensions/extension_message_bubble_bridge.h"
#include "chrome/browser/ui/toolbar/test_toolbar_actions_bar_bubble_delegate.h"
#include "chrome/browser/ui/toolbar/toolbar_actions_bar_bubble_delegate.h"
#include "chrome/browser/ui/toolbar/toolbar_actions_model.h"
#include "chrome/browser/ui/toolbar/toolbar_actions_model_factory.h"
#include "chrome/common/chrome_paths.h"
#include "chrome/grit/generated_resources.h"
#include "chrome/test/base/test_browser_window.h"
#include "chrome/test/base/testing_profile.h"
#include "components/crx_file/id_util.h"
#include "components/grit/components_scaled_resources.h"
#include "components/keyed_service/core/keyed_service.h"
#include "components/strings/grit/components_strings.h"
#include "content/public/browser/browser_context.h"
#include "extensions/browser/extension_registry.h"
#include "extensions/browser/extension_system.h"
#include "extensions/common/extension_builder.h"
#include "extensions/common/manifest.h"
#include "extensions/common/value_builder.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "ui/base/l10n/l10n_util.h"
#include "ui/gfx/vector_icons_public.h"
namespace {
std::unique_ptr<KeyedService> BuildOverrideRegistrar(
content::BrowserContext* context) {
return base::MakeUnique<extensions::ExtensionWebUIOverrideRegistrar>(context);
}
std::unique_ptr<KeyedService> BuildToolbarModel(
content::BrowserContext* context) {
return base::MakeUnique<ToolbarActionsModel>(
Profile::FromBrowserContext(context),
extensions::ExtensionPrefs::Get(context));
}
} // namespace
class ExtensionMessageBubbleBridgeUnitTest
: public extensions::ExtensionServiceTestWithInstall {
public:
ExtensionMessageBubbleBridgeUnitTest() {}
~ExtensionMessageBubbleBridgeUnitTest() override {}
Browser* browser() { return browser_.get(); }
private:
void SetUp() override {
ExtensionServiceTestWithInstall::SetUp();
InitializeEmptyExtensionService();
browser_window_.reset(new TestBrowserWindow());
Browser::CreateParams params(profile());
params.type = Browser::TYPE_TABBED;
params.window = browser_window_.get();
browser_.reset(new Browser(params));
extensions::ExtensionWebUIOverrideRegistrar::GetFactoryInstance()
->SetTestingFactory(browser()->profile(), &BuildOverrideRegistrar);
extensions::ExtensionWebUIOverrideRegistrar::GetFactoryInstance()->Get(
browser()->profile());
ToolbarActionsModelFactory::GetInstance()->SetTestingFactory(
browser()->profile(), &BuildToolbarModel);
}
void TearDown() override {
browser_.reset();
browser_window_.reset();
ExtensionServiceTestWithInstall::TearDown();
}
std::unique_ptr<TestBrowserWindow> browser_window_;
std::unique_ptr<Browser> browser_;
DISALLOW_COPY_AND_ASSIGN(ExtensionMessageBubbleBridgeUnitTest);
};
TEST_F(ExtensionMessageBubbleBridgeUnitTest,
TestGetExtraViewInfoMethodWithNormalSettingsOverrideExtension) {
base::FilePath path(data_dir().AppendASCII("api_test/override/newtab/"));
EXPECT_NE(nullptr, PackAndInstallCRX(path, INSTALL_NEW));
std::unique_ptr<extensions::ExtensionMessageBubbleController>
ntp_bubble_controller(new extensions::ExtensionMessageBubbleController(
new extensions::NtpOverriddenBubbleDelegate(browser()->profile()),
browser()));
ASSERT_EQ(1U, ntp_bubble_controller->GetExtensionList().size());
std::unique_ptr<ToolbarActionsBarBubbleDelegate> bridge(
new ExtensionMessageBubbleBridge(std::move(ntp_bubble_controller)));
std::unique_ptr<ToolbarActionsBarBubbleDelegate::ExtraViewInfo>
extra_view_info = bridge->GetExtraViewInfo();
EXPECT_EQ(gfx::VectorIconId::VECTOR_ICON_NONE, extra_view_info->resource_id);
EXPECT_EQ(l10n_util::GetStringUTF16(IDS_LEARN_MORE), extra_view_info->text);
EXPECT_TRUE(extra_view_info->is_text_linked);
EXPECT_EQ(
l10n_util::GetStringUTF16(IDS_EXTENSION_CONTROLLED_RESTORE_SETTINGS),
bridge->GetActionButtonText());
}
TEST_F(ExtensionMessageBubbleBridgeUnitTest,
TestGetExtraViewInfoMethodWithPolicyInstalledSettingsOverrideExtension) {
base::FilePath path(data_dir().AppendASCII("api_test/override/newtab/"));
EXPECT_NE(nullptr,
PackAndInstallCRX(path, extensions::Manifest::EXTERNAL_POLICY,
INSTALL_NEW));
std::unique_ptr<extensions::ExtensionMessageBubbleController>
ntp_bubble_controller(new extensions::ExtensionMessageBubbleController(
new extensions::NtpOverriddenBubbleDelegate(browser()->profile()),
browser()));
ASSERT_EQ(1U, ntp_bubble_controller->GetExtensionList().size());
std::unique_ptr<ToolbarActionsBarBubbleDelegate> bridge(
new ExtensionMessageBubbleBridge(std::move(ntp_bubble_controller)));
std::unique_ptr<ToolbarActionsBarBubbleDelegate::ExtraViewInfo>
extra_view_info = bridge->GetExtraViewInfo();
extra_view_info = bridge->GetExtraViewInfo();
EXPECT_EQ(gfx::VectorIconId::BUSINESS, extra_view_info->resource_id);
EXPECT_EQ(l10n_util::GetStringUTF16(IDS_EXTENSIONS_INSTALLED_BY_ADMIN),
extra_view_info->text);
EXPECT_FALSE(extra_view_info->is_text_linked);
EXPECT_EQ(base::string16(), bridge->GetActionButtonText());
}
// Tests the ExtensionMessageBubbleBridge in conjunction with the
// SuspiciousExtensionBubbleDelegate.
TEST_F(ExtensionMessageBubbleBridgeUnitTest, SuspiciousExtensionBubble) {
// Load up a simple extension.
extensions::DictionaryBuilder manifest;
manifest.Set("name", "foo")
.Set("description", "some extension")
.Set("version", "0.1")
.Set("manifest_version", 2);
scoped_refptr<const extensions::Extension> extension =
extensions::ExtensionBuilder().SetID(crx_file::id_util::GenerateId("foo"))
.SetManifest(manifest.Build())
.Build();
ASSERT_TRUE(extension);
service()->AddExtension(extension.get());
const std::string id = extension->id();
ASSERT_TRUE(registry()->enabled_extensions().GetByID(id));
// Disable the extension for being from outside the webstore.
service()->DisableExtension(
extension->id(), extensions::Extension::DISABLE_NOT_VERIFIED);
EXPECT_TRUE(registry()->disabled_extensions().GetByID(id));
// Create a new message bubble; it should want to display for the disabled
// extension. (Note: The bubble logic itself is tested more thoroughly in
// extension_message_bubble_controller_unittest.cc.)
auto suspicious_bubble_controller =
base::MakeUnique<extensions::ExtensionMessageBubbleController>(
new extensions::SuspiciousExtensionBubbleDelegate(profile()),
browser());
EXPECT_TRUE(suspicious_bubble_controller->ShouldShow());
ASSERT_EQ(1u, suspicious_bubble_controller->GetExtensionIdList().size());
EXPECT_EQ(id, suspicious_bubble_controller->GetExtensionIdList()[0]);
// Create a new bridge and poke at a few of the methods to verify they are
// correct and that nothing crashes.
std::unique_ptr<ToolbarActionsBarBubbleDelegate> bridge =
base::MakeUnique<ExtensionMessageBubbleBridge>(
std::move(suspicious_bubble_controller));
EXPECT_TRUE(bridge->ShouldShow());
EXPECT_FALSE(bridge->ShouldCloseOnDeactivate());
std::unique_ptr<ToolbarActionsBarBubbleDelegate::ExtraViewInfo>
extra_view_info = bridge->GetExtraViewInfo();
ASSERT_TRUE(extra_view_info);
EXPECT_FALSE(extra_view_info->text.empty());
EXPECT_TRUE(extra_view_info->is_text_linked);
EXPECT_EQ(gfx::VectorIconId::VECTOR_ICON_NONE,
extra_view_info->resource_id);
}
|
