1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496
|
// Copyright (c) 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "components/omnibox/browser/bookmark_provider.h"
#include <stddef.h>
#include <algorithm>
#include <memory>
#include <string>
#include <vector>
#include "base/macros.h"
#include "base/memory/ref_counted.h"
#include "base/message_loop/message_loop.h"
#include "base/strings/string16.h"
#include "base/strings/string_number_conversions.h"
#include "base/strings/string_split.h"
#include "base/strings/utf_string_conversions.h"
#include "components/bookmarks/browser/bookmark_model.h"
#include "components/bookmarks/browser/titled_url_match.h"
#include "components/bookmarks/test/test_bookmark_client.h"
#include "components/metrics/proto/omnibox_event.pb.h"
#include "components/omnibox/browser/autocomplete_provider.h"
#include "components/omnibox/browser/mock_autocomplete_provider_client.h"
#include "components/omnibox/browser/test_scheme_classifier.h"
#include "components/omnibox/browser/titled_url_match_utils.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
using bookmarks::BookmarkModel;
using bookmarks::BookmarkNode;
using bookmarks::TitledUrlMatch;
namespace {
// The bookmark corpus against which we will simulate searches.
struct BookmarksTestInfo {
std::string title;
std::string url;
} bookmark_provider_test_data[] = {
{ "abc def", "http://www.catsanddogs.com/a" },
{ "abcde", "http://www.catsanddogs.com/b" },
{ "abcdef", "http://www.catsanddogs.com/c" },
{ "carry carbon carefully", "http://www.catsanddogs.com/d" },
{ "a definition", "http://www.catsanddogs.com/e" },
{ "ghi jkl", "http://www.catsanddogs.com/f" },
{ "jkl ghi", "http://www.catsanddogs.com/g" },
{ "frankly frankly frank", "http://www.catsanddogs.com/h" },
{ "foobar foobar", "http://www.foobar.com/" },
{ "domain", "http://www.domain.com/http/" },
{ "repeat", "http://www.repeat.com/1/repeat/2/" },
// For testing inline_autocompletion.
{ "http://blah.com/", "http://blah.com/" },
{ "http://fiddle.com/", "http://fiddle.com/" },
{ "http://www.www.com/", "http://www.www.com/" },
{ "chrome://version", "chrome://version" },
{ "chrome://omnibox", "chrome://omnibox" },
// For testing ranking with different URLs.
{ "achlorhydric featherheads resuscitates mockingbirds",
"http://www.manylongwords.com/1a" },
{ "achlorhydric mockingbirds resuscitates featherhead",
"http://www.manylongwords.com/2b" },
{ "featherhead resuscitates achlorhydric mockingbirds",
"http://www.manylongwords.com/3c" },
{ "mockingbirds resuscitates featherheads achlorhydric",
"http://www.manylongwords.com/4d" },
// For testing URL boosting. (URLs referenced multiple times are boosted.)
{ "burning worms #1", "http://www.burns.com/" },
{ "burning worms #2", "http://www.worms.com/" },
{ "worming burns #10", "http://www.burns.com/" },
// For testing strange spacing in bookmark titles.
{ " hello1 hello2 ", "http://whatever.com/" },
{ "", "http://emptytitle.com/" },
};
// Structures and functions supporting the BookmarkProviderTest.Positions
// unit test.
struct TestBookmarkPosition {
TestBookmarkPosition(size_t begin, size_t end)
: begin(begin), end(end) {}
size_t begin;
size_t end;
};
typedef std::vector<TestBookmarkPosition> TestBookmarkPositions;
// Return |positions| as a formatted string for unit test diagnostic output.
std::string TestBookmarkPositionsAsString(
const TestBookmarkPositions& positions) {
std::string position_string("{");
for (TestBookmarkPositions::const_iterator i = positions.begin();
i != positions.end(); ++i) {
if (i != positions.begin())
position_string += ", ";
position_string += "{" + base::SizeTToString(i->begin) + ", " +
base::SizeTToString(i->end) + "}";
}
position_string += "}\n";
return position_string;
}
// Return the positions in |matches| as a formatted string for unit test
// diagnostic output.
base::string16 MatchesAsString16(const ACMatches& matches) {
base::string16 matches_string;
for (ACMatches::const_iterator i = matches.begin(); i != matches.end(); ++i) {
matches_string.append(base::ASCIIToUTF16(" '"));
matches_string.append(i->description);
matches_string.append(base::ASCIIToUTF16("'\n"));
}
return matches_string;
}
// Comparison function for sorting search terms by descending length.
bool TestBookmarkPositionsEqual(const TestBookmarkPosition& pos_a,
const TestBookmarkPosition& pos_b) {
return pos_a.begin == pos_b.begin && pos_a.end == pos_b.end;
}
// Convience function to make comparing ACMatchClassifications against the
// test expectations structure easier.
TestBookmarkPositions PositionsFromAutocompleteMatch(
const AutocompleteMatch& match) {
TestBookmarkPositions positions;
bool started = false;
size_t start = 0;
for (AutocompleteMatch::ACMatchClassifications::const_iterator
i = match.description_class.begin();
i != match.description_class.end(); ++i) {
if (i->style & AutocompleteMatch::ACMatchClassification::MATCH) {
// We have found the start of a match.
EXPECT_FALSE(started);
started = true;
start = i->offset;
} else if (started) {
// We have found the end of a match.
started = false;
positions.push_back(TestBookmarkPosition(start, i->offset));
start = 0;
}
}
// Record the final position if the last match goes to the end of the
// candidate string.
if (started)
positions.push_back(TestBookmarkPosition(start, match.description.size()));
return positions;
}
// Convience function to make comparing test expectations structure against the
// actual ACMatchClassifications easier.
TestBookmarkPositions PositionsFromExpectations(
const size_t expectations[9][2]) {
TestBookmarkPositions positions;
size_t i = 0;
// The array is zero-terminated in the [1]th element.
while (expectations[i][1]) {
positions.push_back(
TestBookmarkPosition(expectations[i][0], expectations[i][1]));
++i;
}
return positions;
}
} // namespace
class BookmarkProviderTest : public testing::Test {
public:
BookmarkProviderTest();
protected:
void SetUp() override;
base::MessageLoop message_loop_;
std::unique_ptr<MockAutocompleteProviderClient> provider_client_;
std::unique_ptr<BookmarkModel> model_;
scoped_refptr<BookmarkProvider> provider_;
TestSchemeClassifier classifier_;
private:
DISALLOW_COPY_AND_ASSIGN(BookmarkProviderTest);
};
BookmarkProviderTest::BookmarkProviderTest() {
model_ = bookmarks::TestBookmarkClient::CreateModel();
}
void BookmarkProviderTest::SetUp() {
provider_client_.reset(
new testing::NiceMock<MockAutocompleteProviderClient>());
EXPECT_CALL(*provider_client_, GetBookmarkModel())
.WillRepeatedly(testing::Return(model_.get()));
EXPECT_CALL(*provider_client_, GetSchemeClassifier())
.WillRepeatedly(testing::ReturnRef(classifier_));
provider_ = new BookmarkProvider(provider_client_.get());
const BookmarkNode* other_node = model_->other_node();
for (size_t i = 0; i < arraysize(bookmark_provider_test_data); ++i) {
const BookmarksTestInfo& cur(bookmark_provider_test_data[i]);
const GURL url(cur.url);
model_->AddURL(other_node, other_node->child_count(),
base::ASCIIToUTF16(cur.title), url);
}
}
TEST_F(BookmarkProviderTest, Positions) {
// Simulate searches.
// Description of |positions|:
// The first index represents the collection of positions for each expected
// match. The count of the actual subarrays in each instance of |query_data|
// must equal |match_count|. The second index represents each expected
// match position. The third index represents the |start| and |end| of the
// expected match's position within the |test_data|. This array must be
// terminated by an entry with a value of '0' for |end|.
// Example:
// Consider the line for 'def' below:
// {"def", 2, {{{4, 7}, {XXX, 0}}, {{2, 5}, {11, 14}, {XXX, 0}}}},
// There are two expected matches:
// 0. {{4, 7}, {XXX, 0}}
// 1. {{2, 5}, {11 ,14}, {XXX, 0}}
// For the first match, [0], there is one match within the bookmark's title
// expected, {4, 7}, which maps to the 'def' within "abc def". The 'XXX'
// value is ignored. The second match, [1], indicates that two matches are
// expected within the bookmark title "a definite definition". In each case,
// the {XXX, 0} indicates the end of the subarray. Or:
// Match #1 Match #2
// ------------------ ----------------------------
// Pos1 Term Pos1 Pos2 Term
// ------ -------- ------ -------- --------
// {"def", 2, {{{4, 7}, {999, 0}}, {{2, 5}, {11, 14}, {999, 0}}}},
//
struct QueryData {
const std::string query;
const size_t match_count; // This count must match the number of major
// elements in the following |positions| array.
const size_t positions[99][9][2];
} query_data[] = {
// This first set is primarily for position detection validation.
{"abc", 3, {{{0, 3}, {0, 0}},
{{0, 3}, {0, 0}},
{{0, 3}, {0, 0}}}},
{"abcde", 2, {{{0, 5}, {0, 0}},
{{0, 5}, {0, 0}}}},
{"foo bar", 0, {{{0, 0}}}},
{"fooey bark", 0, {{{0, 0}}}},
{"def", 2, {{{2, 5}, {0, 0}},
{{4, 7}, {0, 0}}}},
{"ghi jkl", 2, {{{0, 3}, {4, 7}, {0, 0}},
{{0, 3}, {4, 7}, {0, 0}}}},
// NB: GetBookmarksMatching(...) uses exact match for "a" in title or URL.
{"a", 2, {{{0, 1}, {0, 0}},
{{0, 0}}}},
{"a d", 0, {{{0, 0}}}},
{"carry carbon", 1, {{{0, 5}, {6, 12}, {0, 0}}}},
// NB: GetBookmarksMatching(...) sorts the match positions.
{"carbon carry", 1, {{{0, 5}, {6, 12}, {0, 0}}}},
{"arbon", 0, {{{0, 0}}}},
{"ar", 0, {{{0, 0}}}},
{"arry", 0, {{{0, 0}}}},
// Quoted terms are single terms.
{"\"carry carbon\"", 1, {{{0, 12}, {0, 0}}}},
{"\"carry carbon\" care", 1, {{{0, 12}, {13, 17}, {0, 0}}}},
// Quoted terms require complete word matches.
{"\"carry carbo\"", 0, {{{0, 0}}}},
// This set uses duplicated and/or overlaps search terms in the title.
{"frank", 1, {{{0, 5}, {8, 13}, {16, 21}, {0, 0}}}},
{"frankly", 1, {{{0, 7}, {8, 15}, {0, 0}}}},
{"frankly frankly", 1, {{{0, 7}, {8, 15}, {0, 0}}}},
{"foobar foo", 1, {{{0, 6}, {7, 13}, {0, 0}}}},
{"foo foobar", 1, {{{0, 6}, {7, 13}, {0, 0}}}},
// This ensures that leading whitespace in the title is not removed.
{"hello", 1, {{{1, 6}, {9, 14}, {0, 0}}}},
// This ensures that empty titles yield empty classifications.
{"emptytitle", 1, {}},
};
for (size_t i = 0; i < arraysize(query_data); ++i) {
AutocompleteInput input(base::ASCIIToUTF16(query_data[i].query),
base::string16::npos, std::string(), GURL(),
metrics::OmniboxEventProto::INVALID_SPEC, false,
false, false, true, false, TestSchemeClassifier());
provider_->Start(input, false);
const ACMatches& matches(provider_->matches());
// Validate number of results is as expected.
EXPECT_LE(matches.size(), query_data[i].match_count)
<< "One or more of the following matches were unexpected:\n"
<< MatchesAsString16(matches)
<< "For query '" << query_data[i].query << "'.";
EXPECT_GE(matches.size(), query_data[i].match_count)
<< "One or more expected matches are missing. Matches found:\n"
<< MatchesAsString16(matches)
<< "for query '" << query_data[i].query << "'.";
// Validate positions within each match is as expected.
for (size_t j = 0; j < matches.size(); ++j) {
// Collect the expected positions as a vector, collect the match's
// classifications for match positions as a vector, then compare.
TestBookmarkPositions expected_positions(
PositionsFromExpectations(query_data[i].positions[j]));
TestBookmarkPositions actual_positions(
PositionsFromAutocompleteMatch(matches[j]));
EXPECT_TRUE(std::equal(expected_positions.begin(),
expected_positions.end(),
actual_positions.begin(),
TestBookmarkPositionsEqual))
<< "EXPECTED: " << TestBookmarkPositionsAsString(expected_positions)
<< "ACTUAL: " << TestBookmarkPositionsAsString(actual_positions)
<< " for query: '" << query_data[i].query << "'.";
}
}
}
TEST_F(BookmarkProviderTest, Rankings) {
// Simulate searches.
struct QueryData {
const std::string query;
// |match_count| must match the number of elements in the following
// |matches| array.
const size_t match_count;
// |matches| specifies the titles for all bookmarks expected to be matched
// by the |query|
const std::string matches[3];
} query_data[] = {
// Basic ranking test.
{"abc", 3, {"abcde", // Most complete match.
"abcdef",
"abc def"}}, // Least complete match.
{"ghi", 2, {"ghi jkl", // Matched earlier.
"jkl ghi", // Matched later.
""}},
// Rankings of exact-word matches with different URLs.
{"achlorhydric",
3, {"achlorhydric mockingbirds resuscitates featherhead",
"achlorhydric featherheads resuscitates mockingbirds",
"featherhead resuscitates achlorhydric mockingbirds"}},
{"achlorhydric featherheads",
2, {"achlorhydric featherheads resuscitates mockingbirds",
"mockingbirds resuscitates featherheads achlorhydric",
""}},
{"mockingbirds resuscitates",
3, {"mockingbirds resuscitates featherheads achlorhydric",
"achlorhydric mockingbirds resuscitates featherhead",
"featherhead resuscitates achlorhydric mockingbirds"}},
// Ranking of exact-word matches with URL boosts.
{"worms", 2, {"burning worms #1", // boosted
"burning worms #2", // not boosted
""}},
// Ranking of prefix matches with URL boost.
{"burn worm", 3, {"burning worms #1", // boosted
"worming burns #10", // boosted but longer title
"burning worms #2"}}, // not boosted
// A query of "worm burn" will have the same results.
{"worm burn", 3, {"burning worms #1", // boosted
"worming burns #10", // boosted but longer title
"burning worms #2"}}, // not boosted
};
for (size_t i = 0; i < arraysize(query_data); ++i) {
AutocompleteInput input(base::ASCIIToUTF16(query_data[i].query),
base::string16::npos, std::string(), GURL(),
metrics::OmniboxEventProto::INVALID_SPEC, false,
false, false, true, false, TestSchemeClassifier());
provider_->Start(input, false);
const ACMatches& matches(provider_->matches());
// Validate number and content of results is as expected.
for (size_t j = 0; j < std::max(query_data[i].match_count, matches.size());
++j) {
EXPECT_LT(j, query_data[i].match_count) << " Unexpected match '"
<< base::UTF16ToUTF8(matches[j].description) << "' for query: '"
<< query_data[i].query << "'.";
if (j >= query_data[i].match_count)
continue;
EXPECT_LT(j, matches.size()) << " Missing match '"
<< query_data[i].matches[j] << "' for query: '"
<< query_data[i].query << "'.";
if (j >= matches.size())
continue;
EXPECT_EQ(query_data[i].matches[j],
base::UTF16ToUTF8(matches[j].description))
<< " Mismatch at [" << base::SizeTToString(j) << "] for query '"
<< query_data[i].query << "'.";
}
}
}
TEST_F(BookmarkProviderTest, InlineAutocompletion) {
// Simulate searches.
struct QueryData {
const std::string query;
const std::string url;
const bool allowed_to_be_default_match;
const std::string inline_autocompletion;
} query_data[] = {
{ "bla", "http://blah.com/", true, "h.com" },
{ "blah ", "http://blah.com/", false, ".com" },
{ "http://bl", "http://blah.com/", true, "ah.com" },
{ "fiddle.c", "http://fiddle.com/", true, "om" },
{ "www", "http://www.www.com/", true, ".com" },
{ "chro", "chrome://version", true, "me://version" },
{ "chrome://ve", "chrome://version", true, "rsion" },
{ "chrome ver", "chrome://version", false, "" },
{ "versi", "chrome://version", false, "" },
{ "abou", "chrome://omnibox", false, "" },
{ "about:om", "chrome://omnibox", true, "nibox" }
// Note: when adding a new URL to this test, be sure to add it to the list
// of bookmarks at the top of the file as well. All items in this list
// need to be in the bookmarks list because BookmarkProvider's
// TitleMatchToACMatch() has an assertion that verifies the URL is
// actually bookmarked.
};
for (size_t i = 0; i < arraysize(query_data); ++i) {
const std::string description = "for query=" + query_data[i].query +
" and url=" + query_data[i].url;
AutocompleteInput input(base::ASCIIToUTF16(query_data[i].query),
base::string16::npos, std::string(), GURL(),
metrics::OmniboxEventProto::INVALID_SPEC, false,
false, false, true, false, TestSchemeClassifier());
const base::string16 fixed_up_input(
provider_->FixupUserInput(input).second);
BookmarkNode node(GURL(query_data[i].url));
node.SetTitle(base::ASCIIToUTF16(query_data[i].url));
TitledUrlMatch bookmark_match;
bookmark_match.node = &node;
int relevance = provider_->CalculateBookmarkMatchRelevance(bookmark_match);
const AutocompleteMatch& ac_match = TitledUrlMatchToAutocompleteMatch(
bookmark_match, AutocompleteMatchType::BOOKMARK_TITLE, relevance,
provider_.get(), classifier_, input, fixed_up_input);
EXPECT_EQ(query_data[i].allowed_to_be_default_match,
ac_match.allowed_to_be_default_match) << description;
EXPECT_EQ(base::ASCIIToUTF16(query_data[i].inline_autocompletion),
ac_match.inline_autocompletion) << description;
}
}
TEST_F(BookmarkProviderTest, StripHttpAndAdjustOffsets) {
// Simulate searches.
struct QueryData {
const std::string query;
const std::string expected_contents;
// |expected_contents_class| is in format offset:style,offset:style,...
const std::string expected_contents_class;
} query_data[] = {
{ "foo", "www.foobar.com", "0:1,4:3,7:1" },
{ "www foo", "www.foobar.com", "0:3,3:1,4:3,7:1" },
{ "foo www", "www.foobar.com", "0:3,3:1,4:3,7:1" },
{ "foo http", "http://www.foobar.com", "0:3,4:1,11:3,14:1" },
{ "blah", "blah.com", "0:3,4:1" },
{ "http blah", "http://blah.com", "0:3,4:1,7:3,11:1" },
{ "dom", "www.domain.com/http/", "0:1,4:3,7:1" },
{ "dom http", "http://www.domain.com/http/",
"0:3,4:1,11:3,14:1,22:3,26:1" },
{ "rep", "www.repeat.com/1/repeat/2/", "0:1,4:3,7:1,17:3,20:1" },
{ "versi", "chrome://version", "0:1,9:3,14:1" }
};
for (size_t i = 0; i < arraysize(query_data); ++i) {
std::string description = "for query=" + query_data[i].query;
AutocompleteInput input(base::ASCIIToUTF16(query_data[i].query),
base::string16::npos, std::string(), GURL(),
metrics::OmniboxEventProto::INVALID_SPEC, false,
false, false, true, false, TestSchemeClassifier());
provider_->Start(input, false);
const ACMatches& matches(provider_->matches());
ASSERT_EQ(1U, matches.size()) << description;
const AutocompleteMatch& match = matches[0];
EXPECT_EQ(base::ASCIIToUTF16(query_data[i].expected_contents),
match.contents) << description;
std::vector<std::string> class_strings = base::SplitString(
query_data[i].expected_contents_class, ",",
base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
ASSERT_EQ(class_strings.size(), match.contents_class.size())
<< description;
for (size_t i = 0; i < class_strings.size(); ++i) {
std::vector<std::string> chunks = base::SplitString(
class_strings[i], ":", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
ASSERT_EQ(2U, chunks.size()) << description;
size_t offset;
EXPECT_TRUE(base::StringToSizeT(chunks[0], &offset)) << description;
EXPECT_EQ(offset, match.contents_class[i].offset) << description;
int style;
EXPECT_TRUE(base::StringToInt(chunks[1], &style)) << description;
EXPECT_EQ(style, match.contents_class[i].style) << description;
}
}
}
TEST_F(BookmarkProviderTest, DoesNotProvideMatchesOnFocus) {
AutocompleteInput input(base::ASCIIToUTF16("foo"), base::string16::npos,
std::string(), GURL(),
metrics::OmniboxEventProto::INVALID_SPEC, false,
false, false, true, true, TestSchemeClassifier());
provider_->Start(input, false);
EXPECT_TRUE(provider_->matches().empty());
}
|