1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391
|
// Copyright (c) 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include <stddef.h>
#include "base/macros.h"
#include "base/memory/ptr_util.h"
#include "base/message_loop/message_loop.h"
#include "base/strings/utf_string_conversions.h"
#include "components/omnibox/browser/autocomplete_classifier.h"
#include "components/omnibox/browser/autocomplete_controller.h"
#include "components/omnibox/browser/autocomplete_scheme_classifier.h"
#include "components/omnibox/browser/mock_autocomplete_provider_client.h"
#include "components/omnibox/browser/omnibox_client.h"
#include "components/omnibox/browser/omnibox_edit_controller.h"
#include "components/omnibox/browser/omnibox_edit_model.h"
#include "components/omnibox/browser/omnibox_view.h"
#include "components/omnibox/browser/search_provider.h"
#include "components/search_engines/search_terms_data.h"
#include "components/search_engines/template_url_service.h"
#include "components/search_engines/template_url_service_client.h"
#include "components/sessions/core/session_id.h"
#include "components/toolbar/test_toolbar_model.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace {
class TestingOmniboxView : public OmniboxView {
public:
explicit TestingOmniboxView(OmniboxEditController* controller)
: OmniboxView(controller, nullptr) {}
// OmniboxView:
void Update() override {}
void OpenMatch(const AutocompleteMatch& match,
WindowOpenDisposition disposition,
const GURL& alternate_nav_url,
const base::string16& pasted_text,
size_t selected_line) override {}
base::string16 GetText() const override { return text_; }
void SetUserText(const base::string16& text,
bool update_popup) override {
text_ = text;
}
void SetWindowTextAndCaretPos(const base::string16& text,
size_t caret_pos,
bool update_popup,
bool notify_text_changed) override {
text_ = text;
}
void EnterKeywordModeForDefaultSearchProvider() override {}
bool IsSelectAll() const override { return false; }
bool DeleteAtEndPressed() override { return false; }
void GetSelectionBounds(size_t* start, size_t* end) const override {}
void SelectAll(bool reversed) override {}
void RevertAll() override {}
void UpdatePopup() override {}
void SetFocus() override {}
void ApplyCaretVisibility() override {}
void OnTemporaryTextMaybeChanged(const base::string16& display_text,
bool save_original_selection,
bool notify_text_changed) override {
text_ = display_text;
}
bool OnInlineAutocompleteTextMaybeChanged(const base::string16& display_text,
size_t user_text_length) override {
const bool text_changed = text_ != display_text;
text_ = display_text;
inline_autocomplete_text_ = display_text.substr(user_text_length);
return text_changed;
}
void OnInlineAutocompleteTextCleared() override {
inline_autocomplete_text_.clear();
}
void OnRevertTemporaryText() override {}
void OnBeforePossibleChange() override {}
bool OnAfterPossibleChange(bool allow_keyword_ui_change) override {
return false;
}
gfx::NativeView GetNativeView() const override { return nullptr; }
gfx::NativeView GetRelativeWindowForPopup() const override { return nullptr; }
int GetTextWidth() const override { return 0; }
int GetWidth() const override { return 0; }
bool IsImeComposing() const override { return false; }
int GetOmniboxTextLength() const override { return 0; }
void EmphasizeURLComponents() override {}
const base::string16& inline_autocomplete_text() const {
return inline_autocomplete_text_;
}
private:
base::string16 text_;
base::string16 inline_autocomplete_text_;
DISALLOW_COPY_AND_ASSIGN(TestingOmniboxView);
};
class TestingOmniboxEditController : public OmniboxEditController {
public:
explicit TestingOmniboxEditController(ToolbarModel* toolbar_model)
: toolbar_model_(toolbar_model) {}
protected:
// OmniboxEditController:
void OnInputInProgress(bool in_progress) override {}
void OnChanged() override {}
ToolbarModel* GetToolbarModel() override { return toolbar_model_; }
const ToolbarModel* GetToolbarModel() const override {
return toolbar_model_;
}
private:
ToolbarModel* toolbar_model_;
DISALLOW_COPY_AND_ASSIGN(TestingOmniboxEditController);
};
class TestingSchemeClassifier : public AutocompleteSchemeClassifier {
public:
TestingSchemeClassifier() {}
metrics::OmniboxInputType::Type GetInputTypeForScheme(
const std::string& scheme) const override {
return metrics::OmniboxInputType::URL;
}
private:
DISALLOW_COPY_AND_ASSIGN(TestingSchemeClassifier);
};
class TestingOmniboxClient : public OmniboxClient {
public:
TestingOmniboxClient();
~TestingOmniboxClient() override;
const AutocompleteMatch& alternate_nav_match() const {
return alternate_nav_match_;
}
// OmniboxClient:
std::unique_ptr<AutocompleteProviderClient> CreateAutocompleteProviderClient()
override;
std::unique_ptr<OmniboxNavigationObserver> CreateOmniboxNavigationObserver(
const base::string16& text,
const AutocompleteMatch& match,
const AutocompleteMatch& alternate_nav_match) override {
alternate_nav_match_ = alternate_nav_match;
return nullptr;
}
bool CurrentPageExists() const override { return true; }
const GURL& GetURL() const override { return GURL::EmptyGURL(); }
const base::string16& GetTitle() const override {
return base::EmptyString16();
}
gfx::Image GetFavicon() const override { return gfx::Image(); }
bool IsInstantNTP() const override { return false; }
bool IsSearchResultsPage() const override { return false; }
bool IsLoading() const override { return false; }
bool IsPasteAndGoEnabled() const override { return false; }
bool IsNewTabPage(const std::string& url) const override { return false; }
bool IsHomePage(const std::string& url) const override { return false; }
const SessionID& GetSessionID() const override { return session_id_; }
bookmarks::BookmarkModel* GetBookmarkModel() override { return nullptr; }
TemplateURLService* GetTemplateURLService() override { return nullptr; }
const AutocompleteSchemeClassifier& GetSchemeClassifier() const override {
return scheme_classifier_;
}
AutocompleteClassifier* GetAutocompleteClassifier() override {
return &autocomplete_classifier_;
}
gfx::Image GetIconIfExtensionMatch(
const AutocompleteMatch& match) const override {
return gfx::Image();
}
bool ProcessExtensionKeyword(TemplateURL* template_url,
const AutocompleteMatch& match,
WindowOpenDisposition disposition,
OmniboxNavigationObserver* observer) override {
return false;
}
void OnInputStateChanged() override {}
void OnFocusChanged(OmniboxFocusState state,
OmniboxFocusChangeReason reason) override {}
void OnResultChanged(const AutocompleteResult& result,
bool default_match_changed,
const base::Callback<void(const SkBitmap& bitmap)>&
on_bitmap_fetched) override {}
void OnCurrentMatchChanged(const AutocompleteMatch& match) override {}
void OnTextChanged(const AutocompleteMatch& current_match,
bool user_input_in_progress,
base::string16& user_text,
const AutocompleteResult& result,
bool is_popup_open,
bool has_focus) override {}
void OnInputAccepted(const AutocompleteMatch& match) override {}
void OnRevert() override {}
void OnURLOpenedFromOmnibox(OmniboxLog* log) override {}
void OnBookmarkLaunched() override {}
void DiscardNonCommittedNavigations() override {}
private:
SessionID session_id_;
TestingSchemeClassifier scheme_classifier_;
AutocompleteClassifier autocomplete_classifier_;
AutocompleteMatch alternate_nav_match_;
DISALLOW_COPY_AND_ASSIGN(TestingOmniboxClient);
};
TestingOmniboxClient::TestingOmniboxClient()
: autocomplete_classifier_(
base::MakeUnique<AutocompleteController>(
CreateAutocompleteProviderClient(),
nullptr,
AutocompleteClassifier::kDefaultOmniboxProviders),
base::MakeUnique<TestingSchemeClassifier>()) {}
TestingOmniboxClient::~TestingOmniboxClient() {
autocomplete_classifier_.Shutdown();
}
std::unique_ptr<AutocompleteProviderClient>
TestingOmniboxClient::CreateAutocompleteProviderClient() {
std::unique_ptr<MockAutocompleteProviderClient> provider_client(
new MockAutocompleteProviderClient());
EXPECT_CALL(*provider_client.get(), GetBuiltinURLs())
.WillRepeatedly(testing::Return(std::vector<base::string16>()));
EXPECT_CALL(*provider_client.get(), GetSchemeClassifier())
.WillRepeatedly(testing::ReturnRef(scheme_classifier_));
std::unique_ptr<TemplateURLService> template_url_service(
new TemplateURLService(
nullptr, std::unique_ptr<SearchTermsData>(new SearchTermsData),
nullptr, std::unique_ptr<TemplateURLServiceClient>(), nullptr,
nullptr, base::Closure()));
provider_client->set_template_url_service(std::move(template_url_service));
return std::move(provider_client);
}
} // namespace
class OmniboxEditTest : public ::testing::Test {
public:
OmniboxEditTest()
: controller_(&toolbar_model_),
view_(&controller_),
model_(&view_, &controller_, base::MakeUnique<TestingOmniboxClient>()) {
}
TestToolbarModel* toolbar_model() { return &toolbar_model_; }
const TestingOmniboxView& view() { return view_; }
OmniboxEditModel* model() { return &model_; }
private:
base::MessageLoop message_loop_;
TestToolbarModel toolbar_model_;
TestingOmniboxEditController controller_;
TestingOmniboxView view_;
OmniboxEditModel model_;
DISALLOW_COPY_AND_ASSIGN(OmniboxEditTest);
};
// Tests various permutations of AutocompleteModel::AdjustTextForCopy.
TEST_F(OmniboxEditTest, AdjustTextForCopy) {
struct Data {
const char* perm_text;
const int sel_start;
const bool is_all_selected;
const char* input;
const char* expected_output;
const bool write_url;
const char* expected_url;
} input[] = {
// Test that http:// is inserted if all text is selected.
{ "a.de/b", 0, true, "a.de/b", "http://a.de/b", true, "http://a.de/b", },
// Test that http:// is inserted if the host is selected.
{ "a.de/b", 0, false, "a.de/", "http://a.de/", true, "http://a.de/" },
// Tests that http:// is inserted if the path is modified.
{ "a.de/b", 0, false, "a.de/c", "http://a.de/c", true, "http://a.de/c" },
// Tests that http:// isn't inserted if the host is modified.
{ "a.de/b", 0, false, "a.com/b", "a.com/b", false, "" },
// Tests that http:// isn't inserted if the start of the selection is 1.
{ "a.de/b", 1, false, "a.de/b", "a.de/b", false, "" },
// Tests that http:// isn't inserted if a portion of the host is selected.
{ "a.de/", 0, false, "a.d", "a.d", false, "" },
// Tests that http:// isn't inserted for an https url after the user nukes
// https.
{ "https://a.com/", 0, false, "a.com/", "a.com/", false, "" },
// Tests that http:// isn't inserted if the user adds to the host.
{ "a.de/", 0, false, "a.de.com/", "a.de.com/", false, "" },
// Tests that we don't get double http if the user manually inserts http.
{ "a.de/", 0, false, "http://a.de/", "http://a.de/", true, "http://a.de/" },
// Makes sure intranet urls get 'http://' prefixed to them.
{ "b/foo", 0, true, "b/foo", "http://b/foo", true, "http://b/foo" },
// Verifies a search term 'foo' doesn't end up with http.
{ "www.google.com/search?", 0, false, "foo", "foo", false, "" },
};
for (size_t i = 0; i < arraysize(input); ++i) {
toolbar_model()->set_text(base::ASCIIToUTF16(input[i].perm_text));
model()->UpdatePermanentText();
base::string16 result = base::ASCIIToUTF16(input[i].input);
GURL url;
bool write_url;
model()->AdjustTextForCopy(input[i].sel_start, input[i].is_all_selected,
&result, &url, &write_url);
EXPECT_EQ(base::ASCIIToUTF16(input[i].expected_output), result) << "@: "
<< i;
EXPECT_EQ(input[i].write_url, write_url) << " @" << i;
if (write_url)
EXPECT_EQ(input[i].expected_url, url.spec()) << " @" << i;
}
}
TEST_F(OmniboxEditTest, InlineAutocompleteText) {
// Test if the model updates the inline autocomplete text in the view.
EXPECT_EQ(base::string16(), view().inline_autocomplete_text());
model()->SetUserText(base::ASCIIToUTF16("he"));
model()->OnPopupDataChanged(base::ASCIIToUTF16("llo"), nullptr,
base::string16(), false);
EXPECT_EQ(base::ASCIIToUTF16("hello"), view().GetText());
EXPECT_EQ(base::ASCIIToUTF16("llo"), view().inline_autocomplete_text());
base::string16 text_before = base::ASCIIToUTF16("he");
base::string16 text_after = base::ASCIIToUTF16("hel");
OmniboxView::StateChanges state_changes{
&text_before, &text_after, 3, 3, false, true, false, false};
model()->OnAfterPossibleChange(state_changes, true);
EXPECT_EQ(base::string16(), view().inline_autocomplete_text());
model()->OnPopupDataChanged(base::ASCIIToUTF16("lo"), nullptr,
base::string16(), false);
EXPECT_EQ(base::ASCIIToUTF16("hello"), view().GetText());
EXPECT_EQ(base::ASCIIToUTF16("lo"), view().inline_autocomplete_text());
model()->Revert();
EXPECT_EQ(base::string16(), view().GetText());
EXPECT_EQ(base::string16(), view().inline_autocomplete_text());
model()->SetUserText(base::ASCIIToUTF16("he"));
model()->OnPopupDataChanged(base::ASCIIToUTF16("llo"), nullptr,
base::string16(), false);
EXPECT_EQ(base::ASCIIToUTF16("hello"), view().GetText());
EXPECT_EQ(base::ASCIIToUTF16("llo"), view().inline_autocomplete_text());
model()->AcceptTemporaryTextAsUserText();
EXPECT_EQ(base::ASCIIToUTF16("hello"), view().GetText());
EXPECT_EQ(base::string16(), view().inline_autocomplete_text());
}
// This verifies the fix for a bug where calling OpenMatch() with a valid
// alternate nav URL would fail a DCHECK if the input began with "http://".
// The failure was due to erroneously trying to strip the scheme from the
// resulting fill_into_edit. Alternate nav matches are never shown, so there's
// no need to ever try and strip this scheme.
TEST_F(OmniboxEditTest, AlternateNavHasHTTP) {
const TestingOmniboxClient* client =
static_cast<TestingOmniboxClient*>(model()->client());
const AutocompleteMatch match(
model()->autocomplete_controller()->search_provider(), 0, false,
AutocompleteMatchType::SEARCH_WHAT_YOU_TYPED);
const GURL alternate_nav_url("http://abcd/");
model()->OnSetFocus(false); // Avoids DCHECK in OpenMatch().
model()->SetUserText(base::ASCIIToUTF16("http://abcd"));
model()->OpenMatch(match, WindowOpenDisposition::CURRENT_TAB,
alternate_nav_url, base::string16(), 0);
EXPECT_TRUE(AutocompleteInput::HasHTTPScheme(
client->alternate_nav_match().fill_into_edit));
model()->SetUserText(base::ASCIIToUTF16("abcd"));
model()->OpenMatch(match, WindowOpenDisposition::CURRENT_TAB,
alternate_nav_url, base::string16(), 0);
EXPECT_TRUE(AutocompleteInput::HasHTTPScheme(
client->alternate_nav_match().fill_into_edit));
}
|