1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753
|
// Copyright (c) 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "components/omnibox/browser/shortcuts_provider.h"
#include <math.h>
#include <stddef.h>
#include <algorithm>
#include <functional>
#include <set>
#include <string>
#include <vector>
#include "base/files/scoped_temp_dir.h"
#include "base/macros.h"
#include "base/memory/ptr_util.h"
#include "base/memory/ref_counted.h"
#include "base/message_loop/message_loop.h"
#include "base/run_loop.h"
#include "base/strings/stringprintf.h"
#include "base/strings/utf_string_conversions.h"
#include "base/test/sequenced_worker_pool_owner.h"
#include "base/threading/thread.h"
#include "components/history/core/browser/history_service.h"
#include "components/history/core/browser/url_database.h"
#include "components/history/core/test/history_service_test_util.h"
#include "components/metrics/proto/omnibox_event.pb.h"
#include "components/omnibox/browser/autocomplete_input.h"
#include "components/omnibox/browser/autocomplete_match.h"
#include "components/omnibox/browser/autocomplete_provider.h"
#include "components/omnibox/browser/autocomplete_result.h"
#include "components/omnibox/browser/in_memory_url_index.h"
#include "components/omnibox/browser/mock_autocomplete_provider_client.h"
#include "components/omnibox/browser/shortcuts_backend.h"
#include "components/omnibox/browser/shortcuts_provider_test_util.h"
#include "components/omnibox/browser/test_scheme_classifier.h"
#include "testing/gtest/include/gtest/gtest.h"
using base::ASCIIToUTF16;
using ExpectedURLs = std::vector<ExpectedURLAndAllowedToBeDefault>;
namespace {
struct TestShortcutData shortcut_test_db[] = {
{ "BD85DBA2-8C29-49F9-84AE-48E1E90880E0", "goog", "www.google.com",
"http://www.google.com/", "Google", "0,1,4,0", "Google", "0,3,4,1",
ui::PAGE_TRANSITION_TYPED, AutocompleteMatchType::HISTORY_URL, "", 1,
100 },
{ "BD85DBA2-8C29-49F9-84AE-48E1E90880E1", "slash", "slashdot.org",
"http://slashdot.org/", "slashdot.org", "0,3,5,1",
"Slashdot - News for nerds, stuff that matters", "0,2,5,0",
ui::PAGE_TRANSITION_TYPED, AutocompleteMatchType::HISTORY_URL, "", 0,
100 },
{ "BD85DBA2-8C29-49F9-84AE-48E1E90880E2", "news", "slashdot.org",
"http://slashdot.org/", "slashdot.org", "0,1",
"Slashdot - News for nerds, stuff that matters", "0,0,11,2,15,0",
ui::PAGE_TRANSITION_TYPED, AutocompleteMatchType::HISTORY_TITLE, "", 0,
5 },
{ "BD85DBA2-8C29-49F9-84AE-48E1E90880E3", "news", "sports.yahoo.com",
"http://sports.yahoo.com/", "sports.yahoo.com", "0,1",
"Yahoo! Sports - Sports News, Scores, Rumors, Fantasy Games, and more",
"0,0,23,2,27,0", ui::PAGE_TRANSITION_TYPED,
AutocompleteMatchType::HISTORY_TITLE, "", 2, 5 },
{ "BD85DBA2-8C29-49F9-84AE-48E1E90880E4", "news weather",
"www.cnn.com/index.html", "http://www.cnn.com/index.html",
"www.cnn.com/index.html", "0,1",
"CNN.com - Breaking News, U.S., World, Weather, Entertainment & Video",
"0,0,19,2,23,0,38,2,45,0", ui::PAGE_TRANSITION_TYPED,
AutocompleteMatchType::HISTORY_TITLE, "", 1, 10 },
{ "BD85DBA2-8C29-49F9-84AE-48E1E90880E5", "nhl scores", "sports.yahoo.com",
"http://sports.yahoo.com/", "sports.yahoo.com", "0,1",
"Yahoo! Sports - Sports News, Scores, Rumors, Fantasy Games, and more",
"0,0,29,2,35,0", ui::PAGE_TRANSITION_TYPED,
AutocompleteMatchType::HISTORY_BODY, "", 1, 10 },
{ "BD85DBA2-8C29-49F9-84AE-48E1E90880E6", "nhl scores",
"www.nhl.com/scores/index.html", "http://www.nhl.com/scores/index.html",
"www.nhl.com/scores/index.html", "0,1,4,3,7,1",
"January 13, 2010 - NHL.com - Scores", "0,0,19,2,22,0,29,2,35,0",
ui::PAGE_TRANSITION_TYPED, AutocompleteMatchType::HISTORY_URL, "", 5,
1 },
{ "BD85DBA2-8C29-49F9-84AE-48E1E90880E7", "just", "www.testsite.com/a.html",
"http://www.testsite.com/a.html", "www.testsite.com/a.html", "0,1",
"Test - site - just a test", "0,0,14,2,18,0",
ui::PAGE_TRANSITION_TYPED, AutocompleteMatchType::HISTORY_TITLE, "", 5,
1 },
{ "BD85DBA2-8C29-49F9-84AE-48E1E90880E8", "just", "www.testsite.com/b.html",
"http://www.testsite.com/b.html", "www.testsite.com/b.html", "0,1",
"Test - site - just a test", "0,0,14,2,18,0",
ui::PAGE_TRANSITION_TYPED, AutocompleteMatchType::HISTORY_TITLE, "", 5,
2 },
{ "BD85DBA2-8C29-49F9-84AE-48E1E90880E9", "just", "www.testsite.com/c.html",
"http://www.testsite.com/c.html", "www.testsite.com/c.html", "0,1",
"Test - site - just a test", "0,0,14,2,18,0",
ui::PAGE_TRANSITION_TYPED, AutocompleteMatchType::HISTORY_TITLE, "", 8,
1 },
{ "BD85DBA2-8C29-49F9-84AE-48E1E90880EA", "just a", "www.testsite.com/d.html",
"http://www.testsite.com/d.html", "www.testsite.com/d.html", "0,1",
"Test - site - just a test", "0,0,14,2,18,0",
ui::PAGE_TRANSITION_TYPED, AutocompleteMatchType::HISTORY_TITLE, "",
12, 1 },
{ "BD85DBA2-8C29-49F9-84AE-48E1E90880EB", "just a t",
"www.testsite.com/e.html", "http://www.testsite.com/e.html",
"www.testsite.com/e.html", "0,1", "Test - site - just a test",
"0,0,14,2,18,0", ui::PAGE_TRANSITION_TYPED,
AutocompleteMatchType::HISTORY_TITLE, "", 12, 1 },
{ "BD85DBA2-8C29-49F9-84AE-48E1E90880EC", "just a te",
"www.testsite.com/f.html", "http://www.testsite.com/f.html",
"www.testsite.com/f.html", "0,1", "Test - site - just a test",
"0,0,14,2,18,0", ui::PAGE_TRANSITION_TYPED,
AutocompleteMatchType::HISTORY_TITLE, "", 12, 1 },
{ "BD85DBA2-8C29-49F9-84AE-48E1E90880ED", "ago", "www.daysagotest.com/a.html",
"http://www.daysagotest.com/a.html", "www.daysagotest.com/a.html",
"0,1,8,3,11,1", "Test - site", "0,0", ui::PAGE_TRANSITION_TYPED,
AutocompleteMatchType::HISTORY_URL, "", 1, 1 },
{ "BD85DBA2-8C29-49F9-84AE-48E1E90880EE", "ago", "www.daysagotest.com/b.html",
"http://www.daysagotest.com/b.html", "www.daysagotest.com/b.html",
"0,1,8,3,11,1", "Test - site", "0,0", ui::PAGE_TRANSITION_TYPED,
AutocompleteMatchType::HISTORY_URL, "", 2, 1 },
{ "BD85DBA2-8C29-49F9-84AE-48E1E90880EF", "ago", "www.daysagotest.com/c.html",
"http://www.daysagotest.com/c.html", "www.daysagotest.com/c.html",
"0,1,8,3,11,1", "Test - site", "0,0", ui::PAGE_TRANSITION_TYPED,
AutocompleteMatchType::HISTORY_URL, "", 3, 1 },
{ "BD85DBA2-8C29-49F9-84AE-48E1E90880F0", "ago", "www.daysagotest.com/d.html",
"http://www.daysagotest.com/d.html", "www.daysagotest.com/d.html",
"0,1,8,3,11,1", "Test - site", "0,0", ui::PAGE_TRANSITION_TYPED,
AutocompleteMatchType::HISTORY_URL, "", 4, 1 },
{ "BD85DBA2-8C29-49F9-84AE-48E1E90880F2", "abcdef.com", "http://abcdef.com",
"http://abcdef.com/", "Abcdef", "0,1,4,0", "Abcdef", "0,3,4,1",
ui::PAGE_TRANSITION_TYPED, AutocompleteMatchType::HISTORY_URL, "", 1,
100 },
{ "BD85DBA2-8C29-49F9-84AE-48E1E90880F3", "query", "query",
"https://www.google.com/search?q=query", "query", "0,0",
"Google Search", "0,4", ui::PAGE_TRANSITION_GENERATED,
AutocompleteMatchType::SEARCH_HISTORY, "", 1, 100 },
{ "BD85DBA2-8C29-49F9-84AE-48E1E90880F4", "word", "www.word",
"https://www.google.com/search?q=www.word", "www.word", "0,0",
"Google Search", "0,4", ui::PAGE_TRANSITION_GENERATED,
AutocompleteMatchType::SEARCH_HISTORY, "", 1, 100 },
{ "BD85DBA2-8C29-49F9-84AE-48E1E90880F5", "about:o", "chrome://omnibox",
"chrome://omnibox/", "about:omnibox", "0,3,10,1", "", "",
ui::PAGE_TRANSITION_TYPED, AutocompleteMatchType::NAVSUGGEST, "",
1, 100 },
{ "BD85DBA2-8C29-49F9-84AE-48E1E90880F6", "www/real sp",
"http://www/real space/long-url-with-space.html",
"http://www/real%20space/long-url-with-space.html",
"www/real space/long-url-with-space.html", "0,3,11,1",
"Page With Space; Input with Space", "0,0",
ui::PAGE_TRANSITION_TYPED, AutocompleteMatchType::HISTORY_URL, "",
1, 100 },
{ "BD85DBA2-8C29-49F9-84AE-48E1E90880F7", "duplicate", "http://duplicate.com",
"http://duplicate.com/", "Duplicate", "0,1", "Duplicate", "0,1",
ui::PAGE_TRANSITION_TYPED, AutocompleteMatchType::HISTORY_URL, "", 1,
100 },
{ "BD85DBA2-8C29-49F9-84AE-48E1E90880F8", "dupl", "http://duplicate.com",
"http://duplicate.com/", "Duplicate", "0,1", "Duplicate", "0,1",
ui::PAGE_TRANSITION_TYPED, AutocompleteMatchType::HISTORY_URL, "", 1,
100 },
{ "BD85DBA2-8C29-49F9-84AE-48E1E90880F9", "notrailing.com/",
"http://notrailing.com", "http://notrailing.com/", "No Trailing Slash",
"0,1", "No Trailing Slash on fill_into_edit", "0,1",
ui::PAGE_TRANSITION_TYPED, AutocompleteMatchType::HISTORY_URL, "",
1, 100 },
{ "BD85DBA2-8C29-49F9-84AE-48E1E90880FA", "http:///foo.com",
"http://foo.com", "http://foo.com/", "Foo - Typo in Input",
"0,1", "Foo - Typo in Input Corrected in fill_into_edit", "0,1",
ui::PAGE_TRANSITION_TYPED, AutocompleteMatchType::HISTORY_URL, "",
1, 100 },
{ "BD85DBA2-8C29-49F9-84AE-48E1E90880FB", "trailing1 ",
"http://trailing1.com", "http://trailing1.com/",
"Trailing1 - Space in Shortcut", "0,1",
"Trailing1 - Space in Shortcut", "0,1", ui::PAGE_TRANSITION_TYPED,
AutocompleteMatchType::HISTORY_URL, "", 1, 100 },
{ "BD85DBA2-8C29-49F9-84AE-48E1E90880FC", "about:trailing2 ",
"chrome://trailing2blah", "chrome://trailing2blah/",
"Trailing2 - Space in Shortcut", "0,1",
"Trailing2 - Space in Shortcut", "0,1", ui::PAGE_TRANSITION_TYPED,
AutocompleteMatchType::HISTORY_URL, "", 1, 100 },
};
class FakeAutocompleteProviderClient
: public testing::NiceMock<MockAutocompleteProviderClient> {
public:
FakeAutocompleteProviderClient()
: db_thread_("Test DB thread"), pool_owner_(3, "Background Pool") {
set_template_url_service(base::MakeUnique<TemplateURLService>(nullptr, 0));
if (history_dir_.CreateUniqueTempDir()) {
history_service_ =
history::CreateHistoryService(history_dir_.GetPath(), true);
}
db_thread_.Start();
shortcuts_backend_ = new ShortcutsBackend(
GetTemplateURLService(), base::MakeUnique<SearchTermsData>(),
history_service_.get(), db_thread_.task_runner(), base::FilePath(),
true);
shortcuts_backend_->Init();
}
~FakeAutocompleteProviderClient() override { db_thread_.Stop(); }
history::HistoryService* GetHistoryService() override {
return history_service_.get();
}
scoped_refptr<ShortcutsBackend> GetShortcutsBackend() override {
return shortcuts_backend_;
}
scoped_refptr<ShortcutsBackend> GetShortcutsBackendIfExists() override {
return shortcuts_backend_;
}
private:
base::Thread db_thread_;
base::SequencedWorkerPoolOwner pool_owner_;
base::ScopedTempDir history_dir_;
std::unique_ptr<history::HistoryService> history_service_;
scoped_refptr<ShortcutsBackend> shortcuts_backend_;
DISALLOW_COPY_AND_ASSIGN(FakeAutocompleteProviderClient);
};
} // namespace
// ClassifyTest ---------------------------------------------------------------
// Helper class to make running tests of ClassifyAllMatchesInString() more
// convenient.
class ClassifyTest {
public:
ClassifyTest(const base::string16& text, ACMatchClassifications matches);
~ClassifyTest();
ACMatchClassifications RunTest(const base::string16& find_text);
private:
const base::string16 text_;
const ACMatchClassifications matches_;
};
ClassifyTest::ClassifyTest(const base::string16& text,
ACMatchClassifications matches)
: text_(text), matches_(matches) {}
ClassifyTest::~ClassifyTest() {}
ACMatchClassifications ClassifyTest::RunTest(const base::string16& find_text) {
return ShortcutsProvider::ClassifyAllMatchesInString(
find_text, ShortcutsProvider::CreateWordMapForString(find_text), text_,
matches_);
}
// ShortcutsProviderTest ------------------------------------------------------
class ShortcutsProviderTest : public testing::Test {
public:
ShortcutsProviderTest();
protected:
void SetUp() override;
void TearDown() override;
// Passthrough to the private function in provider_.
int CalculateScore(const std::string& terms,
const ShortcutsDatabase::Shortcut& shortcut,
int max_relevance);
base::MessageLoop message_loop_;
std::unique_ptr<FakeAutocompleteProviderClient> client_;
scoped_refptr<ShortcutsProvider> provider_;
};
ShortcutsProviderTest::ShortcutsProviderTest() {}
void ShortcutsProviderTest::SetUp() {
client_.reset(new FakeAutocompleteProviderClient());
ASSERT_TRUE(client_->GetShortcutsBackend());
provider_ = new ShortcutsProvider(client_.get());
PopulateShortcutsBackendWithTestData(client_->GetShortcutsBackend(),
shortcut_test_db,
arraysize(shortcut_test_db));
}
void ShortcutsProviderTest::TearDown() {
// Run all pending tasks or else some threads hold on to the message loop
// and prevent it from being deleted.
base::RunLoop().RunUntilIdle();
provider_ = NULL;
}
int ShortcutsProviderTest::CalculateScore(
const std::string& terms,
const ShortcutsDatabase::Shortcut& shortcut,
int max_relevance) {
return provider_->CalculateScore(ASCIIToUTF16(terms), shortcut,
max_relevance);
}
// Actual tests ---------------------------------------------------------------
TEST_F(ShortcutsProviderTest, SimpleSingleMatch) {
base::string16 text(ASCIIToUTF16("go"));
std::string expected_url("http://www.google.com/");
ExpectedURLs expected_urls;
expected_urls.push_back(ExpectedURLAndAllowedToBeDefault(expected_url, true));
RunShortcutsProviderTest(provider_, text, false, expected_urls, expected_url,
ASCIIToUTF16("ogle.com"));
// Same test with prevent inline autocomplete.
expected_urls.clear();
expected_urls.push_back(
ExpectedURLAndAllowedToBeDefault(expected_url, false));
// The match will have an |inline_autocompletion| set, but the value will not
// be used because |allowed_to_be_default_match| will be false.
RunShortcutsProviderTest(provider_, text, true, expected_urls, expected_url,
ASCIIToUTF16("ogle.com"));
// A pair of analogous tests where the shortcut ends at the end of
// |fill_into_edit|. This exercises the inline autocompletion and default
// match code.
text = ASCIIToUTF16("abcdef.com");
expected_url = "http://abcdef.com/";
expected_urls.clear();
expected_urls.push_back(ExpectedURLAndAllowedToBeDefault(expected_url, true));
RunShortcutsProviderTest(provider_, text, false, expected_urls, expected_url,
base::string16());
// With prevent inline autocomplete, the suggestion should be the same
// (because there is no completion).
RunShortcutsProviderTest(provider_, text, true, expected_urls, expected_url,
base::string16());
// Another test, simply for a query match type, not a navigation URL match
// type.
text = ASCIIToUTF16("que");
expected_url = "https://www.google.com/search?q=query";
expected_urls.clear();
expected_urls.push_back(ExpectedURLAndAllowedToBeDefault(expected_url, true));
RunShortcutsProviderTest(provider_, text, false, expected_urls, expected_url,
ASCIIToUTF16("ry"));
// Same test with prevent inline autocomplete.
expected_urls.clear();
expected_urls.push_back(
ExpectedURLAndAllowedToBeDefault(expected_url, false));
// The match will have an |inline_autocompletion| set, but the value will not
// be used because |allowed_to_be_default_match| will be false.
RunShortcutsProviderTest(provider_, text, true, expected_urls, expected_url,
ASCIIToUTF16("ry"));
// A pair of analogous tests where the shortcut ends at the end of
// |fill_into_edit|. This exercises the inline autocompletion and default
// match code.
text = ASCIIToUTF16("query");
expected_urls.clear();
expected_urls.push_back(ExpectedURLAndAllowedToBeDefault(expected_url, true));
RunShortcutsProviderTest(provider_, text, false, expected_urls, expected_url,
base::string16());
// With prevent inline autocomplete, the suggestion should be the same
// (because there is no completion).
RunShortcutsProviderTest(provider_, text, true, expected_urls, expected_url,
base::string16());
// Now the shortcut ends at the end of |fill_into_edit| but has a
// non-droppable prefix. ("www.", for instance, is not droppable for
// queries.)
text = ASCIIToUTF16("word");
expected_url = "https://www.google.com/search?q=www.word";
expected_urls.clear();
expected_urls.push_back(
ExpectedURLAndAllowedToBeDefault(expected_url, false));
RunShortcutsProviderTest(provider_, text, false, expected_urls, expected_url,
base::string16());
}
// These tests are like those in SimpleSingleMatch but more complex,
// involving URLs that need to be fixed up to match properly.
TEST_F(ShortcutsProviderTest, TrickySingleMatch) {
// Test that about: URLs are fixed up/transformed to chrome:// URLs.
base::string16 text(ASCIIToUTF16("about:o"));
std::string expected_url("chrome://omnibox/");
ExpectedURLs expected_urls;
expected_urls.push_back(ExpectedURLAndAllowedToBeDefault(expected_url, true));
RunShortcutsProviderTest(provider_, text, false, expected_urls, expected_url,
ASCIIToUTF16("mnibox"));
// Same test with prevent inline autocomplete.
expected_urls.clear();
expected_urls.push_back(
ExpectedURLAndAllowedToBeDefault(expected_url, false));
// The match will have an |inline_autocompletion| set, but the value will not
// be used because |allowed_to_be_default_match| will be false.
RunShortcutsProviderTest(provider_, text, true, expected_urls, expected_url,
ASCIIToUTF16("mnibox"));
// Test that an input with a space can match URLs with a (escaped) space.
// This would fail if we didn't try to lookup the un-fixed-up string.
text = ASCIIToUTF16("www/real sp");
expected_url = "http://www/real%20space/long-url-with-space.html";
expected_urls.clear();
expected_urls.push_back(ExpectedURLAndAllowedToBeDefault(expected_url, true));
RunShortcutsProviderTest(provider_, text, false, expected_urls, expected_url,
ASCIIToUTF16("ace/long-url-with-space.html"));
// Same test with prevent inline autocomplete.
expected_urls.clear();
expected_urls.push_back(
ExpectedURLAndAllowedToBeDefault(expected_url, false));
// The match will have an |inline_autocompletion| set, but the value will not
// be used because |allowed_to_be_default_match| will be false.
RunShortcutsProviderTest(provider_, text, true, expected_urls, expected_url,
ASCIIToUTF16("ace/long-url-with-space.html"));
// Test when the user input has a trailing slash but fill_into_edit does
// not. This should still be allowed to be default.
text = ASCIIToUTF16("notrailing.com/");
expected_url = "http://notrailing.com/";
expected_urls.clear();
expected_urls.push_back(ExpectedURLAndAllowedToBeDefault(expected_url, true));
RunShortcutsProviderTest(provider_, text, true, expected_urls, expected_url,
base::string16());
// Test when the user input has a typo that can be fixed up for matching
// fill_into_edit. This should still be allowed to be default.
text = ASCIIToUTF16("http:///foo.com");
expected_url = "http://foo.com/";
expected_urls.clear();
expected_urls.push_back(ExpectedURLAndAllowedToBeDefault(expected_url, true));
RunShortcutsProviderTest(provider_, text, true, expected_urls, expected_url,
base::string16());
// A foursome of tests to verify that trailing spaces prevent the shortcut
// from being allowed to be the default match. For each of two tests, we
// first verify that the match is allowed to be default without the trailing
// space but is not allowed to be default with the trailing space. In both
// of these with-trailing-space cases, we actually get an
// inline_autocompletion, though it's never used because the match is
// prohibited from being default.
text = ASCIIToUTF16("trailing1");
expected_url = "http://trailing1.com/";
expected_urls.clear();
expected_urls.push_back(ExpectedURLAndAllowedToBeDefault(expected_url, true));
RunShortcutsProviderTest(provider_, text, false, expected_urls, expected_url,
ASCIIToUTF16(".com"));
text = ASCIIToUTF16("trailing1 ");
expected_urls.clear();
expected_urls.push_back(
ExpectedURLAndAllowedToBeDefault(expected_url, false));
RunShortcutsProviderTest(provider_, text, false, expected_urls, expected_url,
ASCIIToUTF16(".com"));
text = ASCIIToUTF16("about:trailing2");
expected_url = "chrome://trailing2blah/";
expected_urls.clear();
expected_urls.push_back(ExpectedURLAndAllowedToBeDefault(expected_url, true));
RunShortcutsProviderTest(provider_, text, false, expected_urls, expected_url,
ASCIIToUTF16("blah"));
text = ASCIIToUTF16("about:trailing2 ");
expected_urls.clear();
expected_urls.push_back(
ExpectedURLAndAllowedToBeDefault(expected_url, false));
RunShortcutsProviderTest(provider_, text, false, expected_urls, expected_url,
ASCIIToUTF16("blah"));
}
TEST_F(ShortcutsProviderTest, MultiMatch) {
base::string16 text(ASCIIToUTF16("NEWS"));
ExpectedURLs expected_urls;
// Scores high because of completion length.
expected_urls.push_back(
ExpectedURLAndAllowedToBeDefault("http://slashdot.org/", false));
// Scores high because of visit count.
expected_urls.push_back(
ExpectedURLAndAllowedToBeDefault("http://sports.yahoo.com/", false));
// Scores high because of visit count but less match span,
// which is more important.
expected_urls.push_back(
ExpectedURLAndAllowedToBeDefault("http://www.cnn.com/index.html", false));
RunShortcutsProviderTest(provider_, text, false, expected_urls,
"http://slashdot.org/", base::string16());
}
TEST_F(ShortcutsProviderTest, RemoveDuplicates) {
base::string16 text(ASCIIToUTF16("dupl"));
ExpectedURLs expected_urls;
expected_urls.push_back(
ExpectedURLAndAllowedToBeDefault("http://duplicate.com/", true));
// Make sure the URL only appears once in the output list.
RunShortcutsProviderTest(provider_, text, false, expected_urls,
"http://duplicate.com/", ASCIIToUTF16("icate.com"));
}
TEST_F(ShortcutsProviderTest, TypedCountMatches) {
base::string16 text(ASCIIToUTF16("just"));
ExpectedURLs expected_urls;
expected_urls.push_back(ExpectedURLAndAllowedToBeDefault(
"http://www.testsite.com/b.html", false));
expected_urls.push_back(ExpectedURLAndAllowedToBeDefault(
"http://www.testsite.com/a.html", false));
expected_urls.push_back(ExpectedURLAndAllowedToBeDefault(
"http://www.testsite.com/c.html", false));
RunShortcutsProviderTest(provider_, text, false, expected_urls,
"http://www.testsite.com/b.html", base::string16());
}
TEST_F(ShortcutsProviderTest, FragmentLengthMatches) {
base::string16 text(ASCIIToUTF16("just a"));
ExpectedURLs expected_urls;
expected_urls.push_back(ExpectedURLAndAllowedToBeDefault(
"http://www.testsite.com/d.html", false));
expected_urls.push_back(ExpectedURLAndAllowedToBeDefault(
"http://www.testsite.com/e.html", false));
expected_urls.push_back(ExpectedURLAndAllowedToBeDefault(
"http://www.testsite.com/f.html", false));
RunShortcutsProviderTest(provider_, text, false, expected_urls,
"http://www.testsite.com/d.html", base::string16());
}
TEST_F(ShortcutsProviderTest, DaysAgoMatches) {
base::string16 text(ASCIIToUTF16("ago"));
ExpectedURLs expected_urls;
expected_urls.push_back(ExpectedURLAndAllowedToBeDefault(
"http://www.daysagotest.com/a.html", false));
expected_urls.push_back(ExpectedURLAndAllowedToBeDefault(
"http://www.daysagotest.com/b.html", false));
expected_urls.push_back(ExpectedURLAndAllowedToBeDefault(
"http://www.daysagotest.com/c.html", false));
RunShortcutsProviderTest(provider_, text, false, expected_urls,
"http://www.daysagotest.com/a.html",
base::string16());
}
TEST_F(ShortcutsProviderTest, ClassifyAllMatchesInString) {
ACMatchClassifications matches =
AutocompleteMatch::ClassificationsFromString("0,0");
ClassifyTest classify_test(ASCIIToUTF16("A man, a plan, a canal Panama"),
matches);
ACMatchClassifications spans_a = classify_test.RunTest(ASCIIToUTF16("man"));
// ACMatch spans should be: '--MMM------------------------'
EXPECT_EQ("0,0,2,2,5,0", AutocompleteMatch::ClassificationsToString(spans_a));
ACMatchClassifications spans_b = classify_test.RunTest(ASCIIToUTF16("man p"));
// ACMatch spans should be: '--MMM----M-------------M-----'
EXPECT_EQ("0,0,2,2,5,0,9,2,10,0,23,2,24,0",
AutocompleteMatch::ClassificationsToString(spans_b));
ACMatchClassifications spans_c =
classify_test.RunTest(ASCIIToUTF16("man plan panama"));
// ACMatch spans should be:'--MMM----MMMM----------MMMMMM'
EXPECT_EQ("0,0,2,2,5,0,9,2,13,0,23,2",
AutocompleteMatch::ClassificationsToString(spans_c));
ClassifyTest classify_test2(
ASCIIToUTF16("Yahoo! Sports - Sports News, "
"Scores, Rumors, Fantasy Games, and more"),
matches);
ACMatchClassifications spans_d = classify_test2.RunTest(ASCIIToUTF16("ne"));
// ACMatch spans should match first two letters of the "news".
EXPECT_EQ("0,0,23,2,25,0",
AutocompleteMatch::ClassificationsToString(spans_d));
ACMatchClassifications spans_e =
classify_test2.RunTest(ASCIIToUTF16("news r"));
EXPECT_EQ(
"0,0,10,2,11,0,19,2,20,0,23,2,27,0,32,2,33,0,37,2,38,0,41,2,42,0,"
"66,2,67,0",
AutocompleteMatch::ClassificationsToString(spans_e));
matches = AutocompleteMatch::ClassificationsFromString("0,1");
ClassifyTest classify_test3(ASCIIToUTF16("livescore.goal.com"), matches);
ACMatchClassifications spans_f = classify_test3.RunTest(ASCIIToUTF16("go"));
// ACMatch spans should match first two letters of the "goal".
EXPECT_EQ("0,1,10,3,12,1",
AutocompleteMatch::ClassificationsToString(spans_f));
matches = AutocompleteMatch::ClassificationsFromString("0,0,13,1");
ClassifyTest classify_test4(ASCIIToUTF16("Email login: mail.somecorp.com"),
matches);
ACMatchClassifications spans_g = classify_test4.RunTest(ASCIIToUTF16("ail"));
EXPECT_EQ("0,0,2,2,5,0,13,1,14,3,17,1",
AutocompleteMatch::ClassificationsToString(spans_g));
ACMatchClassifications spans_h =
classify_test4.RunTest(ASCIIToUTF16("lo log"));
EXPECT_EQ("0,0,6,2,9,0,13,1",
AutocompleteMatch::ClassificationsToString(spans_h));
ACMatchClassifications spans_i =
classify_test4.RunTest(ASCIIToUTF16("ail em"));
// 'Email' and 'ail' should be matched.
EXPECT_EQ("0,2,5,0,13,1,14,3,17,1",
AutocompleteMatch::ClassificationsToString(spans_i));
// Some web sites do not have a description. If the string being searched is
// empty, the classifications must also be empty: http://crbug.com/148647
// Extra parens in the next line hack around C++03's "most vexing parse".
class ClassifyTest classify_test5((base::string16()),
ACMatchClassifications());
ACMatchClassifications spans_j = classify_test5.RunTest(ASCIIToUTF16("man"));
ASSERT_EQ(0U, spans_j.size());
// Matches which end at beginning of classification merge properly.
matches = AutocompleteMatch::ClassificationsFromString("0,4,9,0");
ClassifyTest classify_test6(ASCIIToUTF16("html password example"), matches);
// Extra space in the next string avoids having the string be a prefix of the
// text above, which would allow for two different valid classification sets,
// one of which uses two spans (the first of which would mark all of "html
// pass" as a match) and one which uses four (which marks the individual words
// as matches but not the space between them). This way only the latter is
// valid.
ACMatchClassifications spans_k =
classify_test6.RunTest(ASCIIToUTF16("html pass"));
EXPECT_EQ("0,6,4,4,5,6,9,0",
AutocompleteMatch::ClassificationsToString(spans_k));
// Multiple matches with both beginning and end at beginning of
// classifications merge properly.
matches = AutocompleteMatch::ClassificationsFromString("0,1,11,0");
ClassifyTest classify_test7(ASCIIToUTF16("http://a.co is great"), matches);
ACMatchClassifications spans_l =
classify_test7.RunTest(ASCIIToUTF16("ht co"));
EXPECT_EQ("0,3,2,1,9,3,11,0",
AutocompleteMatch::ClassificationsToString(spans_l));
}
TEST_F(ShortcutsProviderTest, CalculateScore) {
ShortcutsDatabase::Shortcut shortcut(
std::string(), ASCIIToUTF16("test"),
ShortcutsDatabase::Shortcut::MatchCore(
ASCIIToUTF16("www.test.com"), GURL("http://www.test.com"),
ASCIIToUTF16("www.test.com"), "0,1,4,3,8,1", ASCIIToUTF16("A test"),
"0,0,2,2", ui::PAGE_TRANSITION_TYPED,
AutocompleteMatchType::HISTORY_URL, base::string16()),
base::Time::Now(), 1);
// Maximal score.
const int max_relevance =
ShortcutsProvider::kShortcutsProviderDefaultMaxRelevance;
const int kMaxScore = CalculateScore("test", shortcut, max_relevance);
// Score decreases as percent of the match is decreased.
int score_three_quarters = CalculateScore("tes", shortcut, max_relevance);
EXPECT_LT(score_three_quarters, kMaxScore);
int score_one_half = CalculateScore("te", shortcut, max_relevance);
EXPECT_LT(score_one_half, score_three_quarters);
int score_one_quarter = CalculateScore("t", shortcut, max_relevance);
EXPECT_LT(score_one_quarter, score_one_half);
// Should decay with time - one week.
shortcut.last_access_time = base::Time::Now() - base::TimeDelta::FromDays(7);
int score_week_old = CalculateScore("test", shortcut, max_relevance);
EXPECT_LT(score_week_old, kMaxScore);
// Should decay more in two weeks.
shortcut.last_access_time = base::Time::Now() - base::TimeDelta::FromDays(14);
int score_two_weeks_old = CalculateScore("test", shortcut, max_relevance);
EXPECT_LT(score_two_weeks_old, score_week_old);
// But not if it was activly clicked on. 2 hits slow decaying power.
shortcut.number_of_hits = 2;
shortcut.last_access_time = base::Time::Now() - base::TimeDelta::FromDays(14);
int score_popular_two_weeks_old =
CalculateScore("test", shortcut, max_relevance);
EXPECT_LT(score_two_weeks_old, score_popular_two_weeks_old);
// But still decayed.
EXPECT_LT(score_popular_two_weeks_old, kMaxScore);
// 3 hits slow decaying power even more.
shortcut.number_of_hits = 3;
shortcut.last_access_time = base::Time::Now() - base::TimeDelta::FromDays(14);
int score_more_popular_two_weeks_old =
CalculateScore("test", shortcut, max_relevance);
EXPECT_LT(score_two_weeks_old, score_more_popular_two_weeks_old);
EXPECT_LT(score_popular_two_weeks_old, score_more_popular_two_weeks_old);
// But still decayed.
EXPECT_LT(score_more_popular_two_weeks_old, kMaxScore);
}
TEST_F(ShortcutsProviderTest, DeleteMatch) {
TestShortcutData shortcuts_to_test_delete[] = {
{"BD85DBA2-8C29-49F9-84AE-48E1E90881F1", "delete", "www.deletetest.com/1",
"http://www.deletetest.com/1", "http://www.deletetest.com/1", "0,2",
"Erase this shortcut!", "0,0", ui::PAGE_TRANSITION_TYPED,
AutocompleteMatchType::HISTORY_URL, "", 1, 1},
{"BD85DBA2-8C29-49F9-84AE-48E1E90881F2", "erase", "www.deletetest.com/1",
"http://www.deletetest.com/1", "http://www.deletetest.com/1", "0,2",
"Erase this shortcut!", "0,0", ui::PAGE_TRANSITION_TYPED,
AutocompleteMatchType::HISTORY_TITLE, "", 1, 1},
{"BD85DBA2-8C29-49F9-84AE-48E1E90881F3", "keep", "www.deletetest.com/1/2",
"http://www.deletetest.com/1/2", "http://www.deletetest.com/1/2", "0,2",
"Keep this shortcut!", "0,0", ui::PAGE_TRANSITION_TYPED,
AutocompleteMatchType::HISTORY_TITLE, "", 1, 1},
{"BD85DBA2-8C29-49F9-84AE-48E1E90881F4", "delete", "www.deletetest.com/2",
"http://www.deletetest.com/2", "http://www.deletetest.com/2", "0,2",
"Erase this shortcut!", "0,0", ui::PAGE_TRANSITION_TYPED,
AutocompleteMatchType::HISTORY_URL, "", 1, 1},
};
scoped_refptr<ShortcutsBackend> backend = client_->GetShortcutsBackend();
size_t original_shortcuts_count = backend->shortcuts_map().size();
PopulateShortcutsBackendWithTestData(backend, shortcuts_to_test_delete,
arraysize(shortcuts_to_test_delete));
EXPECT_EQ(original_shortcuts_count + 4, backend->shortcuts_map().size());
EXPECT_FALSE(backend->shortcuts_map().end() ==
backend->shortcuts_map().find(ASCIIToUTF16("delete")));
EXPECT_FALSE(backend->shortcuts_map().end() ==
backend->shortcuts_map().find(ASCIIToUTF16("erase")));
AutocompleteMatch match(provider_.get(), 1200, true,
AutocompleteMatchType::HISTORY_TITLE);
match.destination_url = GURL(shortcuts_to_test_delete[0].destination_url);
match.contents = ASCIIToUTF16(shortcuts_to_test_delete[0].contents);
match.description = ASCIIToUTF16(shortcuts_to_test_delete[0].description);
provider_->DeleteMatch(match);
// shortcuts_to_test_delete[0] and shortcuts_to_test_delete[1] should be
// deleted, but not shortcuts_to_test_delete[2] or
// shortcuts_to_test_delete[3], which have different URLs.
EXPECT_EQ(original_shortcuts_count + 2, backend->shortcuts_map().size());
EXPECT_FALSE(backend->shortcuts_map().end() ==
backend->shortcuts_map().find(ASCIIToUTF16("delete")));
EXPECT_TRUE(backend->shortcuts_map().end() ==
backend->shortcuts_map().find(ASCIIToUTF16("erase")));
match.destination_url = GURL(shortcuts_to_test_delete[3].destination_url);
match.contents = ASCIIToUTF16(shortcuts_to_test_delete[3].contents);
match.description = ASCIIToUTF16(shortcuts_to_test_delete[3].description);
provider_->DeleteMatch(match);
EXPECT_EQ(original_shortcuts_count + 1, backend->shortcuts_map().size());
EXPECT_TRUE(backend->shortcuts_map().end() ==
backend->shortcuts_map().find(ASCIIToUTF16("delete")));
}
TEST_F(ShortcutsProviderTest, DoesNotProvideOnFocus) {
AutocompleteInput input(ASCIIToUTF16("about:o"), base::string16::npos,
std::string(), GURL(),
metrics::OmniboxEventProto::INVALID_SPEC, false,
false, true, true, true, TestSchemeClassifier());
provider_->Start(input, false);
EXPECT_TRUE(provider_->matches().empty());
}
|