1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
|
// Copyright 2016 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "base/files/file_path.h"
#include "base/memory/ptr_util.h"
#include "base/path_service.h"
#include "components/update_client/updater_state.h"
#include "components/update_client/utils.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "url/gurl.h"
using std::string;
namespace {
base::FilePath MakeTestFilePath(const char* file) {
base::FilePath path;
PathService::Get(base::DIR_SOURCE_ROOT, &path);
return path.AppendASCII("components/test/data/update_client")
.AppendASCII(file);
}
} // namespace
namespace update_client {
TEST(UpdateClientUtils, BuildProtocolRequest_ProdIdVersion) {
// Verifies that |prod_id| and |version| are serialized.
const string request = BuildProtocolRequest("some_prod_id", "1.0", "", "", "",
"", "", "", nullptr);
EXPECT_NE(string::npos, request.find(" version=\"some_prod_id-1.0\" "));
}
TEST(UpdateClientUtils, BuildProtocolRequest_DownloadPreference) {
// Verifies that an empty |download_preference| is not serialized.
const string request_no_dlpref =
BuildProtocolRequest("", "", "", "", "", "", "", "", nullptr);
EXPECT_EQ(string::npos, request_no_dlpref.find(" dlpref="));
// Verifies that |download_preference| is serialized.
const string request_with_dlpref =
BuildProtocolRequest("", "", "", "", "", "some pref", "", "", nullptr);
EXPECT_NE(string::npos, request_with_dlpref.find(" dlpref=\"some pref\""));
}
TEST(UpdateClientUtils, BuildProtocolRequest_UpdaterState) {}
TEST(UpdateClientUtils, VerifyFileHash256) {
EXPECT_TRUE(VerifyFileHash256(
MakeTestFilePath("jebgalgnebhfojomionfpkfelancnnkf.crx"),
std::string(
"6fc4b93fd11134de1300c2c0bb88c12b644a4ec0fd7c9b12cb7cc067667bde87")));
EXPECT_FALSE(VerifyFileHash256(
MakeTestFilePath("jebgalgnebhfojomionfpkfelancnnkf.crx"),
std::string("")));
EXPECT_FALSE(VerifyFileHash256(
MakeTestFilePath("jebgalgnebhfojomionfpkfelancnnkf.crx"),
std::string("abcd")));
EXPECT_FALSE(VerifyFileHash256(
MakeTestFilePath("jebgalgnebhfojomionfpkfelancnnkf.crx"),
std::string(
"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa")));
}
// Tests that the brand matches ^[a-zA-Z]{4}?$
TEST(UpdateClientUtils, IsValidBrand) {
// The valid brand code must be empty or exactly 4 chars long.
EXPECT_TRUE(IsValidBrand(std::string("")));
EXPECT_TRUE(IsValidBrand(std::string("TEST")));
EXPECT_TRUE(IsValidBrand(std::string("test")));
EXPECT_TRUE(IsValidBrand(std::string("TEst")));
EXPECT_FALSE(IsValidBrand(std::string("T"))); // Too short.
EXPECT_FALSE(IsValidBrand(std::string("TE"))); //
EXPECT_FALSE(IsValidBrand(std::string("TES"))); //
EXPECT_FALSE(IsValidBrand(std::string("TESTS"))); // Too long.
EXPECT_FALSE(IsValidBrand(std::string("TES1"))); // Has digit.
EXPECT_FALSE(IsValidBrand(std::string(" TES"))); // Begins with white space.
EXPECT_FALSE(IsValidBrand(std::string("TES "))); // Ends with white space.
EXPECT_FALSE(IsValidBrand(std::string("T ES"))); // Contains white space.
EXPECT_FALSE(IsValidBrand(std::string("<TE"))); // Has <.
EXPECT_FALSE(IsValidBrand(std::string("TE>"))); // Has >.
EXPECT_FALSE(IsValidBrand(std::string("\""))); // Has "
EXPECT_FALSE(IsValidBrand(std::string("\\"))); // Has backslash.
EXPECT_FALSE(IsValidBrand(std::string("\xaa"))); // Has non-ASCII char.
}
// Tests that the name of an InstallerAttribute matches ^[-_=a-zA-Z0-9]{1,256}$
TEST(UpdateClientUtils, IsValidInstallerAttributeName) {
// Test the length boundaries.
EXPECT_FALSE(IsValidInstallerAttribute(
make_pair(std::string(0, 'a'), std::string("value"))));
EXPECT_TRUE(IsValidInstallerAttribute(
make_pair(std::string(1, 'a'), std::string("value"))));
EXPECT_TRUE(IsValidInstallerAttribute(
make_pair(std::string(256, 'a'), std::string("value"))));
EXPECT_FALSE(IsValidInstallerAttribute(
make_pair(std::string(257, 'a'), std::string("value"))));
const char* const valid_names[] = {"A", "Z", "a", "a-b", "A_B",
"z", "0", "9", "-_"};
for (const char* name : valid_names)
EXPECT_TRUE(IsValidInstallerAttribute(
make_pair(std::string(name), std::string("value"))));
const char* const invalid_names[] = {
"", "a=1", " name", "name ", "na me", "<name", "name>",
"\"", "\\", "\xaa", ".", ",", ";", "+"};
for (const char* name : invalid_names)
EXPECT_FALSE(IsValidInstallerAttribute(
make_pair(std::string(name), std::string("value"))));
}
// Tests that the value of an InstallerAttribute matches
// ^[-.,;+_=a-zA-Z0-9]{0,256}$
TEST(UpdateClientUtils, IsValidInstallerAttributeValue) {
// Test the length boundaries.
EXPECT_TRUE(IsValidInstallerAttribute(
make_pair(std::string("name"), std::string(0, 'a'))));
EXPECT_TRUE(IsValidInstallerAttribute(
make_pair(std::string("name"), std::string(256, 'a'))));
EXPECT_FALSE(IsValidInstallerAttribute(
make_pair(std::string("name"), std::string(257, 'a'))));
const char* const valid_values[] = {"", "a=1", "A", "Z", "a",
"z", "0", "9", "-.,;+_="};
for (const char* value : valid_values)
EXPECT_TRUE(IsValidInstallerAttribute(
make_pair(std::string("name"), std::string(value))));
const char* const invalid_values[] = {" ap", "ap ", "a p", "<ap",
"ap>", "\"", "\\", "\xaa"};
for (const char* value : invalid_values)
EXPECT_FALSE(IsValidInstallerAttribute(
make_pair(std::string("name"), std::string(value))));
}
TEST(UpdateClientUtils, RemoveUnsecureUrls) {
const GURL test1[] = {GURL("http://foo"), GURL("https://foo")};
std::vector<GURL> urls(std::begin(test1), std::end(test1));
RemoveUnsecureUrls(&urls);
EXPECT_EQ(1u, urls.size());
EXPECT_EQ(urls[0], GURL("https://foo"));
const GURL test2[] = {GURL("https://foo"), GURL("http://foo")};
urls.assign(std::begin(test2), std::end(test2));
RemoveUnsecureUrls(&urls);
EXPECT_EQ(1u, urls.size());
EXPECT_EQ(urls[0], GURL("https://foo"));
const GURL test3[] = {GURL("https://foo"), GURL("https://bar")};
urls.assign(std::begin(test3), std::end(test3));
RemoveUnsecureUrls(&urls);
EXPECT_EQ(2u, urls.size());
EXPECT_EQ(urls[0], GURL("https://foo"));
EXPECT_EQ(urls[1], GURL("https://bar"));
const GURL test4[] = {GURL("http://foo")};
urls.assign(std::begin(test4), std::end(test4));
RemoveUnsecureUrls(&urls);
EXPECT_EQ(0u, urls.size());
const GURL test5[] = {GURL("http://foo"), GURL("http://bar")};
urls.assign(std::begin(test5), std::end(test5));
RemoveUnsecureUrls(&urls);
EXPECT_EQ(0u, urls.size());
}
TEST(UpdateClientUtils, BuildProtocolRequestUpdaterStateAttributes) {
// When no updater state is provided, then check that the elements and
// attributes related to the updater state are not serialized.
std::string request =
BuildProtocolRequest("", "", "", "", "", "", "", "", nullptr).c_str();
EXPECT_EQ(std::string::npos, request.find(" domainjoined"));
EXPECT_EQ(std::string::npos, request.find("<updater"));
UpdaterState::Attributes attributes;
attributes["domainjoined"] = "1";
attributes["name"] = "Omaha";
attributes["version"] = "1.2.3.4";
attributes["laststarted"] = "1";
attributes["lastchecked"] = "2";
attributes["autoupdatecheckenabled"] = "0";
attributes["updatepolicy"] = "-1";
request = BuildProtocolRequest(
"", "", "", "", "", "", "", "",
base::MakeUnique<UpdaterState::Attributes>(attributes));
EXPECT_NE(std::string::npos, request.find(" domainjoined=\"1\""));
const std::string updater_element =
"<updater autoupdatecheckenabled=\"0\" "
"lastchecked=\"2\" laststarted=\"1\" name=\"Omaha\" "
"updatepolicy=\"-1\" version=\"1.2.3.4\"/>";
#if defined(GOOGLE_CHROME_BUILD)
EXPECT_NE(std::string::npos, request.find(updater_element));
#else
EXPECT_EQ(std::string::npos, request.find(updater_element));
#endif // GOOGLE_CHROME_BUILD
}
} // namespace update_client
|
