1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
|
// Copyright 2016 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "core/layout/compositing/CompositingReasonFinder.h"
#include "core/frame/FrameView.h"
#include "core/layout/LayoutBlock.h"
#include "core/layout/LayoutTestHelper.h"
#include "core/paint/PaintLayer.h"
#include "platform/graphics/GraphicsLayer.h"
#include "platform/scroll/ScrollTypes.h"
#include "platform/testing/RuntimeEnabledFeaturesTestHelpers.h"
namespace blink {
class CompositingReasonFinderTest : public RenderingTest {
public:
CompositingReasonFinderTest()
: RenderingTest(EmptyFrameLoaderClient::create()) {}
private:
void SetUp() override {
RenderingTest::SetUp();
enableCompositing();
}
};
TEST_F(CompositingReasonFinderTest, PromoteOpaqueFixedPosition) {
ScopedCompositeFixedPositionForTest compositeFixedPosition(true);
setBodyInnerHTML(
"<div id='translucent' style='width: 20px; height: 20px; position: "
"fixed; top: 100px; left: 100px;'></div>"
"<div id='opaque' style='width: 20px; height: 20px; position: fixed; "
"top: 100px; left: 200px; background: white;'></div>"
"<div id='opaque-with-shadow' style='width: 20px; height: 20px; "
"position: fixed; top: 100px; left: 300px; background: white; "
"box-shadow: 10px 10px 5px #888888;'></div>"
"<div id='spacer' style='height: 2000px'></div>");
document().view()->updateAllLifecyclePhases();
// The translucent fixed box should not be promoted.
Element* element = document().getElementById("translucent");
PaintLayer* paintLayer =
toLayoutBoxModelObject(element->layoutObject())->layer();
EXPECT_EQ(NotComposited, paintLayer->compositingState());
// The opaque fixed box should be promoted and be opaque so that text will be
// drawn with subpixel anti-aliasing.
element = document().getElementById("opaque");
paintLayer = toLayoutBoxModelObject(element->layoutObject())->layer();
EXPECT_EQ(PaintsIntoOwnBacking, paintLayer->compositingState());
EXPECT_TRUE(paintLayer->graphicsLayerBacking()->contentsOpaque());
// The opaque fixed box with shadow should not be promoted because the layer
// will include the shadow which is not opaque.
element = document().getElementById("opaque-with-shadow");
paintLayer = toLayoutBoxModelObject(element->layoutObject())->layer();
EXPECT_EQ(NotComposited, paintLayer->compositingState());
}
// Tests that a transform on the fixed or an ancestor will prevent promotion
// TODO(flackr): Allow integer transforms as long as all of the ancestor
// transforms are also integer.
TEST_F(CompositingReasonFinderTest, OnlyNonTransformedFixedLayersPromoted) {
ScopedCompositeFixedPositionForTest compositeFixedPosition(true);
setBodyInnerHTML(
"<style>"
"#fixed { position: fixed; height: 200px; width: 200px; background: "
"white; top: 0; }"
"#spacer { height: 3000px; }"
"</style>"
"<div id=\"parent\">"
" <div id=\"fixed\"></div>"
" <div id=\"spacer\"></div>"
"</div>");
document().view()->updateAllLifecyclePhases();
EXPECT_TRUE(RuntimeEnabledFeatures::compositeOpaqueScrollersEnabled());
Element* parent = document().getElementById("parent");
Element* fixed = document().getElementById("fixed");
PaintLayer* paintLayer =
toLayoutBoxModelObject(fixed->layoutObject())->layer();
ASSERT_TRUE(paintLayer);
EXPECT_EQ(PaintsIntoOwnBacking, paintLayer->compositingState());
EXPECT_TRUE(paintLayer->graphicsLayerBacking()->contentsOpaque());
// Change the parent to have a transform.
parent->setAttribute(HTMLNames::styleAttr, "transform: translate(1px, 0);");
document().view()->updateAllLifecyclePhases();
paintLayer = toLayoutBoxModelObject(fixed->layoutObject())->layer();
ASSERT_TRUE(paintLayer);
EXPECT_EQ(NotComposited, paintLayer->compositingState());
// Change the parent to have no transform again.
parent->removeAttribute(HTMLNames::styleAttr);
document().view()->updateAllLifecyclePhases();
paintLayer = toLayoutBoxModelObject(fixed->layoutObject())->layer();
ASSERT_TRUE(paintLayer);
EXPECT_EQ(PaintsIntoOwnBacking, paintLayer->compositingState());
EXPECT_TRUE(paintLayer->graphicsLayerBacking()->contentsOpaque());
// Apply a transform to the fixed directly.
fixed->setAttribute(HTMLNames::styleAttr, "transform: translate(1px, 0);");
document().view()->updateAllLifecyclePhases();
paintLayer = toLayoutBoxModelObject(fixed->layoutObject())->layer();
ASSERT_TRUE(paintLayer);
EXPECT_EQ(NotComposited, paintLayer->compositingState());
}
// Test that opacity applied to the fixed or an ancestor will cause the
// scrolling contents layer to not be promoted.
TEST_F(CompositingReasonFinderTest, OnlyOpaqueFixedLayersPromoted) {
ScopedCompositeFixedPositionForTest compositeFixedPosition(true);
setBodyInnerHTML(
"<style>"
"#fixed { position: fixed; height: 200px; width: 200px; background: "
"white; top: 0}"
"#spacer { height: 3000px; }"
"</style>"
"<div id=\"parent\">"
" <div id=\"fixed\"></div>"
" <div id=\"spacer\"></div>"
"</div>");
document().view()->updateAllLifecyclePhases();
EXPECT_TRUE(RuntimeEnabledFeatures::compositeOpaqueScrollersEnabled());
Element* parent = document().getElementById("parent");
Element* fixed = document().getElementById("fixed");
PaintLayer* paintLayer =
toLayoutBoxModelObject(fixed->layoutObject())->layer();
ASSERT_TRUE(paintLayer);
EXPECT_EQ(PaintsIntoOwnBacking, paintLayer->compositingState());
EXPECT_TRUE(paintLayer->graphicsLayerBacking()->contentsOpaque());
// Change the parent to be partially translucent.
parent->setAttribute(HTMLNames::styleAttr, "opacity: 0.5;");
document().view()->updateAllLifecyclePhases();
paintLayer = toLayoutBoxModelObject(fixed->layoutObject())->layer();
ASSERT_TRUE(paintLayer);
EXPECT_EQ(NotComposited, paintLayer->compositingState());
// Change the parent to be opaque again.
parent->setAttribute(HTMLNames::styleAttr, "opacity: 1;");
document().view()->updateAllLifecyclePhases();
paintLayer = toLayoutBoxModelObject(fixed->layoutObject())->layer();
ASSERT_TRUE(paintLayer);
EXPECT_EQ(PaintsIntoOwnBacking, paintLayer->compositingState());
EXPECT_TRUE(paintLayer->graphicsLayerBacking()->contentsOpaque());
// Make the fixed translucent.
fixed->setAttribute(HTMLNames::styleAttr, "opacity: 0.5");
document().view()->updateAllLifecyclePhases();
paintLayer = toLayoutBoxModelObject(fixed->layoutObject())->layer();
ASSERT_TRUE(paintLayer);
EXPECT_EQ(NotComposited, paintLayer->compositingState());
}
TEST_F(CompositingReasonFinderTest, RequiresCompositingForTransformAnimation) {
RefPtr<ComputedStyle> style = ComputedStyle::create();
style->setSubtreeWillChangeContents(false);
style->setHasCurrentTransformAnimation(false);
style->setIsRunningTransformAnimationOnCompositor(false);
EXPECT_FALSE(
CompositingReasonFinder::requiresCompositingForTransformAnimation(
*style));
style->setHasCurrentTransformAnimation(false);
style->setIsRunningTransformAnimationOnCompositor(true);
EXPECT_FALSE(
CompositingReasonFinder::requiresCompositingForTransformAnimation(
*style));
style->setHasCurrentTransformAnimation(true);
style->setIsRunningTransformAnimationOnCompositor(false);
EXPECT_TRUE(CompositingReasonFinder::requiresCompositingForTransformAnimation(
*style));
style->setHasCurrentTransformAnimation(true);
style->setIsRunningTransformAnimationOnCompositor(true);
EXPECT_TRUE(CompositingReasonFinder::requiresCompositingForTransformAnimation(
*style));
style->setSubtreeWillChangeContents(true);
style->setHasCurrentTransformAnimation(false);
style->setIsRunningTransformAnimationOnCompositor(false);
EXPECT_FALSE(
CompositingReasonFinder::requiresCompositingForTransformAnimation(
*style));
style->setHasCurrentTransformAnimation(false);
style->setIsRunningTransformAnimationOnCompositor(true);
EXPECT_TRUE(CompositingReasonFinder::requiresCompositingForTransformAnimation(
*style));
style->setHasCurrentTransformAnimation(true);
style->setIsRunningTransformAnimationOnCompositor(false);
EXPECT_FALSE(
CompositingReasonFinder::requiresCompositingForTransformAnimation(
*style));
style->setHasCurrentTransformAnimation(true);
style->setIsRunningTransformAnimationOnCompositor(true);
EXPECT_TRUE(CompositingReasonFinder::requiresCompositingForTransformAnimation(
*style));
}
TEST_F(CompositingReasonFinderTest, RequiresCompositingForEffectAnimation) {
RefPtr<ComputedStyle> style = ComputedStyle::create();
style->setSubtreeWillChangeContents(false);
// In the interest of brevity, for each side of subtreeWillChangeContents()
// code path we only check that any one of the effect related animation flags
// being set produces true, rather than every permutation.
style->setHasCurrentOpacityAnimation(false);
style->setHasCurrentFilterAnimation(false);
style->setHasCurrentBackdropFilterAnimation(false);
EXPECT_FALSE(
CompositingReasonFinder::requiresCompositingForEffectAnimation(*style));
style->setHasCurrentOpacityAnimation(true);
style->setHasCurrentFilterAnimation(false);
style->setHasCurrentBackdropFilterAnimation(false);
EXPECT_TRUE(
CompositingReasonFinder::requiresCompositingForEffectAnimation(*style));
style->setHasCurrentOpacityAnimation(false);
style->setHasCurrentFilterAnimation(true);
style->setHasCurrentBackdropFilterAnimation(false);
EXPECT_TRUE(
CompositingReasonFinder::requiresCompositingForEffectAnimation(*style));
style->setHasCurrentOpacityAnimation(false);
style->setHasCurrentFilterAnimation(false);
style->setHasCurrentBackdropFilterAnimation(true);
EXPECT_TRUE(
CompositingReasonFinder::requiresCompositingForEffectAnimation(*style));
// Check the other side of subtreeWillChangeContents.
style->setSubtreeWillChangeContents(true);
style->setHasCurrentOpacityAnimation(false);
style->setHasCurrentFilterAnimation(false);
style->setHasCurrentBackdropFilterAnimation(false);
EXPECT_FALSE(
CompositingReasonFinder::requiresCompositingForEffectAnimation(*style));
style->setIsRunningOpacityAnimationOnCompositor(true);
style->setIsRunningFilterAnimationOnCompositor(false);
style->setIsRunningBackdropFilterAnimationOnCompositor(false);
EXPECT_TRUE(
CompositingReasonFinder::requiresCompositingForEffectAnimation(*style));
style->setIsRunningOpacityAnimationOnCompositor(false);
style->setIsRunningFilterAnimationOnCompositor(true);
style->setIsRunningBackdropFilterAnimationOnCompositor(false);
EXPECT_TRUE(
CompositingReasonFinder::requiresCompositingForEffectAnimation(*style));
style->setIsRunningOpacityAnimationOnCompositor(false);
style->setIsRunningFilterAnimationOnCompositor(false);
style->setIsRunningBackdropFilterAnimationOnCompositor(true);
EXPECT_TRUE(
CompositingReasonFinder::requiresCompositingForEffectAnimation(*style));
}
} // namespace blink
|
