1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359
|
// Copyright 2016 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/ui/startup/startup_browser_creator_impl.h"
#include "base/command_line.h"
#include "chrome/browser/ui/startup/startup_tab_provider.h"
#include "chrome/common/url_constants.h"
#include "testing/gtest/include/gtest/gtest.h"
using Creator = StartupBrowserCreatorImpl;
namespace {
// Bits for FakeStartupTabProvider options.
constexpr uint32_t kOnboardingTabs = 1 << 0;
constexpr uint32_t kDistributionFirstRunTabs = 1 << 1;
constexpr uint32_t kResetTriggerTabs = 1 << 2;
constexpr uint32_t kPinnedTabs = 1 << 3;
constexpr uint32_t kPreferencesTabs = 1 << 4;
constexpr uint32_t kNewTabPageTabs = 1 << 5;
constexpr uint32_t kWelcomeBackTab = 1 << 6;
constexpr uint32_t kPostCrashTab = 1 << 7;
class FakeStartupTabProvider : public StartupTabProvider {
public:
// For each option passed, the corresponding adder below will add a sentinel
// tab and return true. For options not passed, the adder will return false.
explicit FakeStartupTabProvider(uint32_t options) : options_(options) {}
StartupTabs GetOnboardingTabs(Profile* profile) const override {
StartupTabs tabs;
if (options_ & kOnboardingTabs)
tabs.emplace_back(GURL("https://onboarding"), false);
return tabs;
}
StartupTabs GetDistributionFirstRunTabs(
StartupBrowserCreator* browser_creator) const override {
StartupTabs tabs;
if (options_ & kDistributionFirstRunTabs)
tabs.emplace_back(GURL("https://distribution"), false);
return tabs;
}
StartupTabs GetResetTriggerTabs(Profile* profile) const override {
StartupTabs tabs;
if (options_ & kResetTriggerTabs)
tabs.emplace_back(GURL("https://reset-trigger"), false);
return tabs;
}
StartupTabs GetPinnedTabs(const base::CommandLine& command_line_,
Profile* profile) const override {
StartupTabs tabs;
if (options_ & kPinnedTabs)
tabs.emplace_back(GURL("https://pinned"), true);
return tabs;
}
StartupTabs GetPreferencesTabs(const base::CommandLine& command_line_,
Profile* profile) const override {
StartupTabs tabs;
if (options_ & kPreferencesTabs)
tabs.emplace_back(GURL("https://prefs"), false);
return tabs;
}
StartupTabs GetNewTabPageTabs(const base::CommandLine& command_line_,
Profile* profile) const override {
StartupTabs tabs;
if (options_ & kNewTabPageTabs)
tabs.emplace_back(GURL("https://new-tab"), false);
return tabs;
}
StartupTabs GetWelcomeBackTabs(Profile* profile,
StartupBrowserCreator* browser_creator,
bool process_startup) const override {
StartupTabs tabs;
if (process_startup && (options_ & kWelcomeBackTab))
tabs.emplace_back(GURL("https://welcome-back"), false);
return tabs;
}
StartupTabs GetPostCrashTabs(
bool has_incompatible_applications) const override {
StartupTabs tabs;
if (has_incompatible_applications && (options_ & kPostCrashTab))
tabs.emplace_back(GURL("https://incompatible-applications"), false);
return tabs;
}
private:
const uint32_t options_;
};
} // namespace
// "Standard" case: Tabs specified in onboarding, reset trigger, pinned tabs, or
// preferences shouldn't interfere with each other. Nothing specified on the
// command line. Reset trigger always appears first.
TEST(StartupBrowserCreatorImplTest, DetermineStartupTabs) {
FakeStartupTabProvider provider(kOnboardingTabs | kResetTriggerTabs |
kPinnedTabs | kPreferencesTabs |
kNewTabPageTabs);
Creator impl(base::FilePath(),
base::CommandLine(base::CommandLine::NO_PROGRAM),
chrome::startup::IS_FIRST_RUN);
StartupTabs output = impl.DetermineStartupTabs(provider, StartupTabs(), true,
false, false, false, true);
ASSERT_EQ(4U, output.size());
EXPECT_EQ("reset-trigger", output[0].url.host());
EXPECT_EQ("onboarding", output[1].url.host());
EXPECT_EQ("prefs", output[2].url.host());
EXPECT_EQ("pinned", output[3].url.host());
// No extra onboarding content for managed starts.
output = impl.DetermineStartupTabs(provider, StartupTabs(), true, false,
false, false, false);
ASSERT_EQ(3U, output.size());
EXPECT_EQ("reset-trigger", output[0].url.host());
EXPECT_EQ("prefs", output[1].url.host());
EXPECT_EQ("pinned", output[2].url.host());
}
// Only the New Tab Page should appear in Incognito mode, skipping all the usual
// tabs.
TEST(StartupBrowserCreatorImplTest, DetermineStartupTabs_Incognito) {
FakeStartupTabProvider provider(kOnboardingTabs | kDistributionFirstRunTabs |
kResetTriggerTabs | kPinnedTabs |
kPreferencesTabs | kNewTabPageTabs);
Creator impl(base::FilePath(),
base::CommandLine(base::CommandLine::NO_PROGRAM),
chrome::startup::IS_FIRST_RUN);
StartupTabs output = impl.DetermineStartupTabs(provider, StartupTabs(), true,
true, false, false, true);
ASSERT_EQ(1U, output.size());
// Check for the actual NTP URL, rather than the sentinel returned by the
// fake, because the Provider is ignored entirely when short-circuited by
// incognito logic.
EXPECT_EQ(GURL(chrome::kChromeUINewTabURL), output[0].url);
}
// Also only show the New Tab Page after a crash, except if there is a
// problem application.
TEST(StartupBrowserCreatorImplTest, DetermineStartupTabs_Crash) {
FakeStartupTabProvider provider(
kOnboardingTabs | kDistributionFirstRunTabs | kResetTriggerTabs |
kPinnedTabs | kPreferencesTabs | kNewTabPageTabs | kPostCrashTab);
Creator impl(base::FilePath(),
base::CommandLine(base::CommandLine::NO_PROGRAM),
chrome::startup::IS_FIRST_RUN);
// Regular Crash Recovery case:
StartupTabs output = impl.DetermineStartupTabs(provider, StartupTabs(), true,
false, true, false, true);
ASSERT_EQ(1U, output.size());
// Check for the actual NTP URL, rather than the sentinel returned by the
// fake, because the Provider is ignored entirely when short-circuited by
// the post-crash logic.
EXPECT_EQ(GURL(chrome::kChromeUINewTabURL), output[0].url);
// Crash Recovery case with problem applications:
output = impl.DetermineStartupTabs(provider, StartupTabs(), true, false, true,
true, true);
ASSERT_EQ(1U, output.size());
EXPECT_EQ(GURL("https://incompatible-applications"), output[0].url);
}
// If Master Preferences specifies content, this should block all other
// policies. The only exception is command line URLs, tested below.
TEST(StartupBrowserCreatorImplTest, DetermineStartupTabs_MasterPrefs) {
FakeStartupTabProvider provider(kOnboardingTabs | kDistributionFirstRunTabs |
kResetTriggerTabs | kPinnedTabs |
kPreferencesTabs | kNewTabPageTabs);
Creator impl(base::FilePath(),
base::CommandLine(base::CommandLine::NO_PROGRAM),
chrome::startup::IS_FIRST_RUN);
StartupTabs output = impl.DetermineStartupTabs(provider, StartupTabs(), true,
false, false, false, true);
ASSERT_EQ(1U, output.size());
EXPECT_EQ("distribution", output[0].url.host());
}
// URLs specified on the command line should always appear, and should block
// all other tabs except the Reset Trigger tab.
TEST(StartupBrowserCreatorImplTest, DetermineStartupTabs_CommandLine) {
FakeStartupTabProvider provider(kOnboardingTabs | kDistributionFirstRunTabs |
kResetTriggerTabs | kPinnedTabs |
kPreferencesTabs | kNewTabPageTabs);
Creator impl(base::FilePath(),
base::CommandLine(base::CommandLine::NO_PROGRAM),
chrome::startup::IS_FIRST_RUN);
StartupTabs cmd_line_tabs = {StartupTab(GURL("https://cmd-line"), false)};
StartupTabs output = impl.DetermineStartupTabs(provider, cmd_line_tabs, true,
false, false, false, true);
ASSERT_EQ(2U, output.size());
EXPECT_EQ("reset-trigger", output[0].url.host());
EXPECT_EQ("cmd-line", output[1].url.host());
// Also test that both incognito and crash recovery don't interfere with
// command line tabs.
// Incognito
output = impl.DetermineStartupTabs(provider, cmd_line_tabs, true, true, false,
false, true);
ASSERT_EQ(1U, output.size());
EXPECT_EQ("cmd-line", output[0].url.host());
// Crash Recovery
output = impl.DetermineStartupTabs(provider, cmd_line_tabs, true, false, true,
false, true);
ASSERT_EQ(1U, output.size());
EXPECT_EQ("cmd-line", output[0].url.host());
// Crash Recovery with incompatible applications.
output = impl.DetermineStartupTabs(provider, cmd_line_tabs, true, false, true,
true, true);
ASSERT_EQ(1U, output.size());
EXPECT_EQ("cmd-line", output[0].url.host());
}
// New Tab Page should appear alongside pinned tabs and the reset trigger, but
// should be superseded by onboarding tabs and by tabs specified in preferences.
TEST(StartupBrowserCreatorImplTest, DetermineStartupTabs_NewTabPage) {
FakeStartupTabProvider provider_allows_ntp(kPinnedTabs | kResetTriggerTabs |
kNewTabPageTabs);
Creator impl(base::FilePath(),
base::CommandLine(base::CommandLine::NO_PROGRAM),
chrome::startup::IS_FIRST_RUN);
StartupTabs output = impl.DetermineStartupTabs(
provider_allows_ntp, StartupTabs(), true, false, false, false, true);
ASSERT_EQ(3U, output.size());
EXPECT_EQ("reset-trigger", output[0].url.host());
EXPECT_EQ("new-tab", output[1].url.host());
EXPECT_EQ("pinned", output[2].url.host());
}
// The welcome back page should appear before any other session restore tabs.
TEST(StartupBrowserCreatorImplTest, DetermineStartupTabs_WelcomeBackPage) {
FakeStartupTabProvider provider_allows_ntp(kPinnedTabs | kPreferencesTabs |
kWelcomeBackTab);
Creator impl(base::FilePath(),
base::CommandLine(base::CommandLine::NO_PROGRAM),
chrome::startup::IS_FIRST_RUN);
StartupTabs output = impl.DetermineStartupTabs(
provider_allows_ntp, StartupTabs(), true, false, false, false, true);
ASSERT_EQ(3U, output.size());
EXPECT_EQ("welcome-back", output[0].url.host());
EXPECT_EQ("prefs", output[1].url.host());
EXPECT_EQ("pinned", output[2].url.host());
// No welcome back for non-startup opens.
output = impl.DetermineStartupTabs(provider_allows_ntp, StartupTabs(), false,
false, false, false, true);
ASSERT_EQ(2U, output.size());
EXPECT_EQ("prefs", output[0].url.host());
EXPECT_EQ("pinned", output[1].url.host());
// No welcome back for managed starts even if first run.
output = impl.DetermineStartupTabs(provider_allows_ntp, StartupTabs(), true,
false, false, false, false);
ASSERT_EQ(2U, output.size());
EXPECT_EQ("prefs", output[0].url.host());
EXPECT_EQ("pinned", output[1].url.host());
}
TEST(StartupBrowserCreatorImplTest, DetermineBrowserOpenBehavior_Startup) {
SessionStartupPref pref_default(SessionStartupPref::Type::DEFAULT);
SessionStartupPref pref_last(SessionStartupPref::Type::LAST);
SessionStartupPref pref_urls(SessionStartupPref::Type::URLS);
// The most typical case: startup, not recovering from a crash, no switches.
// Test each pref with and without command-line tabs.
Creator::BrowserOpenBehavior output = Creator::DetermineBrowserOpenBehavior(
pref_default, Creator::PROCESS_STARTUP);
EXPECT_EQ(Creator::BrowserOpenBehavior::NEW, output);
output = Creator::DetermineBrowserOpenBehavior(
pref_default, Creator::PROCESS_STARTUP | Creator::HAS_CMD_LINE_TABS);
EXPECT_EQ(Creator::BrowserOpenBehavior::NEW, output);
output = Creator::DetermineBrowserOpenBehavior(pref_urls,
Creator::PROCESS_STARTUP);
EXPECT_EQ(Creator::BrowserOpenBehavior::NEW, output);
output = Creator::DetermineBrowserOpenBehavior(
pref_urls, Creator::PROCESS_STARTUP | Creator::HAS_CMD_LINE_TABS);
EXPECT_EQ(Creator::BrowserOpenBehavior::NEW, output);
output = Creator::DetermineBrowserOpenBehavior(pref_last,
Creator::PROCESS_STARTUP);
EXPECT_EQ(Creator::BrowserOpenBehavior::SYNCHRONOUS_RESTORE, output);
output = Creator::DetermineBrowserOpenBehavior(
pref_last, Creator::PROCESS_STARTUP | Creator::HAS_CMD_LINE_TABS);
EXPECT_EQ(Creator::BrowserOpenBehavior::SYNCHRONOUS_RESTORE, output);
}
TEST(StartupBrowserCreatorImplTest, DetermineBrowserOpenBehavior_CmdLineTabs) {
SessionStartupPref pref_default(SessionStartupPref::Type::DEFAULT);
SessionStartupPref pref_last(SessionStartupPref::Type::LAST);
SessionStartupPref pref_urls(SessionStartupPref::Type::URLS);
// Command line tabs after startup should prompt use of existing window,
// regardless of pref.
Creator::BrowserOpenBehavior output = Creator::DetermineBrowserOpenBehavior(
pref_default, Creator::HAS_CMD_LINE_TABS);
EXPECT_EQ(Creator::BrowserOpenBehavior::USE_EXISTING, output);
output = Creator::DetermineBrowserOpenBehavior(pref_urls,
Creator::HAS_CMD_LINE_TABS);
EXPECT_EQ(Creator::BrowserOpenBehavior::USE_EXISTING, output);
output = Creator::DetermineBrowserOpenBehavior(pref_last,
Creator::HAS_CMD_LINE_TABS);
EXPECT_EQ(Creator::BrowserOpenBehavior::USE_EXISTING, output);
// Exception: this can be overridden by passing a switch.
output = Creator::DetermineBrowserOpenBehavior(
pref_urls, Creator::HAS_NEW_WINDOW_SWITCH | Creator::HAS_CMD_LINE_TABS);
EXPECT_EQ(Creator::BrowserOpenBehavior::NEW, output);
}
TEST(StartupBrowserCreatorImplTest, DetermineBrowserOpenBehavior_PostCrash) {
SessionStartupPref pref_last(SessionStartupPref::Type::LAST);
// Launching after crash should block session restore.
Creator::BrowserOpenBehavior output = Creator::DetermineBrowserOpenBehavior(
pref_last, Creator::PROCESS_STARTUP | Creator::IS_POST_CRASH_LAUNCH);
EXPECT_EQ(Creator::BrowserOpenBehavior::NEW, output);
}
TEST(StartupBrowserCreatorImplTest, DetermineBrowserOpenBehavior_NotStartup) {
SessionStartupPref pref_default(SessionStartupPref::Type::DEFAULT);
SessionStartupPref pref_last(SessionStartupPref::Type::LAST);
SessionStartupPref pref_urls(SessionStartupPref::Type::URLS);
// Launch after startup without command-line tabs should always create a new
// window.
Creator::BrowserOpenBehavior output =
Creator::DetermineBrowserOpenBehavior(pref_default, 0);
EXPECT_EQ(Creator::BrowserOpenBehavior::NEW, output);
output = Creator::DetermineBrowserOpenBehavior(pref_last, 0);
EXPECT_EQ(Creator::BrowserOpenBehavior::NEW, output);
output = Creator::DetermineBrowserOpenBehavior(pref_urls, 0);
EXPECT_EQ(Creator::BrowserOpenBehavior::NEW, output);
}
|