1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456
|
// Copyright 2016 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/ui/app_list/arc/arc_app_dialog.h"
#include "base/command_line.h"
#include "base/macros.h"
#include "base/run_loop.h"
#include "base/strings/utf_string_conversions.h"
#include "chrome/browser/chromeos/arc/arc_session_manager.h"
#include "chrome/browser/chromeos/arc/arc_util.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/app_list/arc/arc_app_list_prefs.h"
#include "chrome/browser/ui/app_list/arc/arc_app_utils.h"
#include "chrome/browser/ui/app_list/arc/arc_usb_host_permission_manager.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_window.h"
#include "chrome/test/base/in_process_browser_test.h"
#include "components/arc/arc_util.h"
#include "components/arc/common/app.mojom.h"
#include "components/arc/test/connection_holder_util.h"
#include "components/arc/test/fake_app_instance.h"
#include "content/public/test/test_utils.h"
namespace arc {
class ArcAppUninstallDialogViewBrowserTest : public InProcessBrowserTest {
public:
ArcAppUninstallDialogViewBrowserTest() {}
~ArcAppUninstallDialogViewBrowserTest() override = default;
void SetUpCommandLine(base::CommandLine* command_line) override {
arc::SetArcAvailableCommandLineForTesting(command_line);
}
void SetUpInProcessBrowserTestFixture() override {
ArcSessionManager::SetUiEnabledForTesting(false);
}
void SetUpOnMainThread() override {
profile_ = browser()->profile();
arc::SetArcPlayStoreEnabledForProfile(profile_, true);
arc_app_list_pref_ = ArcAppListPrefs::Get(profile_);
DCHECK(arc_app_list_pref_);
base::RunLoop run_loop;
arc_app_list_pref_->SetDefaltAppsReadyCallback(run_loop.QuitClosure());
run_loop.Run();
app_instance_.reset(new arc::FakeAppInstance(arc_app_list_pref_));
arc_app_list_pref_->app_connection_holder()->SetInstance(
app_instance_.get());
WaitForInstanceReady(arc_app_list_pref_->app_connection_holder());
// In this setup, we have one app and one shortcut which share one package.
mojom::AppInfo app;
app.name = "Fake App 0";
app.package_name = "fake.package.0";
app.activity = "fake.app.0.activity";
app.sticky = false;
app_instance_->SendRefreshAppList(std::vector<mojom::AppInfo>(1, app));
mojom::ShortcutInfo shortcut;
shortcut.name = "Fake Shortcut 0";
shortcut.package_name = "fake.package.0";
shortcut.intent_uri = "Fake Shortcut uri 0";
app_instance_->SendInstallShortcut(shortcut);
mojom::ArcPackageInfo package;
package.package_name = "fake.package.0";
package.package_version = 0;
package.last_backup_android_id = 0;
package.last_backup_time = 0;
package.sync = false;
app_instance_->SendRefreshPackageList(
std::vector<mojom::ArcPackageInfo>(1, package));
}
void TearDownOnMainThread() override {
arc_app_list_pref_->app_connection_holder()->CloseInstance(
app_instance_.get());
app_instance_.reset();
ArcSessionManager::Get()->Shutdown();
}
// Ensures the ArcAppDialogView is destoryed.
void TearDown() override { ASSERT_FALSE(IsArcAppDialogViewAliveForTest()); }
ArcAppListPrefs* arc_app_list_pref() { return arc_app_list_pref_; }
FakeAppInstance* instance() { return app_instance_.get(); }
Profile* profile() { return profile_; }
private:
ArcAppListPrefs* arc_app_list_pref_ = nullptr;
Profile* profile_ = nullptr;
std::unique_ptr<arc::FakeAppInstance> app_instance_;
DISALLOW_COPY_AND_ASSIGN(ArcAppUninstallDialogViewBrowserTest);
};
class ArcAppPermissionDialogViewBrowserTest
: public ArcAppUninstallDialogViewBrowserTest {
public:
ArcAppPermissionDialogViewBrowserTest() : weak_ptr_factory_(this) {}
// InProcessBrowserTest:
~ArcAppPermissionDialogViewBrowserTest() override = default;
void InstallExtraPackage(int id) {
mojom::AppInfo app;
app.name = base::StringPrintf("Fake App %d", id);
app.package_name = base::StringPrintf("fake.package.%d", id);
app.activity = base::StringPrintf("fake.app.%d.activity", id);
app.sticky = false;
instance()->SendAppAdded(app);
mojom::ArcPackageInfo package;
package.package_name = base::StringPrintf("fake.package.%d", id);
package.package_version = id;
package.last_backup_android_id = id;
package.last_backup_time = 0;
package.sync = false;
instance()->SendPackageAdded(package);
}
void set_accepted(bool accepted) { accepted_ = accepted; }
bool accepted() const { return accepted_; }
base::WeakPtr<ArcAppPermissionDialogViewBrowserTest> weak_ptr() {
return weak_ptr_factory_.GetWeakPtr();
}
void RequestScanDeviceListPermission(
ArcUsbHostPermissionManager* arc_usb_permission_manager,
const std::string& package_name) {
arc_usb_permission_manager->RequestUsbScanDeviceListPermission(
package_name,
base::BindOnce(&ArcAppPermissionDialogViewBrowserTest::set_accepted,
weak_ptr()));
}
void RequestAccessPermission(
ArcUsbHostPermissionManager* arc_usb_permission_manager,
const std::string& package_name) {
arc_usb_permission_manager->RequestUsbAccessPermission(
package_name, guid_, serial_number_, manufacturer_string_,
product_string_, vendor_id_, product_id_,
base::BindOnce(&ArcAppPermissionDialogViewBrowserTest::set_accepted,
weak_ptr()));
}
const std::string& guid() const { return guid_; }
const base::string16& serial_number() const { return serial_number_; }
uint16_t vendor_id() const { return vendor_id_; }
uint16_t product_id() const { return product_id_; }
private:
// boolean used to verify dialog result if |set_accepted| is passed as
// callback. Used in USB basic permission flow test.
bool accepted_ = false;
// USB flow test related.
const std::string guid_ = "TestGuidXXXXXX";
const base::string16 serial_number_ = base::UTF8ToUTF16("TestSerialNumber");
const base::string16 manufacturer_string_ = base::UTF8ToUTF16("Factory");
const base::string16 product_string_ = base::UTF8ToUTF16("Product");
uint16_t vendor_id_ = 123;
uint16_t product_id_ = 456;
base::WeakPtrFactory<ArcAppPermissionDialogViewBrowserTest> weak_ptr_factory_;
DISALLOW_COPY_AND_ASSIGN(ArcAppPermissionDialogViewBrowserTest);
};
// Basic flow of requesting scan device list or access permission.
IN_PROC_BROWSER_TEST_F(ArcAppPermissionDialogViewBrowserTest,
ArcUsbPermissionBasicFlow) {
ArcUsbHostPermissionManager* arc_usb_permission_manager =
ArcUsbHostPermissionManager::GetForBrowserContext(profile());
DCHECK(arc_usb_permission_manager);
// Invalid package name. Requesut is automatically rejected.
const std::string invalid_package = "invalid_package";
RequestScanDeviceListPermission(arc_usb_permission_manager, invalid_package);
EXPECT_FALSE(IsArcAppDialogViewAliveForTest());
EXPECT_FALSE(accepted());
const std::string package_name = "fake.package.0";
// Package sends scan devicelist request.
RequestScanDeviceListPermission(arc_usb_permission_manager, package_name);
// Dialog is shown. Call runs with false.
EXPECT_TRUE(IsArcAppDialogViewAliveForTest());
// Accept the dialog.
EXPECT_TRUE(CloseAppDialogViewAndConfirmForTest(true));
content::RunAllPendingInMessageLoop();
EXPECT_FALSE(IsArcAppDialogViewAliveForTest());
// Result will apply when next time the package tries to request the
// permisson.
EXPECT_FALSE(accepted());
// Package tries to request scan device list permission again.
RequestScanDeviceListPermission(arc_usb_permission_manager, package_name);
EXPECT_FALSE(IsArcAppDialogViewAliveForTest());
EXPECT_TRUE(accepted());
set_accepted(false);
// Package sends device access request.
RequestAccessPermission(arc_usb_permission_manager, package_name);
// Dialog is shown.
EXPECT_TRUE(IsArcAppDialogViewAliveForTest());
// Accept the dialog.
EXPECT_TRUE(CloseAppDialogViewAndConfirmForTest(true));
content::RunAllPendingInMessageLoop();
EXPECT_FALSE(IsArcAppDialogViewAliveForTest());
// Permission applies.
EXPECT_TRUE(accepted());
// Package sends same device access request again.
RequestAccessPermission(arc_usb_permission_manager, package_name);
// Dialog is not shown. Permission still applies.
EXPECT_FALSE(IsArcAppDialogViewAliveForTest());
EXPECT_TRUE(accepted());
}
// Multiple requests are sent at same time and are processed in request order.
// Previously accepted requests will be remembered.
IN_PROC_BROWSER_TEST_F(ArcAppPermissionDialogViewBrowserTest,
ArcUsbPermissionMultipleRequestFlow) {
ArcUsbHostPermissionManager* arc_usb_permission_manager =
ArcUsbHostPermissionManager::GetForBrowserContext(profile());
DCHECK(arc_usb_permission_manager);
InstallExtraPackage(1);
InstallExtraPackage(2);
const std::string package0 = "fake.package.0";
const std::string package1 = "fake.package.1";
const std::string package2 = "fake.package.2";
// Package0 sends device access request.
RequestAccessPermission(arc_usb_permission_manager, package0);
// Package1 sends device access request.
RequestAccessPermission(arc_usb_permission_manager, package1);
// Package0 sends device access request again.
RequestAccessPermission(arc_usb_permission_manager, package0);
// Package2 sends device access request.
RequestAccessPermission(arc_usb_permission_manager, package2);
// Dialog is shown.
EXPECT_TRUE(IsArcAppDialogViewAliveForTest());
const auto& pending_requests =
arc_usb_permission_manager->GetPendingRequestsForTesting();
EXPECT_EQ(3u, pending_requests.size());
EXPECT_EQ(package1, pending_requests[0].package_name());
EXPECT_EQ(package0, pending_requests[1].package_name());
EXPECT_EQ(package2, pending_requests[2].package_name());
// Accept the dialog.
EXPECT_TRUE(CloseAppDialogViewAndConfirmForTest(true));
content::RunAllPendingInMessageLoop();
// Dialog is shown for the next request.
EXPECT_TRUE(IsArcAppDialogViewAliveForTest());
EXPECT_EQ(2u, pending_requests.size());
EXPECT_EQ(package0, pending_requests[0].package_name());
EXPECT_EQ(package2, pending_requests[1].package_name());
// Accept the dialog.
EXPECT_TRUE(CloseAppDialogViewAndConfirmForTest(true));
content::RunAllPendingInMessageLoop();
// The 3rd request is the same to the first request so it's automatically
// confirmed. Dialog is shown for the final request.
EXPECT_TRUE(IsArcAppDialogViewAliveForTest());
EXPECT_EQ(0u, pending_requests.size());
// Reject the dialog.
EXPECT_TRUE(CloseAppDialogViewAndConfirmForTest(false));
content::RunAllPendingInMessageLoop();
// All requests are handled. No dialog is shown.
EXPECT_FALSE(IsArcAppDialogViewAliveForTest());
// Checks permissions.
EXPECT_TRUE(arc_usb_permission_manager->HasUsbAccessPermission(
package0, guid(), serial_number(), vendor_id(), product_id()));
EXPECT_TRUE(arc_usb_permission_manager->HasUsbAccessPermission(
package1, guid(), serial_number(), vendor_id(), product_id()));
EXPECT_FALSE(arc_usb_permission_manager->HasUsbAccessPermission(
package2, guid(), serial_number(), vendor_id(), product_id()));
}
// Package is removed when permission request is queued.
IN_PROC_BROWSER_TEST_F(ArcAppPermissionDialogViewBrowserTest,
ArcUsbPermissionPackageUninstallFlow) {
ArcUsbHostPermissionManager* arc_usb_permission_manager =
ArcUsbHostPermissionManager::GetForBrowserContext(profile());
DCHECK(arc_usb_permission_manager);
InstallExtraPackage(1);
InstallExtraPackage(2);
const std::string package0 = "fake.package.0";
const std::string package1 = "fake.package.1";
const std::string package2 = "fake.package.2";
// Package0 sends device access request.
RequestAccessPermission(arc_usb_permission_manager, package0);
// Package1 sends device access request.
RequestAccessPermission(arc_usb_permission_manager, package1);
// Package2 sends device access request.
RequestAccessPermission(arc_usb_permission_manager, package2);
// Dialog is shown.
EXPECT_TRUE(IsArcAppDialogViewAliveForTest());
const auto& pending_requests =
arc_usb_permission_manager->GetPendingRequestsForTesting();
EXPECT_EQ(2u, pending_requests.size());
EXPECT_EQ(package1, pending_requests[0].package_name());
EXPECT_EQ(package2, pending_requests[1].package_name());
// Uninstall package0 and package2.
UninstallPackage(package0);
UninstallPackage(package2);
EXPECT_EQ(1u, pending_requests.size());
EXPECT_EQ(package1, pending_requests[0].package_name());
// Accept the dialog. But callback is ignored as package0 is uninstalled.
EXPECT_TRUE(CloseAppDialogViewAndConfirmForTest(true));
content::RunAllPendingInMessageLoop();
// Permision dialog for next request is shown.
EXPECT_TRUE(IsArcAppDialogViewAliveForTest());
EXPECT_EQ(0u, pending_requests.size());
EXPECT_TRUE(CloseAppDialogViewAndConfirmForTest(true));
content::RunAllPendingInMessageLoop();
EXPECT_FALSE(arc_usb_permission_manager->HasUsbAccessPermission(
package0, guid(), serial_number(), vendor_id(), product_id()));
EXPECT_TRUE(arc_usb_permission_manager->HasUsbAccessPermission(
package1, guid(), serial_number(), vendor_id(), product_id()));
EXPECT_FALSE(arc_usb_permission_manager->HasUsbAccessPermission(
package2, guid(), serial_number(), vendor_id(), product_id()));
}
// Device is removed when permission request is queued.
IN_PROC_BROWSER_TEST_F(ArcAppPermissionDialogViewBrowserTest,
ArcUsbPermissionDeviceRemoveFlow) {
ArcUsbHostPermissionManager* arc_usb_permission_manager =
ArcUsbHostPermissionManager::GetForBrowserContext(profile());
DCHECK(arc_usb_permission_manager);
InstallExtraPackage(1);
const std::string package0 = "fake.package.0";
const std::string package1 = "fake.package.1";
// Package0 sends device access request.
RequestAccessPermission(arc_usb_permission_manager, package0);
// Package1 sends device access request.
RequestAccessPermission(arc_usb_permission_manager, package1);
// Dialog is shown.
EXPECT_TRUE(IsArcAppDialogViewAliveForTest());
const auto& pending_requests =
arc_usb_permission_manager->GetPendingRequestsForTesting();
EXPECT_EQ(1u, pending_requests.size());
EXPECT_EQ(package1, pending_requests[0].package_name());
// Device is removed.
arc_usb_permission_manager->DeviceRemoved(guid());
EXPECT_EQ(0u, pending_requests.size());
// Accept the dialog. But callback is ignored as device is removed.
EXPECT_TRUE(CloseAppDialogViewAndConfirmForTest(true));
content::RunAllPendingInMessageLoop();
EXPECT_FALSE(arc_usb_permission_manager->HasUsbAccessPermission(
package0, guid(), serial_number(), vendor_id(), product_id()));
EXPECT_FALSE(arc_usb_permission_manager->HasUsbAccessPermission(
package1, guid(), serial_number(), vendor_id(), product_id()));
}
// User confirms/cancels ARC app uninstall. Note that the shortcut is removed
// when the app and the package are uninstalled since the shortcut and the app
// share same package.
IN_PROC_BROWSER_TEST_F(ArcAppUninstallDialogViewBrowserTest,
UserConfirmsUninstall) {
EXPECT_EQ(2u, arc_app_list_pref()->GetAppIds().size());
std::string package_name = "fake.package.0";
std::string app_activity = "fake.app.0.activity";
std::string app_id =
arc_app_list_pref()->GetAppId(package_name, app_activity);
ShowArcAppUninstallDialog(browser()->profile(), app_id);
content::RunAllPendingInMessageLoop();
// Cancelling the dialog won't uninstall any app.
EXPECT_TRUE(CloseAppDialogViewAndConfirmForTest(false));
content::RunAllPendingInMessageLoop();
EXPECT_EQ(2u, arc_app_list_pref()->GetAppIds().size());
ShowArcAppUninstallDialog(browser()->profile(), app_id);
content::RunAllPendingInMessageLoop();
EXPECT_TRUE(IsArcAppDialogViewAliveForTest());
// Accepting the dialog should work now.
EXPECT_TRUE(CloseAppDialogViewAndConfirmForTest(true));
content::RunAllPendingInMessageLoop();
EXPECT_EQ(0u, arc_app_list_pref()->GetAppIds().size());
}
// User confirms/cancels ARC app shortcut removal. Note that the app is not
// uninstalled when the shortcut is removed.
IN_PROC_BROWSER_TEST_F(ArcAppUninstallDialogViewBrowserTest,
UserConfirmsUninstallShortcut) {
EXPECT_EQ(2u, arc_app_list_pref()->GetAppIds().size());
std::string package_name = "fake.package.0";
std::string intent_uri = "Fake Shortcut uri 0";
std::string app_id = arc_app_list_pref()->GetAppId(package_name, intent_uri);
ShowArcAppUninstallDialog(browser()->profile(), app_id);
content::RunAllPendingInMessageLoop();
// Cancelling the dialog won't uninstall any app.
EXPECT_TRUE(CloseAppDialogViewAndConfirmForTest(false));
content::RunAllPendingInMessageLoop();
EXPECT_EQ(2u, arc_app_list_pref()->GetAppIds().size());
ShowArcAppUninstallDialog(browser()->profile(), app_id);
content::RunAllPendingInMessageLoop();
EXPECT_TRUE(IsArcAppDialogViewAliveForTest());
// Accepting the dialog should uninstall the shortcut only.
EXPECT_TRUE(CloseAppDialogViewAndConfirmForTest(true));
content::RunAllPendingInMessageLoop();
EXPECT_EQ(1u, arc_app_list_pref()->GetAppIds().size());
}
} // namespace arc
|