1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461
|
// Copyright 2013 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/ui/views/translate/translate_bubble_view.h"
#include <memory>
#include <utility>
#include "base/strings/utf_string_conversions.h"
#include "base/test/scoped_feature_list.h"
#include "build/build_config.h"
#include "chrome/browser/ui/translate/translate_bubble_model.h"
#include "chrome/browser/ui/translate/translate_bubble_view_state_transition.h"
#include "chrome/grit/generated_resources.h"
#include "chrome/test/views/chrome_views_test_base.h"
#include "components/translate/core/browser/translate_prefs.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "ui/base/l10n/l10n_util.h"
#include "ui/events/event_constants.h"
#include "ui/events/event_utils.h"
#include "ui/events/keycodes/dom/dom_code.h"
#include "ui/gfx/range/range.h"
#include "ui/views/bubble/bubble_frame_view.h"
#include "ui/views/controls/button/checkbox.h"
#include "ui/views/controls/button/menu_button.h"
#include "ui/views/controls/combobox/combobox.h"
#include "ui/views/controls/styled_label.h"
#include "ui/views/widget/widget.h"
namespace {
class MockTranslateBubbleModel : public TranslateBubbleModel {
public:
explicit MockTranslateBubbleModel(TranslateBubbleModel::ViewState view_state)
: view_state_transition_(view_state),
error_type_(translate::TranslateErrors::NONE),
original_language_index_(0),
target_language_index_(1),
never_translate_language_(false),
never_translate_site_(false),
should_always_translate_(false),
always_translate_checked_(false),
set_always_translate_called_count_(0),
translate_called_(false),
revert_translation_called_(false),
translation_declined_(false),
original_language_index_on_translation_(-1),
target_language_index_on_translation_(-1),
can_blacklist_site_(true) {}
TranslateBubbleModel::ViewState GetViewState() const override {
return view_state_transition_.view_state();
}
void SetViewState(TranslateBubbleModel::ViewState view_state) override {
view_state_transition_.SetViewState(view_state);
}
void ShowError(translate::TranslateErrors::Type error_type) override {
error_type_ = error_type;
}
void GoBackFromAdvanced() override {
view_state_transition_.GoBackFromAdvanced();
}
int GetNumberOfLanguages() const override { return 1000; }
base::string16 GetLanguageNameAt(int index) const override {
return base::ASCIIToUTF16("English");
}
int GetOriginalLanguageIndex() const override {
return original_language_index_;
}
void UpdateOriginalLanguageIndex(int index) override {
original_language_index_ = index;
}
int GetTargetLanguageIndex() const override { return target_language_index_; }
void UpdateTargetLanguageIndex(int index) override {
target_language_index_ = index;
}
void DeclineTranslation() override { translation_declined_ = true; }
void SetNeverTranslateLanguage(bool value) override {
never_translate_language_ = value;
}
void SetNeverTranslateSite(bool value) override {
never_translate_site_ = value;
}
bool ShouldAlwaysTranslateBeCheckedByDefault() const override {
return always_translate_checked_;
}
bool ShouldAlwaysTranslate() const override {
return should_always_translate_;
}
bool ShouldShowAlwaysTranslateShortcut() const override { return false; }
void SetAlwaysTranslate(bool value) override {
should_always_translate_ = value;
set_always_translate_called_count_++;
}
void Translate() override {
translate_called_ = true;
original_language_index_on_translation_ = original_language_index_;
target_language_index_on_translation_ = target_language_index_;
}
void RevertTranslation() override { revert_translation_called_ = true; }
void OnBubbleClosing() override {}
bool IsPageTranslatedInCurrentLanguages() const override {
return original_language_index_on_translation_ ==
original_language_index_ &&
target_language_index_on_translation_ == target_language_index_;
}
bool CanBlacklistSite() override { return can_blacklist_site_; }
void SetCanBlacklistSite(bool value) { can_blacklist_site_ = value; }
TranslateBubbleViewStateTransition view_state_transition_;
translate::TranslateErrors::Type error_type_;
int original_language_index_;
int target_language_index_;
bool never_translate_language_;
bool never_translate_site_;
bool should_always_translate_;
bool always_translate_checked_;
int set_always_translate_called_count_;
bool translate_called_;
bool revert_translation_called_;
bool translation_declined_;
int original_language_index_on_translation_;
int target_language_index_on_translation_;
bool can_blacklist_site_;
};
} // namespace
class TranslateBubbleViewTest : public ChromeViewsTestBase {
public:
TranslateBubbleViewTest() {}
protected:
void SetUp() override {
ChromeViewsTestBase::SetUp();
// The bubble needs the parent as an anchor.
views::Widget::InitParams params =
CreateParams(views::Widget::InitParams::TYPE_WINDOW);
params.ownership = views::Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET;
anchor_widget_.reset(new views::Widget());
anchor_widget_->Init(params);
anchor_widget_->Show();
mock_model_ = new MockTranslateBubbleModel(
TranslateBubbleModel::VIEW_STATE_BEFORE_TRANSLATE);
}
void CreateAndShowBubble() {
std::unique_ptr<TranslateBubbleModel> model(mock_model_);
bubble_ = new TranslateBubbleView(anchor_widget_->GetContentsView(),
gfx::Point(), std::move(model),
translate::TranslateErrors::NONE, NULL);
views::BubbleDialogDelegateView::CreateBubble(bubble_)->Show();
}
void PressButton(TranslateBubbleView::ButtonID id) {
views::LabelButton button(nullptr, base::ASCIIToUTF16("hello"));
button.set_id(id);
bubble_->ButtonPressed(&button,
ui::KeyEvent(ui::ET_KEY_PRESSED, ui::VKEY_RETURN,
ui::DomCode::ENTER, ui::EF_NONE));
}
void TearDown() override {
bubble_->GetWidget()->CloseNow();
anchor_widget_.reset();
ChromeViewsTestBase::TearDown();
}
bool denial_button_clicked() { return mock_model_->translation_declined_; }
void TriggerOptionsMenu() {
bubble_->ButtonPressed(bubble_->before_translate_options_button_,
ui::KeyEvent(ui::ET_KEY_PRESSED, ui::VKEY_RETURN,
ui::DomCode::ENTER, ui::EF_NONE));
}
ui::SimpleMenuModel* options_menu_model() {
return bubble_->options_menu_model_.get();
}
std::unique_ptr<views::Widget> anchor_widget_;
MockTranslateBubbleModel* mock_model_;
TranslateBubbleView* bubble_;
base::test::ScopedFeatureList scoped_feature_list_;
};
TEST_F(TranslateBubbleViewTest, TranslateButton) {
CreateAndShowBubble();
EXPECT_FALSE(mock_model_->translate_called_);
// Press the "Translate" button.
PressButton(TranslateBubbleView::BUTTON_ID_TRANSLATE);
EXPECT_TRUE(mock_model_->translate_called_);
}
TEST_F(TranslateBubbleViewTest, OptionsMenuNeverTranslateLanguage) {
CreateAndShowBubble();
EXPECT_FALSE(bubble_->GetWidget()->IsClosed());
EXPECT_FALSE(mock_model_->never_translate_language_);
EXPECT_FALSE(denial_button_clicked());
TriggerOptionsMenu();
const int index = bubble_->options_menu_model_->GetIndexOfCommandId(
TranslateBubbleView::NEVER_TRANSLATE_LANGUAGE);
bubble_->options_menu_model_->ActivatedAt(index);
EXPECT_TRUE(denial_button_clicked());
EXPECT_TRUE(mock_model_->never_translate_language_);
EXPECT_TRUE(bubble_->GetWidget()->IsClosed());
}
TEST_F(TranslateBubbleViewTest, OptionsMenuNeverTranslateSite) {
// NEVER_TRANSLATE_SITE should only show up for sites that can be blacklisted.
mock_model_->SetCanBlacklistSite(true);
CreateAndShowBubble();
EXPECT_FALSE(mock_model_->never_translate_site_);
EXPECT_FALSE(denial_button_clicked());
EXPECT_FALSE(bubble_->GetWidget()->IsClosed());
TriggerOptionsMenu();
const int index = bubble_->options_menu_model_->GetIndexOfCommandId(
TranslateBubbleView::NEVER_TRANSLATE_SITE);
bubble_->options_menu_model_->ActivatedAt(index);
EXPECT_TRUE(denial_button_clicked());
EXPECT_TRUE(mock_model_->never_translate_site_);
EXPECT_TRUE(bubble_->GetWidget()->IsClosed());
}
TEST_F(TranslateBubbleViewTest, ShowOriginalButton) {
CreateAndShowBubble();
bubble_->SwitchView(TranslateBubbleModel::VIEW_STATE_AFTER_TRANSLATE);
// Click the "Show original" button to revert translation.
EXPECT_FALSE(mock_model_->revert_translation_called_);
PressButton(TranslateBubbleView::BUTTON_ID_SHOW_ORIGINAL);
EXPECT_TRUE(mock_model_->revert_translation_called_);
}
TEST_F(TranslateBubbleViewTest, TryAgainButton) {
CreateAndShowBubble();
bubble_->SwitchToErrorView(translate::TranslateErrors::NETWORK);
EXPECT_EQ(translate::TranslateErrors::NETWORK, mock_model_->error_type_);
// Click the "Try again" button to translate.
EXPECT_FALSE(mock_model_->translate_called_);
PressButton(TranslateBubbleView::BUTTON_ID_TRY_AGAIN);
EXPECT_TRUE(mock_model_->translate_called_);
}
TEST_F(TranslateBubbleViewTest, AlwaysTranslateCheckboxAndCancelButton) {
CreateAndShowBubble();
bubble_->SwitchView(TranslateBubbleModel::VIEW_STATE_ADVANCED);
// Click the "Always Translate" checkbox. Changing the state of this checkbox
// should NOT affect the model after pressing the cancel button.
// Check the initial state.
EXPECT_FALSE(mock_model_->should_always_translate_);
EXPECT_EQ(0, mock_model_->set_always_translate_called_count_);
EXPECT_FALSE(bubble_->advanced_always_translate_checkbox_->checked());
// Click the checkbox. The state is not saved yet.
bubble_->advanced_always_translate_checkbox_->SetChecked(true);
PressButton(TranslateBubbleView::BUTTON_ID_ALWAYS_TRANSLATE);
EXPECT_FALSE(mock_model_->should_always_translate_);
EXPECT_EQ(0, mock_model_->set_always_translate_called_count_);
// Click the cancel button. The state is not saved.
PressButton(TranslateBubbleView::BUTTON_ID_CANCEL);
EXPECT_FALSE(mock_model_->should_always_translate_);
EXPECT_EQ(0, mock_model_->set_always_translate_called_count_);
}
TEST_F(TranslateBubbleViewTest, AlwaysTranslateCheckboxAndDoneButton) {
CreateAndShowBubble();
bubble_->SwitchView(TranslateBubbleModel::VIEW_STATE_ADVANCED);
// Click the "Always Translate" checkbox. Changing the state of this checkbox
// should affect the model after pressing the done button.
// Check the initial state.
EXPECT_FALSE(mock_model_->should_always_translate_);
EXPECT_EQ(0, mock_model_->set_always_translate_called_count_);
EXPECT_FALSE(bubble_->advanced_always_translate_checkbox_->checked());
// Click the checkbox. The state is not saved yet.
bubble_->advanced_always_translate_checkbox_->SetChecked(true);
PressButton(TranslateBubbleView::BUTTON_ID_ALWAYS_TRANSLATE);
EXPECT_FALSE(mock_model_->should_always_translate_);
EXPECT_EQ(0, mock_model_->set_always_translate_called_count_);
// Click the done button. The state is saved.
PressButton(TranslateBubbleView::BUTTON_ID_DONE);
EXPECT_TRUE(mock_model_->should_always_translate_);
EXPECT_EQ(1, mock_model_->set_always_translate_called_count_);
}
TEST_F(TranslateBubbleViewTest, DoneButton) {
CreateAndShowBubble();
bubble_->SwitchView(TranslateBubbleModel::VIEW_STATE_ADVANCED);
// Click the "Done" button to translate. The selected languages by the user
// are applied.
EXPECT_FALSE(mock_model_->translate_called_);
bubble_->source_language_combobox_->SetSelectedIndex(10);
bubble_->HandleComboboxPerformAction(
TranslateBubbleView::COMBOBOX_ID_SOURCE_LANGUAGE);
bubble_->target_language_combobox_->SetSelectedIndex(20);
bubble_->HandleComboboxPerformAction(
TranslateBubbleView::COMBOBOX_ID_TARGET_LANGUAGE);
PressButton(TranslateBubbleView::BUTTON_ID_DONE);
EXPECT_TRUE(mock_model_->translate_called_);
EXPECT_EQ(10, mock_model_->original_language_index_);
EXPECT_EQ(20, mock_model_->target_language_index_);
}
TEST_F(TranslateBubbleViewTest, DoneButtonWithoutTranslating) {
CreateAndShowBubble();
EXPECT_EQ(TranslateBubbleModel::VIEW_STATE_BEFORE_TRANSLATE,
bubble_->GetViewState());
// Translate the page once.
mock_model_->Translate();
EXPECT_TRUE(mock_model_->translate_called_);
// Go back to the initial view.
EXPECT_EQ(TranslateBubbleModel::VIEW_STATE_BEFORE_TRANSLATE,
bubble_->GetViewState());
mock_model_->translate_called_ = false;
EXPECT_EQ(TranslateBubbleModel::VIEW_STATE_BEFORE_TRANSLATE,
bubble_->GetViewState());
bubble_->SwitchView(TranslateBubbleModel::VIEW_STATE_ADVANCED);
// Click the "Done" button with the current language pair. This time,
// translation is not performed and the view state will be back to the
// previous view.
PressButton(TranslateBubbleView::BUTTON_ID_DONE);
EXPECT_FALSE(mock_model_->translate_called_);
EXPECT_EQ(TranslateBubbleModel::VIEW_STATE_BEFORE_TRANSLATE,
bubble_->GetViewState());
}
TEST_F(TranslateBubbleViewTest, CancelButtonReturningBeforeTranslate) {
CreateAndShowBubble();
bubble_->SwitchView(TranslateBubbleModel::VIEW_STATE_BEFORE_TRANSLATE);
bubble_->SwitchView(TranslateBubbleModel::VIEW_STATE_ADVANCED);
// Click the "Cancel" button to go back.
EXPECT_EQ(TranslateBubbleModel::VIEW_STATE_ADVANCED, bubble_->GetViewState());
PressButton(TranslateBubbleView::BUTTON_ID_CANCEL);
EXPECT_EQ(TranslateBubbleModel::VIEW_STATE_BEFORE_TRANSLATE,
bubble_->GetViewState());
}
TEST_F(TranslateBubbleViewTest, CancelButtonReturningAfterTranslate) {
CreateAndShowBubble();
bubble_->SwitchView(TranslateBubbleModel::VIEW_STATE_AFTER_TRANSLATE);
bubble_->SwitchView(TranslateBubbleModel::VIEW_STATE_ADVANCED);
// Click the "Cancel" button to go back.
EXPECT_EQ(TranslateBubbleModel::VIEW_STATE_ADVANCED, bubble_->GetViewState());
PressButton(TranslateBubbleView::BUTTON_ID_CANCEL);
EXPECT_EQ(TranslateBubbleModel::VIEW_STATE_AFTER_TRANSLATE,
bubble_->GetViewState());
}
TEST_F(TranslateBubbleViewTest, CancelButtonReturningError) {
CreateAndShowBubble();
bubble_->SwitchView(TranslateBubbleModel::VIEW_STATE_ERROR);
bubble_->SwitchView(TranslateBubbleModel::VIEW_STATE_ADVANCED);
// Click the "Cancel" button to go back.
EXPECT_EQ(TranslateBubbleModel::VIEW_STATE_ADVANCED, bubble_->GetViewState());
PressButton(TranslateBubbleView::BUTTON_ID_CANCEL);
EXPECT_EQ(TranslateBubbleModel::VIEW_STATE_ERROR, bubble_->GetViewState());
}
TEST_F(TranslateBubbleViewTest, OptionsMenuRespectsBlacklistSite) {
mock_model_->SetCanBlacklistSite(false);
CreateAndShowBubble();
TriggerOptionsMenu();
// NEVER_TRANSLATE_SITE shouldn't show up for sites that can't be blacklisted.
EXPECT_EQ(-1, bubble_->options_menu_model_->GetIndexOfCommandId(
TranslateBubbleView::NEVER_TRANSLATE_SITE));
// Verify that the menu is populated so previous check makes sense.
EXPECT_GE(bubble_->options_menu_model_->GetIndexOfCommandId(
TranslateBubbleView::NEVER_TRANSLATE_LANGUAGE),
0);
}
TEST_F(TranslateBubbleViewTest, AlwaysTranslateLanguageMenuItem) {
CreateAndShowBubble();
TriggerOptionsMenu();
const int index = bubble_->options_menu_model_->GetIndexOfCommandId(
TranslateBubbleView::ALWAYS_TRANSLATE_LANGUAGE);
EXPECT_FALSE(mock_model_->ShouldAlwaysTranslate());
EXPECT_FALSE(bubble_->options_menu_model_->IsItemCheckedAt(index));
EXPECT_FALSE(mock_model_->translate_called_);
bubble_->options_menu_model_->ActivatedAt(index);
EXPECT_TRUE(mock_model_->ShouldAlwaysTranslate());
EXPECT_TRUE(mock_model_->translate_called_);
// Go back to untranslated page, since the *language* should still always
// be translated (and this "untranslate" is temporary) the option should now
// be checked and it should be possible to disable it from the menu.
PressButton(TranslateBubbleView::BUTTON_ID_SHOW_ORIGINAL);
EXPECT_TRUE(mock_model_->revert_translation_called_);
TriggerOptionsMenu();
EXPECT_TRUE(mock_model_->ShouldAlwaysTranslate());
EXPECT_TRUE(bubble_->options_menu_model_->IsItemCheckedAt(index));
// Translate should not be called when disabling always-translate. The page is
// not currently in a translated state and nothing needs to be reverted.
// translate_called_ is set back to false just to make sure it's not being
// called again.
mock_model_->translate_called_ = false;
bubble_->options_menu_model_->ActivatedAt(index);
EXPECT_FALSE(mock_model_->ShouldAlwaysTranslate());
EXPECT_FALSE(mock_model_->translate_called_);
TriggerOptionsMenu();
EXPECT_FALSE(bubble_->options_menu_model_->IsItemCheckedAt(index));
}
|