1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331
|
// Copyright 2015 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "components/ntp_snippets/remote/remote_suggestion.h"
#include <limits>
#include "base/memory/ptr_util.h"
#include "base/strings/string_number_conversions.h"
#include "base/strings/stringprintf.h"
#include "base/strings/utf_string_conversions.h"
#include "base/values.h"
#include "components/ntp_snippets/category.h"
#include "components/ntp_snippets/remote/proto/ntp_snippets.pb.h"
#include "components/ntp_snippets/time_serialization.h"
namespace {
// dict.Get() specialization for base::Time values
bool GetTimeValue(const base::DictionaryValue& dict,
const std::string& key,
base::Time* time) {
std::string time_value;
return dict.GetString(key, &time_value) &&
base::Time::FromString(time_value.c_str(), time);
}
// dict.Get() specialization for GURL values
bool GetURLValue(const base::DictionaryValue& dict,
const std::string& key,
GURL* url) {
std::string spec;
if (!dict.GetString(key, &spec)) {
return false;
}
*url = GURL(spec);
return url->is_valid();
}
} // namespace
namespace ntp_snippets {
const int kArticlesRemoteId = 1;
static_assert(
static_cast<int>(KnownCategories::ARTICLES) -
static_cast<int>(KnownCategories::REMOTE_CATEGORIES_OFFSET) ==
kArticlesRemoteId,
"kArticlesRemoteId has a wrong value?!");
RemoteSuggestion::RemoteSuggestion(const std::vector<std::string>& ids,
int remote_category_id)
: ids_(ids),
score_(0),
is_dismissed_(false),
remote_category_id_(remote_category_id),
rank_(std::numeric_limits<int>::max()),
should_notify_(false),
content_type_(ContentType::UNKNOWN) {}
RemoteSuggestion::~RemoteSuggestion() = default;
// static
std::unique_ptr<RemoteSuggestion>
RemoteSuggestion::CreateFromContentSuggestionsDictionary(
const base::DictionaryValue& dict,
int remote_category_id,
const base::Time& fetch_date) {
const base::ListValue* ids;
if (!dict.GetList("ids", &ids)) {
return nullptr;
}
std::vector<std::string> parsed_ids;
for (const auto& value : *ids) {
std::string id;
if (!value.GetAsString(&id)) {
return nullptr;
}
parsed_ids.push_back(id);
}
if (parsed_ids.empty()) {
return nullptr;
}
auto snippet = MakeUnique(parsed_ids, remote_category_id);
snippet->fetch_date_ = fetch_date;
if (!(dict.GetString("title", &snippet->title_) &&
dict.GetString("snippet", &snippet->snippet_) &&
GetTimeValue(dict, "creationTime", &snippet->publish_date_) &&
GetTimeValue(dict, "expirationTime", &snippet->expiry_date_) &&
GetURLValue(dict, "imageUrl", &snippet->salient_image_url_) &&
dict.GetString("attribution", &snippet->publisher_name_) &&
GetURLValue(dict, "fullPageUrl", &snippet->url_))) {
return nullptr;
}
GetURLValue(dict, "ampUrl", &snippet->amp_url_); // May fail; OK.
// TODO(sfiera): also favicon URL.
const base::Value* image_dominant_color_value =
dict.FindKey("imageDominantColor");
if (image_dominant_color_value) {
// The field is defined as fixed32 in the proto (effectively 32 bits
// unsigned int), however, JSON does not support unsigned types. As a result
// the value is parsed as int if it fits and as double otherwise. Double can
// hold 32 bits precisely.
uint32_t image_dominant_color;
if (image_dominant_color_value->is_int()) {
image_dominant_color = image_dominant_color_value->GetInt();
} else if (image_dominant_color_value->is_double()) {
image_dominant_color =
static_cast<uint32_t>(image_dominant_color_value->GetDouble());
}
snippet->image_dominant_color_ = image_dominant_color;
}
double score;
if (dict.GetDouble("score", &score)) {
snippet->score_ = score;
}
const base::DictionaryValue* notification_info = nullptr;
if (dict.GetDictionary("notificationInfo", ¬ification_info)) {
if (notification_info->GetBoolean("shouldNotify",
&snippet->should_notify_) &&
snippet->should_notify_) {
if (!GetTimeValue(*notification_info, "deadline",
&snippet->notification_deadline_)) {
snippet->notification_deadline_ = base::Time::Max();
}
}
}
// In the JSON dictionary contentType is an optional field. The field
// content_type_ of the class |RemoteSuggestion| is by default initialized to
// ContentType::UNKNOWN.
std::string content_type;
if (dict.GetString("contentType", &content_type)) {
if (content_type == "VIDEO") {
snippet->content_type_ = ContentType::VIDEO;
} else {
// The supported values are: VIDEO, UNKNOWN. Therefore if the field is
// present the value has to be "UNKNOWN" here.
DCHECK_EQ(content_type, "UNKNOWN");
snippet->content_type_ = ContentType::UNKNOWN;
}
}
return snippet;
}
// static
std::unique_ptr<RemoteSuggestion>
RemoteSuggestion::CreateFromContextualSuggestionsDictionary(
const base::DictionaryValue& dict) {
std::string id;
if (!dict.GetString("url", &id) || id.empty()) {
return nullptr;
}
// TODO(gaschler): Remove the unused kArticlesRemoteId argument when moving
// away from RemoteSuggestion.
auto remote_suggestion = MakeUnique({id}, kArticlesRemoteId);
GetURLValue(dict, "url", &remote_suggestion->url_);
if (!dict.GetString("title", &remote_suggestion->title_)) {
dict.GetString("source", &remote_suggestion->title_);
}
dict.GetString("snippet", &remote_suggestion->snippet_);
GetTimeValue(dict, "creationTime", &remote_suggestion->publish_date_);
GetTimeValue(dict, "expirationTime", &remote_suggestion->expiry_date_);
GetURLValue(dict, "imageUrl", &remote_suggestion->salient_image_url_);
if (!dict.GetString("attribution", &remote_suggestion->publisher_name_)) {
dict.GetString("source", &remote_suggestion->publisher_name_);
}
return remote_suggestion;
}
// static
std::unique_ptr<RemoteSuggestion> RemoteSuggestion::CreateFromProto(
const SnippetProto& proto) {
// Need at least the id.
if (proto.ids_size() == 0 || proto.ids(0).empty()) {
return nullptr;
}
int remote_category_id = proto.has_remote_category_id()
? proto.remote_category_id()
: kArticlesRemoteId;
std::vector<std::string> ids(proto.ids().begin(), proto.ids().end());
auto snippet = MakeUnique(ids, remote_category_id);
snippet->title_ = proto.title();
snippet->snippet_ = proto.snippet();
snippet->salient_image_url_ = GURL(proto.salient_image_url());
if (proto.has_image_dominant_color()) {
snippet->image_dominant_color_ = proto.image_dominant_color();
}
snippet->publish_date_ = DeserializeTime(proto.publish_date());
snippet->expiry_date_ = DeserializeTime(proto.expiry_date());
snippet->score_ = proto.score();
snippet->is_dismissed_ = proto.dismissed();
if (!proto.has_source()) {
DLOG(WARNING) << "No source found for article " << snippet->id();
return nullptr;
}
GURL url(proto.source().url());
if (!url.is_valid()) {
// We must at least have a valid source URL.
DLOG(WARNING) << "Invalid article url " << proto.source().url();
return nullptr;
}
GURL amp_url;
if (proto.source().has_amp_url()) {
amp_url = GURL(proto.source().amp_url());
DLOG_IF(WARNING, !amp_url.is_valid())
<< "Invalid AMP URL " << proto.source().amp_url();
}
snippet->url_ = url;
snippet->publisher_name_ = proto.source().publisher_name();
snippet->amp_url_ = amp_url;
if (proto.has_fetch_date()) {
snippet->fetch_date_ = DeserializeTime(proto.fetch_date());
}
if (proto.content_type() == SnippetProto_ContentType_VIDEO) {
snippet->content_type_ = ContentType::VIDEO;
}
snippet->rank_ =
proto.has_rank() ? proto.rank() : std::numeric_limits<int>::max();
return snippet;
}
SnippetProto RemoteSuggestion::ToProto() const {
SnippetProto result;
for (const std::string& id : ids_) {
result.add_ids(id);
}
if (!title_.empty()) {
result.set_title(title_);
}
if (!snippet_.empty()) {
result.set_snippet(snippet_);
}
if (salient_image_url_.is_valid()) {
result.set_salient_image_url(salient_image_url_.spec());
}
if (image_dominant_color_.has_value()) {
result.set_image_dominant_color(*image_dominant_color_);
}
if (!publish_date_.is_null()) {
result.set_publish_date(SerializeTime(publish_date_));
}
if (!expiry_date_.is_null()) {
result.set_expiry_date(SerializeTime(expiry_date_));
}
result.set_score(score_);
result.set_dismissed(is_dismissed_);
result.set_remote_category_id(remote_category_id_);
SnippetSourceProto* source_proto = result.mutable_source();
source_proto->set_url(url_.spec());
if (!publisher_name_.empty()) {
source_proto->set_publisher_name(publisher_name_);
}
if (amp_url_.is_valid()) {
source_proto->set_amp_url(amp_url_.spec());
}
if (!fetch_date_.is_null()) {
result.set_fetch_date(SerializeTime(fetch_date_));
}
if (content_type_ == ContentType::VIDEO) {
result.set_content_type(SnippetProto_ContentType_VIDEO);
}
result.set_rank(rank_);
return result;
}
ContentSuggestion RemoteSuggestion::ToContentSuggestion(
Category category) const {
GURL url = url_;
bool use_amp = !amp_url_.is_empty();
if (use_amp) {
url = amp_url_;
}
ContentSuggestion suggestion(category, id(), url);
// Set url for fetching favicons if it differs from the main url (domains of
// AMP URLs sometimes failed to provide favicons).
if (use_amp) {
suggestion.set_url_with_favicon(url_);
}
suggestion.set_title(base::UTF8ToUTF16(title_));
suggestion.set_snippet_text(base::UTF8ToUTF16(snippet_));
suggestion.set_publish_date(publish_date_);
suggestion.set_publisher_name(base::UTF8ToUTF16(publisher_name_));
suggestion.set_score(score_);
suggestion.set_salient_image_url(salient_image_url_);
if (should_notify_) {
NotificationExtra extra;
extra.deadline = notification_deadline_;
suggestion.set_notification_extra(
std::make_unique<NotificationExtra>(extra));
}
suggestion.set_fetch_date(fetch_date_);
if (content_type_ == ContentType::VIDEO) {
suggestion.set_is_video_suggestion(true);
}
suggestion.set_optional_image_dominant_color(image_dominant_color_);
return suggestion;
}
// static
std::unique_ptr<RemoteSuggestion> RemoteSuggestion::MakeUnique(
const std::vector<std::string>& ids,
int remote_category_id) {
return base::WrapUnique(new RemoteSuggestion(ids, remote_category_id));
}
} // namespace ntp_snippets
|