1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405
|
// Copyright 2017 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "components/ntp_snippets/remote/remote_suggestions_fetcher_impl.h"
#include "base/metrics/histogram_functions.h"
#include "base/metrics/histogram_macros.h"
#include "base/strings/stringprintf.h"
#include "base/strings/utf_string_conversions.h"
#include "base/time/default_clock.h"
#include "base/time/time.h"
#include "base/values.h"
#include "components/language/core/browser/url_language_histogram.h"
#include "components/ntp_snippets/category.h"
#include "components/ntp_snippets/features.h"
#include "components/ntp_snippets/ntp_snippets_constants.h"
#include "components/ntp_snippets/user_classifier.h"
#include "components/variations/variations_associated_data.h"
#include "net/base/url_util.h"
#include "services/identity/public/cpp/identity_manager.h"
#include "services/identity/public/cpp/primary_account_access_token_fetcher.h"
#include "services/network/public/cpp/shared_url_loader_factory.h"
using language::UrlLanguageHistogram;
namespace ntp_snippets {
using internal::FetchResult;
using internal::JsonRequest;
namespace {
const char kApiKeyQueryParam[] = "key";
const char kPriorityQueryParam[] = "priority";
const char kInteractivePriority[] = "user_action";
const char kNonInteractivePriority[] = "background_prefetch";
const char kAuthorizationRequestHeaderFormat[] = "Bearer %s";
const int kFetchTimeHistogramResolution = 5;
// Enables appending request priority as a query parameter to the fetch url,
// when fetching article suggestions.
const char kAppendRequestPriorityAsQueryParameterParamName[] =
"append_request_priority_as_query_parameter";
const bool kAppendRequestPriorityAsQueryParameterParamDefault = true;
bool IsAppendingRequestPriorityAsQueryParameterEnabled() {
return variations::GetVariationParamByFeatureAsBool(
ntp_snippets::kArticleSuggestionsFeature,
kAppendRequestPriorityAsQueryParameterParamName,
kAppendRequestPriorityAsQueryParameterParamDefault);
}
GURL AppendPriorityQueryParameterIfEnabled(const GURL& url,
bool is_interactive_request) {
if (IsAppendingRequestPriorityAsQueryParameterEnabled()) {
return net::AppendQueryParameter(url, kPriorityQueryParam,
is_interactive_request
? kInteractivePriority
: kNonInteractivePriority);
}
return url;
}
std::string FetchResultToString(FetchResult result) {
switch (result) {
case FetchResult::SUCCESS:
return "OK";
case FetchResult::URL_REQUEST_STATUS_ERROR:
return "URLRequestStatus error";
case FetchResult::HTTP_ERROR:
return "HTTP error";
case FetchResult::JSON_PARSE_ERROR:
return "Received invalid JSON";
case FetchResult::INVALID_SNIPPET_CONTENT_ERROR:
return "Invalid / empty list.";
case FetchResult::OAUTH_TOKEN_ERROR:
return "Error in obtaining an OAuth2 access token.";
case FetchResult::MISSING_API_KEY:
return "No API key available.";
case FetchResult::HTTP_ERROR_UNAUTHORIZED:
return "Access token invalid";
case FetchResult::RESULT_MAX:
break;
}
NOTREACHED();
return "Unknown error";
}
Status FetchResultToStatus(FetchResult result) {
switch (result) {
case FetchResult::SUCCESS:
return Status::Success();
// Permanent errors occur if it is more likely that the error originated
// from the client.
case FetchResult::OAUTH_TOKEN_ERROR:
case FetchResult::MISSING_API_KEY:
return Status(StatusCode::PERMANENT_ERROR, FetchResultToString(result));
// Temporary errors occur if it's more likely that the client behaved
// correctly but the server failed to respond as expected.
// TODO(fhorschig): Revisit HTTP_ERROR once the rescheduling was reworked.
case FetchResult::HTTP_ERROR:
case FetchResult::HTTP_ERROR_UNAUTHORIZED:
case FetchResult::URL_REQUEST_STATUS_ERROR:
case FetchResult::INVALID_SNIPPET_CONTENT_ERROR:
case FetchResult::JSON_PARSE_ERROR:
return Status(StatusCode::TEMPORARY_ERROR, FetchResultToString(result));
case FetchResult::RESULT_MAX:
break;
}
NOTREACHED();
return Status(StatusCode::PERMANENT_ERROR, std::string());
}
int GetMinuteOfTheDay(bool local_time,
bool reduced_resolution,
base::Clock* clock) {
base::Time now(clock->Now());
base::Time::Exploded now_exploded{};
local_time ? now.LocalExplode(&now_exploded) : now.UTCExplode(&now_exploded);
int now_minute = reduced_resolution
? now_exploded.minute / kFetchTimeHistogramResolution *
kFetchTimeHistogramResolution
: now_exploded.minute;
return now_exploded.hour * 60 + now_minute;
}
// The response from the backend might include suggestions from multiple
// categories. If only a single category was requested, this function filters
// all other categories out.
void FilterCategories(FetchedCategoriesVector* categories,
base::Optional<Category> exclusive_category) {
if (!exclusive_category.has_value()) {
return;
}
Category exclusive = exclusive_category.value();
auto category_it =
std::find_if(categories->begin(), categories->end(),
[&exclusive](const FetchedCategory& c) -> bool {
return c.category == exclusive;
});
if (category_it == categories->end()) {
categories->clear();
return;
}
FetchedCategory category = std::move(*category_it);
categories->clear();
categories->push_back(std::move(category));
}
} // namespace
bool RemoteSuggestionsFetcherImpl::skip_api_key_check_for_testing_ = false;
RemoteSuggestionsFetcherImpl::RemoteSuggestionsFetcherImpl(
identity::IdentityManager* identity_manager,
scoped_refptr<network::SharedURLLoaderFactory> url_loader_factory,
PrefService* pref_service,
UrlLanguageHistogram* language_histogram,
const ParseJSONCallback& parse_json_callback,
const GURL& api_endpoint,
const std::string& api_key,
const UserClassifier* user_classifier)
: identity_manager_(identity_manager),
url_loader_factory_(std::move(url_loader_factory)),
language_histogram_(language_histogram),
parse_json_callback_(parse_json_callback),
fetch_url_(api_endpoint),
api_key_(api_key),
clock_(base::DefaultClock::GetInstance()),
user_classifier_(user_classifier),
last_fetch_authenticated_(false) {}
RemoteSuggestionsFetcherImpl::~RemoteSuggestionsFetcherImpl() = default;
const std::string& RemoteSuggestionsFetcherImpl::GetLastStatusForDebugging()
const {
return last_status_;
}
const std::string& RemoteSuggestionsFetcherImpl::GetLastJsonForDebugging()
const {
return last_fetch_json_;
}
bool RemoteSuggestionsFetcherImpl::WasLastFetchAuthenticatedForDebugging()
const {
return last_fetch_authenticated_;
}
const GURL& RemoteSuggestionsFetcherImpl::GetFetchUrlForDebugging() const {
return fetch_url_;
}
void RemoteSuggestionsFetcherImpl::FetchSnippets(
const RequestParams& params,
SnippetsAvailableCallback callback) {
if (!params.interactive_request) {
base::UmaHistogramSparse(
"NewTabPage.Snippets.FetchTimeLocal",
GetMinuteOfTheDay(/*local_time=*/true,
/*reduced_resolution=*/true, clock_));
base::UmaHistogramSparse(
"NewTabPage.Snippets.FetchTimeUTC",
GetMinuteOfTheDay(/*local_time=*/false,
/*reduced_resolution=*/true, clock_));
}
JsonRequest::Builder builder;
builder.SetLanguageHistogram(language_histogram_)
.SetParams(params)
.SetParseJsonCallback(parse_json_callback_)
.SetClock(clock_)
.SetUrlLoaderFactory(url_loader_factory_)
.SetUserClassifier(*user_classifier_);
if (identity_manager_->HasPrimaryAccount()) {
// Signed-in: get OAuth token --> fetch suggestions.
pending_requests_.emplace(std::move(builder), std::move(callback));
StartTokenRequest();
} else {
// Not signed in: fetch suggestions (without authentication).
FetchSnippetsNonAuthenticated(std::move(builder), std::move(callback));
}
}
void RemoteSuggestionsFetcherImpl::FetchSnippetsNonAuthenticated(
JsonRequest::Builder builder,
SnippetsAvailableCallback callback) {
if (api_key_.empty() && !skip_api_key_check_for_testing_) {
// If we don't have an API key, don't even try.
FetchFinished(OptionalFetchedCategories(), std::move(callback),
FetchResult::MISSING_API_KEY, std::string(),
/*is_authenticated=*/false, std::string());
return;
}
// When not providing OAuth token, we need to pass the Google API key.
GURL url = net::AppendQueryParameter(fetch_url_, kApiKeyQueryParam, api_key_);
url = AppendPriorityQueryParameterIfEnabled(url,
builder.is_interactive_request());
builder.SetUrl(url);
StartRequest(std::move(builder), std::move(callback),
/*is_authenticated=*/false, std::string());
}
void RemoteSuggestionsFetcherImpl::FetchSnippetsAuthenticated(
JsonRequest::Builder builder,
SnippetsAvailableCallback callback,
const std::string& oauth_access_token) {
GURL url = AppendPriorityQueryParameterIfEnabled(
fetch_url_, builder.is_interactive_request());
builder.SetUrl(url).SetAuthentication(
identity_manager_->GetPrimaryAccountInfo().account_id,
base::StringPrintf(kAuthorizationRequestHeaderFormat,
oauth_access_token.c_str()));
StartRequest(std::move(builder), std::move(callback),
/*is_authenticated=*/true, oauth_access_token);
}
void RemoteSuggestionsFetcherImpl::StartRequest(
JsonRequest::Builder builder,
SnippetsAvailableCallback callback,
bool is_authenticated,
std::string access_token) {
std::unique_ptr<JsonRequest> request = builder.Build();
JsonRequest* raw_request = request.get();
raw_request->Start(base::BindOnce(
&RemoteSuggestionsFetcherImpl::JsonRequestDone, base::Unretained(this),
std::move(request), std::move(callback), is_authenticated, access_token));
}
void RemoteSuggestionsFetcherImpl::StartTokenRequest() {
// If there is already an ongoing token request, just wait for that.
if (token_fetcher_) {
return;
}
OAuth2TokenService::ScopeSet scopes{kContentSuggestionsApiScope};
token_fetcher_ = std::make_unique<identity::PrimaryAccountAccessTokenFetcher>(
"ntp_snippets", identity_manager_, scopes,
base::BindOnce(&RemoteSuggestionsFetcherImpl::AccessTokenFetchFinished,
base::Unretained(this)),
identity::PrimaryAccountAccessTokenFetcher::Mode::kWaitUntilAvailable);
}
void RemoteSuggestionsFetcherImpl::AccessTokenFetchFinished(
GoogleServiceAuthError error,
identity::AccessTokenInfo access_token_info) {
DCHECK(token_fetcher_);
token_fetcher_.reset();
if (error.state() != GoogleServiceAuthError::NONE) {
AccessTokenError(error);
return;
}
DCHECK(!access_token_info.token.empty());
while (!pending_requests_.empty()) {
std::pair<JsonRequest::Builder, SnippetsAvailableCallback>
builder_and_callback = std::move(pending_requests_.front());
pending_requests_.pop();
FetchSnippetsAuthenticated(std::move(builder_and_callback.first),
std::move(builder_and_callback.second),
access_token_info.token);
}
}
void RemoteSuggestionsFetcherImpl::AccessTokenError(
const GoogleServiceAuthError& error) {
DCHECK_NE(error.state(), GoogleServiceAuthError::NONE);
DLOG(ERROR) << "Unable to get token: " << error.ToString();
while (!pending_requests_.empty()) {
std::pair<JsonRequest::Builder, SnippetsAvailableCallback>
builder_and_callback = std::move(pending_requests_.front());
FetchFinished(OptionalFetchedCategories(),
std::move(builder_and_callback.second),
FetchResult::OAUTH_TOKEN_ERROR,
/*error_details=*/
base::StringPrintf(" (%s)", error.ToString().c_str()),
/*is_authenticated=*/true, std::string());
pending_requests_.pop();
}
}
void RemoteSuggestionsFetcherImpl::JsonRequestDone(
std::unique_ptr<JsonRequest> request,
SnippetsAvailableCallback callback,
bool is_authenticated,
std::string access_token,
std::unique_ptr<base::Value> result,
FetchResult status_code,
const std::string& error_details) {
DCHECK(request);
// Record the time when request for fetching remote content snippets finished.
const base::Time fetch_time = clock_->Now();
last_fetch_json_ = request->GetResponseString();
UMA_HISTOGRAM_TIMES("NewTabPage.Snippets.FetchTime",
request->GetFetchDuration());
if (!result) {
FetchFinished(OptionalFetchedCategories(), std::move(callback), status_code,
error_details, is_authenticated, access_token);
return;
}
FetchedCategoriesVector categories;
if (!JsonToCategories(*result, &categories, fetch_time)) {
LOG(WARNING) << "Received invalid snippets: " << last_fetch_json_;
FetchFinished(OptionalFetchedCategories(), std::move(callback),
FetchResult::INVALID_SNIPPET_CONTENT_ERROR, std::string(),
is_authenticated, access_token);
return;
}
// Filter out unwanted categories if necessary.
// TODO(fhorschig): As soon as the server supports filtering by category,
// adjust the request instead of over-fetching and filtering here.
FilterCategories(&categories, request->exclusive_category());
FetchFinished(std::move(categories), std::move(callback),
FetchResult::SUCCESS, std::string(), is_authenticated,
access_token);
}
void RemoteSuggestionsFetcherImpl::FetchFinished(
OptionalFetchedCategories categories,
SnippetsAvailableCallback callback,
FetchResult fetch_result,
const std::string& error_details,
bool is_authenticated,
std::string access_token) {
DCHECK(fetch_result == FetchResult::SUCCESS || !categories.has_value());
if (fetch_result == FetchResult::HTTP_ERROR_UNAUTHORIZED) {
OAuth2TokenService::ScopeSet scopes{kContentSuggestionsApiScope};
std::string account_id =
identity_manager_->GetPrimaryAccountInfo().account_id;
identity_manager_->RemoveAccessTokenFromCache(account_id, scopes,
access_token);
}
last_status_ = FetchResultToString(fetch_result) + error_details;
last_fetch_authenticated_ = is_authenticated;
UMA_HISTOGRAM_ENUMERATION("NewTabPage.Snippets.FetchResult",
static_cast<int>(fetch_result),
static_cast<int>(FetchResult::RESULT_MAX));
DVLOG(1) << "Fetch finished: " << last_status_;
std::move(callback).Run(FetchResultToStatus(fetch_result),
std::move(categories));
}
// static
void RemoteSuggestionsFetcherImpl::set_skip_api_key_check_for_testing() {
skip_api_key_check_for_testing_ = true;
}
} // namespace ntp_snippets
|