File: remote_suggestions_scheduler_impl_unittest.cc

package info (click to toggle)
chromium-browser 70.0.3538.110-1~deb9u1
  • links: PTS, VCS
  • area: main
  • in suites: stretch
  • size: 1,619,476 kB
  • sloc: cpp: 13,024,755; ansic: 1,349,823; python: 916,672; xml: 314,489; java: 280,047; asm: 276,936; perl: 75,771; objc: 66,634; sh: 45,860; cs: 28,354; php: 11,064; makefile: 10,911; yacc: 9,109; tcl: 8,403; ruby: 4,065; lex: 1,779; pascal: 1,411; lisp: 1,055; awk: 41; jsp: 39; sed: 17; sql: 3
file content (1314 lines) | stat: -rw-r--r-- 52,770 bytes parent folder | download | duplicates (2)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
// Copyright 2016 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

#include "components/ntp_snippets/remote/remote_suggestions_scheduler_impl.h"

#include <memory>
#include <set>
#include <string>
#include <utility>
#include <vector>

#include "base/command_line.h"
#include "base/macros.h"
#include "base/run_loop.h"
#include "base/strings/string_number_conversions.h"
#include "base/test/scoped_feature_list.h"
#include "base/test/simple_test_clock.h"
#include "base/threading/thread_task_runner_handle.h"
#include "base/time/clock.h"
#include "base/time/default_clock.h"
#include "base/time/time.h"
#include "components/ntp_snippets/features.h"
#include "components/ntp_snippets/logger.h"
#include "components/ntp_snippets/ntp_snippets_constants.h"
#include "components/ntp_snippets/pref_names.h"
#include "components/ntp_snippets/remote/persistent_scheduler.h"
#include "components/ntp_snippets/remote/remote_suggestions_provider.h"
#include "components/ntp_snippets/remote/test_utils.h"
#include "components/ntp_snippets/status.h"
#include "components/ntp_snippets/user_classifier.h"
#include "components/prefs/testing_pref_service.h"
#include "components/sync_preferences/testing_pref_service_syncable.h"
#include "components/variations/variations_params_manager.h"
#include "components/web_resource/web_resource_pref_names.h"
#include "net/base/network_change_notifier.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"

using testing::AnyNumber;
using testing::ElementsAre;
using testing::Eq;
using testing::Field;
using testing::InSequence;
using testing::Invoke;
using testing::InvokeArgument;
using testing::IsEmpty;
using testing::Mock;
using testing::MockFunction;
using testing::Not;
using testing::Return;
using testing::SaveArg;
using testing::SaveArgPointee;
using testing::SizeIs;
using testing::StartsWith;
using testing::StrictMock;
using testing::WithArgs;
using testing::_;

namespace ntp_snippets {

class RemoteSuggestionsFetcher;

namespace {

const int kDefaultStartupIntervalHours = 24;

ACTION_TEMPLATE(SaveArgByMove,
                HAS_1_TEMPLATE_PARAMS(int, k),
                AND_1_VALUE_PARAMS(pointer)) {
  *pointer = std::move(*::testing::get<k>(args));
}

class MockPersistentScheduler : public PersistentScheduler {
 public:
  MOCK_METHOD2(Schedule,
               bool(base::TimeDelta period_wifi,
                    base::TimeDelta period_fallback));
  MOCK_METHOD0(Unschedule, bool());
  MOCK_METHOD0(IsOnUnmeteredConnection, bool());
};

// TODO(jkrcal): Move into its own library to reuse in other unit-tests?
class MockRemoteSuggestionsProvider : public RemoteSuggestionsProvider {
 public:
  MockRemoteSuggestionsProvider(Observer* observer)
      : RemoteSuggestionsProvider(observer) {}
  // Gmock cannot mock a method with movable-only type callback
  // FetchStatusCallback as a parameter. As a work-around, this function calls
  // the mock function with value passed by pointer. The mock function may then
  // be checked with EXPECT_CALL.
  void RefetchInTheBackground(
      RemoteSuggestionsProvider::FetchStatusCallback callback) override {
    RefetchInTheBackground(&callback);
  }
  MOCK_METHOD1(RefetchInTheBackground,
               void(RemoteSuggestionsProvider::FetchStatusCallback*));
  // Gmock cannot mock a method with movable-only type callback
  // FetchStatusCallback as a parameter. As a work-around, this function calls
  // the mock function with value passed by pointer. The mock function may then
  // be checked with EXPECT_CALL.
  void RefetchWhileDisplaying(
      RemoteSuggestionsProvider::FetchStatusCallback callback) override {
    RefetchWhileDisplaying(&callback);
  }
  MOCK_METHOD1(RefetchWhileDisplaying,
               void(RemoteSuggestionsProvider::FetchStatusCallback*));
  MOCK_CONST_METHOD0(suggestions_fetcher_for_debugging,
                     const RemoteSuggestionsFetcher*());
  MOCK_CONST_METHOD1(GetUrlWithFavicon,
                     GURL(const ContentSuggestion::ID& suggestion_id));
  MOCK_CONST_METHOD0(IsDisabled, bool());
  MOCK_CONST_METHOD0(ready, bool());
  MOCK_METHOD1(GetCategoryStatus, CategoryStatus(Category));
  MOCK_METHOD1(GetCategoryInfo, CategoryInfo(Category));
  MOCK_METHOD3(ClearHistory,
               void(base::Time begin,
                    base::Time end,
                    const base::Callback<bool(const GURL& url)>& filter));
  // Gmock cannot mock a method with movable-only type callback
  // FetchDoneCallback as a parameter. As a work-around, this function calls the
  // mock function with value passed by pointer. The mock function may then be
  // checked with EXPECT_CALL.
  void Fetch(const Category& category,
             const std::set<std::string>& set,
             FetchDoneCallback callback) override {
    Fetch(category, set, &callback);
  }
  MOCK_METHOD3(Fetch,
               void(const Category&,
                    const std::set<std::string>&,
                    FetchDoneCallback*));
  MOCK_METHOD0(ReloadSuggestions, void());
  MOCK_METHOD0(ClearCachedSuggestions, void());
  MOCK_METHOD1(ClearDismissedSuggestionsForDebugging, void(Category));
  MOCK_METHOD1(DismissSuggestion, void(const ContentSuggestion::ID&));
  // Gmock cannot mock a method with movable-only type callback
  // ImageFetchedCallback as a parameter. As a work-around, this function calls
  // the mock function with value passed by pointer. The mock function may then
  // be checked with EXPECT_CALL.
  void FetchSuggestionImage(const ContentSuggestion::ID& id,
                            ImageFetchedCallback callback) override {
    FetchSuggestionImage(id, &callback);
  }
  MOCK_METHOD2(FetchSuggestionImage,
               void(const ContentSuggestion::ID&, ImageFetchedCallback*));

  void FetchSuggestionImageData(const ContentSuggestion::ID& suggestion_id,
                                ImageDataFetchedCallback callback) override {
    FetchSuggestionImageData(suggestion_id, &callback);
  }
  MOCK_METHOD2(FetchSuggestionImageData,
               void(const ContentSuggestion::ID&, ImageDataFetchedCallback*));

  void GetDismissedSuggestionsForDebugging(
      Category category,
      DismissedSuggestionsCallback callback) override {
    GetDismissedSuggestionsForDebugging(category, &callback);
  }
  MOCK_METHOD2(GetDismissedSuggestionsForDebugging,
               void(Category category, DismissedSuggestionsCallback* callback));
  MOCK_METHOD1(OnSignInStateChanged, void(bool));
};

class FakeOfflineNetworkChangeNotifier : public net::NetworkChangeNotifier {
 public:
  ConnectionType GetCurrentConnectionType() const override {
    return NetworkChangeNotifier::CONNECTION_NONE;
  }
};

}  // namespace

class RemoteSuggestionsSchedulerImplTest : public ::testing::Test {
 public:
  RemoteSuggestionsSchedulerImplTest()
      :  // For the test we enabled all trigger types.
        default_variation_params_{{"scheduler_trigger_types",
                                   "persistent_scheduler_wake_up,ntp_opened,"
                                   "browser_foregrounded,browser_cold_start"}},
        params_manager_(ntp_snippets::kArticleSuggestionsFeature.name,
                        default_variation_params_,
                        {kArticleSuggestionsFeature.name}),
        user_classifier_(/*pref_service=*/nullptr,
                         base::DefaultClock::GetInstance()) {
    RemoteSuggestionsSchedulerImpl::RegisterProfilePrefs(
        utils_.pref_service()->registry());
    RequestThrottler::RegisterProfilePrefs(utils_.pref_service()->registry());
    // TODO(jkrcal) Create a static function in EulaAcceptedNotifier that
    // registers this pref and replace the call in browser_process_impl.cc & in
    // eula_accepted_notifier_unittest.cc with the new static function.
    local_state_.registry()->RegisterBooleanPref(::prefs::kEulaAccepted, false);
    // By default pretend we are on WiFi.
    EXPECT_CALL(*persistent_scheduler(), IsOnUnmeteredConnection())
        .WillRepeatedly(Return(true));
    ResetProvider();
  }

  void ResetProvider() {
    provider_ = std::make_unique<StrictMock<MockRemoteSuggestionsProvider>>(
        /*observer=*/nullptr);

    test_clock_.SetNow(base::Time::Now());

    scheduler_ = std::make_unique<RemoteSuggestionsSchedulerImpl>(
        &persistent_scheduler_, &user_classifier_, utils_.pref_service(),
        &local_state_, &test_clock_, &debug_logger_);
    scheduler_->SetProvider(provider_.get());
  }

  void SetVariationParameter(const std::string& param_name,
                             const std::string& param_value) {
    std::map<std::string, std::string> params = default_variation_params_;
    params[param_name] = param_value;

    params_manager_.ClearAllVariationParams();
    params_manager_.SetVariationParamsWithFeatureAssociations(
        ntp_snippets::kArticleSuggestionsFeature.name, params,
        {ntp_snippets::kArticleSuggestionsFeature.name});
  }

  bool IsEulaNotifierAvailable() {
    // Create() returns a unique_ptr, so this is no leak.
    return web_resource::EulaAcceptedNotifier::Create(&local_state_) != nullptr;
  }

  void SetEulaAcceptedPref() {
    local_state_.SetBoolean(::prefs::kEulaAccepted, true);
  }

  // GMock cannot deal with move-only types. We need to pass the vector to the
  // mock function as const ref using this wrapper callback.
  void FetchDoneWrapper(
      MockFunction<void(Status status_code,
                        const std::vector<ContentSuggestion>& suggestions)>*
          fetch_done,
      Status status_code,
      std::vector<ContentSuggestion> suggestions) {
    fetch_done->Call(status_code, suggestions);
  }

 protected:
  std::map<std::string, std::string> default_variation_params_;
  variations::testing::VariationParamsManager params_manager_;

  void ActivateProviderAndEula() {
    SetEulaAcceptedPref();
    EXPECT_CALL(*provider(), ready()).WillRepeatedly(Return(true));
    scheduler_->OnProviderActivated();
  }

  void ActivateProvider() {
    EXPECT_CALL(*provider(), ready()).WillRepeatedly(Return(true));
    scheduler_->OnProviderActivated();
  }

  void DeactivateProvider() {
    scheduler_->OnProviderDeactivated();
    EXPECT_CALL(*provider(), ready()).WillRepeatedly(Return(true));
  }

  void ExpectOneRetiringRefetchInTheBackground() {
    // After a successful fetch, the client updates it's schedule, so we expect
    // another call here.
    EXPECT_CALL(*persistent_scheduler(), Schedule(_, _)).RetiresOnSaturation();
    EXPECT_CALL(*provider(), RefetchInTheBackground(_))
        .WillOnce(Invoke(
            [](RemoteSuggestionsProvider::FetchStatusCallback* callback) {
              std::move(*callback).Run(Status::Success());
            }))
        .RetiresOnSaturation();
  }

  MockPersistentScheduler* persistent_scheduler() {
    return &persistent_scheduler_;
  }

  base::SimpleTestClock* test_clock() { return &test_clock_; }
  MockRemoteSuggestionsProvider* provider() { return provider_.get(); }
  RemoteSuggestionsSchedulerImpl* scheduler() { return scheduler_.get(); }

 private:
  test::RemoteSuggestionsTestUtils utils_;
  UserClassifier user_classifier_;
  TestingPrefServiceSimple local_state_;
  StrictMock<MockPersistentScheduler> persistent_scheduler_;
  base::SimpleTestClock test_clock_;
  std::unique_ptr<MockRemoteSuggestionsProvider> provider_;
  std::unique_ptr<RemoteSuggestionsSchedulerImpl> scheduler_;
  Logger debug_logger_;

  DISALLOW_COPY_AND_ASSIGN(RemoteSuggestionsSchedulerImplTest);
};

TEST_F(RemoteSuggestionsSchedulerImplTest, ShouldIgnoreSignalsWhenNotEnabled) {
  // The signals should be ignored even if the provider itself claims it is
  // ready.
  EXPECT_CALL(*provider(), ready()).WillRepeatedly(Return(true));

  scheduler()->OnPersistentSchedulerWakeUp();
  scheduler()->OnSuggestionsSurfaceOpened();
  scheduler()->OnBrowserForegrounded();
  scheduler()->OnBrowserColdStart();
}

TEST_F(RemoteSuggestionsSchedulerImplTest,
       ShouldIgnoreEulaStateOnPlatformsWhereNotAvaiable) {
  // Only run this tests on platforms that don't support Eula.
  if (IsEulaNotifierAvailable()) {
    return;
  }

  // Activating the provider should schedule the persistent background fetches.
  EXPECT_CALL(*persistent_scheduler(), Schedule(_, _));
  ActivateProvider();

  // Verify fetches get triggered.
  ExpectOneRetiringRefetchInTheBackground();
  scheduler()->OnPersistentSchedulerWakeUp();
}

TEST_F(RemoteSuggestionsSchedulerImplTest,
       ShouldIgnoreSignalsWhenEulaNotAccepted) {
  // Only run this tests on platforms supporting Eula.
  if (!IsEulaNotifierAvailable()) {
    return;
  }
  // Activating the provider should schedule the persistent background fetches.
  EXPECT_CALL(*persistent_scheduler(), Schedule(_, _));
  ActivateProvider();

  // All signals are ignored because of Eula not being accepted.
  scheduler()->OnPersistentSchedulerWakeUp();
  scheduler()->OnSuggestionsSurfaceOpened();
  scheduler()->OnBrowserForegrounded();
  scheduler()->OnBrowserColdStart();
}

TEST_F(RemoteSuggestionsSchedulerImplTest, ShouldFetchWhenEulaGetsAccepted) {
  // Only run this tests on platforms supporting Eula.
  if (!IsEulaNotifierAvailable()) {
    return;
  }
  // Activating the provider should schedule the persistent background fetches.
  EXPECT_CALL(*persistent_scheduler(), Schedule(_, _));
  ActivateProvider();

  // Make one (ignored) call to make sure we are interested in eula state.
  scheduler()->OnPersistentSchedulerWakeUp();

  // Accepting Eula afterwards results in a background fetch.
  ExpectOneRetiringRefetchInTheBackground();
  SetEulaAcceptedPref();
}

TEST_F(RemoteSuggestionsSchedulerImplTest,
       ShouldQueueBackgroundRequestIfEulaIsMissing) {
  // Only run this tests on platforms supporting Eula.
  if (!IsEulaNotifierAvailable()) {
    return;
  }
  // Eula is not ready -- no fetch. But request should get queued.
  EXPECT_CALL(*provider(), ready()).WillRepeatedly(Return(false));
  scheduler()->OnPersistentSchedulerWakeUp();
  EXPECT_CALL(*persistent_scheduler(), Schedule(_, _));
  // Activate provider -- this should set up the schedule but cannot trigger a
  // fetch due to Eula missing.
  ActivateProvider();

  // Accepting Eula picks up the queued fetch.
  ExpectOneRetiringRefetchInTheBackground();
  SetEulaAcceptedPref();
}

TEST_F(RemoteSuggestionsSchedulerImplTest,
       ShouldQueueBackgroundRequestBeforeActivated) {
  // Set the Eula bit to be sure we queue them because of not being activated.
  SetEulaAcceptedPref();

  // Activate provider -- this should set up the schedule and store it to prefs.
  EXPECT_CALL(*persistent_scheduler(), Schedule(_, _)).RetiresOnSaturation();
  ActivateProvider();

  // Reset the provider after we have the schedule stored in prefs.
  ResetProvider();

  // Provider is not active -- no fetch. But request should get queued.
  EXPECT_CALL(*provider(), ready()).WillRepeatedly(Return(false));
  scheduler()->OnPersistentSchedulerWakeUp();

  ExpectOneRetiringRefetchInTheBackground();
  // Activate provider -- this should trigger the fetch (the schedule was set up
  // previously).
  ActivateProvider();
}

TEST_F(RemoteSuggestionsSchedulerImplTest,
       ShouldIgnoreSignalsWhenDisabledByParam) {
  // First set an empty list of allowed trigger types.
  SetVariationParameter("scheduler_trigger_types", "-");
  ResetProvider();

  // Then enable the scheduler.
  EXPECT_CALL(*persistent_scheduler(), Schedule(_, _));
  ActivateProviderAndEula();

  scheduler()->OnPersistentSchedulerWakeUp();
  scheduler()->OnSuggestionsSurfaceOpened();
  scheduler()->OnBrowserForegrounded();
  scheduler()->OnBrowserColdStart();
}

TEST_F(RemoteSuggestionsSchedulerImplTest,
       ShouldHandleEmptyParamForTriggerTypes) {
  // First set an empty param for allowed trigger types -> should result in the
  // default list.
  SetVariationParameter("scheduler_trigger_types", "");
  ResetProvider();

  // Then enable the scheduler.
  EXPECT_CALL(*persistent_scheduler(), Schedule(_, _));
  ActivateProviderAndEula();

  // For instance, persistent scheduler wake up should be enabled by default.
  ExpectOneRetiringRefetchInTheBackground();
  scheduler()->OnPersistentSchedulerWakeUp();
}

TEST_F(RemoteSuggestionsSchedulerImplTest,
       ShouldHandleIncorrentParamForTriggerTypes) {
  // First set an invalid list of allowed trigger types.
  SetVariationParameter("scheduler_trigger_types", "ntp_opened,foo;");
  ResetProvider();

  // Then enable the scheduler.
  EXPECT_CALL(*persistent_scheduler(), Schedule(_, _));
  ActivateProviderAndEula();

  // For instance, persistent scheduler wake up should be enabled by default.
  ExpectOneRetiringRefetchInTheBackground();
  scheduler()->OnPersistentSchedulerWakeUp();
}

TEST_F(RemoteSuggestionsSchedulerImplTest,
       ShouldFetchOnPersistentSchedulerWakeUp) {
  // First set only this type to be allowed.
  SetVariationParameter("scheduler_trigger_types",
                        "persistent_scheduler_wake_up");
  ResetProvider();

  // Then enable the scheduler.
  EXPECT_CALL(*persistent_scheduler(), Schedule(_, _));
  ActivateProviderAndEula();

  ExpectOneRetiringRefetchInTheBackground();
  scheduler()->OnPersistentSchedulerWakeUp();
}

TEST_F(RemoteSuggestionsSchedulerImplTest,
       ShouldFetchOnPersistentSchedulerWakeUpRepeated) {
  RemoteSuggestionsProvider::FetchStatusCallback signal_fetch_done;
  {
    InSequence s;
    EXPECT_CALL(*persistent_scheduler(), Schedule(_, _));
    EXPECT_CALL(*provider(), RefetchInTheBackground(_))
        .WillOnce(SaveArgByMove<0>(&signal_fetch_done));
    EXPECT_CALL(*persistent_scheduler(), Schedule(_, _));
    EXPECT_CALL(*provider(), RefetchInTheBackground(_));
  }
  // First enable the scheduler -- calling Schedule() for the first time.
  ActivateProviderAndEula();
  // Make the first persistent fetch successful -- calling Schedule() again.
  scheduler()->OnPersistentSchedulerWakeUp();
  std::move(signal_fetch_done).Run(Status::Success());
  // Make the second fetch.
  scheduler()->OnPersistentSchedulerWakeUp();
}

TEST_F(RemoteSuggestionsSchedulerImplTest,
       ShouldNotTriggerBackgroundFetchIfAlreadyInProgess) {
  {
    InSequence s;
    EXPECT_CALL(*persistent_scheduler(), Schedule(_, _));
    // We do not capture and execute the callback to keep the fetch in-flight.
    EXPECT_CALL(*provider(), RefetchInTheBackground(_));
    // Refetch is not called after the second trigger.
  }
  // First enable the scheduler -- calling Schedule() for the first time.
  ActivateProviderAndEula();
  // Make the first persistent fetch never finish.
  scheduler()->OnPersistentSchedulerWakeUp();
  // Make the second fetch.
  scheduler()->OnPersistentSchedulerWakeUp();
}

TEST_F(RemoteSuggestionsSchedulerImplTest,
       ShouldFetchOnSuggestionsSurfaceOpenedForTheFirstTime) {
  // First set only this type to be allowed.
  SetVariationParameter("scheduler_trigger_types", "ntp_opened");
  ResetProvider();

  // Then enable the scheduler.
  EXPECT_CALL(*persistent_scheduler(), Schedule(_, _));
  ActivateProviderAndEula();

  ExpectOneRetiringRefetchInTheBackground();
  scheduler()->OnSuggestionsSurfaceOpened();
}

TEST_F(RemoteSuggestionsSchedulerImplTest,
       ShouldFetchOnBrowserForegroundedForTheFirstTime) {
  // First set only this type to be allowed.
  SetVariationParameter("scheduler_trigger_types", "browser_foregrounded");
  ResetProvider();

  // Then enable the scheduler.
  EXPECT_CALL(*persistent_scheduler(), Schedule(_, _));
  ActivateProviderAndEula();

  ExpectOneRetiringRefetchInTheBackground();
  scheduler()->OnBrowserForegrounded();
}

TEST_F(RemoteSuggestionsSchedulerImplTest,
       ShouldFetchOnBrowserColdStartForTheFirstTime) {
  // Then enable the scheduler.
  EXPECT_CALL(*persistent_scheduler(), Schedule(_, _));
  ActivateProviderAndEula();

  ExpectOneRetiringRefetchInTheBackground();
  scheduler()->OnBrowserColdStart();
}

TEST_F(RemoteSuggestionsSchedulerImplTest,
       ShouldQueueBackgroundFetchSignalsOnPersistentSchedulerWakeUp) {
  // Enable EULA to make this test not depend on that setting (or it being
  // flipped)
  SetEulaAcceptedPref();

  // On activation, the Schedule should get updated and the queued background
  // fetch should get propagated.
  EXPECT_CALL(*provider(), ready()).WillRepeatedly(Return(false));
  scheduler()->OnPersistentSchedulerWakeUp();
  EXPECT_CALL(*persistent_scheduler(), Schedule(_, _));
  ExpectOneRetiringRefetchInTheBackground();
  ActivateProviderAndEula();
}

TEST_F(RemoteSuggestionsSchedulerImplTest,
       ShouldQueueBackgroundFetchSignalsOnSurfaceOpened) {
  // Enable EULA to make this test not depend on that setting (or it being
  // flipped)
  SetEulaAcceptedPref();

  // On activation, the Schedule should get updated and the queued background
  // fetch should get propagated.
  EXPECT_CALL(*provider(), ready()).WillRepeatedly(Return(false));
  scheduler()->OnSuggestionsSurfaceOpened();
  EXPECT_CALL(*persistent_scheduler(), Schedule(_, _));
  ExpectOneRetiringRefetchInTheBackground();
  ActivateProviderAndEula();
}

TEST_F(RemoteSuggestionsSchedulerImplTest,
       ShouldQueueBackgroundFetchSignalsOnBrowserForegrounded) {
  // Enable EULA to make this test not depend on that setting (or it being
  // flipped)
  SetEulaAcceptedPref();

  // On activation, the Schedule should get updated and the queued background
  // fetch should get propagated.
  EXPECT_CALL(*provider(), ready()).WillRepeatedly(Return(false));
  scheduler()->OnBrowserForegrounded();
  EXPECT_CALL(*persistent_scheduler(), Schedule(_, _));
  ExpectOneRetiringRefetchInTheBackground();
  ActivateProviderAndEula();
}

TEST_F(RemoteSuggestionsSchedulerImplTest,
       ShouldQueueBackgroundFetchSignalsOnBrowserColdStart) {
  // Enable EULA to make this test not depend on that setting (or it being
  // flipped)
  SetEulaAcceptedPref();

  // On activation, the Schedule should get updated and the queued background
  // fetch should get propagated.
  EXPECT_CALL(*provider(), ready()).WillRepeatedly(Return(false));
  scheduler()->OnBrowserColdStart();
  EXPECT_CALL(*persistent_scheduler(), Schedule(_, _));
  ExpectOneRetiringRefetchInTheBackground();
  ActivateProviderAndEula();
}

TEST_F(RemoteSuggestionsSchedulerImplTest,
       ShouldQueueMultipleBackgroundFetchSignals) {
  // Enable EULA to make this test not depend on that setting (or it being
  // flipped)
  SetEulaAcceptedPref();

  // We want to store multiple events to respect lower thresholds for specific
  // events properly. To test this, we do the following setup:
  // (1) Force a fetch.
  // (2) Simulate a stop of the browser, wait until surface-opened would trigger
  // a fetch but start-up would not trigger a fetch yet.
  // (3) simulate a very slow initialization, where the scheduler sees both
  // events (cold start and surface opened) before being activated.
  // (4) make sure that activation triggers a background fetch.
  EXPECT_CALL(*persistent_scheduler(), Schedule(_, _)).Times(AnyNumber());
  ActivateProviderAndEula();
  ExpectOneRetiringRefetchInTheBackground();
  scheduler()->OnBrowserColdStart();

  // UserClassifier defaults to UserClass::ACTIVE_NTP_USER - we work with the
  // default interval for this class here. This time would allow for a fetch on
  // NTP open but not on cold start.
  test_clock()->Advance(base::TimeDelta::FromHours(13));
  // This should *not* trigger a fetch.
  scheduler()->OnBrowserColdStart();

  // Simulate a restart.
  EXPECT_CALL(*persistent_scheduler(), Unschedule());
  scheduler()->OnProviderDeactivated();
  ResetProvider();  // Also resets the scheduler and test clock.

  test_clock()->Advance(base::TimeDelta::FromHours(13));
  EXPECT_CALL(*provider(), ready()).WillRepeatedly(Return(false));
  scheduler()->OnSuggestionsSurfaceOpened();
  scheduler()->OnBrowserColdStart();
  ExpectOneRetiringRefetchInTheBackground();

  // Signal the provider is ready (EULA check should still pass from the first
  // start). We don't want to trigger EULA again as it will simulate a
  // persistent fetch.
  ActivateProviderAndEula();
}

TEST_F(RemoteSuggestionsSchedulerImplTest,
       ShouldNotFetchOnSuggestionsSurfaceOpenedAfterSuccessfulSoftFetch) {
  // First enable the scheduler; the second Schedule is called after the
  // successful fetch.
  EXPECT_CALL(*persistent_scheduler(), Schedule(_, _)).Times(2);
  ActivateProviderAndEula();

  // Make the first soft fetch successful.
  RemoteSuggestionsProvider::FetchStatusCallback signal_fetch_done;
  EXPECT_CALL(*provider(), RefetchInTheBackground(_))
      .WillOnce(SaveArgByMove<0>(&signal_fetch_done));
  scheduler()->OnSuggestionsSurfaceOpened();
  std::move(signal_fetch_done).Run(Status::Success());
  // The second call is ignored if it happens right after the first one.
  scheduler()->OnSuggestionsSurfaceOpened();
}

TEST_F(RemoteSuggestionsSchedulerImplTest,
       ShouldNotFetchOnSuggestionsSurfaceOpenedAfterSuccessfulPersistentFetch) {
  // First enable the scheduler; the second Schedule is called after the
  // successful fetch.
  EXPECT_CALL(*persistent_scheduler(), Schedule(_, _)).Times(2);
  ActivateProviderAndEula();

  // Make the first persistent fetch successful.
  RemoteSuggestionsProvider::FetchStatusCallback signal_fetch_done;
  EXPECT_CALL(*provider(), RefetchInTheBackground(_))
      .WillOnce(SaveArgByMove<0>(&signal_fetch_done));
  scheduler()->OnPersistentSchedulerWakeUp();
  std::move(signal_fetch_done).Run(Status::Success());
  // The second call is ignored if it happens right after the first one.
  scheduler()->OnSuggestionsSurfaceOpened();
}

TEST_F(RemoteSuggestionsSchedulerImplTest,
       ShouldNotFetchOnSuggestionsSurfaceOpenedAfterFailedSoftFetch) {
  // First enable the scheduler.
  EXPECT_CALL(*persistent_scheduler(), Schedule(_, _));
  ActivateProviderAndEula();

  // Make the first soft fetch failed.
  RemoteSuggestionsProvider::FetchStatusCallback signal_fetch_done;
  EXPECT_CALL(*provider(), RefetchInTheBackground(_))
      .WillOnce(SaveArgByMove<0>(&signal_fetch_done));
  scheduler()->OnSuggestionsSurfaceOpened();
  std::move(signal_fetch_done).Run(Status(StatusCode::PERMANENT_ERROR, ""));

  // The second call is ignored if it happens right after the first one.
  scheduler()->OnSuggestionsSurfaceOpened();
}

TEST_F(RemoteSuggestionsSchedulerImplTest,
       ShouldNotFetchOnSuggestionsSurfaceOpenedAfterFailedPersistentFetch) {
  // First enable the scheduler.
  EXPECT_CALL(*persistent_scheduler(), Schedule(_, _));
  ActivateProviderAndEula();

  // Make the first persistent fetch failed.
  RemoteSuggestionsProvider::FetchStatusCallback signal_fetch_done;
  EXPECT_CALL(*provider(), RefetchInTheBackground(_))
      .WillOnce(SaveArgByMove<0>(&signal_fetch_done));
  scheduler()->OnPersistentSchedulerWakeUp();
  std::move(signal_fetch_done).Run(Status(StatusCode::PERMANENT_ERROR, ""));

  // The second call is ignored if it happens right after the first one.
  scheduler()->OnSuggestionsSurfaceOpened();
}

TEST_F(RemoteSuggestionsSchedulerImplTest,
       ShouldFetchAgainOnBrowserForgroundLaterAgain) {
  RemoteSuggestionsProvider::FetchStatusCallback signal_fetch_done;
  {
    InSequence s;
    // Initial scheduling after being enabled.
    EXPECT_CALL(*persistent_scheduler(), Schedule(_, _));
    // The first call to NTPOpened results in a fetch.
    EXPECT_CALL(*provider(), RefetchInTheBackground(_))
        .WillOnce(SaveArgByMove<0>(&signal_fetch_done));
    // Rescheduling after a succesful fetch.
    EXPECT_CALL(*persistent_scheduler(), Schedule(_, _));
    // The second call to NTPOpened 4hrs later again results in a fetch.
    EXPECT_CALL(*provider(), RefetchInTheBackground(_));
  }

  // First enable the scheduler.
  ActivateProviderAndEula();
  // Make the first soft fetch successful.
  scheduler()->OnBrowserForegrounded();
  std::move(signal_fetch_done).Run(Status::Success());
  test_clock()->Advance(
      base::TimeDelta::FromHours(kDefaultStartupIntervalHours));
  scheduler()->OnBrowserForegrounded();
}

TEST_F(RemoteSuggestionsSchedulerImplTest, ShouldRescheduleOnBrowserUpgraded) {
  EXPECT_CALL(*persistent_scheduler(), Schedule(_, _));
  scheduler()->OnBrowserUpgraded();
}

TEST_F(RemoteSuggestionsSchedulerImplTest, ShouldScheduleOnActivation) {
  EXPECT_CALL(*persistent_scheduler(), Schedule(_, _));
  ActivateProviderAndEula();
}

TEST_F(RemoteSuggestionsSchedulerImplTest,
       ShouldUnscheduleOnLaterInactivation) {
  {
    InSequence s;
    EXPECT_CALL(*persistent_scheduler(), Schedule(_, _));
    EXPECT_CALL(*persistent_scheduler(), Unschedule());
  }
  ActivateProviderAndEula();
  DeactivateProvider();
}

TEST_F(RemoteSuggestionsSchedulerImplTest, ShouldScheduleOnLaterActivation) {
  EXPECT_CALL(*persistent_scheduler(), Schedule(_, _));
  // There is no schedule yet, so inactivation does not trigger unschedule.
  DeactivateProvider();
  ActivateProviderAndEula();
}

TEST_F(RemoteSuggestionsSchedulerImplTest,
       ShouldRescheduleAfterSuccessfulFetch) {
  // First reschedule on becoming active.
  EXPECT_CALL(*persistent_scheduler(), Schedule(_, _)).Times(2);
  ActivateProviderAndEula();

  RemoteSuggestionsProvider::FetchStatusCallback signal_fetch_done;
  EXPECT_CALL(*provider(), RefetchInTheBackground(_))
      .WillOnce(SaveArgByMove<0>(&signal_fetch_done));

  // Trigger a fetch.
  scheduler()->OnPersistentSchedulerWakeUp();
  // Second reschedule after a successful fetch.
  std::move(signal_fetch_done).Run(Status::Success());
}

TEST_F(RemoteSuggestionsSchedulerImplTest,
       ShouldNotRescheduleAfterFailedFetch) {
  // Only reschedule on becoming active.
  EXPECT_CALL(*persistent_scheduler(), Schedule(_, _));
  ActivateProviderAndEula();

  RemoteSuggestionsProvider::FetchStatusCallback signal_fetch_done;
  EXPECT_CALL(*provider(), RefetchInTheBackground(_))
      .WillOnce(SaveArgByMove<0>(&signal_fetch_done));

  // Trigger a fetch.
  scheduler()->OnPersistentSchedulerWakeUp();
  // No furter reschedule after a failure.
  std::move(signal_fetch_done).Run(Status(StatusCode::PERMANENT_ERROR, ""));
}

TEST_F(RemoteSuggestionsSchedulerImplTest, ShouldScheduleOnlyOnce) {
  EXPECT_CALL(*persistent_scheduler(), Schedule(_, _));
  ActivateProviderAndEula();
  // No further call to Schedule on a second status callback.
  ActivateProviderAndEula();
}

TEST_F(RemoteSuggestionsSchedulerImplTest, ShouldUnscheduleOnlyOnce) {
  {
    InSequence s;
    EXPECT_CALL(*persistent_scheduler(), Schedule(_, _));
    EXPECT_CALL(*persistent_scheduler(), Unschedule());
  }
  // First schedule so that later we really unschedule.
  ActivateProviderAndEula();
  DeactivateProvider();
  // No further call to Unschedule on second status callback.
  DeactivateProvider();
}

TEST_F(RemoteSuggestionsSchedulerImplTest,
       ReschedulesWhenPersistentWifiParamChanges) {
  EXPECT_CALL(*persistent_scheduler(), Schedule(_, _)).Times(2);
  ActivateProviderAndEula();

  // UserClassifier defaults to UserClass::ACTIVE_NTP_USER if PrefService is
  // null. Change the wifi interval for this class.
  SetVariationParameter("fetching_interval_hours-wifi-active_ntp_user", "1.5");

  // Schedule() should get called for the second time after params have changed.
  ActivateProviderAndEula();
}

TEST_F(RemoteSuggestionsSchedulerImplTest,
       ReschedulesWhenPersistentFallbackParamChanges) {
  EXPECT_CALL(*persistent_scheduler(), Schedule(_, _)).Times(2);
  ActivateProviderAndEula();

  // UserClassifier defaults to UserClass::ACTIVE_NTP_USER if PrefService is
  // null. Change the fallback interval for this class.
  SetVariationParameter("fetching_interval_hours-fallback-active_ntp_user",
                        "1.5");

  // Schedule() should get called for the second time after params have changed.
  ActivateProviderAndEula();
}

TEST_F(RemoteSuggestionsSchedulerImplTest,
       ReschedulesWhenShownWifiParamChanges) {
  EXPECT_CALL(*persistent_scheduler(), Schedule(_, _)).Times(2);
  ActivateProviderAndEula();

  // UserClassifier defaults to UserClass::ACTIVE_NTP_USER if PrefService is
  // null. Change the on usage interval for this class.
  SetVariationParameter("soft_fetching_interval_hours-wifi-active_ntp_user",
                        "1.5");

  // Schedule() should get called for the second time after params have changed.
  ActivateProviderAndEula();
}

TEST_F(RemoteSuggestionsSchedulerImplTest,
       ReschedulesWhenShownFallbackParamChanges) {
  EXPECT_CALL(*persistent_scheduler(), Schedule(_, _)).Times(2);
  ActivateProviderAndEula();

  // UserClassifier defaults to UserClass::ACTIVE_NTP_USER if PrefService is
  // null. Change the fallback interval for this class.
  SetVariationParameter("soft_fetching_interval_hours-fallback-active_ntp_user",
                        "1.5");

  // Schedule() should get called for the second time after params have changed.
  ActivateProviderAndEula();
}

TEST_F(RemoteSuggestionsSchedulerImplTest,
       ReschedulesWhenStartupWifiParamChanges) {
  EXPECT_CALL(*persistent_scheduler(), Schedule(_, _)).Times(2);
  ActivateProviderAndEula();

  // UserClassifier defaults to UserClass::ACTIVE_NTP_USER if PrefService is
  // null. Change the on usage interval for this class.
  SetVariationParameter("startup_fetching_interval_hours-wifi-active_ntp_user",
                        "1.5");

  // Schedule() should get called for the second time after params have changed.
  ActivateProviderAndEula();
}

TEST_F(RemoteSuggestionsSchedulerImplTest,
       ReschedulesWhenStartupFallbackParamChanges) {
  EXPECT_CALL(*persistent_scheduler(), Schedule(_, _)).Times(2);
  ActivateProviderAndEula();

  // UserClassifier defaults to UserClass::ACTIVE_NTP_USER if PrefService is
  // null. Change the fallback interval for this class.
  SetVariationParameter(
      "startup_fetching_interval_hours-fallback-active_ntp_user", "1.5");

  // Schedule() should get called for the second time after params have changed.
  ActivateProviderAndEula();
}

TEST_F(RemoteSuggestionsSchedulerImplTest, FetchIntervalForShownTriggerOnWifi) {
  // Pretend we are on WiFi (already done in ctor, we make it explicit here).
  EXPECT_CALL(*persistent_scheduler(), IsOnUnmeteredConnection())
      .WillRepeatedly(Return(true));

  // Initial scheduling after being enabled.
  EXPECT_CALL(*persistent_scheduler(), Schedule(_, _));
  ActivateProviderAndEula();

  // The first call to NTPOpened results in a fetch.
  RemoteSuggestionsProvider::FetchStatusCallback signal_fetch_done;
  EXPECT_CALL(*provider(), RefetchInTheBackground(_))
      .WillOnce(SaveArgByMove<0>(&signal_fetch_done));
  scheduler()->OnSuggestionsSurfaceOpened();
  // Rescheduling after a succesful fetch.
  EXPECT_CALL(*persistent_scheduler(), Schedule(_, _));
  std::move(signal_fetch_done).Run(Status::Success());

  // Open NTP again after too short delay (one minute missing). UserClassifier
  // defaults to UserClass::ACTIVE_NTP_USER - we work with the default interval
  // for this class here. This time no fetch is executed.
  test_clock()->Advance(base::TimeDelta::FromHours(4) -
                        base::TimeDelta::FromMinutes(1));
  scheduler()->OnSuggestionsSurfaceOpened();

  // Open NTP after another delay, now together long enough to issue a fetch.
  test_clock()->Advance(base::TimeDelta::FromMinutes(2));
  EXPECT_CALL(*provider(), RefetchInTheBackground(_));
  scheduler()->OnSuggestionsSurfaceOpened();
}

TEST_F(RemoteSuggestionsSchedulerImplTest,
       OverrideFetchIntervalForShownTriggerOnWifi) {
  // Pretend we are on WiFi (already done in ctor, we make it explicit here).
  EXPECT_CALL(*persistent_scheduler(), IsOnUnmeteredConnection())
      .WillRepeatedly(Return(true));
  // UserClassifier defaults to UserClass::ACTIVE_NTP_USER if PrefService is
  // null. Change the interval for this class from 4h to 30min.
  SetVariationParameter("soft_fetching_interval_hours-wifi-active_ntp_user",
                        "0.5");

  // Initial scheduling after being enabled.
  EXPECT_CALL(*persistent_scheduler(), Schedule(_, _));
  ActivateProviderAndEula();

  // The first call to NTPOpened results in a fetch.
  RemoteSuggestionsProvider::FetchStatusCallback signal_fetch_done;
  EXPECT_CALL(*provider(), RefetchInTheBackground(_))
      .WillOnce(SaveArgByMove<0>(&signal_fetch_done));
  scheduler()->OnSuggestionsSurfaceOpened();
  // Rescheduling after a succesful fetch.
  EXPECT_CALL(*persistent_scheduler(), Schedule(_, _));
  std::move(signal_fetch_done).Run(Status::Success());

  // Open NTP again after too short delay. This time no fetch is executed.
  test_clock()->Advance(base::TimeDelta::FromMinutes(20));
  scheduler()->OnSuggestionsSurfaceOpened();

  // Open NTP after another delay, now together long enough to issue a fetch.
  test_clock()->Advance(base::TimeDelta::FromMinutes(10));
  EXPECT_CALL(*provider(), RefetchInTheBackground(_));
  scheduler()->OnSuggestionsSurfaceOpened();
}

TEST_F(RemoteSuggestionsSchedulerImplTest,
       FetchIntervalForShownTriggerOnFallback) {
  // Pretend we are not on wifi -> fallback connection.
  EXPECT_CALL(*persistent_scheduler(), IsOnUnmeteredConnection())
      .WillRepeatedly(Return(false));
  // UserClassifier defaults to UserClass::ACTIVE_NTP_USER which uses a 12h time
  // interval by default for shown trigger not on WiFi.

  // Initial scheduling after being enabled.
  EXPECT_CALL(*persistent_scheduler(), Schedule(_, _));
  ActivateProviderAndEula();

  // The first call to NTPOpened results in a fetch.
  RemoteSuggestionsProvider::FetchStatusCallback signal_fetch_done;
  EXPECT_CALL(*provider(), RefetchInTheBackground(_))
      .WillOnce(SaveArgByMove<0>(&signal_fetch_done));
  scheduler()->OnSuggestionsSurfaceOpened();
  // Rescheduling after a succesful fetch.
  EXPECT_CALL(*persistent_scheduler(), Schedule(_, _));
  std::move(signal_fetch_done).Run(Status::Success());

  // Open NTP again after too short delay. This time no fetch is executed.
  test_clock()->Advance(base::TimeDelta::FromHours(4) -
                        base::TimeDelta::FromMinutes(1));
  scheduler()->OnSuggestionsSurfaceOpened();

  // Open NTP after another delay, now together long enough to issue a fetch.
  test_clock()->Advance(base::TimeDelta::FromMinutes(2));
  EXPECT_CALL(*provider(), RefetchInTheBackground(_));
  scheduler()->OnSuggestionsSurfaceOpened();
}

TEST_F(RemoteSuggestionsSchedulerImplTest,
       OverrideFetchIntervalForShownTriggerOnFallback) {
  // Pretend we are not on wifi -> fallback connection.
  EXPECT_CALL(*persistent_scheduler(), IsOnUnmeteredConnection())
      .WillRepeatedly(Return(false));
  // UserClassifier defaults to UserClass::ACTIVE_NTP_USER if PrefService is
  // null. Change the interval for this class from 4h to 30min.
  SetVariationParameter("soft_fetching_interval_hours-fallback-active_ntp_user",
                        "0.5");

  // Initial scheduling after being enabled.
  EXPECT_CALL(*persistent_scheduler(), Schedule(_, _));
  ActivateProviderAndEula();

  // The first call to NTPOpened results in a fetch.
  RemoteSuggestionsProvider::FetchStatusCallback signal_fetch_done;
  EXPECT_CALL(*provider(), RefetchInTheBackground(_))
      .WillOnce(SaveArgByMove<0>(&signal_fetch_done));
  scheduler()->OnSuggestionsSurfaceOpened();
  // Rescheduling after a succesful fetch.
  EXPECT_CALL(*persistent_scheduler(), Schedule(_, _));
  std::move(signal_fetch_done).Run(Status::Success());

  // Open NTP again after too short delay. This time no fetch is executed.
  test_clock()->Advance(base::TimeDelta::FromMinutes(20));
  scheduler()->OnSuggestionsSurfaceOpened();

  // Open NTP after another delay, now together long enough to issue a fetch.
  test_clock()->Advance(base::TimeDelta::FromMinutes(10));
  EXPECT_CALL(*provider(), RefetchInTheBackground(_));
  scheduler()->OnSuggestionsSurfaceOpened();
}

TEST_F(RemoteSuggestionsSchedulerImplTest,
       ShouldBlockFetchingForSomeTimeAfterHistoryCleared) {
  // First enable the scheduler -- this will trigger the persistent scheduling.
  EXPECT_CALL(*persistent_scheduler(), Schedule(_, _));
  ActivateProviderAndEula();
  // Clear the history.
  scheduler()->OnHistoryCleared();

  // A trigger after 15 minutes is ignored.
  test_clock()->Advance(base::TimeDelta::FromMinutes(15));
  scheduler()->OnBrowserForegrounded();

  // A trigger after another 16 minutes is performed (more than 30m after
  // clearing the history).
  EXPECT_CALL(*provider(), RefetchWhileDisplaying(_));
  test_clock()->Advance(base::TimeDelta::FromMinutes(16));
  scheduler()->OnBrowserForegrounded();
}

TEST_F(RemoteSuggestionsSchedulerImplTest,
       ShouldImmediatelyFetchAfterSuggestionsCleared) {
  RemoteSuggestionsProvider::FetchStatusCallback signal_fetch_done;

  // First enable the scheduler -- this will trigger the persistent scheduling.
  EXPECT_CALL(*persistent_scheduler(), Schedule(_, _));
  ActivateProviderAndEula();

  // The first trigger results in a fetch.
  EXPECT_CALL(*provider(), RefetchInTheBackground(_))
      .WillOnce(SaveArgByMove<0>(&signal_fetch_done));
  scheduler()->OnBrowserForegrounded();
  // Make the fetch successful -- this results in rescheduling.
  EXPECT_CALL(*persistent_scheduler(), Schedule(_, _));
  std::move(signal_fetch_done).Run(Status::Success());

  // Clear the suggestions - results in an immediate fetch.
  EXPECT_CALL(*provider(), RefetchWhileDisplaying(_));
  scheduler()->OnSuggestionsCleared();
}

TEST_F(RemoteSuggestionsSchedulerImplTest, ShouldThrottleInteractiveRequests) {
  // Change the quota for interactive requests ("active NTP user" is the default
  // class in tests).
  SetVariationParameter("interactive_quota_SuggestionFetcherActiveNTPUser",
                        "10");
  ResetProvider();

  for (int x = 0; x < 10; ++x) {
    EXPECT_THAT(scheduler()->AcquireQuotaForInteractiveFetch(), Eq(true));
  }

  // Now the quota is over.
  EXPECT_THAT(scheduler()->AcquireQuotaForInteractiveFetch(), Eq(false));
}

TEST_F(RemoteSuggestionsSchedulerImplTest,
       ShouldThrottleNonInteractiveRequests) {
  // Change the quota for interactive requests ("active NTP user" is the default
  // class in tests).
  SetVariationParameter("quota_SuggestionFetcherActiveNTPUser", "5");
  ResetProvider();

  // One scheduling on start, 5 times after successful fetches.
  EXPECT_CALL(*persistent_scheduler(), Schedule(_, _)).Times(6);

  // First enable the scheduler -- this will trigger the persistent scheduling.
  ActivateProviderAndEula();

  // As long as the quota suffices, the call gets through.
  RemoteSuggestionsProvider::FetchStatusCallback signal_fetch_done;
  EXPECT_CALL(*provider(), RefetchInTheBackground(_))
      .Times(5)
      .WillRepeatedly(SaveArgByMove<0>(&signal_fetch_done));
  for (int x = 0; x < 5; ++x) {
    scheduler()->OnPersistentSchedulerWakeUp();
    std::move(signal_fetch_done).Run(Status::Success());
  }

  // For the 6th time, it is blocked by the scheduling provider.
  scheduler()->OnPersistentSchedulerWakeUp();
}

TEST_F(RemoteSuggestionsSchedulerImplTest,
       ShouldIgnoreSubsequentStartupSignalsForM58) {
  base::test::ScopedFeatureList feature_list;
  feature_list.InitAndEnableFeature(
      kRemoteSuggestionsEmulateM58FetchingSchedule);
  RemoteSuggestionsProvider::FetchStatusCallback signal_fetch_done;

  // First enable the scheduler -- this will trigger the persistent scheduling.
  EXPECT_CALL(*persistent_scheduler(), Schedule(_, _));
  ActivateProviderAndEula();

  // The startup triggers are ignored.
  EXPECT_CALL(*provider(), RefetchInTheBackground(_)).Times(0);
  scheduler()->OnBrowserForegrounded();
  scheduler()->OnBrowserColdStart();

  // Foreground the browser again after a very long delay. Again, no fetch is
  // executed for neither Foregrounded, nor ColdStart.
  test_clock()->Advance(base::TimeDelta::FromHours(100000));
  scheduler()->OnBrowserForegrounded();
  scheduler()->OnBrowserColdStart();
}

TEST_F(RemoteSuggestionsSchedulerImplTest, ShouldIgnoreSignalsWhenOffline) {
  // Simulate being offline. NetworkChangeNotifier is a singleton, thus, this
  // instance is actually globally accessible (from the static function
  // NetworkChangeNotifier::IsOffline() that is called from the scheduler).
  FakeOfflineNetworkChangeNotifier fake;

  // Activating the provider should schedule the persistent background fetches.
  EXPECT_CALL(*persistent_scheduler(), Schedule(_, _));
  ActivateProviderAndEula();

  // All signals are ignored because of being offline.
  EXPECT_CALL(*provider(), RefetchInTheBackground(_)).Times(0);
  scheduler()->OnPersistentSchedulerWakeUp();
  scheduler()->OnSuggestionsSurfaceOpened();
  scheduler()->OnBrowserForegrounded();
  scheduler()->OnBrowserColdStart();
}

TEST_F(RemoteSuggestionsSchedulerImplTest,
       ShouldNotRefetchWhileDisplayingBeforeDefaultDelay) {
  // Activating the provider should schedule the persistent background fetches.
  EXPECT_CALL(*persistent_scheduler(), Schedule(_, _)).Times(2);
  // First enable the scheduler -- this will trigger the persistent scheduling.
  ActivateProviderAndEula();

  // The first refetch is never considered due to staleness.
  RemoteSuggestionsProvider::FetchStatusCallback signal_fetch_done;
  EXPECT_CALL(*provider(), RefetchInTheBackground(_))
      .WillOnce(SaveArgByMove<0>(&signal_fetch_done));
  scheduler()->OnBrowserForegrounded();
  std::move(signal_fetch_done).Run(Status::Success());

  // The staleness threshold by default equals to the startup interval.
  test_clock()->Advance(
      base::TimeDelta::FromHours(kDefaultStartupIntervalHours) -
      base::TimeDelta::FromMinutes(1));

  // Not long enough: non-stale.
  EXPECT_CALL(*provider(), RefetchWhileDisplaying(_)).Times(0);
  EXPECT_CALL(*provider(), RefetchInTheBackground(_));
  // Use the SurfaceOpened trigger as this has the shortest intervals and thus
  // allows to test both short and long delay in the same way.
  scheduler()->OnSuggestionsSurfaceOpened();
}

TEST_F(RemoteSuggestionsSchedulerImplTest,
       ShouldRefetchWhileDisplayingAfterDefaultDelay) {
  // Activating the provider should schedule the persistent background fetches.
  EXPECT_CALL(*persistent_scheduler(), Schedule(_, _)).Times(2);
  // First enable the scheduler -- this will trigger the persistent scheduling.
  ActivateProviderAndEula();

  // The first refetch is never considered due to staleness.
  RemoteSuggestionsProvider::FetchStatusCallback signal_fetch_done;
  EXPECT_CALL(*provider(), RefetchInTheBackground(_))
      .WillOnce(SaveArgByMove<0>(&signal_fetch_done));
  scheduler()->OnBrowserForegrounded();
  std::move(signal_fetch_done).Run(Status::Success());

  // The staleness threshold by default equals to the startup interval.
  test_clock()->Advance(
      base::TimeDelta::FromHours(kDefaultStartupIntervalHours) +
      base::TimeDelta::FromMinutes(1));

  // Long enough: stale.
  EXPECT_CALL(*provider(), RefetchWhileDisplaying(_));
  EXPECT_CALL(*provider(), RefetchInTheBackground(_)).Times(0);
  // Use the SurfaceOpened trigger as this has the shortest intervals and thus
  // allows to test both short and long delay in the same way.
  scheduler()->OnSuggestionsSurfaceOpened();
}

TEST_F(RemoteSuggestionsSchedulerImplTest,
       ShouldNotRefetchWhileDisplayingBeforeConfigurableDelay) {
  constexpr int kStaleHours = 18;
  SetVariationParameter("min_age_for_stale_fetch_hours",
                        base::IntToString(kStaleHours));
  // Activating the provider should schedule the persistent background fetches.
  EXPECT_CALL(*persistent_scheduler(), Schedule(_, _)).Times(2);
  // First enable the scheduler -- this will trigger the persistent scheduling.
  ActivateProviderAndEula();

  // The first refetch is never considered due to staleness.
  RemoteSuggestionsProvider::FetchStatusCallback signal_fetch_done;
  EXPECT_CALL(*provider(), RefetchInTheBackground(_))
      .WillOnce(SaveArgByMove<0>(&signal_fetch_done));
  scheduler()->OnBrowserForegrounded();
  std::move(signal_fetch_done).Run(Status::Success());

  // The staleness threshold by default equals to the startup interval.
  test_clock()->Advance(base::TimeDelta::FromHours(kStaleHours) -
                        base::TimeDelta::FromMinutes(1));

  // Not long enough: non-stale.
  EXPECT_CALL(*provider(), RefetchWhileDisplaying(_)).Times(0);
  EXPECT_CALL(*provider(), RefetchInTheBackground(_));
  // Use the SurfaceOpened trigger as this has the shortest intervals and thus
  // allows to test both short and long delay in the same way.
  scheduler()->OnSuggestionsSurfaceOpened();
}

TEST_F(RemoteSuggestionsSchedulerImplTest,
       ShouldRefetchWhileDisplayingAfterConfigurableDelay) {
  constexpr int kStaleHours = 18;
  SetVariationParameter("min_age_for_stale_fetch_hours",
                        base::IntToString(kStaleHours));
  // Activating the provider should schedule the persistent background fetches.
  EXPECT_CALL(*persistent_scheduler(), Schedule(_, _)).Times(2);
  // First enable the scheduler -- this will trigger the persistent scheduling.
  ActivateProviderAndEula();

  // The first refetch is never considered due to staleness.
  RemoteSuggestionsProvider::FetchStatusCallback signal_fetch_done;
  EXPECT_CALL(*provider(), RefetchInTheBackground(_))
      .WillOnce(SaveArgByMove<0>(&signal_fetch_done));
  scheduler()->OnBrowserForegrounded();
  std::move(signal_fetch_done).Run(Status::Success());

  test_clock()->Advance(base::TimeDelta::FromHours(kStaleHours) +
                        base::TimeDelta::FromMinutes(1));

  // Long enough: stale.
  EXPECT_CALL(*provider(), RefetchWhileDisplaying(_));
  EXPECT_CALL(*provider(), RefetchInTheBackground(_)).Times(0);
  // Use the SurfaceOpened trigger as this has the shortest intervals and thus
  // allows to test both short and long delay in the same way.
  scheduler()->OnSuggestionsSurfaceOpened();
}

TEST_F(RemoteSuggestionsSchedulerImplTest,
       ShouldNotRefetchWhileDisplayingBeforeFallbackConfigurableDelay) {
  constexpr int kStartupHours = 12;
  SetVariationParameter("startup_fetching_interval_hours-wifi-active_ntp_user",
                        base::IntToString(kStartupHours));
  // Activating the provider should schedule the persistent background fetches.
  EXPECT_CALL(*persistent_scheduler(), Schedule(_, _)).Times(2);
  // First enable the scheduler -- this will trigger the persistent scheduling.
  ActivateProviderAndEula();

  // The first refetch is never considered due to staleness.
  RemoteSuggestionsProvider::FetchStatusCallback signal_fetch_done;
  EXPECT_CALL(*provider(), RefetchInTheBackground(_))
      .WillOnce(SaveArgByMove<0>(&signal_fetch_done));
  scheduler()->OnBrowserForegrounded();
  std::move(signal_fetch_done).Run(Status::Success());

  // The staleness threshold by default equals to the startup interval.
  test_clock()->Advance(base::TimeDelta::FromHours(kStartupHours) -
                        base::TimeDelta::FromMinutes(1));

  // Not long enough: non-stale.
  EXPECT_CALL(*provider(), RefetchWhileDisplaying(_)).Times(0);
  EXPECT_CALL(*provider(), RefetchInTheBackground(_));
  // Use the SurfaceOpened trigger as this has the shortest intervals and thus
  // allows to test both short and long delay in the same way.
  scheduler()->OnSuggestionsSurfaceOpened();
}

TEST_F(RemoteSuggestionsSchedulerImplTest,
       ShouldRefetchWhileDisplayingAfterFallbackConfigurableDelay) {
  constexpr int kStartupHours = 12;
  SetVariationParameter("startup_fetching_interval_hours-wifi-active_ntp_user",
                        base::IntToString(kStartupHours));
  // Activating the provider should schedule the persistent background fetches.
  EXPECT_CALL(*persistent_scheduler(), Schedule(_, _)).Times(2);
  // First enable the scheduler -- this will trigger the persistent scheduling.
  ActivateProviderAndEula();

  // The first refetch is never considered due to staleness.
  RemoteSuggestionsProvider::FetchStatusCallback signal_fetch_done;
  EXPECT_CALL(*provider(), RefetchInTheBackground(_))
      .WillOnce(SaveArgByMove<0>(&signal_fetch_done));
  scheduler()->OnBrowserForegrounded();
  std::move(signal_fetch_done).Run(Status::Success());

  test_clock()->Advance(base::TimeDelta::FromHours(kStartupHours) +
                        base::TimeDelta::FromMinutes(1));

  // Long enough: stale.
  EXPECT_CALL(*provider(), RefetchWhileDisplaying(_));
  EXPECT_CALL(*provider(), RefetchInTheBackground(_)).Times(0);
  // Use the SurfaceOpened trigger as this has the shortest intervals and thus
  // allows to test both short and long delay in the same way.
  scheduler()->OnSuggestionsSurfaceOpened();
}

}  // namespace ntp_snippets