1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311
|
// Copyright 2017 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "components/ntp_snippets/user_classifier.h"
#include <memory>
#include <string>
#include <utility>
#include "base/test/metrics/histogram_tester.h"
#include "base/test/simple_test_clock.h"
#include "base/time/time.h"
#include "components/ntp_snippets/features.h"
#include "components/ntp_snippets/ntp_snippets_constants.h"
#include "components/prefs/pref_registry_simple.h"
#include "components/prefs/testing_pref_service.h"
#include "components/variations/variations_params_manager.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
using testing::DoubleNear;
using testing::Eq;
using testing::Gt;
using testing::Lt;
using testing::SizeIs;
namespace ntp_snippets {
namespace {
char kNowString[] = "2017-03-01 10:45";
class UserClassifierTest : public testing::Test {
public:
UserClassifierTest() {
UserClassifier::RegisterProfilePrefs(test_prefs_.registry());
}
UserClassifier* CreateUserClassifier() {
base::Time now;
CHECK(base::Time::FromUTCString(kNowString, &now));
test_clock_.SetNow(now);
user_classifier_ =
std::make_unique<UserClassifier>(&test_prefs_, &test_clock_);
return user_classifier_.get();
}
base::SimpleTestClock* test_clock() { return &test_clock_; }
private:
TestingPrefServiceSimple test_prefs_;
std::unique_ptr<UserClassifier> user_classifier_;
base::SimpleTestClock test_clock_;
DISALLOW_COPY_AND_ASSIGN(UserClassifierTest);
};
TEST_F(UserClassifierTest, ShouldBeActiveNtpUserInitially) {
UserClassifier* user_classifier = CreateUserClassifier();
EXPECT_THAT(user_classifier->GetUserClass(),
Eq(UserClassifier::UserClass::ACTIVE_NTP_USER));
}
TEST_F(UserClassifierTest,
ShouldBecomeActiveSuggestionsConsumerByClickingOften) {
UserClassifier* user_classifier = CreateUserClassifier();
// After one click still only an active user.
user_classifier->OnEvent(UserClassifier::Metric::SUGGESTIONS_USED);
EXPECT_THAT(user_classifier->GetUserClass(),
Eq(UserClassifier::UserClass::ACTIVE_NTP_USER));
// After a few more clicks, become an active consumer.
for (int i = 0; i < 5; i++) {
test_clock()->Advance(base::TimeDelta::FromHours(1));
user_classifier->OnEvent(UserClassifier::Metric::SUGGESTIONS_USED);
}
EXPECT_THAT(user_classifier->GetUserClass(),
Eq(UserClassifier::UserClass::ACTIVE_SUGGESTIONS_CONSUMER));
}
TEST_F(UserClassifierTest,
ShouldBecomeActiveSuggestionsConsumerByClickingOftenWithDecreasedParam) {
// Increase the param to one half.
variations::testing::VariationParamsManager variation_params(
kArticleSuggestionsFeature.name,
{{"user_classifier_active_consumer_clicks_at_least_once_per_hours",
"36"}},
{kArticleSuggestionsFeature.name});
UserClassifier* user_classifier = CreateUserClassifier();
// After two clicks still only an active user.
user_classifier->OnEvent(UserClassifier::Metric::SUGGESTIONS_USED);
test_clock()->Advance(base::TimeDelta::FromHours(1));
user_classifier->OnEvent(UserClassifier::Metric::SUGGESTIONS_USED);
EXPECT_THAT(user_classifier->GetUserClass(),
Eq(UserClassifier::UserClass::ACTIVE_NTP_USER));
// One more click to become an active consumer.
test_clock()->Advance(base::TimeDelta::FromHours(1));
user_classifier->OnEvent(UserClassifier::Metric::SUGGESTIONS_USED);
EXPECT_THAT(user_classifier->GetUserClass(),
Eq(UserClassifier::UserClass::ACTIVE_SUGGESTIONS_CONSUMER));
}
TEST_F(UserClassifierTest, ShouldBecomeRareNtpUserByNoActivity) {
UserClassifier* user_classifier = CreateUserClassifier();
// After two days of waiting still an active user.
test_clock()->Advance(base::TimeDelta::FromDays(2));
EXPECT_THAT(user_classifier->GetUserClass(),
Eq(UserClassifier::UserClass::ACTIVE_NTP_USER));
// Two more days to become a rare user.
test_clock()->Advance(base::TimeDelta::FromDays(2));
EXPECT_THAT(user_classifier->GetUserClass(),
Eq(UserClassifier::UserClass::RARE_NTP_USER));
}
TEST_F(UserClassifierTest,
ShouldBecomeRareNtpUserByNoActivityWithDecreasedParam) {
// Decrease the param to one half.
variations::testing::VariationParamsManager variation_params(
kArticleSuggestionsFeature.name,
{{"user_classifier_rare_user_opens_ntp_at_most_once_per_hours", "48"}},
{kArticleSuggestionsFeature.name});
UserClassifier* user_classifier = CreateUserClassifier();
// After one days of waiting still an active user.
test_clock()->Advance(base::TimeDelta::FromDays(1));
EXPECT_THAT(user_classifier->GetUserClass(),
Eq(UserClassifier::UserClass::ACTIVE_NTP_USER));
// One more day to become a rare user.
test_clock()->Advance(base::TimeDelta::FromDays(1));
EXPECT_THAT(user_classifier->GetUserClass(),
Eq(UserClassifier::UserClass::RARE_NTP_USER));
}
class UserClassifierMetricTest
: public UserClassifierTest,
public ::testing::WithParamInterface<
std::pair<UserClassifier::Metric, std::string>> {
public:
UserClassifierMetricTest() {}
private:
DISALLOW_COPY_AND_ASSIGN(UserClassifierMetricTest);
};
TEST_P(UserClassifierMetricTest, ShouldDecreaseEstimateAfterEvent) {
UserClassifier::Metric metric = GetParam().first;
UserClassifier* user_classifier = CreateUserClassifier();
// The initial event does not decrease the estimate.
user_classifier->OnEvent(metric);
for (int i = 0; i < 10; i++) {
test_clock()->Advance(base::TimeDelta::FromHours(1));
double old_metric = user_classifier->GetEstimatedAvgTime(metric);
user_classifier->OnEvent(metric);
EXPECT_THAT(user_classifier->GetEstimatedAvgTime(metric), Lt(old_metric));
}
}
TEST_P(UserClassifierMetricTest, ShouldReportToUmaOnEvent) {
UserClassifier::Metric metric = GetParam().first;
const std::string& histogram_name = GetParam().second;
base::HistogramTester histogram_tester;
UserClassifier* user_classifier = CreateUserClassifier();
user_classifier->OnEvent(metric);
EXPECT_THAT(histogram_tester.GetAllSamples(histogram_name), SizeIs(1));
}
TEST_P(UserClassifierMetricTest, ShouldConvergeTowardsPattern) {
UserClassifier::Metric metric = GetParam().first;
UserClassifier* user_classifier = CreateUserClassifier();
// Have the pattern of an event every five hours and start changing it towards
// an event every 10 hours.
for (int i = 0; i < 100; i++) {
test_clock()->Advance(base::TimeDelta::FromHours(5));
user_classifier->OnEvent(metric);
}
EXPECT_THAT(user_classifier->GetEstimatedAvgTime(metric),
DoubleNear(5.0, 0.1));
for (int i = 0; i < 3; i++) {
test_clock()->Advance(base::TimeDelta::FromHours(10));
user_classifier->OnEvent(metric);
}
EXPECT_THAT(user_classifier->GetEstimatedAvgTime(metric), Gt(5.5));
for (int i = 0; i < 100; i++) {
test_clock()->Advance(base::TimeDelta::FromHours(10));
user_classifier->OnEvent(metric);
}
EXPECT_THAT(user_classifier->GetEstimatedAvgTime(metric),
DoubleNear(10.0, 0.1));
}
TEST_P(UserClassifierMetricTest, ShouldIgnoreSubsequentEventsForHalfAnHour) {
UserClassifier::Metric metric = GetParam().first;
UserClassifier* user_classifier = CreateUserClassifier();
// The initial event
user_classifier->OnEvent(metric);
// Subsequent events get ignored for the next 30 minutes.
for (int i = 0; i < 5; i++) {
test_clock()->Advance(base::TimeDelta::FromMinutes(5));
double old_metric = user_classifier->GetEstimatedAvgTime(metric);
user_classifier->OnEvent(metric);
EXPECT_THAT(user_classifier->GetEstimatedAvgTime(metric), Eq(old_metric));
}
// An event 30 minutes after the initial event is finally not ignored.
test_clock()->Advance(base::TimeDelta::FromMinutes(5));
double old_metric = user_classifier->GetEstimatedAvgTime(metric);
user_classifier->OnEvent(metric);
EXPECT_THAT(user_classifier->GetEstimatedAvgTime(metric), Lt(old_metric));
}
TEST_P(UserClassifierMetricTest,
ShouldIgnoreSubsequentEventsWithIncreasedLimit) {
UserClassifier::Metric metric = GetParam().first;
// Increase the min_hours to 1.0, i.e. 60 minutes.
variations::testing::VariationParamsManager variation_params(
kArticleSuggestionsFeature.name, {{"user_classifier_min_hours", "1.0"}},
{kArticleSuggestionsFeature.name});
UserClassifier* user_classifier = CreateUserClassifier();
// The initial event
user_classifier->OnEvent(metric);
// Subsequent events get ignored for the next 60 minutes.
for (int i = 0; i < 11; i++) {
test_clock()->Advance(base::TimeDelta::FromMinutes(5));
double old_metric = user_classifier->GetEstimatedAvgTime(metric);
user_classifier->OnEvent(metric);
EXPECT_THAT(user_classifier->GetEstimatedAvgTime(metric), Eq(old_metric));
}
// An event 60 minutes after the initial event is finally not ignored.
test_clock()->Advance(base::TimeDelta::FromMinutes(5));
double old_metric = user_classifier->GetEstimatedAvgTime(metric);
user_classifier->OnEvent(metric);
EXPECT_THAT(user_classifier->GetEstimatedAvgTime(metric), Lt(old_metric));
}
TEST_P(UserClassifierMetricTest, ShouldCapDelayBetweenEvents) {
UserClassifier::Metric metric = GetParam().first;
UserClassifier* user_classifier = CreateUserClassifier();
// The initial event
user_classifier->OnEvent(metric);
// Wait for an insane amount of time
test_clock()->Advance(base::TimeDelta::FromDays(365));
user_classifier->OnEvent(metric);
double metric_after_a_year = user_classifier->GetEstimatedAvgTime(metric);
// Now repeat the same with s/one year/one week.
user_classifier->ClearClassificationForDebugging();
user_classifier->OnEvent(metric);
test_clock()->Advance(base::TimeDelta::FromDays(7));
user_classifier->OnEvent(metric);
// The results should be the same.
EXPECT_THAT(user_classifier->GetEstimatedAvgTime(metric),
Eq(metric_after_a_year));
}
TEST_P(UserClassifierMetricTest,
ShouldCapDelayBetweenEventsWithDecreasedLimit) {
UserClassifier::Metric metric = GetParam().first;
// Decrease the max_hours to 72, i.e. 3 days.
variations::testing::VariationParamsManager variation_params(
kArticleSuggestionsFeature.name, {{"user_classifier_max_hours", "72"}},
{kArticleSuggestionsFeature.name});
UserClassifier* user_classifier = CreateUserClassifier();
// The initial event
user_classifier->OnEvent(metric);
// Wait for an insane amount of time
test_clock()->Advance(base::TimeDelta::FromDays(365));
user_classifier->OnEvent(metric);
double metric_after_a_year = user_classifier->GetEstimatedAvgTime(metric);
// Now repeat the same with s/one year/two days.
user_classifier->ClearClassificationForDebugging();
user_classifier->OnEvent(metric);
test_clock()->Advance(base::TimeDelta::FromDays(3));
user_classifier->OnEvent(metric);
// The results should be the same.
EXPECT_THAT(user_classifier->GetEstimatedAvgTime(metric),
Eq(metric_after_a_year));
}
INSTANTIATE_TEST_CASE_P(
, // An empty prefix for the parametrized tests names (no need to
// distinguish the only instance we make here).
UserClassifierMetricTest,
testing::Values(
std::make_pair(UserClassifier::Metric::NTP_OPENED,
"NewTabPage.UserClassifier.AverageHoursToOpenNTP"),
std::make_pair(
UserClassifier::Metric::SUGGESTIONS_SHOWN,
"NewTabPage.UserClassifier.AverageHoursToShowSuggestions"),
std::make_pair(
UserClassifier::Metric::SUGGESTIONS_USED,
"NewTabPage.UserClassifier.AverageHoursToUseSuggestions")));
} // namespace
} // namespace ntp_snippets
|