1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308
|
// Copyright 2014 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "components/omnibox/browser/omnibox_popup_model.h"
#include <stddef.h>
#include <memory>
#include "base/macros.h"
#include "base/strings/utf_string_conversions.h"
#include "base/test/scoped_task_environment.h"
#include "components/omnibox/browser/autocomplete_controller.h"
#include "components/omnibox/browser/autocomplete_match.h"
#include "components/omnibox/browser/omnibox_edit_model.h"
#include "components/omnibox/browser/omnibox_popup_view.h"
#include "components/omnibox/browser/test_omnibox_client.h"
#include "components/omnibox/browser/test_omnibox_edit_controller.h"
#include "components/omnibox/browser/test_omnibox_view.h"
#include "components/omnibox/browser/test_scheme_classifier.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "ui/gfx/geometry/rect.h"
namespace {
class TestOmniboxPopupView : public OmniboxPopupView {
public:
~TestOmniboxPopupView() override {}
bool IsOpen() const override { return false; }
void InvalidateLine(size_t line) override {}
void OnLineSelected(size_t line) override {}
void UpdatePopupAppearance() override {}
void OnMatchIconUpdated(size_t match_index) override {}
void PaintUpdatesNow() override {}
void OnDragCanceled() override {}
};
} // namespace
class OmniboxPopupModelTest : public ::testing::Test {
public:
OmniboxPopupModelTest()
: view_(&controller_),
model_(&view_, &controller_, std::make_unique<TestOmniboxClient>()),
popup_model_(&popup_view_, &model_) {}
OmniboxEditModel* model() { return &model_; }
OmniboxPopupModel* popup_model() { return &popup_model_; }
private:
base::test::ScopedTaskEnvironment task_environment_;
TestOmniboxEditController controller_;
TestOmniboxView view_;
OmniboxEditModel model_;
TestOmniboxPopupView popup_view_;
OmniboxPopupModel popup_model_;
DISALLOW_COPY_AND_ASSIGN(OmniboxPopupModelTest);
};
// This verifies that the new treatment of the user's selected match in
// |SetSelectedLine()| with removed |AutocompleteResult::Selection::empty()|
// is correct in the face of various replacement versions of |empty()|.
TEST_F(OmniboxPopupModelTest, SetSelectedLine) {
ACMatches matches;
for (size_t i = 0; i < 2; ++i) {
AutocompleteMatch match(nullptr, 1000, false,
AutocompleteMatchType::URL_WHAT_YOU_TYPED);
match.keyword = base::ASCIIToUTF16("match");
match.allowed_to_be_default_match = true;
matches.push_back(match);
}
auto* result = &model()->autocomplete_controller()->result_;
AutocompleteInput input(base::UTF8ToUTF16("match"),
metrics::OmniboxEventProto::NTP,
TestSchemeClassifier());
result->AppendMatches(input, matches);
result->SortAndCull(input, nullptr);
popup_model()->OnResultChanged();
EXPECT_FALSE(popup_model()->has_selected_match());
popup_model()->SetSelectedLine(0, true, false);
EXPECT_FALSE(popup_model()->has_selected_match());
popup_model()->SetSelectedLine(0, false, false);
EXPECT_TRUE(popup_model()->has_selected_match());
}
TEST_F(OmniboxPopupModelTest, ComputeMatchMaxWidths) {
int contents_max_width, description_max_width;
const int separator_width = 10;
const int kMinimumContentsWidth = 300;
int contents_width, description_width, available_width;
// Both contents and description fit fine.
contents_width = 100;
description_width = 50;
available_width = 200;
OmniboxPopupModel::ComputeMatchMaxWidths(
contents_width, separator_width, description_width, available_width,
false, true, &contents_max_width, &description_max_width);
EXPECT_EQ(contents_width, contents_max_width);
EXPECT_EQ(description_width, description_max_width);
// Contents should be given as much space as it wants up to 300 pixels.
contents_width = 100;
description_width = 50;
available_width = 100;
OmniboxPopupModel::ComputeMatchMaxWidths(
contents_width, separator_width, description_width, available_width,
false, true, &contents_max_width, &description_max_width);
EXPECT_EQ(contents_width, contents_max_width);
EXPECT_EQ(0, description_max_width);
// Description should be hidden if it's at least 75 pixels wide but doesn't
// get 75 pixels of space.
contents_width = 300;
description_width = 100;
available_width = 384;
OmniboxPopupModel::ComputeMatchMaxWidths(
contents_width, separator_width, description_width, available_width,
false, true, &contents_max_width, &description_max_width);
EXPECT_EQ(contents_width, contents_max_width);
EXPECT_EQ(0, description_max_width);
// If contents and description are on separate lines, each can take the full
// available width.
contents_width = 300;
description_width = 100;
available_width = 384;
OmniboxPopupModel::ComputeMatchMaxWidths(
contents_width, separator_width, description_width, available_width, true,
true, &contents_max_width, &description_max_width);
EXPECT_EQ(contents_width, contents_max_width);
EXPECT_EQ(description_width, description_max_width);
// Both contents and description will be limited.
contents_width = 310;
description_width = 150;
available_width = 400;
OmniboxPopupModel::ComputeMatchMaxWidths(
contents_width, separator_width, description_width, available_width,
false, true, &contents_max_width, &description_max_width);
EXPECT_EQ(kMinimumContentsWidth, contents_max_width);
EXPECT_EQ(available_width - kMinimumContentsWidth - separator_width,
description_max_width);
// Contents takes all available space.
contents_width = 400;
description_width = 0;
available_width = 200;
OmniboxPopupModel::ComputeMatchMaxWidths(
contents_width, separator_width, description_width, available_width,
false, true, &contents_max_width, &description_max_width);
EXPECT_EQ(available_width, contents_max_width);
EXPECT_EQ(0, description_max_width);
// Large contents will be truncated but small description won't if two line
// suggestion.
contents_width = 400;
description_width = 100;
available_width = 200;
OmniboxPopupModel::ComputeMatchMaxWidths(
contents_width, separator_width, description_width, available_width, true,
true, &contents_max_width, &description_max_width);
EXPECT_EQ(available_width, contents_max_width);
EXPECT_EQ(description_width, description_max_width);
// Large description will be truncated but small contents won't if two line
// suggestion.
contents_width = 100;
description_width = 400;
available_width = 200;
OmniboxPopupModel::ComputeMatchMaxWidths(
contents_width, separator_width, description_width, available_width, true,
true, &contents_max_width, &description_max_width);
EXPECT_EQ(contents_width, contents_max_width);
EXPECT_EQ(available_width, description_max_width);
// Half and half.
contents_width = 395;
description_width = 395;
available_width = 700;
OmniboxPopupModel::ComputeMatchMaxWidths(
contents_width, separator_width, description_width, available_width,
false, true, &contents_max_width, &description_max_width);
EXPECT_EQ(345, contents_max_width);
EXPECT_EQ(345, description_max_width);
// When we disallow shrinking the contents, it should get as much space as
// it wants.
contents_width = 395;
description_width = 395;
available_width = 700;
OmniboxPopupModel::ComputeMatchMaxWidths(
contents_width, separator_width, description_width, available_width,
false, false, &contents_max_width, &description_max_width);
EXPECT_EQ(contents_width, contents_max_width);
EXPECT_EQ((available_width - contents_width - separator_width),
description_max_width);
// (available_width - separator_width) is odd, so contents gets the extra
// pixel.
contents_width = 395;
description_width = 395;
available_width = 699;
OmniboxPopupModel::ComputeMatchMaxWidths(
contents_width, separator_width, description_width, available_width,
false, true, &contents_max_width, &description_max_width);
EXPECT_EQ(345, contents_max_width);
EXPECT_EQ(344, description_max_width);
// Not enough space to draw anything.
contents_width = 1;
description_width = 1;
available_width = 0;
OmniboxPopupModel::ComputeMatchMaxWidths(
contents_width, separator_width, description_width, available_width,
false, true, &contents_max_width, &description_max_width);
EXPECT_EQ(0, contents_max_width);
EXPECT_EQ(0, description_max_width);
}
// Makes sure focus remains on the tab switch button when nothing changes,
// and leaves when it does. Exercises the ratcheting logic in
// OmniboxPopupModel::OnResultChanged().
TEST_F(OmniboxPopupModelTest, TestFocusFixing) {
ACMatches matches;
AutocompleteMatch match(nullptr, 1000, false,
AutocompleteMatchType::URL_WHAT_YOU_TYPED);
match.contents = base::ASCIIToUTF16("match1.com");
match.destination_url = GURL("http://match1.com");
match.allowed_to_be_default_match = true;
match.has_tab_match = true;
matches.push_back(match);
auto* result = &model()->autocomplete_controller()->result_;
AutocompleteInput input(base::UTF8ToUTF16("match"),
metrics::OmniboxEventProto::NTP,
TestSchemeClassifier());
result->AppendMatches(input, matches);
result->SortAndCull(input, nullptr);
popup_model()->OnResultChanged();
popup_model()->SetSelectedLine(0, true, false);
// The default state should be unfocused.
EXPECT_EQ(OmniboxPopupModel::NORMAL, popup_model()->selected_line_state());
// Focus the selection.
popup_model()->SetSelectedLine(0, false, false);
popup_model()->SetSelectedLineState(OmniboxPopupModel::TAB_SWITCH);
EXPECT_EQ(OmniboxPopupModel::TAB_SWITCH,
popup_model()->selected_line_state());
// Adding a match at end won't change that we selected first suggestion, so
// shouldn't change focused state.
matches[0].relevance = 999;
// Give it a different name so not deduped.
matches[0].contents = base::ASCIIToUTF16("match2.com");
matches[0].destination_url = GURL("http://match2.com");
result->AppendMatches(input, matches);
result->SortAndCull(input, nullptr);
popup_model()->OnResultChanged();
EXPECT_EQ(OmniboxPopupModel::TAB_SWITCH,
popup_model()->selected_line_state());
// Changing selection should change focused state.
popup_model()->SetSelectedLine(1, false, false);
EXPECT_EQ(OmniboxPopupModel::NORMAL, popup_model()->selected_line_state());
// Changing selection to same selection might change state.
popup_model()->SetSelectedLineState(OmniboxPopupModel::TAB_SWITCH);
// Letting routine filter selecting same line should not change it.
popup_model()->SetSelectedLine(1, false, false);
EXPECT_EQ(OmniboxPopupModel::TAB_SWITCH,
popup_model()->selected_line_state());
// Forcing routine to handle selecting same line should change it.
popup_model()->SetSelectedLine(1, false, true);
EXPECT_EQ(OmniboxPopupModel::NORMAL, popup_model()->selected_line_state());
// Adding a match at end will reset selection to first, so should change
// selected line, and thus focus.
popup_model()->SetSelectedLineState(OmniboxPopupModel::TAB_SWITCH);
matches[0].relevance = 999;
matches[0].contents = base::ASCIIToUTF16("match3.com");
matches[0].destination_url = GURL("http://match3.com");
result->AppendMatches(input, matches);
result->SortAndCull(input, nullptr);
popup_model()->OnResultChanged();
EXPECT_EQ(0U, popup_model()->selected_line());
EXPECT_EQ(OmniboxPopupModel::NORMAL, popup_model()->selected_line_state());
// Prepending a match won't change selection, but since URL is different,
// should clear the focus state.
popup_model()->SetSelectedLineState(OmniboxPopupModel::TAB_SWITCH);
matches[0].relevance = 1100;
matches[0].contents = base::ASCIIToUTF16("match4.com");
matches[0].destination_url = GURL("http://match4.com");
result->AppendMatches(input, matches);
result->SortAndCull(input, nullptr);
popup_model()->OnResultChanged();
EXPECT_EQ(0U, popup_model()->selected_line());
EXPECT_EQ(OmniboxPopupModel::NORMAL, popup_model()->selected_line_state());
// Selecting |kNoMatch| should clear focus.
popup_model()->SetSelectedLineState(OmniboxPopupModel::TAB_SWITCH);
popup_model()->SetSelectedLine(OmniboxPopupModel::kNoMatch, false, false);
popup_model()->OnResultChanged();
EXPECT_EQ(OmniboxPopupModel::NORMAL, popup_model()->selected_line_state());
}
|