1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
|
// Copyright 2018 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "components/omnibox/browser/search_suggestion_parser.h"
#include "base/json/json_reader.h"
#include "base/strings/utf_string_conversions.h"
#include "base/values.h"
#include "components/omnibox/browser/test_scheme_classifier.h"
#include "testing/gtest/include/gtest/gtest.h"
////////////////////////////////////////////////////////////////////////////////
// DeserializeJsonData:
TEST(SearchSuggestionParserTest, DeserializeNonListJsonIsInvalid) {
std::string json_data = "{}";
std::unique_ptr<base::Value> result =
SearchSuggestionParser::DeserializeJsonData(json_data);
ASSERT_FALSE(result);
}
TEST(SearchSuggestionParserTest, DeserializeMalformedJsonIsInvalid) {
std::string json_data = "} malformed json {";
std::unique_ptr<base::Value> result =
SearchSuggestionParser::DeserializeJsonData(json_data);
ASSERT_FALSE(result);
}
TEST(SearchSuggestionParserTest, DeserializeJsonData) {
std::string json_data = R"([{"one": 1}])";
std::unique_ptr<base::Value> manifest_value =
base::JSONReader::Read(json_data);
std::unique_ptr<base::Value> result =
SearchSuggestionParser::DeserializeJsonData(json_data);
ASSERT_TRUE(result);
ASSERT_EQ(*manifest_value, *result);
}
TEST(SearchSuggestionParserTest, DeserializeWithXssiGuard) {
// For XSSI protection, non-json may precede the actual data.
// Parsing fails at: v v
std::string json_data = R"([non-json [prefix [{"one": 1}])";
// Parsing succeeds at: ^
std::unique_ptr<base::Value> result =
SearchSuggestionParser::DeserializeJsonData(json_data);
ASSERT_TRUE(result);
// Specifically, we precede JSON with )]}'\n.
json_data = ")]}'\n[{\"one\": 1}]";
result = SearchSuggestionParser::DeserializeJsonData(json_data);
ASSERT_TRUE(result);
}
TEST(SearchSuggestionParserTest, DeserializeWithTrailingComma) {
// The comma in this string makes this badly formed JSON, but we explicitly
// allow for this error in the JSON data.
std::string json_data = R"([{"one": 1},])";
std::unique_ptr<base::Value> result =
SearchSuggestionParser::DeserializeJsonData(json_data);
ASSERT_TRUE(result);
}
////////////////////////////////////////////////////////////////////////////////
// ExtractJsonData:
// TODO(crbug.com/831283): Add some ExtractJsonData tests.
////////////////////////////////////////////////////////////////////////////////
// ParseSuggestResults:
TEST(SearchSuggestionParserTest, ParseEmptyValueIsInvalid) {
base::Value root_val;
AutocompleteInput input;
TestSchemeClassifier scheme_classifier;
int default_result_relevance = 0;
bool is_keyword_result = false;
SearchSuggestionParser::Results results;
ASSERT_FALSE(SearchSuggestionParser::ParseSuggestResults(
root_val, input, scheme_classifier, default_result_relevance,
is_keyword_result, &results));
}
TEST(SearchSuggestionParserTest, ParseNonSuggestionValueIsInvalid) {
std::string json_data = R"([{"one": 1}])";
std::unique_ptr<base::Value> root_val = base::JSONReader::Read(json_data);
AutocompleteInput input;
TestSchemeClassifier scheme_classifier;
int default_result_relevance = 0;
bool is_keyword_result = false;
SearchSuggestionParser::Results results;
ASSERT_FALSE(SearchSuggestionParser::ParseSuggestResults(
*root_val, input, scheme_classifier, default_result_relevance,
is_keyword_result, &results));
}
TEST(SearchSuggestionParserTest, ParseSuggestResults) {
std::string json_data = R"([
"chris",
["christmas", "christopher doe"],
["", ""],
[],
{
"google:clientdata": {
"bpc": false,
"tlw": false
},
"google:fieldtrialtriggered": true,
"google:suggestdetail": [{
}, {
"a": "American author",
"dc": "#424242",
"i": "http://example.com/a.png",
"q": "gs_ssp=abc",
"t": "Christopher Doe"
}],
"google:suggestrelevance": [607, 606],
"google:suggesttype": ["QUERY", "ENTITY"],
"google:verbatimrelevance": 851
}])";
std::unique_ptr<base::Value> root_val = base::JSONReader::Read(json_data);
TestSchemeClassifier scheme_classifier;
AutocompleteInput input(base::ASCIIToUTF16("chris"),
metrics::OmniboxEventProto::NTP, scheme_classifier);
SearchSuggestionParser::Results results;
ASSERT_TRUE(SearchSuggestionParser::ParseSuggestResults(
*root_val, input, scheme_classifier, /*default_result_relevance=*/400,
/*is_keyword_result=*/false, &results));
// We have "google:suggestrelevance".
ASSERT_EQ(true, results.relevances_from_server);
// We have "google:fieldtrialtriggered".
ASSERT_EQ(true, results.field_trial_triggered);
// The "google:verbatimrelevance".
ASSERT_EQ(851, results.verbatim_relevance);
{
const auto& suggestion_result = results.suggest_results[0];
ASSERT_EQ(base::ASCIIToUTF16("christmas"), suggestion_result.suggestion());
ASSERT_EQ(base::ASCIIToUTF16(""), suggestion_result.annotation());
// This entry has no image.
ASSERT_EQ("", suggestion_result.image_dominant_color());
ASSERT_EQ("", suggestion_result.image_url());
}
{
const auto& suggestion_result = results.suggest_results[1];
ASSERT_EQ(base::ASCIIToUTF16("christopher doe"),
suggestion_result.suggestion());
ASSERT_EQ(base::ASCIIToUTF16("American author"),
suggestion_result.annotation());
ASSERT_EQ("#424242", suggestion_result.image_dominant_color());
ASSERT_EQ("http://example.com/a.png", suggestion_result.image_url());
}
}
|
