1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
|
/*
* Copyright (C) 2013 Google Inc. All Rights Reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
* are met:
* 1. Redistributions of source code must retain the above copyright
* notice, this list of conditions and the following disclaimer.
* 2. Redistributions in binary form must reproduce the above copyright
* notice, this list of conditions and the following disclaimer in the
* documentation and/or other materials provided with the distribution.
*
* THIS SOFTWARE IS PROVIDED BY APPLE COMPUTER, INC. ``AS IS'' AND ANY
* EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
* PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE COMPUTER, INC. OR
* CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
* EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
* PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
* PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
* OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*
*/
#include "testing/gtest/include/gtest/gtest.h"
#include "third_party/blink/renderer/platform/heap/handle.h"
#include "third_party/blink/renderer/platform/lifecycle_notifier.h"
#include "third_party/blink/renderer/platform/lifecycle_observer.h"
#include "third_party/blink/renderer/platform/runtime_enabled_features.h"
namespace blink {
class TestingObserver;
class DummyContext final
: public GarbageCollectedFinalized<DummyContext>,
public LifecycleNotifier<DummyContext, TestingObserver> {
USING_GARBAGE_COLLECTED_MIXIN(DummyContext);
public:
static DummyContext* Create() { return new DummyContext; }
void Trace(blink::Visitor* visitor) override {
LifecycleNotifier<DummyContext, TestingObserver>::Trace(visitor);
}
// Make the protected method public for testing.
using LifecycleNotifier<DummyContext, TestingObserver>::ForEachObserver;
};
class TestingObserver final
: public GarbageCollected<TestingObserver>,
public LifecycleObserver<DummyContext, TestingObserver> {
USING_GARBAGE_COLLECTED_MIXIN(TestingObserver);
public:
static TestingObserver* Create(DummyContext* context) {
return new TestingObserver(context);
}
void ContextDestroyed(DummyContext* destroyed_context) {
if (observer_to_remove_on_destruct_) {
destroyed_context->RemoveObserver(observer_to_remove_on_destruct_);
observer_to_remove_on_destruct_.Clear();
}
context_destroyed_called_ = true;
}
void Trace(blink::Visitor* visitor) override {
visitor->Trace(observer_to_remove_on_destruct_);
LifecycleObserver::Trace(visitor);
}
void Unobserve() { SetContext(nullptr); }
void SetObserverToRemoveAndDestroy(
TestingObserver* observer_to_remove_on_destruct) {
DCHECK(!observer_to_remove_on_destruct_);
observer_to_remove_on_destruct_ = observer_to_remove_on_destruct;
}
TestingObserver* InnerObserver() const {
return observer_to_remove_on_destruct_;
}
bool ContextDestroyedCalled() const { return context_destroyed_called_; }
private:
explicit TestingObserver(DummyContext* context)
: LifecycleObserver(context), context_destroyed_called_(false) {}
Member<TestingObserver> observer_to_remove_on_destruct_;
bool context_destroyed_called_;
};
TEST(LifecycleContextTest, ShouldObserveContextDestroyed) {
DummyContext* context = DummyContext::Create();
Persistent<TestingObserver> observer = TestingObserver::Create(context);
EXPECT_EQ(observer->LifecycleContext(), context);
EXPECT_FALSE(observer->ContextDestroyedCalled());
context->NotifyContextDestroyed();
context = nullptr;
ThreadState::Current()->CollectAllGarbage();
EXPECT_EQ(observer->LifecycleContext(), static_cast<DummyContext*>(nullptr));
EXPECT_TRUE(observer->ContextDestroyedCalled());
}
TEST(LifecycleContextTest, ShouldNotObserveContextDestroyedIfUnobserve) {
DummyContext* context = DummyContext::Create();
Persistent<TestingObserver> observer = TestingObserver::Create(context);
observer->Unobserve();
context->NotifyContextDestroyed();
context = nullptr;
ThreadState::Current()->CollectAllGarbage();
EXPECT_EQ(observer->LifecycleContext(), static_cast<DummyContext*>(nullptr));
EXPECT_FALSE(observer->ContextDestroyedCalled());
}
TEST(LifecycleContextTest, ObserverRemovedDuringNotifyDestroyed) {
DummyContext* context = DummyContext::Create();
Persistent<TestingObserver> observer = TestingObserver::Create(context);
TestingObserver* inner_observer = TestingObserver::Create(context);
// Attach the observer to the other. When 'observer' is notified
// of destruction, it will remove & destroy 'innerObserver'.
observer->SetObserverToRemoveAndDestroy(inner_observer);
EXPECT_EQ(observer->LifecycleContext(), context);
EXPECT_EQ(observer->InnerObserver()->LifecycleContext(), context);
EXPECT_FALSE(observer->ContextDestroyedCalled());
EXPECT_FALSE(observer->InnerObserver()->ContextDestroyedCalled());
context->NotifyContextDestroyed();
EXPECT_EQ(observer->InnerObserver(), nullptr);
context = nullptr;
ThreadState::Current()->CollectAllGarbage();
EXPECT_EQ(observer->LifecycleContext(), static_cast<DummyContext*>(nullptr));
EXPECT_TRUE(observer->ContextDestroyedCalled());
}
// This is a regression test for http://crbug.com/854639.
TEST(LifecycleContextTest, ShouldNotHitCFICheckOnIncrementalMarking) {
bool was_enabled = RuntimeEnabledFeatures::HeapIncrementalMarkingEnabled();
RuntimeEnabledFeatures::SetHeapIncrementalMarkingEnabled(true);
ThreadState* thread_state = ThreadState::Current();
thread_state->IncrementalMarkingStart(BlinkGC::GCReason::kTesting);
DummyContext* context = DummyContext::Create();
// This should not cause a CFI check failure.
Persistent<TestingObserver> observer = TestingObserver::Create(context);
EXPECT_FALSE(observer->ContextDestroyedCalled());
context->NotifyContextDestroyed();
EXPECT_TRUE(observer->ContextDestroyedCalled());
context = nullptr;
while (thread_state->GetGCState() ==
ThreadState::kIncrementalMarkingStepScheduled)
thread_state->IncrementalMarkingStep();
thread_state->IncrementalMarkingFinalize();
RuntimeEnabledFeatures::SetHeapIncrementalMarkingEnabled(was_enabled);
}
TEST(LifecycleContextTest, ForEachObserver) {
Persistent<DummyContext> context = DummyContext::Create();
Persistent<TestingObserver> observer = TestingObserver::Create(context);
HeapVector<Member<TestingObserver>> seen_observers;
context->ForEachObserver(
[&](TestingObserver* observer) { seen_observers.push_back(observer); });
ASSERT_EQ(1u, seen_observers.size());
EXPECT_EQ(observer.Get(), seen_observers[0].Get());
seen_observers.clear();
observer.Clear();
ThreadState::Current()->CollectAllGarbage();
context->ForEachObserver(
[&](TestingObserver* observer) { seen_observers.push_back(observer); });
ASSERT_EQ(0u, seen_observers.size());
}
} // namespace blink
|
